@yemi33/minions 0.1.971 → 0.1.973

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.971 (2026-04-14)
+## 0.1.973 (2026-04-14)
 
 ### Features
 -  flush queued CC messages as single combined request
@@ -25,6 +25,7 @@
 - replace magic string 'active' with PR_STATUS.ACTIVE in lifecycle.js (#969)
 
 ### Fixes
+-  skip isAlreadyDispatched in needsReReview to allow re-review within 1hr
 -  loop queue flush so messages queued during combined send aren't orphaned
 -  set lastPushedAt on fix completion to unblock re-review without poller
 -  trigger second-pass re-review after fix agent completes
@@ -34,6 +35,7 @@
 -  CC stale lock auto-release + queue drain on abort
 -  CC streaming 'tabId' TDZ error on new tab first message
 - fix tabId scope and close-event lock race in CC handlers
+- defer setCooldown to post-gating in discoverWork
 - fix CC queued message 'already processing' and thinking UX stacking
 - enforce --timeout 1 on all azureauth calls to prevent agent orphans (#1063)
 - cancel steering kill watcher on resume spawn (#1052) (#1062)
@@ -43,8 +45,6 @@
 - tighten build query guard to require mergeCommitId
 - restore sourceVersion filter after refs/pull merge ref switch
 - use refs/pull/{id}/merge for build status scoping
-- use repositoryId+reasonFilter for ADO build query
--  deduplicate work item creation by title
 
 ### Other
 - refactor(dashboard): extract _releaseCCTab helper and CC_LOCK_WAIT_MS constant

package/engine.js

@@ -1981,7 +1981,7 @@ async function discoverFromPrs(config, project) {
         pr_id: pr.id, pr_number: prNumber, pr_title: pr.title || '', pr_branch: pr.branch || '',
         pr_author: pr.agent || '', pr_url: pr.url || '',
       }, `Review ${pr.id}: ${pr.title}`, { dispatchKey: key, source: 'pr', pr, branch: pr.branch, project: projMeta });
-      if (item) { newWork.push(item); setCooldown(key); }
+      if (item) { newWork.push(item); }
     }
 
     // Re-review after fix: fall back to fixedAt > lastReviewedAt when lastPushedAt lags poller
@@ -1991,7 +1991,9 @@ async function discoverFromPrs(config, project) {
       (fixedAfterReview || (!alreadyReviewed && !!pr.minionsReview?.fixedAt)) && !evalEscalated;
     if (needsReReview) {
       const key = `review-${project?.name || 'default'}-${pr.id}`;
-      if (isAlreadyDispatched(key) || isOnCooldown(key, cooldownMs)) continue;
+      // Skip isAlreadyDispatched — fixedAfterReview/alreadyReviewed already dedup; the 1hr
+      // completed-dispatch window would block legitimate re-reviews within the hour after a fix
+      if (isOnCooldown(key, cooldownMs)) continue;
 
       // Pre-dispatch live vote check — cached 'waiting' may be stale if reviewer already acted
       try {
@@ -2034,7 +2036,7 @@ async function discoverFromPrs(config, project) {
         review_note: pr.minionsReview?.note || pr.reviewNote || 'See PR thread comments',
       }, `Fix ${pr.id}: ${pr.title || ''} — review feedback`, { dispatchKey: key, source: 'pr', pr, branch: pr.branch, project: projMeta });
       if (item) {
-        newWork.push(item); setCooldown(key); fixDispatched = true;
+        newWork.push(item); fixDispatched = true;
         // Increment review→fix cycle counter
         try {
           mutatePullRequests(projectPrPath(project), prs => {
@@ -2072,7 +2074,7 @@ async function discoverFromPrs(config, project) {
         reviewer: 'Human Reviewer',
         review_note: reviewNote,
       }, `Fix ${pr.id}: ${pr.title || ''} — human feedback`, { dispatchKey: key, source: 'pr-human-feedback', pr, branch: pr.branch, project: projMeta });
-      if (item) { newWork.push(item); setCooldown(key); fixDispatched = true; }
+      if (item) { newWork.push(item); fixDispatched = true; }
     }
 
     // PRs with build failures — route to author (has session context from implementing)
@@ -2121,7 +2123,7 @@ async function discoverFromPrs(config, project) {
         review_note: reviewNote,
       }, `Fix build failure on ${pr.id}: ${pr.title || ''}`, { dispatchKey: key, source: 'pr', pr, branch: pr.branch, project: projMeta });
       if (item) {
-        newWork.push(item); setCooldown(key);
+        newWork.push(item);
         // Increment build fix attempts counter
         try {
           const prPath = projectPrPath(project);
@@ -2178,7 +2180,6 @@ async function discoverFromPrs(config, project) {
           }, `Fix merge conflicts on ${pr.id}: ${pr.title || ''}`, { dispatchKey: key, source: 'pr', pr, branch: pr.branch, project: projMeta });
           if (item) {
             newWork.push(item);
-            setCooldown(key);
             // Record dispatch timestamp so re-dispatch is suppressed during ADO lag window
             try {
               mutatePullRequests(projectPrPath(project), prs => {
@@ -3079,6 +3080,7 @@ async function discoverWork(config) {
 
   for (const item of allWork) {
     addToDispatch(item);
+    if (item.meta?.dispatchKey) setCooldown(item.meta.dispatchKey);
     if (item.meta?.source === 'pr-human-feedback') {
       clearPendingHumanFeedbackFlag(item.meta.project, item.meta.pr?.id);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.971",
+  "version": "0.1.973",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"