@yemi33/minions 0.1.967 → 0.1.969

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.967 (2026-04-14)
+## 0.1.969 (2026-04-14)
 
 ### Features
 -  add quality standard reminder to all agent and CC prompts
@@ -25,6 +25,8 @@
 - fix dashboard plan-pause nested lock violation (#968)
 
 ### Fixes
+-  set lastPushedAt on fix completion to unblock re-review without poller
+-  trigger second-pass re-review after fix agent completes
 -  update ccInFlightAborts when retry LLM replaces original
 -  skip orphaned LLM retry when client disconnected during CC stream
 -  restore queue flush after abort — queued messages are user intent
@@ -43,8 +45,6 @@
 - use repositoryId+reasonFilter for ADO build query
 -  deduplicate work item creation by title
 - ADO build query uses repositoryId+pullRequest instead of branchName
--  persist adoPollEnabled/ghPollEnabled in settings save
-- prevent _consolidationInFlight race from stale force-reset timeout (#1023)
 
 ### Other
 - refactor(dashboard): extract _releaseCCTab helper and CC_LOCK_WAIT_MS constant

package/engine/lifecycle.js

@@ -940,6 +940,8 @@ function updatePrAfterFix(pr, project, source) {
     if (!target) return prs;
     // Never downgrade from approved — fix was dispatched but PR is already approved
     if (target.reviewStatus !== 'approved') target.reviewStatus = 'waiting';
+    // Advance lastPushedAt so alreadyReviewed resets immediately, without waiting for the poller
+    target.lastPushedAt = ts();
     // Always clear pendingFix — a fix dispatch (regardless of source) addresses all pending feedback
     if (target.humanFeedback) target.humanFeedback.pendingFix = false;
     if (source === 'pr-human-feedback') {

package/engine.js

@@ -1984,6 +1984,43 @@ async function discoverFromPrs(config, project) {
       if (item) { newWork.push(item); setCooldown(key); }
     }
 
+    // Re-review after fix: fall back to fixedAt > lastReviewedAt when lastPushedAt lags poller
+    const fixedAfterReview = !!(pr.minionsReview?.fixedAt &&
+      pr.lastReviewedAt && pr.minionsReview.fixedAt > pr.lastReviewedAt);
+    const needsReReview = autoReview && reviewStatus === 'waiting' &&
+      (fixedAfterReview || (!alreadyReviewed && !!pr.minionsReview?.fixedAt)) && !evalEscalated;
+    if (needsReReview) {
+      const key = `review-${project?.name || 'default'}-${pr.id}`;
+      if (isAlreadyDispatched(key) || isOnCooldown(key, cooldownMs)) continue;
+
+      // Pre-dispatch live vote check — cached 'waiting' may be stale if reviewer already acted
+      try {
+        const checkFn = project.repoHost === 'github' ? ghCheckLiveReview : adoCheckLiveReview;
+        const liveStatus = await checkFn(pr, project);
+        if (liveStatus && liveStatus !== 'waiting') {
+          log('info', `Pre-dispatch vote check: ${pr.id} is ${liveStatus} (cached was waiting) — skipping re-review`);
+          if (pr.reviewStatus !== 'approved') pr.reviewStatus = liveStatus;
+          try {
+            mutateJsonFileLocked(projectPrPath(project), data => {
+              if (!Array.isArray(data)) return data;
+              const target = data.find(p => p.id === pr.id);
+              if (target && target.reviewStatus !== 'approved') target.reviewStatus = liveStatus;
+              return data;
+            });
+          } catch {}
+          continue;
+        }
+      } catch (e) { log('warn', `Pre-dispatch vote check for ${pr.id}: ${e.message}`); }
+
+      const agentId = resolveAgent('review', config);
+      if (!agentId) continue;
+      const item = buildPrDispatch(agentId, config, project, pr, 'review', {
+        pr_id: pr.id, pr_number: prNumber, pr_title: pr.title || '', pr_branch: pr.branch || '',
+        pr_author: pr.agent || '', pr_url: pr.url || '',
+      }, `Review ${pr.id}: ${pr.title}`, { dispatchKey: key, source: 'pr', pr, branch: pr.branch, project: projMeta });
+      if (item) { newWork.push(item); setCooldown(key); }
+    }
+
     // PRs with changes requested → route back to author for fix
     let fixDispatched = false;
     if (reviewStatus === 'changes-requested' && !awaitingReReview && !evalEscalated) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.967",
+  "version": "0.1.969",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"