@yemi33/minions 0.1.961 → 0.1.963

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.961 (2026-04-14)
+## 0.1.963 (2026-04-14)
 
 ### Features
 -  add quality standard reminder to all agent and CC prompts
@@ -25,6 +25,8 @@
 - fix dashboard plan-pause nested lock violation (#968)
 
 ### Fixes
+-  CC streaming 'tabId' TDZ error on new tab first message
+- fix tabId scope and close-event lock race in CC handlers
 - fix CC queued message 'already processing' and thinking UX stacking
 - enforce --timeout 1 on all azureauth calls to prevent agent orphans (#1063)
 - cancel steering kill watcher on resume spawn (#1052) (#1062)
@@ -43,8 +45,6 @@
 - await discoverPipelineWork instead of fire-and-forget .catch (#1020)
 - add unhandledRejection/uncaughtException handlers to engine process (#1019)
 - show doc-chat badges on Notes and KB items (#1016)
-- steering kill on no-session re-queues dispatch instead of erroring (#1015)
-- inject cached ADO token into spawned agents (#998) (#1012)
 
 ### Other
 - refactor(dashboard): extract _releaseCCTab helper and CC_LOCK_WAIT_MS constant

package/dashboard.js

@@ -3396,12 +3396,13 @@ What would you like to discuss or change? When you're happy, say "approve" and I
 
   async function handleCommandCenter(req, res) {
     if (checkRateLimit('command-center', 10)) return jsonReply(res, 429, { error: 'Rate limited — max 10 requests/minute' });
+    let tabId;
     try {
       const body = await readBody(req);
       if (!body.message) return jsonReply(res, 400, { error: 'message required' });
 
       // Per-tab concurrency guard
-      const tabId = body.tabId || 'default';
+      tabId = body.tabId || 'default';
       if (ccInFlightTabs.has(tabId)) {
         await new Promise(r => setTimeout(r, CC_LOCK_WAIT_MS));
         if (ccInFlightTabs.has(tabId)) {
@@ -3472,10 +3473,11 @@ What would you like to discuss or change? When you're happy, say "approve" and I
 
   async function handleCommandCenterStream(req, res) {
     if (checkRateLimit('command-center', 10)) { res.statusCode = 429; res.end('Rate limited'); return; }
+    let tabId;
     try {
       const body = await readBody(req);
       if (!body.message) { res.statusCode = 400; res.end('message required'); return; }
-      const tabId = body.tabId || 'default';
+      tabId = body.tabId || 'default';
       if (ccInFlightTabs.has(tabId)) {
         // Previous request still in-flight — abort its LLM (handles keep-alive abort where close event didn't fire)
         const prevAbort = ccInFlightAborts.get(tabId);
@@ -3490,12 +3492,16 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       res.writeHead(200, { 'Content-Type': 'text/event-stream', 'Cache-Control': 'no-cache', 'Connection': 'keep-alive' });
       let _ccStreamAbort = null;
       let _ccStreamEnded = false;
-      // Kill LLM process immediately if client disconnects mid-stream
+      // Kill LLM process immediately if client disconnects mid-stream.
+      // Guard with !_ccStreamEnded: when the stream ends normally, finally already released the lock;
+      // without the guard, this close event (which fires after res.end) could wipe a new request's lock.
       req.on('close', () => {
-        _releaseCCTab(tabId);
-        if (!_ccStreamEnded && _ccStreamAbort) {
-          console.log(`[CC-stream] Client disconnected for tab ${tabId} — aborting LLM`);
-          _ccStreamAbort();
+        if (!_ccStreamEnded) {
+          _releaseCCTab(tabId);
+          if (_ccStreamAbort) {
+            console.log(`[CC-stream] Client disconnected for tab ${tabId} — aborting LLM`);
+            _ccStreamAbort();
+          }
         }
       });
 
@@ -3580,11 +3586,11 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         // Persist tab→session mapping (no global ccSession mutation)
         const now = Date.now();
         const responseSessionId = result.sessionId || tabSessionId;
-        const tabId = body.tabId;
-        if (tabId && responseSessionId) {
+        const _persistTabId = body.tabId;
+        if (_persistTabId && responseSessionId) {
           try {
             const sessions = shared.safeJsonArr(CC_SESSIONS_PATH);
-            const existing = sessions.find(s => s.id === tabId);
+            const existing = sessions.find(s => s.id === _persistTabId);
             const preview = (body.message || '').slice(0, 80);
             if (existing) {
               existing.sessionId = responseSessionId;
@@ -3593,7 +3599,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
               existing.preview = preview;
               existing._promptHash = _ccPromptHash;
             } else {
-              sessions.push({ id: tabId, title: (body.message || 'New chat').slice(0, 40), sessionId: responseSessionId, createdAt: new Date(now).toISOString(), lastActiveAt: new Date(now).toISOString(), turnCount: 1, preview, _promptHash: _ccPromptHash });
+              sessions.push({ id: _persistTabId, title: (body.message || 'New chat').slice(0, 40), sessionId: responseSessionId, createdAt: new Date(now).toISOString(), lastActiveAt: new Date(now).toISOString(), turnCount: 1, preview, _promptHash: _ccPromptHash });
             }
             safeWrite(CC_SESSIONS_PATH, sessions);
           } catch { /* non-critical */ }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.961",
+  "version": "0.1.963",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"