@yemi33/minions 0.1.96 → 0.1.98

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## 0.1.98 (2026-04-01)
+
+### Engine
+- engine/ado.js
+- engine/github.js
+
+## 0.1.97 (2026-04-01)
+
+### Engine
+- engine/ado.js
+- engine/github.js
+
+### Dashboard
+- dashboard.js
+- dashboard/js/render-prd.js
+- dashboard/js/render-prs.js
+
 ## 0.1.96 (2026-04-01)
 
 ### Engine

package/dashboard/js/render-prd.js

@@ -238,9 +238,7 @@ function renderPrdProgress(prog) {
         : isCompleted
           ? '<span onclick="event.stopPropagation();triggerVerify(\'' + escHtml(g.file) + '\',this)" style="color:var(--green);cursor:pointer;font-size:9px;padding:1px 6px;background:rgba(63,185,80,0.1);border:1px solid rgba(63,185,80,0.3);border-radius:3px">Verify</span>'
           : '<span onclick="event.stopPropagation();planPause(\'' + escHtml(g.file) + '\',this)" style="color:var(--yellow);cursor:pointer;font-size:9px;padding:1px 6px;background:rgba(210,153,34,0.1);border:1px solid rgba(210,153,34,0.3);border-radius:3px">Pause</span>';
-    const archiveBtn = isCompleted
-      ? '<span onclick="event.stopPropagation();planArchive(\'' + escHtml(g.file) + '\',this)" style="color:var(--muted);cursor:pointer;font-size:9px;padding:1px 6px;background:var(--surface);border:1px solid var(--border);border-radius:3px">Archive</span>'
-      : '';
+    const archiveBtn = (isCompleted || isPaused) ? '<span onclick="event.stopPropagation();planArchive(\'' + escHtml(g.file) + '\',this)" style="color:var(--muted);cursor:pointer;font-size:9px;padding:1px 6px;background:rgba(139,148,158,0.1);border:1px solid rgba(139,148,158,0.3);border-radius:3px">Archive</span>' : '';
     const deleteBtn = '<span onclick="event.stopPropagation();planDelete(\'' + escHtml(g.file) + '\')" style="color:var(--red);cursor:pointer;font-size:9px;padding:1px 6px;background:rgba(248,81,73,0.1);border:1px solid rgba(248,81,73,0.3);border-radius:3px">Delete</span>';
     const sourcePlanLink = g.sourcePlan
       ? '<span onclick="event.stopPropagation();planView(\'' + escHtml(g.sourcePlan) + '\')" style="color:var(--blue);cursor:pointer;font-size:9px;padding:1px 6px;background:rgba(56,139,253,0.1);border:1px solid rgba(56,139,253,0.3);border-radius:3px" title="View source plan">&#x1F4C4; Plan</span>'
@@ -509,6 +507,7 @@ function showArchivedPrdDetail(idx) {
     '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px;' + (isGraph ? 'background:var(--blue);color:#fff;border-color:var(--blue)' : '') + '" onclick="window._archivedPrdViewMode=\'graph\';showArchivedPrdDetail(' + idx + ')">Graph</button>' +
     '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px;' + (!isGraph ? 'background:var(--blue);color:#fff;border-color:var(--blue)' : '') + '" onclick="window._archivedPrdViewMode=\'list\';showArchivedPrdDetail(' + idx + ')">List</button>' +
     '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px;color:var(--green);margin-left:auto" onclick="triggerVerify(\'' + escHtml(g.file) + '\')">Trigger Verify</button>' +
+    '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px" onclick="planUnarchive(\'' + escHtml(g.file) + '\',this)">Unarchive</button>' +
     '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px" onclick="openArchivedPrdModal()">Back</button>' +
   '</div>';
 

package/dashboard/js/render-prs.js

@@ -7,9 +7,11 @@ const PR_PER_PAGE = 25;
 function prRow(pr) {
   // Minions review (agent) state — separate from ADO human review
   const sq = pr.minionsReview || {};
-  const reviewSource = sq.status || pr.reviewStatus || 'pending';
+  // If PR is merged/abandoned, treat 'waiting' review as resolved
+  const effectiveReviewStatus = (pr.status === 'merged' || pr.status === 'abandoned') && pr.reviewStatus === 'waiting' ? (pr.status === 'merged' ? 'approved' : 'pending') : pr.reviewStatus;
+  const reviewSource = sq.status || effectiveReviewStatus || 'pending';
   const reviewClass = reviewSource === 'approved' ? 'approved' : (reviewSource === 'changes-requested' || reviewSource === 'rejected') ? 'rejected' : reviewSource === 'waiting' ? 'building' : 'draft';
-  const reviewLabel = sq.status === 'waiting' ? 'reviewing (minions)' : sq.status ? sq.status + ' (minions)' : (pr.reviewStatus || 'pending');
+  const reviewLabel = sq.status === 'waiting' ? 'reviewing (minions)' : sq.status ? sq.status + ' (minions)' : (effectiveReviewStatus || 'pending');
   const buildClass = pr.buildStatus === 'passing' ? 'build-pass' : pr.buildStatus === 'failing' ? 'build-fail' : pr.buildStatus === 'running' ? 'building' : 'no-build';
   const buildLabel = pr.buildStatus || 'none';
   const statusClass = pr.status === 'merged' ? 'merged' : pr.status === 'abandoned' ? 'rejected' : pr.status === 'active' ? 'active' : 'draft';

package/dashboard.js

@@ -1647,6 +1647,80 @@ If nothing to do, return: { "duplicates": [], "reclassify": [], "remove": [] }`;
     return jsonReply(res, 200, plans);
   }
 
+  async function handlePlansArchiveMove(req, res) {
+    try {
+      const body = await readBody(req);
+      if (!body.file) return jsonReply(res, 400, { error: 'file required' });
+      const file = body.file;
+      if (file.includes('..') || file.includes('\0')) return jsonReply(res, 400, { error: 'invalid' });
+
+      const isJson = file.endsWith('.json');
+      const sourceDir = isJson ? PRD_DIR : PLANS_DIR;
+      const archiveDir = path.join(sourceDir, 'archive');
+      const sourcePath = path.join(sourceDir, file);
+
+      if (!fs.existsSync(sourcePath)) return jsonReply(res, 404, { error: 'File not found' });
+      if (!fs.existsSync(archiveDir)) fs.mkdirSync(archiveDir, { recursive: true });
+
+      fs.renameSync(sourcePath, path.join(archiveDir, file));
+
+      // If archiving a PRD .json, also archive its source .md plan
+      let archivedSource = null;
+      if (isJson) {
+        try {
+          const prd = safeJson(path.join(archiveDir, file));
+          if (prd?.source_plan) {
+            const mdPath = path.join(PLANS_DIR, prd.source_plan);
+            if (fs.existsSync(mdPath)) {
+              const planArchive = path.join(PLANS_DIR, 'archive');
+              if (!fs.existsSync(planArchive)) fs.mkdirSync(planArchive, { recursive: true });
+              fs.renameSync(mdPath, path.join(planArchive, prd.source_plan));
+              archivedSource = prd.source_plan;
+            }
+          }
+        } catch { /* optional — source plan may not exist */ }
+      }
+
+      invalidateStatusCache();
+      return jsonReply(res, 200, { ok: true, archivedSource });
+    } catch (e) { return jsonReply(res, 400, { error: e.message }); }
+  }
+
+  async function handlePlansUnarchive(req, res) {
+    try {
+      const body = await readBody(req);
+      if (!body.file) return jsonReply(res, 400, { error: 'file required' });
+      const file = body.file;
+      if (file.includes('..') || file.includes('\0')) return jsonReply(res, 400, { error: 'invalid' });
+
+      const isJson = file.endsWith('.json');
+      const targetDir = isJson ? PRD_DIR : PLANS_DIR;
+      const archiveDir = path.join(targetDir, 'archive');
+      const archivePath = path.join(archiveDir, file);
+
+      if (!fs.existsSync(archivePath)) return jsonReply(res, 404, { error: 'File not found in archive' });
+      fs.renameSync(archivePath, path.join(targetDir, file));
+
+      // If unarchiving a PRD .json, also unarchive its source .md plan
+      let unarchivedSource = null;
+      if (isJson) {
+        try {
+          const prd = safeJson(path.join(targetDir, file));
+          if (prd?.source_plan) {
+            const mdArchivePath = path.join(PLANS_DIR, 'archive', prd.source_plan);
+            if (fs.existsSync(mdArchivePath)) {
+              fs.renameSync(mdArchivePath, path.join(PLANS_DIR, prd.source_plan));
+              unarchivedSource = prd.source_plan;
+            }
+          }
+        } catch { /* optional */ }
+      }
+
+      invalidateStatusCache();
+      return jsonReply(res, 200, { ok: true, unarchivedSource });
+    } catch (e) { return jsonReply(res, 400, { error: e.message }); }
+  }
+
   async function handlePlansArchiveRead(req, res, match) {
     const file = decodeURIComponent(match[1]);
     if (file.includes('..') || file.includes('\0')) return jsonReply(res, 400, { error: 'invalid' });
@@ -3162,6 +3236,8 @@ What would you like to discuss or change? When you're happy, say "approve" and I
     { method: 'POST', path: '/api/plans/unarchive', desc: 'Restore a plan/PRD from archive', params: 'file', handler: handlePlansUnarchive },
     { method: 'POST', path: '/api/plans/revise', desc: 'Request revision with feedback, dispatches agent to revise', params: 'file, feedback, requestedBy?', handler: handlePlansRevise },
     { method: 'POST', path: '/api/plans/discuss', desc: 'Generate a plan discussion session script for Claude CLI', params: 'file', handler: handlePlansDiscuss },
+    { method: 'POST', path: '/api/plans/archive', desc: 'Archive a plan/PRD (move to archive folder)', params: 'file', handler: handlePlansArchiveMove },
+    { method: 'POST', path: '/api/plans/unarchive', desc: 'Unarchive a plan/PRD (restore from archive folder)', params: 'file', handler: handlePlansUnarchive },
     { method: 'GET', path: /^\/api\/plans\/archive\/([^?]+)$/, desc: 'Read an archived plan file', handler: handlePlansArchiveRead },
     { method: 'GET', path: /^\/api\/plans\/([^?]+)$/, desc: 'Read a full plan (JSON from prd/ or markdown from plans/)', handler: handlePlansRead },
 

package/engine/ado.js

@@ -3,6 +3,7 @@
  * Extracted from engine.js: ADO token management, PR status polling, human comment polling.
  */
 
+const path = require('path');
 const shared = require('./shared');
 const { exec, getAdoOrgBase, addPrLink } = shared;
 const { getPrs } = require('./queries');
@@ -26,6 +27,8 @@ function getAdoToken() {
   // If recent fetch failed, don't retry until backoff expires (avoids repeated browser popups)
   if (Date.now() < _adoTokenFailedUntil) return null;
   try {
+    // azureauth supports multiple --mode flags as an ordered fallback chain:
+    // tries IWA (Integrated Windows Auth) first, falls back to broker if unavailable.
     const token = exec('azureauth ado token --mode iwa --mode broker --output token --timeout 1', {
       timeout: 15000, encoding: 'utf-8', stdio: ['pipe', 'pipe', 'pipe'], windowsHide: true    }).trim();
     if (token && token.startsWith('eyJ')) {
@@ -131,6 +134,10 @@ async function pollPrStatus(config) {
       updated = true;
 
       if (newStatus === 'merged' || newStatus === 'abandoned') {
+        if (pr.reviewStatus === 'waiting') {
+          pr.reviewStatus = newStatus === 'merged' ? 'approved' : 'pending';
+          e.log('info', `PR ${pr.id} reviewStatus: waiting → ${pr.reviewStatus} (${newStatus})`);
+        }
         await engine().handlePostMerge(pr, project, config, newStatus);
       }
     }
@@ -334,7 +341,7 @@ async function reconcilePrs(config) {
     // Load work items to match branches to work item IDs
     const wiPath = shared.projectWorkItemsPath(project);
     const workItems = shared.safeJson(wiPath) || [];
-    const centralWiPath = require('path').join(shared.MINIONS_DIR, 'work-items.json');
+    const centralWiPath = path.join(shared.MINIONS_DIR, 'work-items.json');
     const centralItems = shared.safeJson(centralWiPath) || [];
     const allItems = [...workItems, ...centralItems];
 

package/engine/github.js

@@ -135,6 +135,11 @@ async function pollPrStatus(config) {
       updated = true;
 
       if (newStatus === 'merged' || newStatus === 'abandoned') {
+        // Resolve stale 'waiting' review status — won't be polled again after this
+        if (pr.reviewStatus === 'waiting') {
+          pr.reviewStatus = newStatus === 'merged' ? 'approved' : 'pending';
+          e.log('info', `PR ${pr.id} reviewStatus: waiting → ${pr.reviewStatus} (${newStatus})`);
+        }
         await engine().handlePostMerge(pr, project, config, newStatus);
       }
     }
@@ -234,7 +239,7 @@ async function pollPrHumanComments(config) {
     const reviewComments = ghApi(`/pulls/${prNum}/comments`, slug);
     const allComments = [
       ...(comments || []).map(c => ({ ...c, _type: 'issue' })),
-      ...((reviewComments || []).map(c => ({ ...c, _type: 'review' })))
+      ...(Array.isArray(reviewComments) ? reviewComments : []).map(c => ({ ...c, _type: 'review' }))
     ];
 
     // Filter out bot comments and minions's own comments

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.96",
+  "version": "0.1.98",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"