@yemi33/minions 0.1.957 → 0.1.958

package/CHANGELOG.md

@@ -1,8 +1,9 @@
 # Changelog
 
-## 0.1.957 (2026-04-14)
+## 0.1.958 (2026-04-14)
 
 ### Features
+- surface in-flight tool calls in lastAction (#1064)
 - wire agentBusyReassignMs into settings UI and persist
 -  ADO throttle detection, poll guards, and dashboard banner (#1051)
 - gate auto-fix conflict dispatch behind autoFixConflicts flag
@@ -22,9 +23,10 @@
 - replace magic string 'active' with PR_STATUS.ACTIVE in lifecycle.js (#969)
 - fix dashboard plan-pause nested lock violation (#968)
 - add missing branch_name to central dispatch vars (#967)
-- fix dispatch.js mutator fallback to use nullish coalescing (#966)
 
 ### Fixes
+- enforce --timeout 1 on all azureauth calls to prevent agent orphans (#1063)
+- cancel steering kill watcher on resume spawn (#1052) (#1062)
 - suppress warn for optional template variables (#1061)
 - fix ENGINE_DEFAULTS ref and derive boolean settings from defaults
 - add autoFixConflicts to boolean settings persist list
@@ -43,8 +45,6 @@
 - steering kill on no-session re-queues dispatch instead of erroring (#1015)
 - inject cached ADO token into spawned agents (#998) (#1012)
 -  qaAbort race + skip kill on completed doc-chat
--  doc-chat Stop button actually works — release server guard on disconnect
--  CC streaming auto-retries fresh session when resume fails
 
 ### Other
 - test(engine): add regression tests for autoFixConflicts flag and DEFAULTS alias

package/docs/auto-discovery.md

@@ -137,7 +137,7 @@ The engine directly polls the Azure DevOps REST API for **all** PR metadata: bui
 | `buildStatus` | PR statuses (codecoverage/deploy/build/ci contexts) | `passing` / `failing` / `running` / `none` |
 | `buildFailReason` | Failed status description | Set on failure, cleared otherwise |
 
-**Auth:** Bearer token via `azureauth ado token --output token` (cached 30 minutes).
+**Auth:** Bearer token via `azureauth ado token --output token --timeout 1` (cached 30 minutes). The `--timeout 1` flag is required — without it, azureauth can hang indefinitely in headless sessions.
 
 This feeds `discoverFromPrs` — when `buildStatus` flips to `"failing"`, the next discovery tick dispatches a fix agent. When `status` becomes `"merged"`, the PR drops out of active polling.
 

package/engine/queries.js

@@ -42,6 +42,34 @@ function readHeadTail(filePath, bytes = 1024) {
   }
 }
 
+/**
+ * Detect in-flight tool calls from live-output.log tail content.
+ * Scans for task_started events with no matching task_notification (by task_id).
+ * Returns { description, taskId } for the most recent in-flight tool, or null.
+ */
+function detectInFlightTool(tail) {
+  if (!tail) return null;
+  const lines = tail.split('\n');
+  const completed = new Set();
+
+  // Reverse scan: collect task_notification ids first (most recent lines),
+  // then the first task_started not in completed is the in-flight tool.
+  for (let i = lines.length - 1; i >= 0; i--) {
+    const line = lines[i];
+    if (!line.includes('"task_')) continue; // fast skip non-task lines
+    try {
+      const parsed = JSON.parse(line);
+      if (parsed.type !== 'system') continue;
+      if (parsed.subtype === 'task_notification') {
+        completed.add(parsed.task_id);
+      } else if (parsed.subtype === 'task_started' && !completed.has(parsed.task_id)) {
+        return { description: parsed.description || null, taskId: parsed.task_id };
+      }
+    } catch { /* not valid JSON — skip heartbeats, headers, partial lines */ }
+  }
+  return null;
+}
+
 // ── Paths ───────────────────────────────────────────────────────────────────
 
 const MINIONS_DIR = shared.MINIONS_DIR;
@@ -220,7 +248,7 @@ function getAgentStatus(agentId) {
     if (active._blockingToolCall) {
       result._blockingToolCall = active._blockingToolCall;
     }
-    // Detect permission-waiting: read only head+tail of live-output.log (max 2KB total)
+    // Detect permission-waiting and in-flight tools: read only head+tail of live-output.log (max 2KB total)
     try {
       const liveLogPath = path.join(AGENTS_DIR, agentId, 'live-output.log');
       const { head, tail } = readHeadTail(liveLogPath, 1024);
@@ -239,6 +267,11 @@ function getAgentStatus(agentId) {
             result._warning = 'Possibly waiting for permission approval — agent is not in bypass mode';
           }
         }
+        // Detect in-flight tool calls (task_started with no task_notification)
+        const inFlight = detectInFlightTool(tail);
+        if (inFlight && inFlight.description) {
+          result._runningToolDescription = inFlight.description;
+        }
       }
     } catch { /* optional — don't block status */ }
     return result;
@@ -328,7 +361,7 @@ function getAgents(config) {
     const s = getAgentStatus(a.id); // derives from dispatch.json
 
     let lastAction = 'Waiting for assignment';
-    if (s.status === 'working') lastAction = `Working: ${s.task}`;
+    if (s.status === 'working') lastAction = s._runningToolDescription ? `Running: ${s._runningToolDescription}` : `Working: ${s.task}`;
     else if (s.status === 'done') lastAction = `Done: ${s.task}`;
     else if (s.status === 'error') lastAction = `Error: ${s.task}`;
     else if (inboxFiles.length > 0) {
@@ -1033,6 +1066,7 @@ module.exports = {
   // Helpers
   timeSince,
   readHeadTail, // exported for testing
+  detectInFlightTool, // exported for testing
   resetPrdInfoCache,
 
   // Core state

package/engine.js

@@ -1051,8 +1051,12 @@ async function spawnAgent(dispatchItem, config) {
         return;
       }
 
-      // Re-attach to existing tracking
-      activeProcesses.set(id, { proc: resumeProc, agentId, startedAt: procInfo.startedAt, sessionId: steerSessionId, _steeringAt: Date.now(), lastRealOutputAt: Date.now() });
+      // Re-attach to existing tracking — do NOT carry _steeringAt forward (#1052).
+      // The kill watcher in timeout.js fires 30s after _steeringAt is set. If we carry it
+      // into the resumed process, it kills the resumed session. The kill watcher only exists
+      // to handle cases where the original kill didn't take effect — once the process has
+      // exited and the resume is spawned, _steeringAt must not be present.
+      activeProcesses.set(id, { proc: resumeProc, agentId, startedAt: procInfo.startedAt, sessionId: steerSessionId, lastRealOutputAt: Date.now() });
 
       // Reset output buffers so post-completion parsing only sees the resumed session
       stdout = '';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.957",
+  "version": "0.1.958",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/playbooks/shared-rules.md

@@ -54,3 +54,5 @@ node engine/ado-status.js <prNumber> --live --project MyProject
 Output is JSON with the same fields. Exit 0 on success, 1 if not found.
 
 **Never make raw `curl` calls to ADO APIs directly.** Use `node engine/ado-status.js` which routes through `ado.js` — authenticated, retried, circuit-broken. Raw `azureauth` + curl bypasses all of that.
+
+**If you must run `azureauth` directly, ALWAYS include `--timeout 1`.** Without this flag, `azureauth ado token` can hang indefinitely waiting for interactive broker UI that never appears in headless agent sessions. This causes the Claude Code process to silently exit and the engine to declare the agent orphaned. Example: `azureauth ado token --mode iwa --mode broker --output token --timeout 1`.