@yemi33/minions 0.1.944 → 0.1.946

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.944 (2026-04-14)
+## 0.1.946 (2026-04-14)
 
 ### Features
 -  make ADO poll frequency configurable and ungate reconcilePrs
@@ -25,6 +25,7 @@
 - bump plan-to-prd max turns from 20 to 35
 
 ### Fixes
+- tighten build query guard to require mergeCommitId
 - restore sourceVersion filter after refs/pull merge ref switch
 - use refs/pull/{id}/merge for build status scoping
 - use repositoryId+reasonFilter for ADO build query
@@ -44,9 +45,9 @@
 -  429 retry on abort race applies to all sends, not just queued
 - show actionable failure context instead of Unknown error (#1003)
 - prioritize error_max_turns over permission-blocked in classifyFailure (#1001)
--  optimistic archive hides both PRD and linked source plan simultaneously
 
 ### Other
+- refactor(ado): move PR enrichment fetch into fetchAdoPrMetadata helper
 - refactor: Make renderLiveChatMessage a thin wrapper over renderAgentOutput
 - test(preflight): add unit tests for findClaudeBinary, runPreflight, printPreflight, checkOrExit (#953)
 - test(meeting): add unit tests for key functions (#957)

package/dashboard.js

@@ -4228,14 +4228,8 @@ What would you like to discuss or change? When you're happy, say "approve" and I
           } else if (adoMatch) {
             const [, adoOrg, adoProj, adoRepo] = adoMatch;
             try {
-              const { getAdoToken } = require('./engine/ado');
-              const token = await getAdoToken();
-              if (token) {
-                const apiUrl = `https://dev.azure.com/${adoOrg}/${adoProj}/_apis/git/repositories/${adoRepo}/pullrequests/${prNum}?api-version=7.1`;
-                const result = await shared.execAsync(`curl -s --max-time 10 -H "Authorization: Bearer ${token}" "${apiUrl}"`, { encoding: 'utf-8', timeout: 15000, windowsHide: true });
-                const d = JSON.parse(result);
-                prData = { title: d.title, description: d.description, branch: d.sourceRefName?.replace('refs/heads/', ''), author: d.createdBy?.displayName };
-              }
+              const { fetchAdoPrMetadata } = require('./engine/ado');
+              prData = await fetchAdoPrMetadata(prNum, adoOrg, adoProj, adoRepo);
             } catch { /* ADO token may not be available */ }
           }
           if (!prData) return;

package/engine/ado.js

@@ -379,7 +379,7 @@ async function pollPrStatus(config) {
     let buildStatuses = []; // for error log fetching
 
     const mergeCommitId = prData.lastMergeCommit?.commitId;
-    if (prNumber) {
+    if (prNumber && mergeCommitId) {
       try {
         // branchName=refs/pull/{id}/merge scopes server-side to this PR's builds.
         // sourceVersion filter then narrows to the current merge commit — a PR updated
@@ -387,7 +387,7 @@ async function pollPrStatus(config) {
         const mergeRef = encodeURIComponent(`refs/pull/${prNumber}/merge`);
         const buildsUrl = `${orgBase}/${project.adoProject}/_apis/build/builds?branchName=${mergeRef}&repositoryId=${project.repositoryId}&repositoryType=TfsGit&$top=25&api-version=7.1`;
         const buildsData = await adoFetch(buildsUrl, token);
-        const prBuilds = (buildsData?.value || []).filter(b => !mergeCommitId || b.sourceVersion === mergeCommitId);
+        const prBuilds = (buildsData?.value || []).filter(b => b.sourceVersion === mergeCommitId);
 
         if (prBuilds.length > 0) {
           // partiallySucceeded = warnings, not failures — counts as passing
@@ -768,6 +768,22 @@ async function checkLiveReviewStatus(pr, project) {
   }
 }
 
+// Fetch basic PR metadata (title, description, branch, author) for a manually-linked ADO PR.
+// Uses adoFetch so retry logic and circuit breaker apply — dashboard.js PR enrichment calls this.
+async function fetchAdoPrMetadata(prNum, adoOrg, adoProj, adoRepo) {
+  const token = await getAdoToken();
+  if (!token) return null;
+  const url = `https://dev.azure.com/${adoOrg}/${adoProj}/_apis/git/repositories/${adoRepo}/pullrequests/${prNum}?api-version=7.1`;
+  const d = await adoFetch(url, token);
+  if (!d) return null;
+  return {
+    title: d.title || '',
+    description: d.description || '',
+    branch: d.sourceRefName?.replace('refs/heads/', '') || '',
+    author: d.createdBy?.displayName || '',
+  };
+}
+
 module.exports = {
   getAdoToken,
   adoFetch,
@@ -777,5 +793,6 @@ module.exports = {
   checkLiveReviewStatus,
   needsAdoPollRetry,
   isAdoAuthError, // exported for testing
+  fetchAdoPrMetadata,
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.944",
+  "version": "0.1.946",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"