@yemi33/minions 0.1.920 → 0.1.921

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.920 (2026-04-13)
+## 0.1.921 (2026-04-13)
 
 ### Features
 - CC tab unread dot + reopened badge on work items
@@ -18,6 +18,7 @@
 - add red dot notification on CC tab when response completes (#934) (#946)
 
 ### Fixes
+- prioritize error_max_turns over permission-blocked in classifyFailure (#1001)
 -  optimistic archive hides both PRD and linked source plan simultaneously
 - align CC tab unread dot to same position as working dot
 - pipeline artifact links use pushModalBack instead of setTimeout race (#993)

package/engine/lifecycle.js

@@ -1910,6 +1910,14 @@ function classifyFailure(code, stdout = '', stderr = '') {
   // Exit code 78 — configuration error (Claude CLI not found, bad setup)
   if (code === 78) return FAILURE_CLASS.CONFIG_ERROR;
 
+  // Max turns exhausted (error_max_turns) — definitive stop reason, retryable
+  // Must be checked FIRST — hook startup failures (e.g. curl exit code 28) can inject
+  // permission/auth text into stderr, but if the agent ran to turn exhaustion that's the
+  // real cause. Checked before PERMISSION_BLOCKED and OUT_OF_CONTEXT.
+  if (/error_max_turns|"subtype"\s*:\s*"error_max_turns"|terminal_reason.*max_turns|max.*turns.*reached/i.test(combined)) {
+    return FAILURE_CLASS.MAX_TURNS;
+  }
+
   // Permission / trust / auth failures
   if (/permission denied|access denied|unauthorized|403 forbidden|trust.*blocked|auth.*fail/i.test(combined)) {
     return FAILURE_CLASS.PERMISSION_BLOCKED;
@@ -1920,12 +1928,6 @@ function classifyFailure(code, stdout = '', stderr = '') {
     return FAILURE_CLASS.MERGE_CONFLICT;
   }
 
-  // Max turns exhausted (error_max_turns) — work in progress, retryable
-  // Must be checked BEFORE OUT_OF_CONTEXT to avoid misclassification as non-retryable
-  if (/error_max_turns|"subtype"\s*:\s*"error_max_turns"|terminal_reason.*max_turns|max.*turns.*reached/i.test(combined)) {
-    return FAILURE_CLASS.MAX_TURNS;
-  }
-
   // Context window exhausted (token limit, context length — NOT max turns)
   if (/context window|token limit|conversation.*too long|context.*length.*exceeded/i.test(combined)) {
     return FAILURE_CLASS.OUT_OF_CONTEXT;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.920",
+  "version": "0.1.921",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"