@yemi33/minions 0.1.916 → 0.1.918

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.916 (2026-04-13)
+## 0.1.918 (2026-04-13)
 
 ### Features
 - CC tab unread dot + reopened badge on work items
@@ -18,6 +18,9 @@
 - add red dot notification on CC tab when response completes (#934) (#946)
 
 ### Fixes
+- pipeline artifact links use pushModalBack instead of setTimeout race (#993)
+- close unclosed code fences and lone backticks in renderMd (#991)
+- PRD item status stuck at dispatched when fix completes (#989)
 - dep merge ancestor pruning + pre-flight simulation (#958) (#979)
 - add MAX_TURNS failure class and fix enum count test (#983)
 - prevent Create Plan from meeting saving doc-chat context bleed (#980)

package/dashboard/js/render-pipelines.js

@@ -64,43 +64,35 @@ function _renderMonitoredResources(resources, options) {
 /**
  * Render clickable artifact links for a pipeline stage.
  * Each artifact type gets an icon and navigates to the relevant detail view.
+ * @param {Object} artifacts - artifact map from stage run
+ * @param {string} [pipelineId] - pipeline ID for modal back-navigation
  */
-function _renderArtifactLinks(artifacts) {
+function _renderArtifactLinks(artifacts, pipelineId) {
   if (!artifacts) return '';
   var links = [];
   var linkStyle = 'display:inline-flex;align-items:center;gap:2px;padding:1px 6px;border-radius:10px;font-size:10px;cursor:pointer;text-decoration:none;color:var(--blue);background:color-mix(in srgb, var(--blue) 10%, transparent);border:1px solid color-mix(in srgb, var(--blue) 20%, transparent)';
 
-  // Work items → navigate to work page & open detail
+  // Pushes current pipeline modal onto back stack so detail modals can navigate back
+  var backFn = pipelineId ? "pushModalBack(function(){openPipelineDetail('" + escHtml(pipelineId) + "')});" : '';
+
   (artifacts.workItems || []).forEach(function(id) {
-    links.push('<span style="' + linkStyle + '" onclick="event.stopPropagation();closeModal();switchPage(\'work\');setTimeout(function(){openWorkItemDetail(\'' + escHtml(id) + '\')},200)" title="Open work item ' + escHtml(id) + '">⚙ ' + escHtml(id) + '</span>');
+    links.push('<span style="' + linkStyle + '" onclick="event.stopPropagation();' + backFn + 'openWorkItemDetail(\'' + escHtml(id) + '\')" title="Open work item ' + escHtml(id) + '">⚙ ' + escHtml(id) + '</span>');
   });
-
-  // Meetings → navigate to meetings page & open detail
   (artifacts.meetings || []).forEach(function(id) {
-    links.push('<span style="' + linkStyle + '" onclick="event.stopPropagation();closeModal();switchPage(\'meetings\');setTimeout(function(){openMeetingDetail(\'' + escHtml(id) + '\')},200)" title="Open meeting ' + escHtml(id) + '">💬 ' + escHtml(id) + '</span>');
+    links.push('<span style="' + linkStyle + '" onclick="event.stopPropagation();' + backFn + 'openMeetingDetail(\'' + escHtml(id) + '\')" title="Open meeting ' + escHtml(id) + '">💬 ' + escHtml(id) + '</span>');
   });
-
-  // Plans → navigate to plans page
   (artifacts.plans || []).forEach(function(name) {
-    links.push('<span style="' + linkStyle + '" onclick="event.stopPropagation();closeModal();switchPage(\'plans\')" title="Plan: ' + escHtml(name) + '">📋 ' + escHtml(name.replace(/\.md$/, '').slice(0, 30)) + '</span>');
+    links.push('<span style="' + linkStyle + '" onclick="event.stopPropagation();' + backFn + 'planView(\'' + escHtml(name) + '\')" title="Plan: ' + escHtml(name) + '">📋 ' + escHtml(name.replace(/\.md$/, '').slice(0, 30)) + '</span>');
   });
-
-  // PRDs → navigate to PRD page
   (artifacts.prds || []).forEach(function(name) {
-    links.push('<span style="' + linkStyle + '" onclick="event.stopPropagation();closeModal();switchPage(\'prd\')" title="PRD: ' + escHtml(name) + '">📄 ' + escHtml(name.replace(/\.json$/, '').slice(0, 30)) + '</span>');
+    links.push('<span style="' + linkStyle + '" onclick="event.stopPropagation();' + backFn + 'planView(\'' + escHtml(name) + '\')" title="PRD: ' + escHtml(name) + '">📄 ' + escHtml(name.replace(/\.json$/, '').slice(0, 30)) + '</span>');
   });
-
-  // PRs → navigate to PRs page
   (artifacts.prs || []).forEach(function(id) {
     links.push('<span style="' + linkStyle + '" onclick="event.stopPropagation();closeModal();switchPage(\'prs\')" title="Pull request ' + escHtml(id) + '">🔀 PR-' + escHtml(id) + '</span>');
   });
-
-  // Sub-stages (parallel) — just label them, no nav needed
   (artifacts.subStages || []).forEach(function(id) {
     links.push('<span style="' + linkStyle + ';cursor:default;color:var(--muted);background:color-mix(in srgb, var(--muted) 8%, transparent);border-color:color-mix(in srgb, var(--muted) 15%, transparent)" title="Sub-stage ' + escHtml(id) + '">⚓ ' + escHtml(id) + '</span>');
   });
-
-  // Notes → navigate to inbox page
   (artifacts.notes || []).forEach(function(name) {
     links.push('<span style="' + linkStyle + '" onclick="event.stopPropagation();closeModal();switchPage(\'inbox\')" title="Note: ' + escHtml(name) + '">📝 ' + escHtml(name.replace(/\.md$/, '').replace(/^\d{4}-\d{2}-\d{2}-/, '').slice(0, 30)) + '</span>');
   });
@@ -367,7 +359,7 @@ function openPipelineDetail(id) {
         (s.type === 'condition' ? ' | Check: ' + escHtml(typeof (s.check || s.condition) === 'string' ? (s.check || s.condition) : ((s.check || s.condition || {}).check || '?')) + (s.onMet ? ' | onMet: ' + escHtml(s.onMet) : '') + (s.onUnmet ? ' | onUnmet: ' + escHtml(s.onUnmet) : '') : '') +
       '</div>' +
       _renderMonitoredResources(s.monitoredResources || []) +
-      _renderArtifactLinks(stageRun.artifacts) +
+      _renderArtifactLinks(stageRun.artifacts, id) +
       (stageRun.output ? '<div style="margin-top:6px;font-size:11px;max-height:150px;overflow-y:auto">' + renderMd(stageRun.output.slice(0, 500)) + '</div>' : '') +
       (stageStatus === 'waiting-human' ? '<button class="pr-pager-btn" style="font-size:9px;padding:2px 8px;color:var(--green);border-color:var(--green);margin-top:6px" onclick="_continuePipeline(\'' + escHtml(id) + '\',\'' + escHtml(s.id) + '\',this)">Continue</button>' : '') +
     '</div>';
@@ -390,7 +382,7 @@ function openPipelineDetail(id) {
           (r.completedAt ? '<span style="color:var(--muted)">\u2192 ' + new Date(r.completedAt).toLocaleString() + '</span>' : '') +
           (artifactCount > 0 ? '<span style="color:var(--blue);cursor:pointer;user-select:none" onclick="var el=document.getElementById(\'' + toggleId + '\');el.style.display=el.style.display===\'none\'?\'flex\':\'none\'" title="Toggle artifacts">' + artifactCount + ' artifact' + (artifactCount !== 1 ? 's' : '') + ' ▾</span>' : '') +
         '</div>' +
-        (artifactCount > 0 ? '<div id="' + toggleId + '" style="display:none;flex-wrap:wrap;gap:4px;margin-top:4px;margin-left:12px">' + _renderArtifactLinks(runArtifacts.merged) + '</div>' : '') +
+        (artifactCount > 0 ? '<div id="' + toggleId + '" style="display:none;flex-wrap:wrap;gap:4px;margin-top:4px;margin-left:12px">' + _renderArtifactLinks(runArtifacts.merged, id) + '</div>' : '') +
       '</div>';
     });
   }

package/dashboard/js/utils.js

@@ -152,15 +152,33 @@ function renderMd(s) {
   return _renderMdCore(s);
 }
 
+function _normalizeCodeFences(s) {
+  var fenceCount = (s.match(/```/g) || []).length;
+  if (fenceCount % 2 !== 0) s = s + '\n```';
+  return s;
+}
+
 function _renderMdCore(s) {
   let html = escHtml(s);
 
+  // Close unclosed code fences before any regex processing
+  html = _normalizeCodeFences(html);
+
   // 1. Extract code blocks and inline code into placeholders (protect from other transforms)
   const codeSlots = [];
   html = html.replace(/```(\w*)\n([\s\S]*?)```/g, function(_, lang, code) {
     codeSlots.push('<pre style="background:var(--bg);padding:8px;border-radius:4px;overflow-x:auto;font-size:11px;margin:4px 0"><code>' + code + '</code></pre>');
     return '\x00CB' + (codeSlots.length - 1) + '\x00';
   });
+
+  // Close lone unclosed backticks per-line before inline code extraction
+  html = html.split('\n').map(function(line) {
+    // Skip code block placeholders
+    if (/^\x00CB\d+\x00$/.test(line)) return line;
+    var ticks = (line.match(/`/g) || []).length;
+    return (ticks % 2 !== 0) ? line + '`' : line;
+  }).join('\n');
+
   html = html.replace(/`([^`\n]+)`/g, function(_, code) {
     codeSlots.push('<code style="background:var(--bg);padding:1px 4px;border-radius:3px;font-size:0.9em">' + code + '</code>');
     return '\x00CB' + (codeSlots.length - 1) + '\x00';
@@ -294,6 +312,9 @@ var MD_CHUNK_SIZE = 10000;
 var _mdChunkUid = 0;
 
 function _renderMdChunked(fullText) {
+  // Close unclosed code fences before chunking
+  fullText = _normalizeCodeFences(fullText);
+
   // Split at blank-line boundaries to avoid breaking code blocks and other multi-line elements
   var chunks = [];
   var pos = 0;

package/engine/lifecycle.js

@@ -617,6 +617,8 @@ function updateWorkItemStatus(meta, status, reason) {
 }
 
 const _VALID_PRD_STATUSES = new Set([...Object.values(WI_STATUS), 'missing']);
+// (#984) PRD statuses that are stale when the work item is actually done
+const _STALE_PRD_STATUSES = new Set([WI_STATUS.DISPATCHED, WI_STATUS.FAILED, WI_STATUS.PENDING]);
 function syncPrdItemStatus(itemId, status, sourcePlan) {
   if (!itemId) return;
   if (!_VALID_PRD_STATUSES.has(status)) return;
@@ -637,11 +639,12 @@ function syncPrdItemStatus(itemId, status, sourcePlan) {
   } catch (err) { log('warn', `PRD status sync: ${err.message}`); }
 }
 
-// ─── PRD Backward-Scan Reconciliation (#929) ────────────────────────────────
-// Proactive counterpart to syncPrdItemStatus. Scans all active PRDs and promotes
-// "missing" items to "updated" when a done work item already exists for that ID.
-// This catches cases where a PRD regeneration incorrectly sets items to "missing"
-// and no subsequent work item state change triggers the reactive sync.
+// ─── PRD Backward-Scan Reconciliation (#929, #984) ─────────────────────────
+// Proactive counterpart to syncPrdItemStatus. Scans all active PRDs and:
+// 1. Promotes "missing" items to "updated" when a done work item already exists (#929)
+// 2. Promotes stale "dispatched"/"failed"/"pending" items to "done" when the work item
+//    is actually done (#984) — catches cases where fix work items complete with a
+//    different ID than the original PRD feature, leaving the PRD status stale.
 
 function reconcilePrdStatuses(config) {
   if (!fs.existsSync(PRD_DIR)) return;
@@ -674,6 +677,14 @@ function reconcilePrdStatuses(config) {
           modified = true;
           log('info', `PRD backward-scan: promoted ${feature.id} from missing→updated in ${file} (done work item exists)`);
         }
+        // (#984) Stale status: PRD item stuck at dispatched/failed/pending while WI is done —
+        // happens when fix work items complete with a different ID than the original PRD feature
+        else if (_STALE_PRD_STATUSES.has(feature.status) && doneWiById.has(feature.id)) {
+          const prev = feature.status;
+          feature.status = WI_STATUS.DONE;
+          modified = true;
+          log('info', `PRD backward-scan: promoted ${feature.id} from ${prev}→done in ${file} (done work item exists)`);
+        }
       }
 
       if (modified) {
@@ -1790,7 +1801,23 @@ async function runPostCompletionHooks(dispatchItem, agentId, code, stdout, confi
   }
 
   if (type === WORK_TYPE.REVIEW) await updatePrAfterReview(agentId, meta?.pr, meta?.project, config, resultSummary);
-  if (type === WORK_TYPE.FIX) updatePrAfterFix(meta?.pr, meta?.project, meta?.source);
+  if (type === WORK_TYPE.FIX) {
+    updatePrAfterFix(meta?.pr, meta?.project, meta?.source);
+    // (#984) Sync PRD status for PR-linked features: fix work items have a different ID
+    // than the original PRD feature, so syncPrdItemStatus(fixWiId, ...) finds nothing.
+    // Use the PR's prdItems to propagate done status when the original work item is done.
+    if (effectiveSuccess && meta?.pr?.prdItems?.length) {
+      try {
+        const allWis = queries.getWorkItems(config);
+        for (const prdItemId of meta.pr.prdItems) {
+          const wi = allWis.find(w => w.id === prdItemId);
+          if (wi && DONE_STATUSES.has(wi.status) && wi.sourcePlan) {
+            syncPrdItemStatus(prdItemId, WI_STATUS.DONE, wi.sourcePlan);
+          }
+        }
+      } catch (err) { log('warn', `PRD sync after fix: ${err.message}`); }
+    }
+  }
   checkForLearnings(agentId, config.agents[agentId], dispatchItem.task);
   if (effectiveSuccess) {
     extractSkillsFromOutput(stdout, agentId, dispatchItem, config);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.916",
+  "version": "0.1.918",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"