@yemi33/minions 0.1.916 → 0.1.917

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.916 (2026-04-13)
+## 0.1.917 (2026-04-13)
 
 ### Features
 - CC tab unread dot + reopened badge on work items
@@ -18,6 +18,7 @@
 - add red dot notification on CC tab when response completes (#934) (#946)
 
 ### Fixes
+- PRD item status stuck at dispatched when fix completes (#989)
 - dep merge ancestor pruning + pre-flight simulation (#958) (#979)
 - add MAX_TURNS failure class and fix enum count test (#983)
 - prevent Create Plan from meeting saving doc-chat context bleed (#980)

package/engine/lifecycle.js

@@ -617,6 +617,8 @@ function updateWorkItemStatus(meta, status, reason) {
 }
 
 const _VALID_PRD_STATUSES = new Set([...Object.values(WI_STATUS), 'missing']);
+// (#984) PRD statuses that are stale when the work item is actually done
+const _STALE_PRD_STATUSES = new Set([WI_STATUS.DISPATCHED, WI_STATUS.FAILED, WI_STATUS.PENDING]);
 function syncPrdItemStatus(itemId, status, sourcePlan) {
   if (!itemId) return;
   if (!_VALID_PRD_STATUSES.has(status)) return;
@@ -637,11 +639,12 @@ function syncPrdItemStatus(itemId, status, sourcePlan) {
   } catch (err) { log('warn', `PRD status sync: ${err.message}`); }
 }
 
-// ─── PRD Backward-Scan Reconciliation (#929) ────────────────────────────────
-// Proactive counterpart to syncPrdItemStatus. Scans all active PRDs and promotes
-// "missing" items to "updated" when a done work item already exists for that ID.
-// This catches cases where a PRD regeneration incorrectly sets items to "missing"
-// and no subsequent work item state change triggers the reactive sync.
+// ─── PRD Backward-Scan Reconciliation (#929, #984) ─────────────────────────
+// Proactive counterpart to syncPrdItemStatus. Scans all active PRDs and:
+// 1. Promotes "missing" items to "updated" when a done work item already exists (#929)
+// 2. Promotes stale "dispatched"/"failed"/"pending" items to "done" when the work item
+//    is actually done (#984) — catches cases where fix work items complete with a
+//    different ID than the original PRD feature, leaving the PRD status stale.
 
 function reconcilePrdStatuses(config) {
   if (!fs.existsSync(PRD_DIR)) return;
@@ -674,6 +677,14 @@ function reconcilePrdStatuses(config) {
           modified = true;
           log('info', `PRD backward-scan: promoted ${feature.id} from missing→updated in ${file} (done work item exists)`);
         }
+        // (#984) Stale status: PRD item stuck at dispatched/failed/pending while WI is done —
+        // happens when fix work items complete with a different ID than the original PRD feature
+        else if (_STALE_PRD_STATUSES.has(feature.status) && doneWiById.has(feature.id)) {
+          const prev = feature.status;
+          feature.status = WI_STATUS.DONE;
+          modified = true;
+          log('info', `PRD backward-scan: promoted ${feature.id} from ${prev}→done in ${file} (done work item exists)`);
+        }
       }
 
       if (modified) {
@@ -1790,7 +1801,23 @@ async function runPostCompletionHooks(dispatchItem, agentId, code, stdout, confi
   }
 
   if (type === WORK_TYPE.REVIEW) await updatePrAfterReview(agentId, meta?.pr, meta?.project, config, resultSummary);
-  if (type === WORK_TYPE.FIX) updatePrAfterFix(meta?.pr, meta?.project, meta?.source);
+  if (type === WORK_TYPE.FIX) {
+    updatePrAfterFix(meta?.pr, meta?.project, meta?.source);
+    // (#984) Sync PRD status for PR-linked features: fix work items have a different ID
+    // than the original PRD feature, so syncPrdItemStatus(fixWiId, ...) finds nothing.
+    // Use the PR's prdItems to propagate done status when the original work item is done.
+    if (effectiveSuccess && meta?.pr?.prdItems?.length) {
+      try {
+        const allWis = queries.getWorkItems(config);
+        for (const prdItemId of meta.pr.prdItems) {
+          const wi = allWis.find(w => w.id === prdItemId);
+          if (wi && DONE_STATUSES.has(wi.status) && wi.sourcePlan) {
+            syncPrdItemStatus(prdItemId, WI_STATUS.DONE, wi.sourcePlan);
+          }
+        }
+      } catch (err) { log('warn', `PRD sync after fix: ${err.message}`); }
+    }
+  }
   checkForLearnings(agentId, config.agents[agentId], dispatchItem.task);
   if (effectiveSuccess) {
     extractSkillsFromOutput(stdout, agentId, dispatchItem, config);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.916",
+  "version": "0.1.917",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"