@yemi33/minions 0.1.901 → 0.1.903

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.1.903 (2026-04-12)
+
+### Fixes
+- make KB sweep endpoint async with status polling (#933)
+- prohibit agents from self-merging their own PRs
+
 ## 0.1.901 (2026-04-12)
 
 ### Fixes

package/dashboard/js/render-kb.js

@@ -144,21 +144,49 @@ async function kbSweep() {
   btn.style.color = 'var(--blue)';
   try {
     showToast('cmd-toast', 'KB sweep started', true);
-    const res = await fetch('/api/knowledge/sweep', { method: 'POST', signal: AbortSignal.timeout(300000), headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({ pinnedKeys: getPinnedItems().filter(function(k) { return k.startsWith('knowledge/'); }) }) });
-    const data = await res.json();
-    if (data.ok) {
-      btn.textContent = 'done';
-      btn.style.color = 'var(--green)';
-      refreshKnowledgeBase();
-    } else {
+    const triggerRes = await fetch('/api/knowledge/sweep', { method: 'POST', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({ pinnedKeys: getPinnedItems().filter(function(k) { return k.startsWith('knowledge/'); }) }) });
+    const triggerData = await triggerRes.json();
+    if (!triggerData.ok) {
       btn.style.color = 'var(--red)';
       btn.textContent = 'failed';
-      showToast('cmd-toast', 'Sweep failed: ' + (data.error || 'unknown'), false);
+      showToast('cmd-toast', 'Sweep failed: ' + (triggerData.error || 'unknown'), false);
+      setTimeout(function() { btn.textContent = origText; btn.style.color = 'var(--muted)'; btn.disabled = false; }, 60000);
+      return;
+    }
+    // Poll status until sweep completes (every 3s, up to 10 min)
+    var maxPolls = 200;
+    var pollCount = 0;
+    while (pollCount < maxPolls) {
+      await new Promise(function(r) { setTimeout(r, 3000); });
+      pollCount++;
+      try {
+        var statusRes = await fetch('/api/knowledge/sweep/status');
+        var statusData = await statusRes.json();
+        if (!statusData.inFlight) {
+          var result = statusData.lastResult;
+          if (result && result.ok) {
+            btn.textContent = 'done';
+            btn.style.color = 'var(--green)';
+            showToast('cmd-toast', 'KB sweep complete: ' + (result.summary || 'done'), true);
+            refreshKnowledgeBase();
+          } else {
+            btn.style.color = 'var(--red)';
+            btn.textContent = 'failed';
+            showToast('cmd-toast', 'Sweep failed: ' + ((result && result.error) || 'unknown'), false);
+          }
+          break;
+        }
+      } catch { /* poll error — retry */ }
+    }
+    if (pollCount >= maxPolls) {
+      btn.textContent = 'timeout';
+      btn.style.color = 'var(--red)';
+      showToast('cmd-toast', 'Sweep polling timed out — check status later', false);
     }
     // Show notification on sidebar if user is on a different page
     var kbLink = document.querySelector('.sidebar-link[data-page="inbox"]');
     var activePage = document.querySelector('.sidebar-link.active')?.getAttribute('data-page');
-    if (kbLink && activePage !== 'inbox') showNotifBadge(kbLink, data.ok ? 'done' : 'done');
+    if (kbLink && activePage !== 'inbox') showNotifBadge(kbLink, 'done');
   } catch (e) {
     btn.style.color = 'var(--red)';
     btn.textContent = 'failed';
@@ -167,8 +195,8 @@ async function kbSweep() {
     var activePage2 = document.querySelector('.sidebar-link.active')?.getAttribute('data-page');
     if (kbLink2 && activePage2 !== 'inbox') showNotifBadge(kbLink2);
   }
-  const isError = btn.textContent === 'failed';
-  setTimeout(() => { btn.textContent = origText; btn.style.color = 'var(--muted)'; btn.disabled = false; }, isError ? 60000 : 3000);
+  var isError = btn.textContent === 'failed' || btn.textContent === 'timeout';
+  setTimeout(function() { btn.textContent = origText; btn.style.color = 'var(--muted)'; btn.disabled = false; }, isError ? 60000 : 3000);
 }
 
 function openCreateKbModal() {

package/dashboard.js

@@ -1942,16 +1942,28 @@ const server = http.createServer(async (req, res) => {
       console.log('[kb-sweep] Auto-releasing stale guard (>5min)');
       global._kbSweepInFlight = false;
     }
-    if (global._kbSweepInFlight) return jsonReply(res, 409, { error: 'sweep already in progress' });
+    if (global._kbSweepInFlight) {
+      return jsonReply(res, 200, { ok: true, alreadyRunning: true, startedAt: global._kbSweepStartedAt });
+    }
     // Generation token prevents stale finally blocks from clearing the flag for a new sweep
     const sweepToken = Date.now() + Math.random();
     global._kbSweepToken = sweepToken;
     global._kbSweepInFlight = true;
     global._kbSweepStartedAt = Date.now();
+    const body = await readBody(req).catch(() => ({}));
+    // Run sweep in background — return immediately so agents/UI don't time out
+    _runKbSweepBackground(body, sweepToken);
+    return jsonReply(res, 202, { ok: true, started: true });
+  }
+
+  async function _runKbSweepBackground(body, sweepToken) {
     try {
-      const body = await readBody(req).catch(() => ({}));
       const entries = getKnowledgeBaseEntries();
-      if (entries.length < 2) return jsonReply(res, 200, { ok: true, summary: 'nothing to sweep (< 2 entries)' });
+      if (entries.length < 2) {
+        global._kbSweepLastResult = { ok: true, summary: 'nothing to sweep (< 2 entries)' };
+        global._kbSweepLastCompletedAt = Date.now();
+        return;
+      }
 
       // Build a manifest of all KB entries with their content (skip pinned — user wants to keep them)
       const pinnedKeys = new Set(body.pinnedKeys || []);
@@ -2012,10 +2024,12 @@ If nothing to do: { "duplicates": [], "reclassify": [], "remove": [] }`;
       let removed = 0, reclassified = 0, merged = 0;
       const kbDir = path.join(MINIONS_DIR, 'knowledge');
 
-      // If nothing to do, return early
+      // If nothing to do, store result and return
       const totalActions = (plan.remove || []).length + (plan.duplicates || []).reduce((n, d) => n + (d.remove || []).length, 0) + (plan.reclassify || []).length;
       if (totalActions === 0) {
-        return jsonReply(res, 200, { ok: true, summary: 'KB is clean — nothing to sweep', plan });
+        global._kbSweepLastResult = { ok: true, summary: 'KB is clean — nothing to sweep', plan };
+        global._kbSweepLastCompletedAt = Date.now();
+        return;
       }
 
       // Archive dir for swept files (never delete, always preserve)
@@ -2086,8 +2100,22 @@ If nothing to do: { "duplicates": [], "reclassify": [], "remove": [] }`;
 
       const summary = `${merged} duplicates merged, ${removed} stale removed, ${reclassified} reclassified${pruned ? ', ' + pruned + ' old swept files pruned' : ''}`;
       safeWrite(path.join(ENGINE_DIR, 'kb-swept.json'), JSON.stringify({ timestamp: new Date().toISOString(), summary }));
-      return jsonReply(res, 200, { ok: true, summary, plan });
-    } catch (e) { return jsonReply(res, 500, { error: e.message }); } finally { if (global._kbSweepToken === sweepToken) global._kbSweepInFlight = false; }
+      global._kbSweepLastResult = { ok: true, summary, plan };
+      global._kbSweepLastCompletedAt = Date.now();
+    } catch (e) {
+      console.error('[kb-sweep] background error:', e.message);
+      global._kbSweepLastResult = { ok: false, error: e.message };
+      global._kbSweepLastCompletedAt = Date.now();
+    } finally { if (global._kbSweepToken === sweepToken) global._kbSweepInFlight = false; }
+  }
+
+  function handleKnowledgeSweepStatus(req, res) {
+    return jsonReply(res, 200, {
+      inFlight: !!global._kbSweepInFlight,
+      startedAt: global._kbSweepStartedAt || null,
+      lastResult: global._kbSweepLastResult || null,
+      lastCompletedAt: global._kbSweepLastCompletedAt || null
+    });
   }
 
   async function handlePlansList(req, res) {
@@ -4131,7 +4159,8 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       invalidateStatusCache();
       return jsonReply(res, 200, { ok: true, path: filePath });
     }},
-    { method: 'POST', path: '/api/knowledge/sweep', desc: 'Deduplicate, consolidate, and reorganize knowledge base', handler: handleKnowledgeSweep },
+    { method: 'POST', path: '/api/knowledge/sweep', desc: 'Trigger async KB sweep (returns 202)', handler: handleKnowledgeSweep },
+    { method: 'GET', path: '/api/knowledge/sweep/status', desc: 'Poll KB sweep status', handler: handleKnowledgeSweepStatus },
     { method: 'GET', path: /^\/api\/knowledge\/([^/]+)\/([^?]+)/, desc: 'Read a specific knowledge base entry', handler: handleKnowledgeRead },
 
     // Doc chat

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.901",
+  "version": "0.1.903",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/playbooks/fix.md

@@ -76,6 +76,8 @@ After pushing, respond to each review comment/thread:
 
 Your task is complete once you have: (1) confirmed build and tests pass, (2) pushed the fix, (3) commented on the PR, and (4) resolved addressed review threads. Do NOT continue exploring unrelated code or making additional improvements. Stop immediately.
 
+**NEVER run `gh pr merge` or any merge command on this PR.** The engine handles merging after review approval. Self-merging bypasses the review cycle and is prohibited.
+
 ## Completion
 
 After finishing, output a structured completion block so the engine can parse your results:

package/playbooks/implement.md

@@ -82,3 +82,5 @@ Include build/test status and run instructions in the PR description. If the pro
 ## When to Stop
 
 Your task is complete once you have: (1) confirmed build and tests pass, (2) pushed your branch, and (3) created the PR. Your final message MUST include the PR URL so the engine can track it. Stop immediately after.
+
+**NEVER run `gh pr merge` or any merge command on your own PR.** The engine reviews and merges PRs through a separate review cycle. Self-merging bypasses code review entirely and is prohibited regardless of circumstances.

package/playbooks/work-item.md

@@ -58,3 +58,5 @@ If you encounter merge conflicts during push or PR creation:
 ## When to Stop
 
 Your task is complete once you have: (1) confirmed build and tests pass, (2) pushed your branch, and (3) created the PR. Do NOT continue beyond the task description. Stop immediately.
+
+**NEVER run `gh pr merge` or any merge command on your own PR.** The engine reviews and merges PRs through a separate review cycle. Self-merging bypasses code review entirely and is prohibited regardless of circumstances.