@yemi33/minions 0.1.886 → 0.1.888

package/CHANGELOG.md

@@ -1,11 +1,12 @@
 # Changelog
 
-## 0.1.886 (2026-04-11)
+## 0.1.888 (2026-04-11)
 
 ### Features
 -  add 13 missing CC action types for full dashboard parity
 
 ### Fixes
+- require explicit vote step in review playbook
 -  CC queued message silently retries on 429 after abort
 - track e2e/ and fix/ branches in PR reconciler
 - show stale banner on paused PRDs (#905) (#909)
@@ -17,6 +18,7 @@
 - include started_at in done/error agent status so duration renders
 
 ### Other
+- refactor: extract reopenWorkItem helper to shared.js
 - simplify: fix CC regenerate-plan field name, remove dead revise-and-regenerate handler
 - remove doc-chat plan auto-pause in favour of stale banner only
 - simplify: CC actions cleanup — missing wakeEngine, redundant refresh, hardened fallback

package/engine/shared.js

@@ -910,6 +910,19 @@ function mutateWorkItems(filePath, mutator) {
   }, { defaultValue: [] });
 }
 
+/**
+ * Reset a done work item for re-dispatch. Clears completion/dispatch metadata.
+ * Caller must set description/title separately.
+ */
+function reopenWorkItem(wi) {
+  wi.status = WI_STATUS.PENDING;
+  wi._reopened = true;
+  delete wi.completedAt;
+  delete wi.dispatched_at;
+  delete wi.dispatched_to;
+  wi._retryCount = 0;
+}
+
 /**
  * Atomic read-modify-write for pull-requests JSON files.
  * Wraps mutateJsonFileLocked with defaultValue of [].
@@ -1043,6 +1056,7 @@ module.exports = {
   withFileLock,
   mutateJsonFileLocked,
   mutateWorkItems,
+  reopenWorkItem,
   mutatePullRequests,
   uid,
   uniquePath,

package/engine.js

@@ -1520,12 +1520,11 @@ function materializePlansAsWorkItems(config) {
 
       mutateWorkItems(wiPath, existingItems => {
         for (const item of projItems) {
-          // Re-open: only 'updated' re-opens a done work item (missing = new item, not re-open)
+          // Re-open: 'updated' or 'missing' re-opens a done work item (#906)
           const existingWi = existingItems.find(w => w.id === item.id);
-          const shouldReopen = item.status === PRD_ITEM_STATUS.UPDATED;
+          const shouldReopen = item.status === PRD_ITEM_STATUS.UPDATED || item.status === PRD_ITEM_STATUS.MISSING;
           if (existingWi && DONE_STATUSES.has(existingWi.status) && shouldReopen) {
-            existingWi.status = WI_STATUS.PENDING;
-            existingWi._reopened = true;
+            shared.reopenWorkItem(existingWi);
             existingWi.description = buildWiDescription(item, file);
             existingWi.title = `Implement: ${item.name}`;
             created++;
@@ -1609,8 +1608,7 @@ function materializePlansAsWorkItems(config) {
         mutateWorkItems(rPath, items => {
           const target = items.find(w => w.id === itemId);
           if (target && DONE_STATUSES.has(target.status)) {
-            target.status = WI_STATUS.PENDING;
-            target._reopened = true;
+            shared.reopenWorkItem(target);
             target.description = buildWiDescription(rItem, file);
             target.title = `Implement: ${rItem.name}`;
           }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.886",
+  "version": "0.1.888",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/playbooks/review.md

@@ -40,26 +40,28 @@ Use subagents only for genuinely parallel, independent tasks (e.g., reviewing un
    - Verdict: **APPROVE**
    - Note any minor non-blocking suggestions
 
-## Post Review — Comment AND Vote on PR
+## Post Review — Two required actions, both mandatory
 
-Do both of the following:
+You MUST complete BOTH steps below. The review is NOT done until both are confirmed. A comment without a vote is an incomplete review.
 
-### Step 1: Leave a detailed review comment
+### Step 1: Post a detailed review comment
 
 {{pr_comment_instructions}}
-- pullRequestId: `{{pr_number}}`
 - content: Your full review with verdict, findings, and sign-off
 - Sign: `Review by Minions ({{agent_name}} — {{agent_role}})`
 
-### Step 2: Set your vote on the PR
+### Step 2: Submit a formal review vote — THIS IS REQUIRED
+
+**This is a separate action from Step 1.** Posting a comment does NOT submit a vote. You must explicitly run the vote command:
 
 {{pr_vote_instructions}}
-- pullRequestId: `{{pr_number}}`
-- If your verdict is **APPROVE**: vote `10` (approved)
-- If your verdict is **REQUEST_CHANGES**: vote `-10` (rejected)
-- If you have minor non-blocking suggestions: vote `5` (approved with suggestions)
+- If your verdict is **APPROVE**: use `--approve`
+- If your verdict is **REQUEST_CHANGES**: use `--request-changes`
+- If you have minor non-blocking suggestions only: use `--approve` with a note
+
+**Do not stop after Step 1.** The task is incomplete until Step 2 is done.
 
-This vote is visible to human reviewers in the PR UI and helps them understand the minions's assessment.
+After running the vote command, confirm it succeeded (check the command output for errors). If it fails, retry once.
 
 ## Handling Merge Conflicts
 If you encounter merge conflicts (e.g., the PR shows conflicts):
@@ -69,5 +71,9 @@ If you encounter merge conflicts (e.g., the PR shows conflicts):
 
 ## When to Stop
 
-Your task is complete once you have: (1) posted your review comment on the PR, and (2) cast your vote. Do NOT continue reading unrelated files or performing additional analysis. Stop after voting.
+Your task is complete only when BOTH of these are true:
+1. Review comment posted (Step 1)
+2. Formal vote submitted via `gh pr review --approve` or `--request-changes` (Step 2)
+
+Do NOT stop after only posting a comment. Do NOT continue reading unrelated files after voting.