@yemi33/minions 0.1.808 → 0.1.810

package/CHANGELOG.md

@@ -1,14 +1,16 @@
 # Changelog
 
-## 0.1.808 (2026-04-10)
+## 0.1.810 (2026-04-10)
 
 ### Features
+-  CC race condition fixes, doc-chat expand, settings save fix, metric rate
 -  configurable ignored comment authors — auto-filtered, never trigger fixes
 -  add open-source community sources to agentic research pipeline
 -  broaden daily pipeline research from Anthropic-only to full agentic space
 -  cap review→fix cycles at evalMaxIterations (default 3)
 
 ### Fixes
+-  allow agents to explain rationale instead of blindly fixing review feedback
 -  don't URL-encode ADO branchName filter (refs/heads/ format expected raw)
 -  ADO build query filters by source branch (not all org builds)
 -  adoFetch supports method/body for PATCH requests (auto-complete)
@@ -28,7 +30,6 @@
 -  flush queued CC messages as single combined request
 -  human feedback fixes are never capped (only minion review→fix loop is)
 -  5 bugs from comprehensive audit
--  stale ADO build detection + merge conflict auto-fix for both platforms
 
 ## 0.1.782 (2026-04-10)
 

package/dashboard/js/command-center.js

@@ -379,10 +379,10 @@ async function ccSend() {
   var wasAborted = await _ccDoSend(message);
 
   // Flush queued messages — combine into single request
-  if (tab._queue && tab._queue.length > 0 && !wasAborted) {
+  if (tab._queue && tab._queue.length > 0) {
     var combined = tab._queue.splice(0).join('\n\n');
     _renderQueueIndicator();
-    wasAborted = await _ccDoSend(combined);
+    await _ccDoSend(combined);
   }
 }
 

package/dashboard/js/modal-qa.js

@@ -26,6 +26,7 @@ let _qaHistory = []; // multi-turn conversation history [{role:'user',text:''},{
 let _qaProcessing = false; // true while waiting for response
 let _qaAbortController = null;
 let _qaQueue = []; // queued messages while processing
+const QA_QUEUE_CAP = 10; // max queued messages
 let _qaSessionKey = ''; // key for current conversation (title or filePath)
 const _qaSessions = new Map(); // persist conversations across modal open/close {key → {history, threadHtml}}
 // Restore from localStorage
@@ -103,7 +104,9 @@ function _initQaSession() {
     _qaHistory = [];
     document.getElementById('modal-qa-thread').innerHTML = '';
     var wrap = document.getElementById('modal-qa-thread-wrap');
+    var expandBar = document.getElementById('qa-expand-bar');
     if (wrap) wrap.style.display = 'none';
+    if (expandBar) expandBar.style.display = 'none';
   }
 }
 
@@ -113,7 +116,9 @@ function clearQaConversation() {
   _qaProcessing = false;
   document.getElementById('modal-qa-thread').innerHTML = '';
   var wrap = document.getElementById('modal-qa-thread-wrap');
+  var expandBar = document.getElementById('qa-expand-bar');
   if (wrap) wrap.style.display = 'none';
+  if (expandBar) expandBar.style.display = 'none';
   if (_qaSessionKey) _qaSessions.delete(_qaSessionKey);
 }
 
@@ -156,10 +161,14 @@ function modalSend() {
   document.getElementById('modal-qa-pill').style.display = 'none';
 
   if (_qaProcessing) {
+    if (_qaQueue.length >= QA_QUEUE_CAP) {
+      showToast('cmd-toast', 'Queue full — wait for current response', false);
+      return;
+    }
     // Queue the message — show it as "queued" in the thread
     _qaQueue.push({ message, selection });
-    const preview = message.split(/\s+/).slice(0, 6).join(' ') + (message.split(/\s+/).length > 6 ? '...' : '');
-    thread.innerHTML += '<div class="modal-qa-loading" style="color:var(--muted);font-size:10px">Queued: "' + escHtml(preview) + '" — will send after current response</div>';
+    const preview = escHtml(message.length > 60 ? message.slice(0, 57) + '...' : message);
+    thread.innerHTML += '<div class="qa-queued-item" style="color:var(--muted);font-size:10px;padding:4px 8px">Queued: "' + preview + '"</div>';
     thread.scrollTop = thread.scrollHeight;
     return;
   }
@@ -320,10 +329,9 @@ async function _processQaMessage(message, selection) {
   // Process next queued message
   if (_qaQueue.length > 0) {
     const next = _qaQueue.shift();
-    const queuedEls = thread.querySelectorAll('.modal-qa-loading');
-    for (const el of queuedEls) {
-      if (el.textContent.includes('Queued')) { el.remove(); break; }
-    }
+    // Remove the first queued indicator (matches the message being sent now)
+    const queuedEl = thread.querySelector('.qa-queued-item');
+    if (queuedEl) queuedEl.remove();
     _processQaMessage(next.message, next.selection);
   } else if (modalIsOpen) {
     document.getElementById('modal-qa-input')?.focus();
@@ -339,20 +347,18 @@ function qaAbort() {
 
 function toggleDocChat() {
   var wrap = document.getElementById('modal-qa-thread-wrap');
+  var expandBar = document.getElementById('qa-expand-bar');
   if (!wrap) return;
   var visible = wrap.style.display !== 'none';
   wrap.style.display = visible ? 'none' : '';
-  var btn = document.getElementById('qa-toggle-btn');
-  if (btn) btn.innerHTML = visible ? '&#x25B2; Expand' : '&#x25BC; Collapse';
+  if (expandBar) expandBar.style.display = visible ? '' : 'none';
 }
 
 function _showThreadWrap() {
   var wrap = document.getElementById('modal-qa-thread-wrap');
-  if (wrap && wrap.style.display === 'none') {
-    wrap.style.display = '';
-    var btn = document.getElementById('qa-toggle-btn');
-    if (btn) btn.innerHTML = '&#x25BC; Collapse';
-  }
+  var expandBar = document.getElementById('qa-expand-bar');
+  if (wrap) wrap.style.display = '';
+  if (expandBar) expandBar.style.display = 'none';
 }
 
 window.MinionsQA = { showModalQa, modalAskAboutSelection, clearQaSelection, clearQaConversation, modalSend, qaAbort, toggleDocChat, _showThreadWrap };

package/dashboard/js/render-other.js

@@ -73,8 +73,10 @@ function renderMetrics(metrics) {
 
   let html = '<table class="pr-table"><thead><tr><th>Agent</th><th>Done</th><th>Errors</th><th>PRs</th><th>Approved</th><th>Rejected</th><th>Rate</th><th>Reviews</th><th>Avg Runtime</th></tr></thead><tbody>';
   for (const [id, m] of rows) {
-    const rate = m.prsCreated > 0 ? Math.round((m.prsApproved / m.prsCreated) * 100) + '%' : '-';
-    const rateColor = m.prsCreated > 0 ? (m.prsApproved / m.prsCreated >= 0.7 ? 'var(--green)' : 'var(--red)') : 'var(--muted)';
+    const totalTasks = (m.tasksCompleted || 0) + (m.tasksErrored || 0);
+    const ratio = totalTasks > 0 ? m.tasksCompleted / totalTasks : 0;
+    const rate = totalTasks > 0 ? Math.round(ratio * 100) + '%' : '-';
+    const rateColor = totalTasks > 0 ? (ratio >= 0.7 ? 'var(--green)' : 'var(--red)') : 'var(--muted)';
     html += '<tr>' +
       '<td style="font-weight:600">' + escHtml(id) + '</td>' +
       '<td style="color:var(--green)">' + (m.tasksCompleted || 0) + '</td>' +

package/dashboard/layout.html

@@ -109,6 +109,9 @@
     </div>
     <div class="modal-body" id="modal-body"></div>
     <div class="modal-qa" id="modal-qa" style="display:none">
+      <div id="qa-expand-bar" style="display:none;text-align:center;padding:2px 0">
+        <button style="background:none;border:none;color:var(--muted);font-size:10px;cursor:pointer;padding:2px 6px" onclick="toggleDocChat()" title="Expand thread">&#x25B2; Expand chat</button>
+      </div>
       <div id="modal-qa-thread-wrap" style="display:none">
         <div style="display:flex;align-items:center;justify-content:space-between;margin-bottom:4px">
           <button id="qa-clear-btn" style="background:none;border:none;color:var(--muted);font-size:10px;cursor:pointer;padding:2px 6px" onclick="clearQaConversation()" title="Clear conversation">Clear</button>

package/dashboard.js

@@ -746,7 +746,7 @@ async function ccDocCall({ message, document, title, filePath, selection, canEdi
     store: 'doc', sessionKey,
     extraContext: docContext, label: 'doc-chat',
     allowedTools: canEdit ? 'Read,Write,Edit,Glob,Grep' : 'Read,Glob,Grep',
-    maxTurns: canEdit ? 15 : 10,
+    maxTurns: canEdit ? 25 : 10,
     skipStatePreamble: true,
     ...(model ? { model } : {}),
   });
@@ -2868,12 +2868,21 @@ What would you like to discuss or change? When you're happy, say "approve" and I
     } catch (e) { return jsonReply(res, 400, { error: e.message }); }
   }
 
+  const docChatInFlight = new Set(); // per-document concurrency guard
   async function handleDocChat(req, res) {
     try {
       const body = await readBody(req);
       if (!body.message) return jsonReply(res, 400, { error: 'message required' });
       if (!body.document) return jsonReply(res, 400, { error: 'document required' });
 
+      // Per-document concurrency guard — prevent parallel writes to same file
+      const docKey = body.filePath || body.title || 'default';
+      if (docChatInFlight.has(docKey)) {
+        return jsonReply(res, 429, { error: 'This document is already being processed — wait for the current response.' });
+      }
+      docChatInFlight.add(docKey);
+
+      try {
       const canEdit = !!body.filePath;
       const isJson = body.filePath?.endsWith('.json');
       let currentContent = body.document;
@@ -2999,6 +3008,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         return jsonReply(res, 200, { ok: true, answer, edited: true, content, actions, pausedPrd });
       }
       return jsonReply(res, 200, { ok: true, answer: answer + '\n\n(Read-only — changes not saved)', edited: false, actions });
+      } finally { docChatInFlight.delete(docKey); }
     } catch (e) { return jsonReply(res, 500, { error: e.message }); }
   }
 
@@ -3682,6 +3692,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       if (!config.claude) config.claude = {};
       if (!config.agents) config.agents = {};
 
+      const _clamped = [];
       if (body.engine) {
         const e = body.engine;
         const D = shared.ENGINE_DEFAULTS;
@@ -3695,14 +3706,13 @@ What would you like to discuss or change? When you're happy, say "approve" and I
           versionCheckInterval: [60000],
           maxBuildFixAttempts: [1, 10],
         };
-        const clamped = [];
         for (const [key, [min, max]] of Object.entries(numericFields)) {
           if (e[key] !== undefined) {
             let val = Number(e[key]) || D[key];
             const raw = val;
             val = Math.max(min, val);
             if (max !== undefined) val = Math.min(max, val);
-            if (val !== raw) clamped.push(`${key}: ${raw} → ${val} (range: ${min}–${max || '∞'})`);
+            if (val !== raw) _clamped.push(`${key}: ${raw} → ${val} (range: ${min}–${max || '∞'})`);
             config.engine[key] = val;
           }
         }
@@ -3766,10 +3776,10 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       reloadConfig();
       invalidateStatusCache();
       console.log('[settings] Saved config.json — engine keys:', Object.keys(config.engine || {}));
-      const msg = clamped.length > 0
-        ? 'Settings saved. Some values were adjusted: ' + clamped.join('; ')
+      const msg = (_clamped.length > 0)
+        ? 'Settings saved. Some values were adjusted: ' + _clamped.join('; ')
         : 'Settings saved. Engine picks up changes on next tick.';
-      return jsonReply(res, 200, { ok: true, message: msg, clamped });
+      return jsonReply(res, 200, { ok: true, message: msg, clamped: _clamped });
     } catch (e) { return jsonReply(res, 500, { error: e.message }); }
   }
 
@@ -4040,13 +4050,13 @@ What would you like to discuss or change? When you're happy, say "approve" and I
           description: '',
           agent: 'human',
           branch: '',
-          reviewStatus: autoObserve ? 'pending' : 'none',
-          status: autoObserve ? 'active' : 'linked',
+          reviewStatus: 'pending',
+          status: 'active',
           created: new Date().toISOString(),
           url,
           prdItems: [],
           _manual: true,
-          _autoObserve: !!autoObserve,
+          _contextOnly: !autoObserve,
           _context: context || '',
         });
         return prs;

package/engine/ado.js

@@ -189,7 +189,7 @@ async function forEachActivePr(config, token, callback) {
     if (!project.adoOrg || !project.adoProject || !project.repositoryId) continue;
 
     const prs = getPrs(project);
-    const activePrs = prs.filter(pr => pr.status === PR_STATUS.ACTIVE);
+    const activePrs = prs.filter(pr => shared.PR_POLLABLE_STATUSES.has(pr.status));
     if (activePrs.length === 0) continue;
 
     let projectUpdated = 0;
@@ -212,11 +212,18 @@ async function forEachActivePr(config, token, callback) {
 
     if (projectUpdated > 0) {
       mutateJsonFileLocked(shared.projectPrPath(project), (currentPrs) => {
-        // Only merge back PRs that the callback actually modified — not the entire
-        // stale snapshot, which would overwrite concurrent writes from other code paths
+        // Merge back updated PRs — preserve disk values that may have been changed
+        // by other writers between poll start and this write
         for (const updatedPr of activePrs) {
           const idx = currentPrs.findIndex(p => p.id === updatedPr.id);
-          if (idx >= 0) currentPrs[idx] = updatedPr;
+          if (idx >= 0) {
+            // Never downgrade reviewStatus from 'approved' — it's a permanent terminal state
+            // The disk version may have been set to 'approved' by another writer after we read
+            if (currentPrs[idx].reviewStatus === 'approved' && updatedPr.reviewStatus !== 'approved') {
+              updatedPr.reviewStatus = 'approved';
+            }
+            currentPrs[idx] = updatedPr;
+          }
           // Don't push if not found — it was deleted by another writer, respect that
         }
         // Remove duplicates — prefer merged/abandoned over active
@@ -297,6 +304,12 @@ async function pollPrStatus(config) {
       pr._adoHeadCommit = headCommit;
       updated = true;
     }
+    // Track source commit separately — detects actual author pushes vs target branch updates
+    const sourceCommit = prData.lastMergeSourceCommit?.commitId || '';
+    if (sourceCommit && pr._adoSourceCommit !== sourceCommit) {
+      pr._adoSourceCommit = sourceCommit;
+      updated = true;
+    }
 
     const reviewers = prData.reviewers || [];
     const votes = reviewers.map(r => r.vote).filter(v => v !== undefined);
@@ -304,6 +317,20 @@ async function pollPrStatus(config) {
     // Once approved, it stays approved permanently
     if (pr.reviewStatus === 'approved') {
       newReviewStatus = 'approved';
+      // Re-approve: ADO resets votes when target branch (master) advances, even though
+      // the source branch is unchanged. Re-apply the approval vote via API.
+      if (!votes.some(v => v >= 5) && sourceCommit && pr._adoSourceCommit === sourceCommit) {
+        try {
+          const identityData = await adoFetch(`${orgBase}/_apis/connectionData?api-version=7.1`, token).catch(() => null);
+          const myId = identityData?.authenticatedUser?.id;
+          if (myId) {
+            await adoFetch(`${repoBase}/reviewers/${myId}?api-version=7.1`, token, {
+              method: 'PUT', body: JSON.stringify({ vote: 10 })
+            });
+            log('info', `PR ${pr.id}: re-applied approval vote (ADO reset due to target branch update)`);
+          }
+        } catch (e) { log('warn', `PR ${pr.id}: failed to re-apply approval: ${e.message}`); }
+      }
     } else if (votes.length > 0) {
       if (votes.some(v => v === -10)) {
         if (pr.reviewStatus === 'waiting' && pr.minionsReview?.fixedAt && (!pr.lastPushedAt || pr.lastPushedAt <= pr.minionsReview.fixedAt)) {
@@ -334,24 +361,10 @@ async function pollPrStatus(config) {
       log('info', `PR ${pr.id} reviewStatus: ${pr.reviewStatus} → ${newReviewStatus}`);
       pr.reviewStatus = newReviewStatus;
       updated = true;
-      // Update author metrics when verdict changes to approved/rejected
-      if (newReviewStatus === 'approved' || newReviewStatus === 'changes-requested') {
-        const authorId = (pr.agent || '').toLowerCase();
-        if (authorId) {
-          try {
-            const metricsPath = path.join(__dirname, 'metrics.json');
-            mutateJsonFileLocked(metricsPath, (metrics) => {
-              if (!metrics[authorId]) metrics[authorId] = {};
-              if (newReviewStatus === 'approved') metrics[authorId].prsApproved = (metrics[authorId].prsApproved || 0) + 1;
-              else metrics[authorId].prsRejected = (metrics[authorId].prsRejected || 0) + 1;
-              return metrics;
-            });
-          } catch (err) { log('warn', `Metrics update: ${err.message}`); }
-        }
-        if (newReviewStatus === 'approved') {
-          delete pr._reviewFixCycles;
-          delete pr._evalEscalated;
-        }
+      shared.trackReviewMetric(pr, newReviewStatus, config);
+      if (newReviewStatus === 'approved') {
+        delete pr._reviewFixCycles;
+        delete pr._evalEscalated;
       }
     }
 
@@ -507,6 +520,8 @@ async function pollPrHumanComments(config) {
     const ignoredAuthors = (config.engine?.ignoredCommentAuthors || []).map(a => a.toLowerCase());
 
     for (const thread of threads) {
+      // Skip resolved/closed threads — only process active (1) and pending (6)
+      if (thread.status && thread.status !== 'active' && thread.status !== 1 && thread.status !== 6) continue;
       for (const comment of (thread.comments || [])) {
         if (!comment.content || comment.commentType === 'system') continue;
         const content = comment.content;

package/engine/cleanup.js

@@ -582,6 +582,99 @@ function runCleanup(config, verbose = false) {
     }
   } catch (e) { log('warn', 'migrate PRD legacy statuses: ' + e.message); }
 
+  // 10. Prune CC tab sessions — cap at 50 entries, remove oldest beyond cap
+  cleaned.ccSessions = 0;
+  try {
+    const ccSessionsPath = path.join(ENGINE_DIR, 'cc-sessions.json');
+    const sessions = shared.safeJsonArr(ccSessionsPath);
+    const CC_SESSIONS_CAP = 50;
+    if (sessions.length > CC_SESSIONS_CAP) {
+      // Sort by lastActiveAt descending, keep newest
+      sessions.sort((a, b) => new Date(b.lastActiveAt || 0) - new Date(a.lastActiveAt || 0));
+      const pruned = sessions.slice(0, CC_SESSIONS_CAP);
+      cleaned.ccSessions = sessions.length - pruned.length;
+      safeWrite(ccSessionsPath, pruned);
+    }
+  } catch (e) { log('warn', 'prune cc-sessions: ' + e.message); }
+
+  // 10b. Prune doc-chat sessions — cap at 100 entries, remove oldest beyond cap
+  cleaned.docSessions = 0;
+  try {
+    const docSessionsPath = path.join(ENGINE_DIR, 'doc-sessions.json');
+    const docSessions = safeJson(docSessionsPath);
+    if (docSessions && typeof docSessions === 'object') {
+      const entries = Object.entries(docSessions);
+      const DOC_SESSIONS_CAP = 100;
+      if (entries.length > DOC_SESSIONS_CAP) {
+        entries.sort((a, b) => new Date(b[1].lastActiveAt || 0) - new Date(a[1].lastActiveAt || 0));
+        const keep = Object.fromEntries(entries.slice(0, DOC_SESSIONS_CAP));
+        cleaned.docSessions = entries.length - DOC_SESSIONS_CAP;
+        safeWrite(docSessionsPath, keep);
+      }
+    }
+  } catch (e) { log('warn', 'prune doc-sessions: ' + e.message); }
+
+  // 11. Cap cooldowns.json — keep at most 500 entries (on top of 24h TTL in cooldown.js)
+  cleaned.cooldowns = 0;
+  try {
+    const cooldownPath = path.join(ENGINE_DIR, 'cooldowns.json');
+    const cooldowns = safeJson(cooldownPath);
+    if (cooldowns && typeof cooldowns === 'object') {
+      const entries = Object.entries(cooldowns);
+      const COOLDOWN_CAP = 500;
+      if (entries.length > COOLDOWN_CAP) {
+        // Keep most recent by timestamp
+        entries.sort((a, b) => (b[1].timestamp || 0) - (a[1].timestamp || 0));
+        const keep = Object.fromEntries(entries.slice(0, COOLDOWN_CAP));
+        cleaned.cooldowns = entries.length - COOLDOWN_CAP;
+        safeWrite(cooldownPath, keep);
+      }
+    }
+  } catch (e) { log('warn', 'cap cooldowns: ' + e.message); }
+
+  // 12. Clean stale PID files — remove PID files whose process is no longer running
+  cleaned.pidFiles = 0;
+  try {
+    const tmpDir = path.join(ENGINE_DIR, 'tmp');
+    if (fs.existsSync(tmpDir)) {
+      let pidDirEntries;
+      try { pidDirEntries = fs.readdirSync(tmpDir); } catch { pidDirEntries = []; }
+      const activePids = new Set();
+      for (const [, info] of activeProcesses) {
+        if (info.proc?.pid) activePids.add(String(info.proc.pid));
+      }
+      for (const f of pidDirEntries) {
+        if (!f.startsWith('pid-') || !f.endsWith('.pid')) continue;
+        const fp = path.join(tmpDir, f);
+        try {
+          const pidStr = fs.readFileSync(fp, 'utf8').trim();
+          // Skip if actively tracked
+          if (activePids.has(pidStr)) continue;
+          // Check if file is stale (>1 hour old)
+          const stat = fs.statSync(fp);
+          if (stat.mtimeMs < oneHourAgo) {
+            fs.unlinkSync(fp);
+            cleaned.pidFiles++;
+          }
+        } catch { /* cleanup */ }
+      }
+    }
+  } catch (e) { log('warn', 'clean stale PID files: ' + e.message); }
+
+  // 13. Prune test-results.json — keep last 200 entries
+  try {
+    const testResultsPath = path.join(ENGINE_DIR, 'test-results.json');
+    const results = shared.safeJsonArr(testResultsPath);
+    const TEST_RESULTS_CAP = 200;
+    if (results.length > TEST_RESULTS_CAP) {
+      safeWrite(testResultsPath, results.slice(-TEST_RESULTS_CAP));
+    }
+  } catch { /* optional — file may not exist */ }
+
+  if (cleaned.ccSessions + cleaned.docSessions + cleaned.cooldowns + cleaned.pidFiles > 0) {
+    log('info', `Cleanup (resources): ${cleaned.ccSessions} cc-sessions, ${cleaned.docSessions} doc-sessions, ${cleaned.cooldowns} cooldowns, ${cleaned.pidFiles} PID files`);
+  }
+
   return cleaned;
 }
 

package/engine/github.js

@@ -5,7 +5,7 @@
  */
 
 const shared = require('./shared');
-const { exec, execAsync, getProjects, projectPrPath, projectWorkItemsPath, safeJson, safeWrite, mutateJsonFileLocked, MINIONS_DIR, addPrLink, getPrLinks, log, ts, dateStamp, PR_STATUS } = shared;
+const { exec, execAsync, getProjects, projectPrPath, projectWorkItemsPath, safeJson, safeWrite, mutateJsonFileLocked, MINIONS_DIR, addPrLink, getPrLinks, log, ts, dateStamp, PR_STATUS, PR_POLLABLE_STATUSES } = shared;
 const { getPrs } = require('./queries');
 const path = require('path');
 
@@ -164,7 +164,7 @@ async function forEachActiveGhPr(config, callback) {
     if (isSlugInBackoff(slug)) continue;
 
     const prs = getPrs(project);
-    const activePrs = prs.filter(pr => pr.status === PR_STATUS.ACTIVE);
+    const activePrs = prs.filter(pr => PR_POLLABLE_STATUSES.has(pr.status));
     if (activePrs.length === 0) continue;
 
     // Probe repo accessibility before iterating PRs — avoids N warnings per inaccessible repo
@@ -194,7 +194,13 @@ async function forEachActiveGhPr(config, callback) {
         // Merge back updated PRs and deduplicate
         for (const updatedPr of activePrs) {
           const idx = currentPrs.findIndex(p => p.id === updatedPr.id);
-          if (idx >= 0) currentPrs[idx] = updatedPr;
+          if (idx >= 0) {
+            // Never downgrade reviewStatus from 'approved' — it's a permanent terminal state
+            if (currentPrs[idx].reviewStatus === 'approved' && updatedPr.reviewStatus !== 'approved') {
+              updatedPr.reviewStatus = 'approved';
+            }
+            currentPrs[idx] = updatedPr;
+          }
         }
         // Remove duplicates — prefer merged/abandoned over active
         const bestById = new Map();
@@ -214,7 +220,7 @@ async function forEachActiveGhPr(config, callback) {
   // Also poll manually-linked PRs from central pull-requests.json (extract slug from URL)
   const centralPath = path.join(MINIONS_DIR, 'pull-requests.json');
   const centralPrs = safeJson(centralPath) || [];
-  const activeCentral = centralPrs.filter(pr => pr.status === PR_STATUS.ACTIVE && pr.url);
+  const activeCentral = centralPrs.filter(pr => PR_POLLABLE_STATUSES.has(pr.status) && pr.url);
   let centralUpdated = 0;
   for (const pr of activeCentral) {
     const ghMatch = pr.url.match(/github\.com\/([^/]+\/[^/]+)\/pull\/(\d+)/);
@@ -348,21 +354,7 @@ async function pollPrStatus(config) {
         log('info', `PR ${pr.id} reviewStatus: ${pr.reviewStatus} → ${newReviewStatus}`);
         pr.reviewStatus = newReviewStatus;
         updated = true;
-        // Update author metrics when verdict changes to approved/rejected
-        if (newReviewStatus === 'approved' || newReviewStatus === 'changes-requested') {
-          const authorId = (pr.agent || '').toLowerCase();
-          if (authorId) {
-            try {
-              const metricsPath = path.join(__dirname, 'metrics.json');
-              mutateJsonFileLocked(metricsPath, (metrics) => {
-                if (!metrics[authorId]) metrics[authorId] = {};
-                if (newReviewStatus === 'approved') metrics[authorId].prsApproved = (metrics[authorId].prsApproved || 0) + 1;
-                else metrics[authorId].prsRejected = (metrics[authorId].prsRejected || 0) + 1;
-                return metrics;
-              });
-            } catch (err) { log('warn', `Metrics update: ${err.message}`); }
-          }
-        }
+        shared.trackReviewMetric(pr, newReviewStatus, config);
         // Reset review→fix cycle counter on approval (loop succeeded)
         if (newReviewStatus === 'approved') {
           delete pr._reviewFixCycles;

package/engine/shared.js

@@ -578,7 +578,24 @@ const PLAN_STATUS = {
   PAUSED: 'paused', REJECTED: 'rejected', COMPLETED: 'completed',
   REVISION_REQUESTED: 'revision-requested',
 };
-const PR_STATUS = { ACTIVE: 'active', MERGED: 'merged', ABANDONED: 'abandoned', CLOSED: 'closed' };
+const PR_STATUS = { ACTIVE: 'active', MERGED: 'merged', ABANDONED: 'abandoned', CLOSED: 'closed', LINKED: 'linked' };
+// PRs eligible for polling (status/build/comment checks) — excludes terminal statuses
+const PR_POLLABLE_STATUSES = new Set([PR_STATUS.ACTIVE, PR_STATUS.LINKED]);
+
+/** Update per-agent review metrics (prsApproved/prsRejected). Only writes for configured agents. */
+function trackReviewMetric(pr, newReviewStatus, config) {
+  if (newReviewStatus !== 'approved' && newReviewStatus !== 'changes-requested') return;
+  const authorId = (pr.agent || '').toLowerCase();
+  if (!authorId || !config?.agents?.[authorId]) return;
+  try {
+    mutateJsonFileLocked(path.join(__dirname, 'metrics.json'), (metrics) => {
+      if (!metrics[authorId]) metrics[authorId] = {};
+      if (newReviewStatus === 'approved') metrics[authorId].prsApproved = (metrics[authorId].prsApproved || 0) + 1;
+      else metrics[authorId].prsRejected = (metrics[authorId].prsRejected || 0) + 1;
+      return metrics;
+    });
+  } catch (err) { log('warn', `Metrics update: ${err.message}`); }
+}
 const DISPATCH_RESULT = { SUCCESS: 'success', ERROR: 'error', TIMEOUT: 'timeout' };
 const PIPELINE_STATUS = {
   PENDING: 'pending', RUNNING: 'running', COMPLETED: 'completed',
@@ -995,7 +1012,7 @@ module.exports = {
   KB_CATEGORIES,
   classifyInboxItem,
   ENGINE_DEFAULTS,
-  WI_STATUS, DONE_STATUSES, PLAN_TERMINAL_STATUSES, WORK_TYPE, PLAN_STATUS, PR_STATUS, DISPATCH_RESULT,
+  WI_STATUS, DONE_STATUSES, PLAN_TERMINAL_STATUSES, WORK_TYPE, PLAN_STATUS, PR_STATUS, PR_POLLABLE_STATUSES, DISPATCH_RESULT, trackReviewMetric,
   PIPELINE_STATUS, STAGE_TYPE, MEETING_STATUS, AGENT_STATUS,
   FAILURE_CLASS, ESCALATION_POLICY, COMPLETION_FIELDS,
   DEFAULT_AGENT_METRICS,

package/engine/timeout.js

@@ -316,6 +316,12 @@ function checkTimeouts(config) {
       const procInfo = activeProcesses.get(item.id);
       if (procInfo) {
         shared.killGracefully(procInfo.proc, 5000);
+        // On Unix, also kill child process tree (killGracefully only hits parent PID)
+        if (process.platform !== 'win32' && procInfo.proc?.pid) {
+          setTimeout(() => {
+            try { shared.exec(`pkill -KILL -P ${procInfo.proc.pid}`, { timeout: 3000 }); } catch { /* children may already be dead */ }
+          }, 6000); // after grace period
+        }
         activeProcesses.delete(item.id);
       }
       // Clear session so retry starts fresh instead of resuming the killed session

package/engine.js

@@ -1576,7 +1576,7 @@ async function discoverFromPrs(config, project) {
 
   const knownAgents = new Set(Object.keys(config.agents || {}));
   for (const pr of prs) {
-    if (pr.status !== 'active') continue;
+    if (pr.status !== PR_STATUS.ACTIVE || pr._contextOnly) continue;
     if (activePrIds.has(pr.id)) continue; // Skip PRs with active dispatch (prevent race)
     // Branch mutex: skip if PR branch is locked by any active dispatch (cross-type collision)
     if (pr.branch && isBranchActive(pr.branch)) {
@@ -1629,13 +1629,14 @@ async function discoverFromPrs(config, project) {
         const liveStatus = await checkFn(pr, project);
         if (liveStatus && liveStatus !== 'pending') {
           log('info', `Pre-dispatch vote check: ${pr.id} is ${liveStatus} (cached was pending) — skipping review`);
-          pr.reviewStatus = liveStatus;
+          // Never downgrade from approved
+          if (pr.reviewStatus !== 'approved') pr.reviewStatus = liveStatus;
           // Persist so next tick doesn't re-check
           try {
             mutateJsonFileLocked(projectPrPath(project), data => {
               if (!Array.isArray(data)) return data;
               const target = data.find(p => p.id === pr.id);
-              if (target) target.reviewStatus = liveStatus;
+              if (target && target.reviewStatus !== 'approved') target.reviewStatus = liveStatus;
               return data;
             });
           } catch {}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.808",
+  "version": "0.1.810",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/playbooks/fix.md

@@ -29,7 +29,9 @@ Use subagents only for genuinely parallel, independent tasks. For sequential wor
 
 1. You are already in the correct worktree on branch `{{pr_branch}}`. Do NOT create additional worktrees.
 
-2. Fix each issue listed above
+2. For each issue listed above, use your judgment:
+   - **Fix it** if the feedback is valid and improves the code
+   - **Explain your rationale** if you believe the current approach is correct — reply on the review thread explaining why, with specific reasoning (e.g., performance, consistency with codebase patterns, intentional design choice). Do NOT silently ignore feedback — always respond.
 
 3. Handle merge conflicts if any:
    - If `git pull` or the PR shows conflicts, resolve them in the worktree
@@ -64,11 +66,11 @@ Do NOT remove the worktree — the engine handles cleanup automatically.
 
 ## Resolve Review Comments
 
-After pushing, resolve each review comment/thread that you've addressed:
-- **GitHub**: Reply to each review comment confirming the fix, then resolve the conversation if possible
-- **ADO**: Reply to each thread with what was fixed, then set the thread status to `fixed` or `closed`
-
-Do NOT leave review threads open if you've addressed the finding — unresolved threads block auto-merge on some repos and create noise for human reviewers.
+After pushing, respond to each review comment/thread:
+- **If you fixed it**: Reply confirming the fix, then resolve the thread
+- **If you chose not to fix it**: Reply with your rationale explaining why the current approach is preferred — leave the thread open for the reviewer to decide
+- **GitHub**: Reply to each review comment, resolve conversations you've fixed
+- **ADO**: Reply to each thread, set status to `fixed` or `closed` for fixes; leave `active` for rationale replies
 
 ## When to Stop
 

package/prompts/cc-system.md

@@ -10,9 +10,29 @@ Minions state lives in `{{minions_dir}}/`. Key paths: `config.json` (config), `r
 
 ## Role: Orchestrator
 Default: **delegate to agents**. Agents have full Claude Code + worktrees + MCP tools.
-DELEGATE: code changes, fixes, PRs, reviews, exploration, testing, plans, architecture analysis.
-SELF: quick file reads, status lookups, notes/plan edits, routing updates, git ops user asked for.
-For exploration/investigation/research/audits — ALWAYS dispatch an `explore` work item.
+
+### When to delegate (ALWAYS)
+- Code changes, fixes, refactors, new features → `implement` or `fix`
+- Exploration, investigation, research, audits → `explore`
+- Code reviews → `review`
+- Testing → `test`
+- Architecture analysis → `explore`
+- Any task that would require **more than 3 tool calls** or touching **more than 2 files**
+
+### When to do it yourself (ONLY these)
+- Quick status lookups (reading 1-2 state files)
+- Notes, plan edits, KB entries, routing updates
+- Git ops the user explicitly asked CC to do
+- Simple config changes (`set-config`)
+- Answering questions from context you already have
+
+### Size estimation rule
+Before responding, estimate the task size:
+- **Small** (≤3 tool calls, 1-2 files): do it yourself
+- **Medium** (4-10 tool calls, 3+ files): DELEGATE to an agent
+- **Large** (10+ tool calls, cross-cutting): DELEGATE, consider a plan with decomposition
+
+When in doubt, delegate. You are the dispatcher, not the worker. Agents have isolated worktrees, full tool access, and no turn limits — they are better suited for real work.
 
 ## Actions
 Append actions at the END of your response. Write your response first, then `===ACTIONS===` on its own line, then a JSON array. No text after the JSON. Omit entirely if no actions needed.
@@ -57,4 +77,4 @@ Terms like schedules, pipelines, agents, inbox, work items, plans, PRD, PRs, dis
 1. Answer from the state preamble and context first. Only use tools for specific file lookups the user asked about — not to explore or investigate.
 2. Be specific — cite IDs, names, filenames, line numbers.
 3. Never modify engine source. Never push to git without user confirmation.
-4. Delegate exploration to agents. You are the dispatcher, not the worker. If answering requires reading more than 2-3 files, dispatch an agent instead.
+4. Delegate, don't do. If a task involves code changes, multi-file reads, debugging, or any real engineering work — dispatch an agent. Your tools are for quick lookups, not for doing the work.