@yemi33/minions 0.1.798 → 0.1.800

package/CHANGELOG.md

@@ -1,13 +1,15 @@
 # Changelog
 
-## 0.1.798 (2026-04-10)
+## 0.1.800 (2026-04-10)
 
 ### Features
+-  configurable ignored comment authors — auto-filtered, never trigger fixes
 -  add open-source community sources to agentic research pipeline
 -  broaden daily pipeline research from Anthropic-only to full agentic space
 -  cap review→fix cycles at evalMaxIterations (default 3)
 
 ### Fixes
+-  approved is permanent — no path can ever downgrade it
 -  allow fix dispatch on approved PRs (only guard is in updatePrAfterFix)
 -  bot comment on approved PR can no longer reset vote
 -  remove redundant 'PR' prefix from dispatch labels (id already has it)

package/dashboard/js/settings.js

@@ -54,6 +54,7 @@ async function openSettings() {
       settingsField('Eval Max Cost', 'set-evalMaxCost', e.evalMaxCost === null || e.evalMaxCost === undefined ? '' : e.evalMaxCost, '$', 'USD ceiling per work item across all eval iterations (blank = no limit)') +
       settingsField('Max Build Fix Attempts', 'set-maxBuildFixAttempts', e.maxBuildFixAttempts || 3, '', 'Max auto-fix dispatches per PR before escalating to human (1-10)') +
       settingsField('Version Check Interval', 'set-versionCheckInterval', e.versionCheckInterval || 3600000, 'ms', 'How often to check npm for updates (default: 1 hour)') +
+      settingsField('Ignored Comment Authors', 'set-ignoredCommentAuthors', (e.ignoredCommentAuthors || []).join(', '), '', 'Comma-separated usernames — comments auto-closed, never trigger fixes') +
     '</div>' +
 
     '<h3 style="font-size:13px;color:var(--blue);margin-bottom:8px">Max Turns by Task Type</h3>' +
@@ -210,6 +211,7 @@ async function saveSettings() {
       evalMaxIterations: document.getElementById('set-evalMaxIterations').value,
       evalMaxCost: document.getElementById('set-evalMaxCost').value || null,
       maxBuildFixAttempts: document.getElementById('set-maxBuildFixAttempts').value,
+      ignoredCommentAuthors: document.getElementById('set-ignoredCommentAuthors').value,
       versionCheckInterval: document.getElementById('set-versionCheckInterval').value,
       ccModel: document.getElementById('set-ccModel').value,
       ccEffort: document.getElementById('set-ccEffort').value || null,

package/dashboard.js

@@ -461,7 +461,8 @@ setInterval(() => {
 
 // ── Command Center: session state + helpers ─────────────────────────────────
 
-const CC_SESSION_EXPIRY_MS = 2 * 60 * 60 * 1000; // 2 hours
+// Sessions never expire by time — user controls lifecycle via tabs (new tab = new session, /clear = reset).
+// Only invalidated by: system prompt change, explicit clear, or tab close.
 const CC_SESSION_MAX_TURNS = Infinity;
 let ccSession = { sessionId: null, createdAt: null, lastActiveAt: null, turnCount: 0 };
 const ccInFlightTabs = new Set(); // per-tab in-flight tracking for parallel CC requests
@@ -477,17 +478,13 @@ function ccSessionValid() {
     ccSession = { sessionId: null, createdAt: null, lastActiveAt: null, turnCount: 0 };
     return false;
   }
-  const age = Date.now() - new Date(ccSession.lastActiveAt || 0).getTime();
-  return age < CC_SESSION_EXPIRY_MS && ccSession.turnCount < CC_SESSION_MAX_TURNS;
+  return ccSession.turnCount < CC_SESSION_MAX_TURNS;
 }
 
 // Load persisted CC session on startup
 try {
   const saved = safeJson(path.join(ENGINE_DIR, 'cc-session.json'));
-  if (saved && saved.sessionId) {
-    const age = Date.now() - new Date(saved.lastActiveAt || 0).getTime();
-    if (age < CC_SESSION_EXPIRY_MS) ccSession = saved;
-  }
+  if (saved && saved.sessionId) ccSession = saved;
 } catch { /* optional */ }
 
 // Static system prompt — baked into session on creation, never changes
@@ -584,10 +581,8 @@ const docSessions = new Map(); // key → { sessionId, lastActiveAt, turnCount }
 try {
   const saved = safeJson(DOC_SESSIONS_PATH);
   if (saved && typeof saved === 'object') {
-    const now = Date.now();
     for (const [key, s] of Object.entries(saved)) {
-      const age = now - new Date(s.lastActiveAt || 0).getTime();
-      if (age < CC_SESSION_EXPIRY_MS && s.turnCount < CC_SESSION_MAX_TURNS) {
+      if (s.turnCount < CC_SESSION_MAX_TURNS) {
         docSessions.set(key, s);
       }
     }
@@ -608,8 +603,7 @@ function resolveSession(store, key) {
   if (!key) return null;
   const s = docSessions.get(key);
   if (!s) return null;
-  const age = Date.now() - new Date(s.lastActiveAt).getTime();
-  if (age > CC_SESSION_EXPIRY_MS || s.turnCount >= CC_SESSION_MAX_TURNS) {
+  if (s.turnCount >= CC_SESSION_MAX_TURNS) {
     docSessions.delete(key);
     persistDocSessions();
     return null;
@@ -3342,9 +3336,15 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       ccInFlightTabs.add(tabId);
 
       try {
+        let sessionReset = false;
         if (body.sessionId && body.sessionId !== ccSession.sessionId) {
           ccSession = { sessionId: null, createdAt: null, lastActiveAt: null, turnCount: 0 };
         }
+        // Detect prompt hash change — force fresh session
+        if (body.sessionId && ccSession._promptHash && ccSession._promptHash !== _ccPromptHash) {
+          ccSession = { sessionId: null, createdAt: null, lastActiveAt: null, turnCount: 0 };
+          sessionReset = true;
+        }
         const wasResume = !!(body.sessionId && body.sessionId === ccSession.sessionId && ccSessionValid());
 
         const result = await ccCall(body.message, { store: 'cc' });
@@ -3365,7 +3365,9 @@ What would you like to discuss or change? When you're happy, say "approve" and I
           });
         }
 
-        return jsonReply(res, 200, { ...parseCCActions(result.text), sessionId: ccSession.sessionId, newSession: !wasResume });
+        const reply = { ...parseCCActions(result.text), sessionId: ccSession.sessionId, newSession: !wasResume };
+        if (sessionReset) reply.sessionReset = true;
+        return jsonReply(res, 200, reply);
       } finally {
         ccInFlightTabs.delete(tabId);
       }
@@ -3397,7 +3399,17 @@ What would you like to discuss or change? When you're happy, say "approve" and I
 
       try {
         // Session management — per-tab: use sessionId from request, don't mutate global ccSession
-        const tabSessionId = body.sessionId || null;
+        let tabSessionId = body.sessionId || null;
+        let sessionReset = false;
+        // If system prompt changed since this session was created, force a fresh session
+        if (tabSessionId) {
+          const sessions = shared.safeJsonArr(CC_SESSIONS_PATH);
+          const tabEntry = sessions.find(s => s.id === (body.tabId || 'default'));
+          if (tabEntry && tabEntry._promptHash && tabEntry._promptHash !== _ccPromptHash) {
+            tabSessionId = null;
+            sessionReset = true;
+          }
+        }
         const wasResume = !!tabSessionId;
         const sessionId = tabSessionId || null;
         const preamble = wasResume ? '' : buildCCStatePreamble();
@@ -3451,10 +3463,11 @@ What would you like to discuss or change? When you're happy, say "approve" and I
             if (existing) {
               existing.sessionId = responseSessionId;
               existing.lastActiveAt = new Date(now).toISOString();
-              existing.turnCount = (existing.turnCount || 0) + 1;
+              existing.turnCount = sessionReset ? 1 : (existing.turnCount || 0) + 1;
               existing.preview = preview;
+              existing._promptHash = _ccPromptHash;
             } else {
-              sessions.push({ id: tabId, title: (body.message || 'New chat').slice(0, 40), sessionId: responseSessionId, createdAt: new Date(now).toISOString(), lastActiveAt: new Date(now).toISOString(), turnCount: 1, preview });
+              sessions.push({ id: tabId, title: (body.message || 'New chat').slice(0, 40), sessionId: responseSessionId, createdAt: new Date(now).toISOString(), lastActiveAt: new Date(now).toISOString(), turnCount: 1, preview, _promptHash: _ccPromptHash });
             }
             safeWrite(CC_SESSIONS_PATH, sessions);
           } catch { /* non-critical */ }
@@ -3462,7 +3475,9 @@ What would you like to discuss or change? When you're happy, say "approve" and I
 
         // Send final result with actions
         const { text: displayText, actions } = parseCCActions(result.text);
-        res.write('data: ' + JSON.stringify({ type: 'done', text: displayText, actions, sessionId: responseSessionId, newSession: !wasResume }) + '\n\n');
+        const donePayload = { type: 'done', text: displayText, actions, sessionId: responseSessionId, newSession: !wasResume };
+        if (sessionReset) donePayload.sessionReset = true;
+        res.write('data: ' + JSON.stringify(donePayload) + '\n\n');
         _ccStreamEnded = true; res.end();
       } finally {
         ccInFlightTabs.delete(tabId);
@@ -3651,6 +3666,9 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         // Eval loop settings
         if (e.evalMaxIterations !== undefined) config.engine.evalMaxIterations = Math.max(1, Math.min(10, Number(e.evalMaxIterations) || D.evalMaxIterations));
         if (e.evalMaxCost !== undefined) config.engine.evalMaxCost = e.evalMaxCost === null || e.evalMaxCost === '' ? null : Math.max(0, Number(e.evalMaxCost) || 0);
+        if (e.ignoredCommentAuthors !== undefined) {
+          config.engine.ignoredCommentAuthors = String(e.ignoredCommentAuthors || '').split(',').map(s => s.trim().toLowerCase()).filter(Boolean);
+        }
       }
 
       if (body.claude) {

package/engine/ado.js

@@ -295,19 +295,18 @@ async function pollPrStatus(config) {
     const reviewers = prData.reviewers || [];
     const votes = reviewers.map(r => r.vote).filter(v => v !== undefined);
     let newReviewStatus = pr.reviewStatus || 'pending';
-    if (votes.length > 0) {
+    // Once approved, it stays approved permanently
+    if (pr.reviewStatus === 'approved') {
+      newReviewStatus = 'approved';
+    } else if (votes.length > 0) {
       if (votes.some(v => v === -10)) {
-        // Don't re-trigger 'changes-requested' if fix agent already responded (waiting state).
-        // Only re-trigger if there's been a new push since the fix (reviewer re-reviewed).
         if (pr.reviewStatus === 'waiting' && pr.minionsReview?.fixedAt && (!pr.lastPushedAt || pr.lastPushedAt <= pr.minionsReview.fixedAt)) {
-          newReviewStatus = 'waiting'; // fix was submitted, same vote still present — wait for re-review
+          newReviewStatus = 'waiting';
         } else {
           newReviewStatus = 'changes-requested';
         }
       }
       else if (votes.some(v => v >= 5)) newReviewStatus = 'approved';
-      // Never downgrade from 'approved' — only -10 (reject) can override it
-      else if (pr.reviewStatus === 'approved') newReviewStatus = 'approved';
       else if (votes.some(v => v === -5)) newReviewStatus = 'waiting';
       else newReviewStatus = 'pending';
     }
@@ -502,8 +501,10 @@ async function pollPrHumanComments(config) {
       for (const comment of (thread.comments || [])) {
         if (!comment.content || comment.commentType === 'system') continue;
         const content = comment.content;
-        // Skip bots and CI noise
+        // Skip bots, CI noise, and ignored authors
         const authorName = (comment.author?.displayName || '').toLowerCase();
+        const ignoredAuthors = (config.engine?.ignoredCommentAuthors || []).map(a => a.toLowerCase());
+        if (ignoredAuthors.some(a => authorName.includes(a))) continue;
         if (/\b(bot|service|build|pipeline|codecov|sonar)\b/i.test(authorName)) continue;
         if (/^#{1,3}\s*(Coverage|Build|Test|Deploy|Pipeline)\s*(Report|Status|Result|Summary)/i.test(content)) continue;
         // Detect agent comments (included in context, but don't trigger fix)

package/engine/github.js

@@ -330,8 +330,10 @@ async function pollPrStatus(config) {
       }
 
       let newReviewStatus = pr.reviewStatus || 'pending';
-      if (states.some(s => s === 'CHANGES_REQUESTED')) {
-        // Don't re-trigger if fix agent already responded — wait for re-review
+      // Once approved, it stays approved permanently
+      if (pr.reviewStatus === 'approved') {
+        newReviewStatus = 'approved';
+      } else if (states.some(s => s === 'CHANGES_REQUESTED')) {
         if (pr.reviewStatus === 'waiting' && pr.minionsReview?.fixedAt && (!pr.lastPushedAt || pr.lastPushedAt <= pr.minionsReview.fixedAt)) {
           newReviewStatus = 'waiting';
         } else {
@@ -339,8 +341,6 @@ async function pollPrStatus(config) {
         }
       }
       else if (states.some(s => s === 'APPROVED')) newReviewStatus = 'approved';
-      // Never downgrade from 'approved' — only CHANGES_REQUESTED can override it
-      else if (pr.reviewStatus === 'approved') newReviewStatus = 'approved';
       else if (states.length > 0) newReviewStatus = 'pending';
       else if (states.length === 0 && reviews.length > 0 && newReviewStatus === 'pending') newReviewStatus = 'waiting';
 
@@ -477,9 +477,11 @@ async function pollPrHumanComments(config) {
 
     // Separate: agent comments (included in context, don't trigger fix) vs human comments (trigger fix)
     // All non-bot, non-CI comments go into context. Only non-agent comments trigger pendingFix.
+    const ignoredAuthors = new Set((config.engine?.ignoredCommentAuthors || []).map(a => a.toLowerCase()));
     function _isBot(c) {
       if (c.user?.type === 'Bot') return true;
       const login = (c.user?.login || '').toLowerCase();
+      if (ignoredAuthors.has(login)) return true;
       if (/\b(bot|codecov|sonar|dependabot|renovate|github-actions|azure-pipelines)\b/i.test(login)) return true;
       const body = c.body || '';
       if (/^#{1,3}\s*(Coverage|Build|Test|Deploy|Pipeline)\s*(Report|Status|Result|Summary)/i.test(body)) return true;

package/engine/lifecycle.js

@@ -751,8 +751,8 @@ async function updatePrAfterReview(agentId, pr, project, config, resultSummary)
     if (!Array.isArray(prs)) return prs;
     const target = prs.find(p => p.id === pr.id);
     if (!target) return prs;
-    // Only update if live check returned decisive result; never downgrade from 'approved' unless explicitly rejected
-    if (postReviewStatus && !(target.reviewStatus === 'approved' && postReviewStatus !== 'changes-requested')) {
+    // Once approved, stays approved permanently — no path can downgrade
+    if (postReviewStatus && target.reviewStatus !== 'approved') {
       target.reviewStatus = postReviewStatus;
     }
     target.lastReviewedAt = ts();

package/engine/shared.js

@@ -549,6 +549,7 @@ const ENGINE_DEFAULTS = {
   buildFixGracePeriod: 600000, // 10min — wait for CI to run after build fix before re-dispatching
   autoCompletePrs: false, // auto-merge PRs when builds green + review approved (opt-in)
   prMergeMethod: 'squash', // merge method: squash, merge, rebase
+  ignoredCommentAuthors: [], // comments from these authors are auto-closed and never trigger fixes
   ccModel: 'sonnet', // model for Command Center and doc-chat (sonnet, haiku, opus)
   ccEffort: null, // effort level for CC/doc-chat (null, 'low', 'medium', 'high')
   ccMaxTurns: 50, // max tool-use turns for CC/doc-chat before CLI stops

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.798",
+  "version": "0.1.800",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"