@yemi33/minions 0.1.797 → 0.1.799

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.797 (2026-04-10)
+## 0.1.799 (2026-04-10)
 
 ### Features
 -  add open-source community sources to agentic research pipeline
@@ -8,6 +8,8 @@
 -  cap review→fix cycles at evalMaxIterations (default 3)
 
 ### Fixes
+-  approved is permanent — no path can ever downgrade it
+-  allow fix dispatch on approved PRs (only guard is in updatePrAfterFix)
 -  bot comment on approved PR can no longer reset vote
 -  remove redundant 'PR' prefix from dispatch labels (id already has it)
 -  include PR title in all dispatch labels and escalation alerts

package/engine/ado.js

@@ -295,19 +295,18 @@ async function pollPrStatus(config) {
     const reviewers = prData.reviewers || [];
     const votes = reviewers.map(r => r.vote).filter(v => v !== undefined);
     let newReviewStatus = pr.reviewStatus || 'pending';
-    if (votes.length > 0) {
+    // Once approved, it stays approved permanently
+    if (pr.reviewStatus === 'approved') {
+      newReviewStatus = 'approved';
+    } else if (votes.length > 0) {
       if (votes.some(v => v === -10)) {
-        // Don't re-trigger 'changes-requested' if fix agent already responded (waiting state).
-        // Only re-trigger if there's been a new push since the fix (reviewer re-reviewed).
         if (pr.reviewStatus === 'waiting' && pr.minionsReview?.fixedAt && (!pr.lastPushedAt || pr.lastPushedAt <= pr.minionsReview.fixedAt)) {
-          newReviewStatus = 'waiting'; // fix was submitted, same vote still present — wait for re-review
+          newReviewStatus = 'waiting';
         } else {
           newReviewStatus = 'changes-requested';
         }
       }
       else if (votes.some(v => v >= 5)) newReviewStatus = 'approved';
-      // Never downgrade from 'approved' — only -10 (reject) can override it
-      else if (pr.reviewStatus === 'approved') newReviewStatus = 'approved';
       else if (votes.some(v => v === -5)) newReviewStatus = 'waiting';
       else newReviewStatus = 'pending';
     }

package/engine/github.js

@@ -330,8 +330,10 @@ async function pollPrStatus(config) {
       }
 
       let newReviewStatus = pr.reviewStatus || 'pending';
-      if (states.some(s => s === 'CHANGES_REQUESTED')) {
-        // Don't re-trigger if fix agent already responded — wait for re-review
+      // Once approved, it stays approved permanently
+      if (pr.reviewStatus === 'approved') {
+        newReviewStatus = 'approved';
+      } else if (states.some(s => s === 'CHANGES_REQUESTED')) {
         if (pr.reviewStatus === 'waiting' && pr.minionsReview?.fixedAt && (!pr.lastPushedAt || pr.lastPushedAt <= pr.minionsReview.fixedAt)) {
           newReviewStatus = 'waiting';
         } else {
@@ -339,8 +341,6 @@ async function pollPrStatus(config) {
         }
       }
       else if (states.some(s => s === 'APPROVED')) newReviewStatus = 'approved';
-      // Never downgrade from 'approved' — only CHANGES_REQUESTED can override it
-      else if (pr.reviewStatus === 'approved') newReviewStatus = 'approved';
       else if (states.length > 0) newReviewStatus = 'pending';
       else if (states.length === 0 && reviews.length > 0 && newReviewStatus === 'pending') newReviewStatus = 'waiting';
 

package/engine/lifecycle.js

@@ -751,8 +751,8 @@ async function updatePrAfterReview(agentId, pr, project, config, resultSummary)
     if (!Array.isArray(prs)) return prs;
     const target = prs.find(p => p.id === pr.id);
     if (!target) return prs;
-    // Only update if live check returned decisive result; never downgrade from 'approved' unless explicitly rejected
-    if (postReviewStatus && !(target.reviewStatus === 'approved' && postReviewStatus !== 'changes-requested')) {
+    // Once approved, stays approved permanently — no path can downgrade
+    if (postReviewStatus && target.reviewStatus !== 'approved') {
       target.reviewStatus = postReviewStatus;
     }
     target.lastReviewedAt = ts();

package/engine.js

@@ -1659,7 +1659,7 @@ async function discoverFromPrs(config, project) {
     // PRs with pending human feedback (skip if review-fix already dispatched above)
     const humanFixKey = `human-fix-${project?.name || 'default'}-${pr.id}`;
     const hasCoalescedFeedback = (dispatchCooldowns.get(humanFixKey)?.pendingContexts || []).length > 0;
-    if ((pr.humanFeedback?.pendingFix || hasCoalescedFeedback) && !awaitingReReview && !fixDispatched && reviewStatus !== 'approved') {
+    if ((pr.humanFeedback?.pendingFix || hasCoalescedFeedback) && !awaitingReReview && !fixDispatched) {
       const key = humanFixKey;
       if (isAlreadyDispatched(key) || isOnCooldown(key, cooldownMs)) {
         // Coalesce: save feedback for next dispatch

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.797",
+  "version": "0.1.799",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"