@yemi33/minions 0.1.791 → 0.1.793

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.791 (2026-04-10)
+## 0.1.793 (2026-04-10)
 
 ### Features
 -  add open-source community sources to agentic research pipeline
@@ -8,6 +8,8 @@
 -  cap review→fix cycles at evalMaxIterations (default 3)
 
 ### Fixes
+-  never downgrade reviewStatus from 'approved' unless explicitly rejected
+-  warn on invalid pipeline JSON instead of silently dropping + add test
 -  repair invalid JSON in daily-arch-improvement pipeline
 -  flush queued CC messages as single combined request
 -  human feedback fixes are never capped (only minion review→fix loop is)

package/engine/ado.js

@@ -306,6 +306,8 @@ async function pollPrStatus(config) {
         }
       }
       else if (votes.some(v => v >= 5)) newReviewStatus = 'approved';
+      // Never downgrade from 'approved' — only -10 (reject) can override it
+      else if (pr.reviewStatus === 'approved') newReviewStatus = 'approved';
       else if (votes.some(v => v === -5)) newReviewStatus = 'waiting';
       else newReviewStatus = 'pending';
     }

package/engine/github.js

@@ -339,9 +339,9 @@ async function pollPrStatus(config) {
         }
       }
       else if (states.some(s => s === 'APPROVED')) newReviewStatus = 'approved';
+      // Never downgrade from 'approved' — only CHANGES_REQUESTED can override it
+      else if (pr.reviewStatus === 'approved') newReviewStatus = 'approved';
       else if (states.length > 0) newReviewStatus = 'pending';
-      // If all reviews were COMMENTED (filtered out), states is empty but reviews exist.
-      // Set to 'waiting' instead of leaving as 'pending' to prevent infinite review re-dispatch.
       else if (states.length === 0 && reviews.length > 0 && newReviewStatus === 'pending') newReviewStatus = 'waiting';
 
       if (pr.reviewStatus !== newReviewStatus) {

package/engine/lifecycle.js

@@ -751,7 +751,10 @@ async function updatePrAfterReview(agentId, pr, project, config, resultSummary)
     if (!Array.isArray(prs)) return prs;
     const target = prs.find(p => p.id === pr.id);
     if (!target) return prs;
-    if (postReviewStatus) target.reviewStatus = postReviewStatus; // only update if live check returned decisive result
+    // Only update if live check returned decisive result; never downgrade from 'approved' unless explicitly rejected
+    if (postReviewStatus && !(target.reviewStatus === 'approved' && postReviewStatus !== 'changes-requested')) {
+      target.reviewStatus = postReviewStatus;
+    }
     target.lastReviewedAt = ts();
     target.minionsReview = {
       reviewer: reviewerName,

package/engine/pipeline.js

@@ -20,7 +20,17 @@ function getPipelines() {
   if (!fs.existsSync(PIPELINES_DIR)) return [];
   return safeReadDir(PIPELINES_DIR)
     .filter(f => f.endsWith('.json'))
-    .map(f => safeJson(path.join(PIPELINES_DIR, f)))
+    .map(f => {
+      const filePath = path.join(PIPELINES_DIR, f);
+      try {
+        const parsed = JSON.parse(fs.readFileSync(filePath, 'utf8'));
+        if (!parsed) log('warn', `getPipelines: ${f} parsed to null — skipping`);
+        return parsed;
+      } catch (e) {
+        log('warn', `getPipelines: ${f} is invalid JSON — skipping (${e.message})`);
+        return null;
+      }
+    })
     .filter(Boolean);
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.791",
+  "version": "0.1.793",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"