@yemi33/minions 0.1.782 → 0.1.784

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.1.784 (2026-04-10)
+
+### Features
+-  cap review→fix cycles at evalMaxIterations (default 3)
+
+### Fixes
+-  don't overwrite approval with 'waiting' when platform API lags
+
 ## 0.1.782 (2026-04-10)
 
 ### Features

package/engine/ado.js

@@ -341,6 +341,10 @@ async function pollPrStatus(config) {
             });
           } catch (err) { log('warn', `Metrics update: ${err.message}`); }
         }
+        if (newReviewStatus === 'approved') {
+          delete pr._reviewFixCycles;
+          delete pr._evalEscalated;
+        }
       }
     }
 

package/engine/github.js

@@ -363,6 +363,11 @@ async function pollPrStatus(config) {
             } catch (err) { log('warn', `Metrics update: ${err.message}`); }
           }
         }
+        // Reset review→fix cycle counter on approval (loop succeeded)
+        if (newReviewStatus === 'approved') {
+          delete pr._reviewFixCycles;
+          delete pr._evalEscalated;
+        }
       }
     }
 

package/engine/lifecycle.js

@@ -730,7 +730,10 @@ async function updatePrAfterReview(agentId, pr, project, config, resultSummary)
   const completedEntry = (dispatch.completed || []).find(d => d.agent === agentId && d.type === 'review');
 
   // Check actual review status from the platform (agent may have approved or requested changes)
-  let postReviewStatus = 'waiting';
+  // Default to 'pending' (not 'waiting') — if platform hasn't propagated the vote yet,
+  // 'pending' lets the next poll cycle pick it up. 'waiting' would trigger the awaitingReReview
+  // gate and block the PR until the fix→re-review flow runs.
+  let postReviewStatus = 'pending';
   try {
     const projectObj = project || shared.getProjects(config)[0];
     if (projectObj) {
@@ -739,7 +742,6 @@ async function updatePrAfterReview(agentId, pr, project, config, resultSummary)
         ? require('./github').checkLiveReviewStatus
         : require('./ado').checkLiveReviewStatus;
       const liveStatus = await checkFn(pr, projectObj);
-      // Use live status only if it's a decisive verdict (not 'pending' — review may not have propagated yet)
       if (liveStatus && liveStatus !== 'pending') postReviewStatus = liveStatus;
     }
   } catch (e) { log('warn', `Post-review status check for ${pr.id}: ${e.message}`); }

package/engine.js

@@ -1576,9 +1576,26 @@ async function discoverFromPrs(config, project) {
     // The poller holds reviewStatus at 'waiting' until the reviewer acts on the new code.
     const awaitingReReview = reviewStatus === 'waiting' && !!pr.minionsReview?.fixedAt;
 
+    // Review→fix cycle cap — stop after N iterations, alert human
+    const evalMax = config.engine?.evalMaxIterations ?? DEFAULTS.evalMaxIterations;
+    const evalCycles = pr._reviewFixCycles || 0;
+    if (evalCycles >= evalMax && !pr._evalEscalated) {
+      writeInboxAlert(`eval-escalated-${pr.agent || 'unassigned'}-${pr.id}`,
+        `# Review Loop Escalation\n\n**PR ${pr.id}** on branch \`${pr.branch || 'unknown'}\` has gone through **${evalCycles}** review→fix cycles without approval.\n\n` +
+        `Last review: ${pr.minionsReview?.note ? pr.minionsReview.note.slice(0, 200) : 'See PR thread'}\n\n` +
+        `Auto-dispatch of reviews and fixes has been suspended. Please review the PR manually.`);
+      try {
+        mutatePullRequests(projectPrPath(project), prs => {
+          const target = prs.find(p => p.id === pr.id);
+          if (target) target._evalEscalated = true;
+        });
+      } catch (e) { log('warn', 'mark eval escalated: ' + e.message); }
+      log('warn', `PR ${pr.id}: review→fix escalated after ${evalCycles} cycles — suspending auto-dispatch`);
+      continue;
+    }
+
     // PRs needing review: pending review status and not already reviewed without new commits
     const autoReview = config.engine?.autoReview !== false;
-    // Skip re-dispatch if already reviewed and no new commits pushed since last review
     const alreadyReviewed = pr.lastReviewedAt && (!pr.lastPushedAt || pr.lastPushedAt <= pr.lastReviewedAt);
     const needsReview = autoReview && reviewStatus === 'pending' && !alreadyReviewed;
     if (needsReview) {
@@ -1627,7 +1644,16 @@ async function discoverFromPrs(config, project) {
         pr_id: pr.id, pr_branch: pr.branch || '',
         review_note: pr.minionsReview?.note || pr.reviewNote || 'See PR thread comments',
       }, `Fix PR ${pr.id} review feedback`, { dispatchKey: key, source: 'pr', pr, branch: pr.branch, project: projMeta });
-      if (item) { newWork.push(item); setCooldown(key); fixDispatched = true; }
+      if (item) {
+        newWork.push(item); setCooldown(key); fixDispatched = true;
+        // Increment review→fix cycle counter
+        try {
+          mutatePullRequests(projectPrPath(project), prs => {
+            const target = prs.find(p => p.id === pr.id);
+            if (target) target._reviewFixCycles = (target._reviewFixCycles || 0) + 1;
+          });
+        } catch (e) { log('warn', 'increment review-fix cycles: ' + e.message); }
+      }
     }
 
     // PRs with pending human feedback (skip if review-fix already dispatched above)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.782",
+  "version": "0.1.784",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"