@yemi33/minions 0.1.777 → 0.1.779

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.1.779 (2026-04-10)
+
+### Features
+-  auto-complete PRs when builds green + review approved
+
+## 0.1.778 (2026-04-10)
+
+### Fixes
+-  agent comments included in context but don't trigger fix dispatch
+
 ## 0.1.777 (2026-04-10)
 
 ### Fixes

package/dashboard/layout.html

@@ -32,11 +32,10 @@
       <span id="cc-session-info" style="font-size:10px;color:var(--muted)">New session</span>
     </div>
     <div style="display:flex;align-items:center;gap:8px">
-      <button onclick="ccNewTab()" style="background:none;border:1px solid var(--border);color:var(--muted);font-size:10px;padding:2px 8px;border-radius:3px;cursor:pointer">New Chat</button>
+      <button onclick="ccNewSession()" style="background:none;border:1px solid var(--border);color:var(--muted);font-size:10px;padding:2px 8px;border-radius:3px;cursor:pointer">Clear Chat</button>
       <button onclick="toggleCommandCenter()" style="background:none;border:none;color:var(--muted);font-size:16px;cursor:pointer;padding:2px 6px">&#10005;</button>
     </div>
   </div>
-  <div id="cc-tab-bar" style="display:flex;gap:4px;padding:4px 12px;border-bottom:1px solid var(--border);overflow-x:auto;align-items:center;flex-shrink:0"></div>
   <div id="cc-messages" style="flex:1;overflow-y:auto;padding:12px 16px;display:flex;flex-direction:column;gap:10px"></div>
   <div style="padding:12px 16px;border-top:1px solid var(--border)">
     <div style="display:flex;gap:8px">
@@ -99,7 +98,6 @@
     <div class="modal-header">
       <h3 id="modal-title">—</h3>
       <div class="modal-header-actions">
-        <button class="modal-copy" id="modal-back-btn" onclick="modalGoBack()" title="Back" style="display:none">&larr; Back</button>
         <button class="modal-copy" id="modal-edit-btn" onclick="modalToggleEdit()" title="Edit" style="display:none"><svg width="12" height="12" viewBox="0 0 16 16" fill="currentColor"><path d="M11.013 1.427a1.75 1.75 0 012.474 0l1.086 1.086a1.75 1.75 0 010 2.474l-8.61 8.61c-.21.21-.47.364-.756.445l-3.251.93a.75.75 0 01-.927-.928l.929-3.25c.081-.286.235-.547.445-.758l8.61-8.61zM12.9 2.97L4.288 11.58l-.537 1.878 1.878-.537L14.242 4.31 12.9 2.97z"/></svg> Edit</button>
         <button class="modal-copy" id="modal-save-btn" onclick="modalSaveEdit()" title="Save" style="display:none;color:var(--green);border-color:var(--green)"><svg width="12" height="12" viewBox="0 0 16 16" fill="currentColor"><path d="M13.78 4.22a.75.75 0 010 1.06l-7.25 7.25a.75.75 0 01-1.06 0L2.22 9.28a.75.75 0 011.06-1.06L6 10.94l6.72-6.72a.75.75 0 011.06 0z"/></svg> Save</button>
         <button class="modal-copy" id="modal-cancel-edit-btn" onclick="modalCancelEdit()" title="Cancel edit" style="display:none">Cancel</button>
@@ -113,14 +111,10 @@
       <div id="modal-qa-thread-wrap" style="display:none">
         <div style="display:flex;align-items:center;justify-content:space-between;margin-bottom:4px">
           <button id="qa-clear-btn" style="background:none;border:none;color:var(--muted);font-size:10px;cursor:pointer;padding:2px 6px" onclick="clearQaConversation()" title="Clear conversation">Clear</button>
-          <button id="qa-toggle-btn" style="background:none;border:none;color:var(--muted);font-size:10px;cursor:pointer;padding:2px 6px" onclick="toggleDocChat()" title="Collapse thread">&#x25BC; Collapse</button>
+          <button style="background:none;border:none;color:var(--muted);font-size:10px;cursor:pointer;padding:2px 6px" onclick="toggleDocChat()" id="qa-toggle-btn" title="Collapse thread">&#x25BC; Collapse</button>
         </div>
         <div class="modal-qa-thread" id="modal-qa-thread"></div>
       </div>
-      <div id="qa-expand-bar" style="display:none;margin-bottom:4px">
-        <button style="background:none;border:none;color:var(--muted);font-size:10px;cursor:pointer;padding:2px 6px" onclick="toggleDocChat()">&#x25B2; Show thread</button>
-      </div>
-      <div id="qa-action-slot"></div>
       <div class="modal-qa-selection-pill" id="modal-qa-pill" style="display:none">
         <span class="pill-label">Selection:</span>
         <span class="pill-text" id="modal-qa-pill-text"></span>

package/engine/ado.js

@@ -418,6 +418,31 @@ async function pollPrStatus(config) {
       }
     }
 
+    // Auto-complete: set auto-complete on PR when builds green + review approved
+    if (pr.status === PR_STATUS.ACTIVE && pr.reviewStatus === 'approved' && pr.buildStatus === 'passing' && !pr._autoCompleted) {
+      const autoComplete = config.engine?.autoCompletePrs !== false;
+      if (autoComplete) {
+        try {
+          const mergeStrategy = config.engine?.prMergeMethod === 'merge' ? 1 : config.engine?.prMergeMethod === 'rebase' ? 2 : 3; // 3 = squash
+          const identityUrl = `${orgBase}/_apis/connectionData?api-version=7.1`;
+          const identity = await adoFetch(identityUrl, token).catch(() => null);
+          const autoCompleteUrl = `${orgBase}/${project.adoProject}/_apis/git/repositories/${project.repositoryId}/pullrequests/${prNum}?api-version=7.1`;
+          await adoFetch(autoCompleteUrl, token, {
+            method: 'PATCH',
+            body: JSON.stringify({
+              autoCompleteSetBy: { id: identity?.authenticatedUser?.id },
+              completionOptions: { mergeStrategy, deleteSourceBranch: true, transitionWorkItems: true }
+            })
+          });
+          pr._autoCompleted = true;
+          log('info', `Auto-complete set on PR ${pr.id}: builds green + review approved`);
+          updated = true;
+        } catch (e) {
+          log('warn', `Auto-complete failed for PR ${pr.id}: ${e.message}`);
+        }
+      }
+    }
+
     return updated;
     } catch (err) {
       // Auth errors → mark build status stale so dashboard shows uncertainty
@@ -459,35 +484,37 @@ async function pollPrHumanComments(config) {
       for (const comment of (thread.comments || [])) {
         if (!comment.content || comment.commentType === 'system') continue;
         const content = comment.content;
-        // Minions agent signatures
-        if (/\bMinions\s*\(/i.test(content)) continue;
-        if (/\b(Review|Fixed|Explored|Verified|Tested)\s+by\s+Minions\b/i.test(content)) continue;
-        if (/\[minions\]/i.test(content)) continue;
-        // Skip bot/service account comments
+        // Skip bots and CI noise
         const authorName = (comment.author?.displayName || '').toLowerCase();
         if (/\b(bot|service|build|pipeline|codecov|sonar)\b/i.test(authorName)) continue;
-        // Short comments from same author that look agent-generated
-        if (content.length < 500 && /\b(fixed|addressed|resolved|pushed|updated|rebased)\b/i.test(content) && /\b(review|feedback|comment|finding)\b/i.test(content)) continue;
-        // Automated status comments (coverage, build reports)
         if (/^#{1,3}\s*(Coverage|Build|Test|Deploy|Pipeline)\s*(Report|Status|Result|Summary)/i.test(content)) continue;
+        // Detect agent comments (included in context, but don't trigger fix)
+        const isAgent = /\bMinions\s*\(/i.test(content) || /\bby\s+Minions\b/i.test(content) || /\[minions\]/i.test(content);
 
         const entry = {
           threadId: thread.id,
           commentId: comment.id,
           author: comment.author?.displayName || 'Human',
           content: comment.content,
-          date: comment.publishedDate
+          date: comment.publishedDate,
+          _isAgent: isAgent
         };
         allHumanComments.push(entry);
 
-        // Track which comments are new (for triggering — any new comment triggers a fix)
+        // Only non-agent new comments trigger a fix (agent reviews trigger via vote)
         const commentMs = comment.publishedDate ? new Date(comment.publishedDate).getTime() : 0;
-        if (commentMs && commentMs > cutoffMs) {
+        if (commentMs && commentMs > cutoffMs && !isAgent) {
           newHumanComments.push(entry);
         }
       }
     }
 
+    // Update cutoff even if only agent comments are new
+    const allNewDates = allHumanComments.filter(c => (new Date(c.date).getTime() || 0) > cutoffMs).map(c => c.date);
+    if (allNewDates.length > 0 && newHumanComments.length === 0) {
+      pr.humanFeedback = { ...(pr.humanFeedback || {}), lastProcessedCommentDate: allNewDates.sort().pop() };
+      return false;
+    }
     if (newHumanComments.length === 0) return false;
 
     // Sort all comments chronologically and build full context for the fix agent

package/engine/github.js

@@ -418,6 +418,22 @@ async function pollPrStatus(config) {
       }
     }
 
+    // Auto-complete: merge PR when builds green + review approved
+    if (pr.status === PR_STATUS.ACTIVE && pr.reviewStatus === 'approved' && pr.buildStatus === 'passing' && !pr._autoCompleted) {
+      const autoComplete = config.engine?.autoCompletePrs !== false; // default: on
+      if (autoComplete) {
+        try {
+          const mergeMethod = config.engine?.prMergeMethod || 'squash';
+          await execAsync(`gh pr merge ${prNum} --${mergeMethod} --repo ${slug} --delete-branch`, { timeout: 30000, encoding: 'utf-8' });
+          pr._autoCompleted = true;
+          log('info', `Auto-completed PR ${pr.id}: builds green + review approved → merged (${mergeMethod})`);
+          updated = true;
+        } catch (e) {
+          log('warn', `Auto-complete failed for PR ${pr.id}: ${e.message}`);
+        }
+      }
+    }
+
     return updated;
   });
 
@@ -441,27 +457,25 @@ async function pollPrHumanComments(config) {
       ...(Array.isArray(reviewComments) ? reviewComments : []).map(c => ({ ...c, _type: 'review' }))
     ];
 
-    // Filter out bot comments, minions agent comments, and CI noise
-    // Agents post as the PAT owner — detect by signature patterns, not account type
-    const prAuthorLogin = (prData?.user?.login || '').toLowerCase();
-    const humanComments = allComments.filter(c => {
-      if (c.user?.type === 'Bot') return false;
-      const body = c.body || '';
-      // Minions agent signatures (review, fix, explore, etc.)
-      if (/\bMinions\s*\(/i.test(body)) return false;
-      if (/\b(Review|Fixed|Explored|Verified|Tested)\s+by\s+Minions\b/i.test(body)) return false;
-      if (/\[minions\]/i.test(body)) return false;
-      // Comments from the PR author account are likely agent-generated (agents use same PAT)
-      // Only skip if the comment looks automated (short, or has agent patterns)
+    // Separate: agent comments (included in context, don't trigger fix) vs human comments (trigger fix)
+    // All non-bot, non-CI comments go into context. Only non-agent comments trigger pendingFix.
+    function _isBot(c) {
+      if (c.user?.type === 'Bot') return true;
       const login = (c.user?.login || '').toLowerCase();
-      if (login === prAuthorLogin && body.length < 500 && /\b(fixed|addressed|resolved|pushed|updated|rebased)\b/i.test(body)) return false;
-      // Common CI bot usernames
-      if (/\b(bot|codecov|sonar|dependabot|renovate|github-actions|azure-pipelines)\b/i.test(login)) return false;
-      // Automated status comments (coverage reports, build badges, etc.)
-      if (/^#{1,3}\s*(Coverage|Build|Test|Deploy|Pipeline)\s*(Report|Status|Result|Summary)/i.test(body)) return false;
-      if (/!\[.*\]\(https?:\/\/.*badge/i.test(body)) return false;
-      return true;
-    });
+      if (/\b(bot|codecov|sonar|dependabot|renovate|github-actions|azure-pipelines)\b/i.test(login)) return true;
+      const body = c.body || '';
+      if (/^#{1,3}\s*(Coverage|Build|Test|Deploy|Pipeline)\s*(Report|Status|Result|Summary)/i.test(body)) return true;
+      if (/!\[.*\]\(https?:\/\/.*badge/i.test(body)) return true;
+      return false;
+    }
+    function _isAgentComment(c) {
+      const body = c.body || '';
+      if (/\bMinions\s*\(/i.test(body)) return true;
+      if (/\bby\s+Minions\b/i.test(body)) return true;
+      if (/\[minions\]/i.test(body)) return true;
+      return false;
+    }
+    const humanComments = allComments.filter(c => !_isBot(c));
 
     const cutoffStr = pr.humanFeedback?.lastProcessedCommentDate || pr.created || '1970-01-01';
     const cutoffMs = new Date(cutoffStr).getTime() || 0;
@@ -472,21 +486,29 @@ async function pollPrHumanComments(config) {
 
     for (const c of humanComments) {
       const date = c.created_at || c.updated_at || '';
+      const isAgent = _isAgentComment(c);
       const entry = {
         commentId: c.id,
         author: c.user?.login || 'Human',
         content: c.body || '',
-        date
+        date,
+        _isAgent: isAgent
       };
       allCommentEntries.push(entry);
 
-      // Any new comment triggers a fix — no @minions filter needed
+      // Only non-agent new comments trigger a fix (agent reviews trigger via vote, not comment)
       const dateMs = date ? new Date(date).getTime() : 0;
-      if (dateMs && dateMs > cutoffMs) {
+      if (dateMs && dateMs > cutoffMs && !isAgent) {
         newComments.push(entry);
       }
     }
 
+    // Update cutoff even if only agent comments are new (so we don't re-scan them)
+    const allNewDates = allCommentEntries.filter(c => (new Date(c.date).getTime() || 0) > cutoffMs).map(c => c.date);
+    if (allNewDates.length > 0 && newComments.length === 0) {
+      pr.humanFeedback = { ...(pr.humanFeedback || {}), lastProcessedCommentDate: allNewDates.sort().pop() };
+      return false; // agent comments only — don't trigger fix
+    }
     if (newComments.length === 0) return false;
 
     // Sort all comments chronologically and build full context for the fix agent

package/engine/shared.js

@@ -547,6 +547,8 @@ const ENGINE_DEFAULTS = {
   lockRetryBackoffMs: 500, // base backoff between lock retries (doubles each attempt: 500ms, 1s, 2s, ...)
   maxBuildFixAttempts: 3, // max consecutive auto-fix dispatch cycles per PR before escalation to human
   buildFixGracePeriod: 600000, // 10min — wait for CI to run after build fix before re-dispatching
+  autoCompletePrs: true, // auto-merge PRs when builds green + review approved
+  prMergeMethod: 'squash', // merge method: squash, merge, rebase
   ccModel: 'sonnet', // model for Command Center and doc-chat (sonnet, haiku, opus)
   ccEffort: null, // effort level for CC/doc-chat (null, 'low', 'medium', 'high')
   ccMaxTurns: 50, // max tool-use turns for CC/doc-chat before CLI stops

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.777",
+  "version": "0.1.779",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"