@yemi33/minions 0.1.768 → 0.1.770

package/CHANGELOG.md

@@ -1,11 +1,13 @@
 # Changelog
 
-## 0.1.768 (2026-04-10)
+## 0.1.770 (2026-04-10)
 
 ### Features
 - id/kill endpoint
 
 ### Fixes
+-  increase ADO pipeline/task caps from 3 to 10, update docs
+-  ADO build detection uses builds API, not unreliable status checks
 -  handle work type names as action aliases for dispatch
 -  align Agent Usage and Engine Usage table columns
 -  harden agent kill endpoint — use killGracefully, clean steer.md, remove dead var

package/docs/pr-review-fix-loop.md

@@ -41,7 +41,7 @@ How the engine manages the lifecycle of a PR from creation through review, fix,
 
 - Gate: `buildFixAttempts < maxBuildFixAttempts` (default 3) + grace period expired
 - **Grace period** (`_buildFixPushedAt`): after fix dispatches, waits `buildFixGracePeriod` (default 10min, configurable in `ENGINE_DEFAULTS`) for CI to run before re-dispatching. Cleared when poller detects build status transition (CI actually ran).
-- **Error logs**: GitHub fetches annotations (failures only, not warnings) + Actions job log (always). ADO fetches build timeline + failed task logs. Both fetch up to 3 failing pipelines.
+- **Error logs**: GitHub fetches annotations (failures only, not warnings) + Actions job log (always). ADO queries builds API directly (not status checks), fetches build timeline → failed task logs (up to 10 per build, up to 10 failing pipelines).
 - **Escalation**: after 3 failed attempts, writes inbox alert, sets `buildFixEscalated = true`, stops auto-dispatch. Counter resets when build recovers.
 
 ## 5. Fix completes
@@ -108,3 +108,20 @@ How the engine manages the lifecycle of a PR from creation through review, fix,
 | `lastReviewedAt` | `updatePrAfterReview()` | Prevents re-dispatch if reviewed |
 | `minionsReview` | Post-completion hooks | `{ reviewer, reviewedAt, note, fixedAt }` |
 | `humanFeedback` | `pollPrHumanComments()` | `{ pendingFix, feedbackContent, lastProcessedCommentDate }` |
+
+## Platform differences
+
+| | GitHub | ADO |
+|---|---|---|
+| **Build status API** | `/commits/{sha}/check-runs` | `_apis/build/builds` (not status checks — those show stale codecoverage postbacks) |
+| **Commit tracking** | `head.sha` (source branch tip) | `lastMergeCommit.commitId` (merge commit that builds use as sourceVersion) |
+| **Passing** | success, skipped, neutral | succeeded, partiallySucceeded (warnings, not failures) |
+| **Error logs** | Annotations (failures only) + Actions job log (always) | Build timeline → failed task logs (up to 10 tasks, up to 10 pipelines) |
+| **Push detection** | `head.sha` change | `lastMergeCommit.commitId` change |
+
+### ADO lessons learned
+
+- Don't trust `/pullRequests/{id}/statuses` — shows stale codecoverage postbacks, not actual build results
+- Builds use the merge commit hash as `sourceVersion`, not the source branch commit — compare against `lastMergeCommit.commitId`
+- `partiallySucceeded` counts as passing (warnings, not failures)
+- A stale but passing build is still valid — don't re-trigger builds that already passed

package/engine/ado.js

@@ -101,13 +101,14 @@ const BUILD_ERROR_LOG_MAX_LINES = 150;
  */
 async function fetchAdoBuildErrorLog(orgBase, project, failedStatus, token, pr, seenBuildIds) {
   try {
-    // Try extracting buildId from targetUrl (e.g. .../_build/results?buildId=12345)
-    const targetUrl = failedStatus?.targetUrl || '';
-    let buildId = null;
-    const buildIdMatch = targetUrl.match(/buildId=(\d+)/);
-    if (buildIdMatch) {
-      buildId = buildIdMatch[1];
-    } else {
+    // Use pre-resolved buildId if available (from builds API query), else parse from targetUrl
+    let buildId = failedStatus?._buildId || null;
+    if (!buildId) {
+      const targetUrl = failedStatus?.targetUrl || '';
+      const buildIdMatch = targetUrl.match(/buildId=(\d+)/);
+      if (buildIdMatch) buildId = buildIdMatch[1];
+    }
+    if (!buildId) {
       // Fallback: query recent failed builds for this PR's source branch
       try {
         const branch = pr?.branch || pr?.sourceRefName?.replace('refs/heads/', '');
@@ -140,9 +141,9 @@ async function fetchAdoBuildErrorLog(orgBase, project, failedStatus, token, pr,
     );
     if (failedRecords.length === 0) return null;
 
-    // Fetch logs for failed tasks (cap at 3 to limit API calls)
+    // Fetch logs for failed tasks (cap at 10 to cover multi-stage pipelines)
     const logParts = [];
-    for (const record of failedRecords.slice(0, 3)) {
+    for (const record of failedRecords.slice(0, 10)) {
       try {
         const logUrl = `${orgBase}/${project.adoProject}/_apis/build/builds/${buildId}/logs/${record.log.id}?api-version=7.1`;
         const text = await adoFetchText(logUrl, token);
@@ -281,7 +282,8 @@ async function pollPrStatus(config) {
     }
 
     // Track head commit changes to detect new pushes (used for review re-dispatch gating)
-    const headCommit = prData.lastMergeSourceCommit?.commitId || prData.sourceRefName || '';
+    // Use lastMergeCommit (the merge commit), not lastMergeSourceCommit (source branch tip)
+    const headCommit = prData.lastMergeCommit?.commitId || prData.lastMergeSourceCommit?.commitId || '';
     if (headCommit && pr._adoHeadCommit !== headCommit) {
       if (pr._adoHeadCommit) { // skip first detection — only track changes
         pr.lastPushedAt = ts();
@@ -344,38 +346,45 @@ async function pollPrStatus(config) {
 
     if (newStatus !== PR_STATUS.ACTIVE) return updated;
 
-    const statusData = await adoFetch(`${repoBase}/statuses?api-version=7.1`, token);
-
-    const latest = new Map();
-    for (const s of statusData.value || []) {
-      const key = (s.context?.genre || '') + '/' + (s.context?.name || '');
-      if (!latest.has(key)) latest.set(key, s);
-    }
-
-    const buildStatuses = [...latest.values()].filter(s => {
-      const ctx = ((s.context?.genre || '') + '/' + (s.context?.name || '')).toLowerCase();
-      return /\bcodecoverage\b/.test(ctx) || /\bbuild\b/.test(ctx) ||
-             /\bdeploy\b/.test(ctx) || /(?:^|\/)ci(?:\/|$)/.test(ctx);
-    });
-
+    // Query builds API directly — status checks (/statuses) are unreliable (stale codecoverage postbacks)
+    // Use the merge commit hash to find builds for this PR
+    const mergeCommitId = prData.lastMergeCommit?.commitId;
     let buildStatus = 'none';
     let buildFailReason = '';
+    let buildStatuses = []; // for error log fetching
 
-    if (buildStatuses.length > 0) {
-      const states = buildStatuses.map(s => s.state).filter(Boolean);
-      const hasFailed = states.some(s => s === 'failed' || s === 'error');
-      const allDone = states.every(s => s === 'succeeded' || s === 'notApplicable');
-      const hasQueued = buildStatuses.some(s => !s.state);
-
-      if (hasFailed) {
-        buildStatus = 'failing';
-        const failed = buildStatuses.find(s => s.state === 'failed' || s.state === 'error');
-        buildFailReason = failed?.description || failed?.context?.name || 'Build failed';
-      } else if (allDone && !hasQueued) {
-        buildStatus = 'passing';
-      } else {
-        buildStatus = 'running';
-      }
+    if (mergeCommitId) {
+      try {
+        // Find builds where sourceVersion matches the PR's merge commit
+        const buildsUrl = `${orgBase}/${project.adoProject}/_apis/build/builds?$top=10&api-version=7.1`;
+        const buildsData = await adoFetch(buildsUrl, token);
+        const prBuilds = (buildsData?.value || []).filter(b =>
+          b.sourceVersion === mergeCommitId || b.sourceBranch === prData.sourceRefName
+        );
+
+        if (prBuilds.length > 0) {
+          // partiallySucceeded = warnings, not failures — counts as passing
+          const hasFailed = prBuilds.some(b => b.result === 'failed' || b.result === 'canceled');
+          const allDone = prBuilds.every(b => b.status === 'completed');
+          const allPassed = prBuilds.every(b => b.result === 'succeeded' || b.result === 'partiallySucceeded');
+          const hasRunning = prBuilds.some(b => b.status === 'inProgress' || b.status === 'notStarted');
+
+          if (hasFailed && allDone) {
+            buildStatus = 'failing';
+            const failed = prBuilds.find(b => b.result === 'failed');
+            buildFailReason = failed?.definition?.name || 'Build failed';
+            // Build fake status objects for error log fetching
+            buildStatuses = prBuilds.filter(b => b.result === 'failed').map(b => ({
+              state: 'failed', targetUrl: `${orgBase}/${project.adoProject}/_build/results?buildId=${b.id}`,
+              _buildId: String(b.id),
+            }));
+          } else if (allDone && allPassed) {
+            buildStatus = 'passing';
+          } else if (hasRunning) {
+            buildStatus = 'running';
+          }
+        }
+      } catch (e) { log('warn', `ADO build query for ${pr.id}: ${e.message}`); }
     }
 
     if (pr.buildStatus !== buildStatus) {
@@ -395,7 +404,7 @@ async function pollPrStatus(config) {
 
       // Fetch actual compiler/build error logs when transitioning to failing
       if (buildStatus === 'failing') {
-        const failedStatusObjs = buildStatuses.filter(s => s.state === 'failed' || s.state === 'error').slice(0, 3);
+        const failedStatusObjs = buildStatuses.filter(s => s.state === 'failed' || s.state === 'error').slice(0, 10);
         const logParts = [];
         const seenBuildIds = new Set();
         for (const failedStatusObj of failedStatusObjs) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.768",
+  "version": "0.1.770",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"