@yemi33/minions 0.1.738 → 0.1.740

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.1.740 (2026-04-09)
+
+### Features
+- add prNumber field to pull-requests.json records (#711)
+
+## 0.1.739 (2026-04-09)
+
+### Fixes
+-  heartbeat feedback loop resets own mtime-based timeout (closes #724) (#728)
+
 ## 0.1.738 (2026-04-09)
 
 ### Fixes

package/engine/ado.js

@@ -561,10 +561,14 @@ async function reconcilePrs(config) {
       const confirmedItemId = linkedItem ? linkedItemId : null;
 
       if (existingIds.has(prId)) {
+        const existing = existingPrs.find(p => p.id === prId);
+        // Backfill prNumber for existing records missing it
+        if (existing && existing.prNumber == null) {
+          existing.prNumber = adoPr.pullRequestId;
+        }
         // PR already tracked — write link to pr-links.json if we can extract an ID
         if (confirmedItemId) {
           addPrLink(prId, confirmedItemId);
-          const existing = existingPrs.find(p => p.id === prId);
           if (existing && !(existing.prdItems || []).includes(confirmedItemId)) {
             existing.prdItems = Array.isArray(existing.prdItems) ? existing.prdItems : [];
             existing.prdItems.push(confirmedItemId);
@@ -582,6 +586,7 @@ async function reconcilePrs(config) {
       const prUrl = project.prUrlBase ? project.prUrlBase + adoPr.pullRequestId : '';
       existingPrs.push({
         id: prId,
+        prNumber: adoPr.pullRequestId,
         title: (adoPr.title || `PR #${adoPr.pullRequestId}`).slice(0, 120),
         agent: (linkedItem?.dispatched_to || adoPr.createdBy?.displayName || 'unknown').toLowerCase(),
         branch,
@@ -597,6 +602,14 @@ async function reconcilePrs(config) {
       log('info', `PR reconciliation: added ${prId} (branch: ${branch}, linked to ${confirmedItemId}) to ${project.name}`);
     }
 
+    // Backfill prNumber from pr.id for any PR missing it (e.g. created before prNumber was stored)
+    for (const pr of existingPrs) {
+      if (pr.prNumber == null) {
+        const derived = parseInt((pr.id || '').replace(/^PR-/, ''), 10);
+        if (derived) pr.prNumber = derived;
+      }
+    }
+
     // Backfill prdItems from pr-links for any PR with empty array
     const prLinks = shared.getPrLinks();
     let backfilled = 0;

package/engine/github.js

@@ -562,9 +562,13 @@ async function reconcilePrs(config) {
       const confirmedItemId = linkedItem ? linkedItemId : null;
 
       if (existingIds.has(prId)) {
+        const existing = currentPrs.find(p => p.id === prId);
+        // Backfill prNumber for existing records missing it
+        if (existing && existing.prNumber == null) {
+          existing.prNumber = ghPr.number;
+        }
         if (confirmedItemId) {
           addPrLink(prId, confirmedItemId);
-          const existing = currentPrs.find(p => p.id === prId);
           if (existing && !(existing.prdItems || []).includes(confirmedItemId)) {
             existing.prdItems = Array.isArray(existing.prdItems) ? existing.prdItems : [];
             existing.prdItems.push(confirmedItemId);
@@ -580,6 +584,7 @@ async function reconcilePrs(config) {
 
       currentPrs.push({
         id: prId,
+        prNumber: ghPr.number,
         title: (ghPr.title || `PR #${ghPr.number}`).slice(0, 120),
         agent: (linkedItem?.dispatched_to || ghPr.user?.login || 'unknown').toLowerCase(),
         branch,
@@ -596,6 +601,14 @@ async function reconcilePrs(config) {
       log('info', `GitHub PR reconciliation: added ${prId} (branch: ${branch}, linked to ${confirmedItemId}) to ${project.name}`);
     }
 
+    // Backfill prNumber from pr.id for any PR missing it (e.g. created before prNumber was stored)
+    for (const pr of currentPrs) {
+      if (pr.prNumber == null) {
+        const derived = parseInt((pr.id || '').replace(/^PR-/, ''), 10);
+        if (derived) pr.prNumber = derived;
+      }
+    }
+
     // Backfill prdItems from pr-links for any PR with empty array
     const prLinks = getPrLinks();
     let backfilled = 0;

package/engine/lifecycle.js

@@ -666,6 +666,7 @@ function syncPrsFromOutput(output, agentId, meta, config) {
       prId, fullId,
       entry: {
         id: fullId,
+        prNumber: parseInt(prId, 10) || prId,
         title: (title || `PR created by ${agentName}`).slice(0, 120),
         agent: agentName,
         branch: meta?.branch || '',

package/engine/timeout.js

@@ -159,11 +159,20 @@ function checkTimeouts(config) {
     const liveLogPath = path.join(AGENTS_DIR, item.agent, 'live-output.log');
     let lastActivity = item.started_at ? new Date(item.started_at).getTime() : 0;
 
-    // Check live-output.log mtime as heartbeat
-    try {
-      const stat = fs.statSync(liveLogPath);
-      lastActivity = Math.max(lastActivity, stat.mtimeMs);
-    } catch { /* optional */ }
+    // For tracked processes, use realActivityMap (tracks actual agent stdout/stderr only,
+    // NOT engine heartbeat writes). This prevents the feedback loop where engine heartbeat
+    // writes to live-output.log reset the mtime that the timeout check reads (#724).
+    const realActivityMap = engine().realActivityMap;
+    if (hasProcess && realActivityMap?.has(item.id)) {
+      lastActivity = Math.max(lastActivity, realActivityMap.get(item.id));
+    } else {
+      // Orphan case (no tracked process): use live-output.log mtime as fallback.
+      // No heartbeat timer is running for orphans, so mtime is accurate.
+      try {
+        const stat = fs.statSync(liveLogPath);
+        lastActivity = Math.max(lastActivity, stat.mtimeMs);
+      } catch { /* optional */ }
+    }
 
     const silentMs = Date.now() - lastActivity;
     const silentSec = Math.round(silentMs / 1000);

package/engine.js

@@ -142,6 +142,7 @@ const { runPostCompletionHooks, updateWorkItemStatus, syncPrdItemStatus, handleP
 // ─── Agent Spawner ──────────────────────────────────────────────────────────
 
 const activeProcesses = new Map(); // dispatchId → { proc, agentId, startedAt }
+const realActivityMap = new Map(); // dispatchId → timestamp of last REAL agent output (not engine heartbeat)
 // tempAgents imported from engine/routing.js
 let engineRestartGraceUntil = 0; // timestamp — suppress orphan detection until this time
 
@@ -597,6 +598,7 @@ async function spawnAgent(dispatchItem, config) {
   proc.stdout.on('data', (data) => {
     const chunk = data.toString();
     lastOutputAt = Date.now();
+    realActivityMap.set(id, Date.now()); // Track real agent output separately from heartbeat
     if (stdout.length < MAX_OUTPUT) stdout += chunk.slice(0, MAX_OUTPUT - stdout.length);
     try { fs.appendFileSync(liveOutputPath, chunk); } catch { /* optional */ }
 
@@ -641,6 +643,7 @@ async function spawnAgent(dispatchItem, config) {
   proc.stderr.on('data', (data) => {
     const chunk = data.toString();
     lastOutputAt = Date.now();
+    realActivityMap.set(id, Date.now()); // Track real agent output separately from heartbeat
     if (stderr.length < MAX_OUTPUT) stderr += chunk.slice(0, MAX_OUTPUT - stderr.length);
     try { fs.appendFileSync(liveOutputPath, '[stderr] ' + chunk); } catch { /* optional */ }
   });
@@ -737,12 +740,14 @@ async function spawnAgent(dispatchItem, config) {
       resumeProc.stdout.on('data', (data) => {
         const chunk = data.toString();
         lastOutputAt = Date.now();
+        realActivityMap.set(id, Date.now()); // Track real agent output separately from heartbeat
         if (stdout.length < MAX_OUTPUT) stdout += chunk.slice(0, MAX_OUTPUT - stdout.length);
         try { fs.appendFileSync(liveOutputPath, chunk); } catch { /* optional */ }
       });
       resumeProc.stderr.on('data', (data) => {
         const chunk = data.toString();
         lastOutputAt = Date.now();
+        realActivityMap.set(id, Date.now()); // Track real agent output separately from heartbeat
         if (stderr.length < MAX_OUTPUT) stderr += chunk.slice(0, MAX_OUTPUT - stderr.length);
         try { fs.appendFileSync(liveOutputPath, '[stderr] ' + chunk); } catch { /* optional */ }
       });
@@ -773,6 +778,7 @@ async function spawnAgent(dispatchItem, config) {
     }
 
     activeProcesses.delete(id);
+    realActivityMap.delete(id); // Clean up real activity tracking
 
     // If timeout checker already finalized this dispatch, don't overwrite work-item status again.
     // This avoids races where close-handler marks an auto-retried item as failed.
@@ -880,6 +886,7 @@ async function spawnAgent(dispatchItem, config) {
     if (heartbeatTimer) { clearInterval(heartbeatTimer); heartbeatTimer = null; }
     log('error', `Failed to spawn agent ${agentId}: ${err.message}`);
     activeProcesses.delete(id);
+    realActivityMap.delete(id); // Clean up real activity tracking
     completeDispatch(id, DISPATCH_RESULT.ERROR, `Spawn error: ${err.message}`);
   });
 
@@ -892,6 +899,7 @@ async function spawnAgent(dispatchItem, config) {
 
   // Track process — even if PID isn't available yet (async on Windows)
   activeProcesses.set(id, { proc, agentId, startedAt, sessionId: cachedSessionId });
+  realActivityMap.set(id, Date.now()); // Initialize real activity at spawn time
 
   updateAgentStatus(id, AGENT_STATUS.RUNNING, `Process spawned for ${agentId}`);
 
@@ -2957,7 +2965,7 @@ module.exports = {
 
   // Dispatch management (re-exported from engine/dispatch.js)
   mutateDispatch, addToDispatch, isRetryableFailureReason, completeDispatch, writeInboxAlert, updateAgentStatus,
-  activeProcesses, get engineRestartGraceUntil() { return engineRestartGraceUntil; },
+  activeProcesses, realActivityMap, get engineRestartGraceUntil() { return engineRestartGraceUntil; },
   set engineRestartGraceUntil(v) { engineRestartGraceUntil = v; },
 
   // Agent lifecycle

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.738",
+  "version": "0.1.740",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"