@yemi33/minions 0.1.734 → 0.1.735

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.1.735 (2026-04-09)
+
+### Features
+-  configurable ccMaxTurns, native binary detection, relaxed CC exit check
+
 ## 0.1.734 (2026-04-09)
 
 ### Fixes

package/dashboard.js

@@ -654,7 +654,8 @@ function updateSession(store, key, sessionId, existing) {
  * @param {number} opts.maxTurns - Max tool-use turns
  * @param {string} opts.allowedTools - Comma-separated tool list
  */
-async function ccCall(message, { store = 'cc', sessionKey, extraContext, label = 'command-center', timeout = 900000, maxTurns = 25, allowedTools = 'Bash,Read,Write,Edit,Glob,Grep,WebFetch,WebSearch', skipStatePreamble = false, model } = {}) {
+async function ccCall(message, { store = 'cc', sessionKey, extraContext, label = 'command-center', timeout = 900000, maxTurns, allowedTools = 'Bash,Read,Write,Edit,Glob,Grep,WebFetch,WebSearch', skipStatePreamble = false, model } = {}) {
+  if (!maxTurns) maxTurns = CONFIG.engine?.ccMaxTurns || shared.ENGINE_DEFAULTS.ccMaxTurns;
   if (!model) model = CONFIG.engine?.ccModel || shared.ENGINE_DEFAULTS.ccModel;
   const ccEffort = CONFIG.engine?.ccEffort || shared.ENGINE_DEFAULTS.ccEffort;
   const existing = resolveSession(store, sessionKey);
@@ -676,18 +677,16 @@ async function ccCall(message, { store = 'cc', sessionKey, extraContext, label =
     });
     llm.trackEngineUsage(label, result.usage);
 
-    if (result.code === 0 && result.text) {
+    if (result.text) {
       updateSession(store, sessionKey, result.sessionId || sessionId, true);
       return result;
     }
 
-    // Distinguish "session exists but call failed" (e.g. tool timeout, signal timeout)
+    // No text — distinguish "session exists but call failed" (e.g. tool timeout)
     // from "session is truly dead" (no sessionId returned, or stderr indicates invalid session).
-    // If the session still exists, preserve it so the next "try again" can resume.
     const sessionStillValid = llm.isResumeSessionStillValid(result);
     if (sessionStillValid) {
       console.log(`[${label}] Resume call failed (code=${result.code}, empty=${!result.text}) but session is still valid — preserving session for retry`);
-      // Update lastActiveAt so session doesn't expire while user retries
       updateSession(store, sessionKey, result.sessionId || sessionId, true);
       return result;
     }
@@ -711,7 +710,7 @@ async function ccCall(message, { store = 'cc', sessionKey, extraContext, label =
   });
   llm.trackEngineUsage(label, result.usage);
 
-  if (result.code === 0 && result.text) {
+  if (result.text) {
     updateSession(store, sessionKey, result.sessionId, false);
     return result;
   }
@@ -725,7 +724,7 @@ async function ccCall(message, { store = 'cc', sessionKey, extraContext, label =
   });
   llm.trackEngineUsage(label, result.usage);
 
-  if (result.code === 0 && result.text) {
+  if (result.text) {
     updateSession(store, sessionKey, result.sessionId, false);
   }
   return result;
@@ -3277,7 +3276,8 @@ What would you like to discuss or change? When you're happy, say "approve" and I
 
         const result = await ccCall(body.message, { store: 'cc' });
 
-        if (result.code !== 0 || !result.text) {
+        // Non-zero exit with text = max_turns or partial success — still usable
+        if (!result.text) {
           const debugInfo = result.code !== 0 ? `(exit code ${result.code})` : '(empty response)';
           const stderrTail = (result.stderr || '').trim().split('\n').filter(Boolean).slice(-5).join(' | ');
           console.error(`[CC] LLM failed after retries ${debugInfo}: ${stderrTail}`);
@@ -3330,8 +3330,9 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         const { callLLMStreaming, trackEngineUsage: trackUsage } = require('./engine/llm');
         const streamModel = CONFIG.engine?.ccModel || shared.ENGINE_DEFAULTS.ccModel;
         const streamEffort = CONFIG.engine?.ccEffort || shared.ENGINE_DEFAULTS.ccEffort;
+        const ccMaxTurns = CONFIG.engine?.ccMaxTurns || shared.ENGINE_DEFAULTS.ccMaxTurns;
         const llmPromise = callLLMStreaming(prompt, CC_STATIC_SYSTEM_PROMPT, {
-          timeout: 900000, label: 'command-center', model: streamModel, maxTurns: 25,
+          timeout: 900000, label: 'command-center', model: streamModel, maxTurns: ccMaxTurns,
           allowedTools: 'Bash,Read,Write,Edit,Glob,Grep,WebFetch,WebSearch',
           sessionId, effort: streamEffort, direct: true,
           onChunk: (text) => {
@@ -3345,8 +3346,8 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         const result = await llmPromise;
         trackUsage('command-center', result.usage);
 
-        // Handle failure — same error reporting as non-streaming
-        if (result.code !== 0 || !result.text) {
+        // Handle failure — non-zero exit with text = max_turns or partial success, still usable
+        if (!result.text) {
           const debugInfo = result.code !== 0 ? `(exit code ${result.code})` : '(empty response)';
           const stderrTail = (result.stderr || '').trim().split('\n').filter(Boolean).slice(-3).join(' | ');
           console.error(`[CC-stream] Failed: code=${result.code}, stderr=${(result.stderr || '').slice(0, 500)}, stdout_tail=${(result.raw || '').slice(-500)}`);

package/engine/preflight.js

@@ -37,7 +37,7 @@ function findClaudeBinary() {
   for (const p of searchPaths) {
     try { if (fs.existsSync(p)) return p; } catch {}
   }
-  // Fallback: which/where → resolve wrapper to cli.js
+  // Fallback: which/where → resolve wrapper to cli.js, or detect native binary
   try {
     const isWin = process.platform === 'win32';
     const cmd = isWin ? 'where claude 2>NUL' : 'which claude 2>/dev/null';
@@ -55,7 +55,11 @@ function findClaudeBinary() {
           const candidate = path.join(path.dirname(whichNative), 'node_modules', '@anthropic-ai', 'claude-code', 'cli.js');
           if (fs.existsSync(candidate)) return candidate;
         }
-      } catch {}
+      } catch {
+        // Can't read as text — it's a compiled native binary
+      }
+      // Native installer binary on PATH — use directly
+      return whichNative;
     }
   } catch { /* optional */ }
   // Last resort: npm root -g
@@ -101,9 +105,11 @@ function runPreflight(opts = {}) {
   // 3. Claude Code CLI
   const claudeBin = findClaudeBinary();
   if (claudeBin) {
-    results.push({ name: 'Claude Code CLI', ok: true, message: path.basename(path.dirname(path.dirname(claudeBin))) });
+    const isNative = !claudeBin.endsWith('cli.js');
+    const label = isNative ? 'native' : path.basename(path.dirname(path.dirname(claudeBin)));
+    results.push({ name: 'Claude Code CLI', ok: true, message: label });
   } else {
-    results.push({ name: 'Claude Code CLI', ok: false, message: 'not found — install with: npm install -g @anthropic-ai/claude-code' });
+    results.push({ name: 'Claude Code CLI', ok: false, message: 'not found — install from https://claude.ai/download or: npm install -g @anthropic-ai/claude-code' });
     allOk = false;
   }
 

package/engine/shared.js

@@ -549,6 +549,7 @@ const ENGINE_DEFAULTS = {
   buildFixGracePeriod: 600000, // 10min — wait for CI to run after build fix before re-dispatching
   ccModel: 'sonnet', // model for Command Center and doc-chat (sonnet, haiku, opus)
   ccEffort: null, // effort level for CC/doc-chat (null, 'low', 'medium', 'high')
+  ccMaxTurns: 50, // max tool-use turns for CC/doc-chat before CLI stops
 };
 
 // ─── Status & Type Constants ─────────────────────────────────────────────────

package/engine/spawn-agent.js

@@ -108,7 +108,7 @@ if (isResume) {
 }
 
 if (!claudeBin) {
-  const msg = 'FATAL: Cannot find claude-code cli.js — install with: npm install -g @anthropic-ai/claude-code';
+  const msg = 'FATAL: Cannot find Claude Code CLI — install from https://claude.ai/download or: npm install -g @anthropic-ai/claude-code';
   fs.appendFileSync(debugPath, msg + '\n');
   console.error(msg);
   process.exit(78); // 78 = configuration error (distinct from runtime failures)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.734",
+  "version": "0.1.735",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/pipelines/pr-review-fix-cycle.json

@@ -1,42 +0,0 @@
-{
-  "id": "pr-review-fix-cycle",
-  "title": "PR Review & Fix Cycle",
-  "description": "Visualizes the default engine flow: review a PR, fix issues if rejected, re-review until approved and build passes.",
-  "trigger": { "manual": true },
-  "stages": [
-    {
-      "id": "review-pr",
-      "type": "task",
-      "taskType": "review",
-      "title": "Review PR",
-      "description": "Review the target PR for correctness, quality, and completeness. Provide actionable feedback if changes are needed."
-    },
-    {
-      "id": "check-review-status",
-      "type": "condition",
-      "title": "Approved?",
-      "check": "allBuildsGreen",
-      "action": "stop",
-      "onMet": "Merge",
-      "onUnmet": "Fix",
-      "dependsOn": ["review-pr"]
-    },
-    {
-      "id": "fix-feedback",
-      "type": "task",
-      "taskType": "fix",
-      "title": "Fix review feedback",
-      "description": "Address all review comments and push fixes to the PR branch.",
-      "dependsOn": ["check-review-status"]
-    },
-    {
-      "id": "re-review",
-      "type": "task",
-      "taskType": "review",
-      "title": "Re-review after fix",
-      "description": "Re-review the PR after fixes have been applied. Verify all prior feedback was addressed.",
-      "dependsOn": ["fix-feedback"]
-    }
-  ],
-  "stopWhen": "allBuildsGreen"
-}