@yemi33/minions 0.1.703 → 0.1.705

package/CHANGELOG.md

@@ -1,8 +1,14 @@
 # Changelog
 
-## 0.1.703 (2026-04-09)
+## 0.1.705 (2026-04-09)
+
+### Fixes
+-  modal buttons now derive status from linked PRD when plan not in status
+
+## 0.1.704 (2026-04-09)
 
 ### Other
+- docs: add PR review & fix loop documentation
 - refactor: move buildFixGracePeriod to ENGINE_DEFAULTS (no magic numbers)
 
 ## 0.1.702 (2026-04-09)

package/dashboard/js/render-plans.js

@@ -453,35 +453,53 @@ function _renderPlanModal(normalizedFile, raw, lastMod) {
   const canExecute = isMdPlan && !hasActiveWork && !prdCompleted;
   const modalExecuteBtn = canExecute && !hasPrd ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--green);font-weight:600" ' +
     'onclick="planExecute(\'' + escHtml(normalizedFile) + '\',\'\',this)">Execute</button>' : '';
-  const modalReExecuteBtn = canExecute && linkedPrdAwaiting ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--green);font-weight:600" ' +
-    'onclick="planExecute(\'' + escHtml(normalizedFile) + '\',\'\',this)">Re-execute</button>' : '';
-  const modalCompletedLabel = prdCompleted && !hasActiveWork ? '<span style="font-size:10px;color:var(--green);font-weight:600">Completed</span>' : '';
-  const modalAwaitingLabel = linkedPrdAwaiting && !hasActiveWork && !prdCompleted ? '<span style="font-size:10px;color:var(--yellow);font-weight:600">Awaiting Approval</span>' : '';
-  const modalInProgressLabel = hasActiveWork ? '<span style="font-size:10px;color:var(--blue)">In Progress</span>' : '';
-  const isModalCompleted = planStatus === 'completed';
-  const modalPauseBtn = isActive && !isMdPlan && !isModalCompleted ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--yellow)" ' +
-    'onclick="planPause(\'' + escHtml(normalizedFile) + '\',this)">Pause</button>' : '';
-  const modalApproveTarget = linkedPrdAwaiting ? linkedPrd.file : normalizedFile;
-  const isActuallyPaused = planStatus === 'paused' || linkedPrd?.status === 'paused';
-  const modalApproveLabel = isActuallyPaused ? 'Resume' : 'Approve';
-  const showRejectInModal = linkedPrdAwaiting || planStatus === 'awaiting-approval';
-  const modalApproveBtn = modalShowResume ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--green)" ' +
-    'onclick="planApprove(\'' + escHtml(modalApproveTarget) + '\',this)">' + modalApproveLabel + '</button>' : '';
-  const modalRejectBtn = showRejectInModal ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--red)" ' +
-    'onclick="planReject(\'' + escHtml(modalApproveTarget) + '\')">Reject</button>' : '';
-  const modalVerifyWi = (window._lastWorkItems || []).find(w => w.itemType === 'verify' && w.sourcePlan === normalizedFile);
-  const modalVerifyBtn = isModalCompleted && !modalVerifyWi ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--green)" ' +
-    'onclick="triggerVerify(\'' + escHtml(normalizedFile) + '\',this)">Verify</button>' : '';
-  const modalVerifyInfo = modalVerifyWi ? _renderVerifyBadge(modalVerifyWi) : '';
-  const modalArchiveBtn = '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--muted)" ' +
-    'onclick="planArchive(\'' + escHtml(normalizedFile) + '\')">Archive</button>';
+  // Modal buttons mirror card logic — derive effectiveStatus the same way
+  const allPlans = window._lastStatus?.plans || [];
+  const cardPlan = allPlans.find(p => p.file === normalizedFile || p.sourcePlan === normalizedFile || (p.file?.endsWith('.json') && p.file === normalizedFile));
+  // Also check for linked PRD by searching all plans for a PRD whose source_plan matches this file
+  const linkedPrd = allPlans.find(p => p.sourcePlan === normalizedFile && p.format === 'prd');
+  const effectiveStatus = cardPlan ? derivePlanStatus(cardPlan) : (linkedPrd ? derivePlanStatus(linkedPrd) : (planStatus || 'active'));
+  const prdFile = cardPlan?.file?.endsWith('.json') ? cardPlan.file : (linkedPrd?.file || '');
+  const isArchived = !!(cardPlan?.archived || linkedPrd?.archived);
+  const isDraft = isMdPlan && !prdFile;
+  const isNeedsAction = (effectiveStatus === 'awaiting-approval' || effectiveStatus === 'paused') && !isArchived;
+
+  const bs = 'font-size:10px;padding:2px 10px'; // button style
+  let modalActions = '';
+
+  // Approve/Reject for awaiting-approval or paused
+  if (isNeedsAction) {
+    const target = prdFile || normalizedFile;
+    const label = effectiveStatus === 'paused' ? 'Resume' : 'Approve';
+    modalActions += '<button class="pr-pager-btn" style="' + bs + ';color:var(--green)" onclick="planApprove(\'' + escHtml(target) + '\',this)">' + label + '</button> ';
+    // Re-execute: re-generate PRD from updated plan (only for .md drafts with existing PRD)
+    if (effectiveStatus === 'awaiting-approval' && isMdPlan && prdFile && canExecute) {
+      modalActions += '<button class="pr-pager-btn" style="' + bs + ';color:var(--green);opacity:0.7" onclick="planExecute(\'' + escHtml(normalizedFile) + '\',\'\',this)">Re-execute</button> ';
+    }
+    modalActions += '<button class="pr-pager-btn" style="' + bs + ';color:var(--red)" onclick="planReject(\'' + escHtml(target) + '\')">Reject</button> ';
+  }
+  // Execute (draft .md without PRD)
+  if (isDraft && (effectiveStatus === 'active' || effectiveStatus === 'draft') && !isArchived) {
+    modalActions += '<button class="pr-pager-btn" style="' + bs + ';color:var(--green);font-weight:600" onclick="planExecute(\'' + escHtml(normalizedFile) + '\',\'\',this)">Execute</button> ';
+  }
+  // Pause (active PRD, not completed)
+  if (effectiveStatus === 'dispatched' && prdFile && !isArchived) {
+    modalActions += '<button class="pr-pager-btn" style="' + bs + ';color:var(--yellow)" onclick="planPause(\'' + escHtml(prdFile) + '\',this)">Pause</button> ';
+  }
+  // Verify / Verified badge
+  const modalVerifyWi = (window._lastWorkItems || []).find(w => w.itemType === 'verify' && w.sourcePlan === (prdFile || normalizedFile));
+  if (effectiveStatus === 'completed' && prdFile && !isArchived && !modalVerifyWi) {
+    modalActions += '<button class="pr-pager-btn" style="' + bs + ';color:var(--green)" onclick="triggerVerify(\'' + escHtml(prdFile) + '\',this)">Verify</button> ';
+  }
+  if (modalVerifyWi) modalActions += _renderVerifyBadge(modalVerifyWi);
+  // Archive + Delete (always, unless archived)
+  if (!isArchived) {
+    modalActions += '<button class="pr-pager-btn" style="' + bs + ';color:var(--muted)" onclick="planArchive(\'' + escHtml(prdFile || normalizedFile) + '\')">Archive</button> ';
+    modalActions += '<button class="pr-pager-btn" style="' + bs + ';color:var(--red)" onclick="planDelete(\'' + escHtml(normalizedFile) + '\')">Delete</button>';
+  }
+
   const lastModLabel = lastMod ? '<div style="font-size:10px;color:var(--muted);font-weight:400;margin-top:2px">Last updated: ' + new Date(lastMod).toLocaleString() + '</div>' : '';
-  const actionBtns = '<div style="display:flex;gap:4px;flex-wrap:wrap;margin-top:4px">' +
-    (modalCompletedLabel || '') + (modalAwaitingLabel || '') + (modalInProgressLabel || '') + (modalApproveBtn || '') + (modalReExecuteBtn || '') + (modalExecuteBtn || '') + (modalPauseBtn || '') + (modalRejectBtn || '') + (modalVerifyBtn || '') + (modalVerifyInfo || '') +
-    ' ' + modalArchiveBtn +
-    ' <button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--red)" ' +
-    'onclick="planDelete(\'' + escHtml(normalizedFile) + '\')">Delete</button>' +
-  '</div>';
+  const actionBtns = '<div style="display:flex;gap:4px;flex-wrap:wrap;margin-top:4px">' + modalActions + '</div>';
 
   document.getElementById('modal-title').innerHTML = escHtml(title) + (versionLabel ? ' <span style="font-size:11px;font-weight:700;padding:1px 6px;border-radius:3px;background:rgba(56,139,253,0.15);color:var(--blue)">' + escHtml(versionLabel) + '</span>' : '') + lastModLabel + actionBtns;
   const modalBody = document.getElementById('modal-body');

package/docs/pr-review-fix-loop.md

@@ -0,0 +1,110 @@
+# PR Review & Fix Loop
+
+How the engine manages the lifecycle of a PR from creation through review, fix, and re-review.
+
+## 1. Implement agent creates PR
+
+- Agent pushes code, output contains PR URL
+- `syncPrsFromOutput()` (lifecycle.js) extracts URL via regex, creates `pull-requests.json` entry, links to work item via `addPrLink()`
+
+## 2. Engine discovers PR needs review
+
+- `discoverFromPrs()` (engine.js) runs each tick (~60s)
+- Gates: `status === 'active'` + `reviewStatus === 'pending'` + not reviewed since last push + not dispatched + not on cooldown
+- Pre-dispatch: `checkLiveReviewStatus()` hits GitHub/ADO API to catch stale cached status
+- Routes to reviewer via `resolveAgent('review')`, dispatches with `review.md` playbook
+
+## 3. Review completes
+
+- `updatePrAfterReview()` (lifecycle.js) re-checks live vote from platform (may have changed during execution)
+- Sets `reviewStatus` to `approved` / `changes-requested` / `waiting`
+- Stores `minionsReview: { reviewer, reviewedAt, note }`
+- Creates feedback file for author agent
+
+## 4. Fix dispatch (3 independent triggers, at most one per tick)
+
+### A. Review feedback (`changes-requested`)
+
+- Gate: `reviewStatus === 'changes-requested'` + `!awaitingReReview` + not dispatched + not on cooldown
+- Routes to PR author via `_author_` routing token
+- `review_note` = reviewer's feedback
+- Sets `fixDispatched = true` — prevents trigger B from also firing this tick
+
+### B. Human comments (`humanFeedback.pendingFix`)
+
+- Gate: `pendingFix || coalescedFeedback` + `!awaitingReReview` + `!fixDispatched`
+- Agent comments filtered out via `/\bMinions\s*\(/i` regex on comment body
+- Coalesces multiple comments arriving during cooldown into single fix
+- Routes to author
+
+### C. Build failures (`buildStatus === 'failing'`)
+
+- Gate: `buildFixAttempts < maxBuildFixAttempts` (default 3) + grace period expired
+- **Grace period** (`_buildFixPushedAt`): after fix dispatches, waits `buildFixGracePeriod` (default 10min, configurable in `ENGINE_DEFAULTS`) for CI to run before re-dispatching. Cleared when poller detects build status transition (CI actually ran).
+- **Error logs**: GitHub fetches annotations (failures only, not warnings) + Actions job log (always). ADO fetches build timeline + failed task logs. Both fetch up to 3 failing pipelines.
+- **Escalation**: after 3 failed attempts, writes inbox alert, sets `buildFixEscalated = true`, stops auto-dispatch. Counter resets when build recovers.
+
+## 5. Fix completes
+
+- `updatePrAfterFix()` (lifecycle.js) sets `reviewStatus = 'waiting'` + `fixedAt = ts()`
+- Clears `humanFeedback.pendingFix`
+- `awaitingReReview` gate (`waiting` + `fixedAt`) blocks all fix dispatch until reviewer acts
+
+## 6. Re-review cycle
+
+- Poller (~3min): detects new commit (`head.sha` changed) → sets `lastPushedAt`
+- Platform review state drives next action:
+  - Reviewer approves → `approved` → done
+  - Reviewer re-requests changes → `changes-requested` → triggers another fix
+  - No reviewer action yet → stays `waiting` → engine waits
+
+## 7. Build fix cycle after fix push
+
+- Fix agent pushes → `_buildFixPushedAt` stamped
+- Poller detects new commit → CI starts → `buildStatus` transitions (`failing` → `running`)
+- `_buildFixPushedAt` cleared on any transition
+- If CI passes → `buildFixAttempts` reset, `buildErrorLog` cleared → done
+- If CI fails again → fresh error logs fetched → new fix dispatches immediately (grace already cleared by transition)
+
+## Race prevention
+
+| Scenario | Guard |
+|---|---|
+| Simultaneous review + fix | `activePrIds` — skip PR if any dispatch in-flight |
+| Duplicate fix (review + human) | `fixDispatched` flag — only one fix per PR per tick |
+| Branch write conflict | `isBranchActive()` mutex |
+| Fix while awaiting re-review | `awaitingReReview` (waiting + fixedAt) |
+| Build fix before CI runs | `_buildFixPushedAt` grace period (10min) |
+| Duplicate dispatch | `dispatchKey` dedup + cooldown |
+| Stale review status | Pre-dispatch live API check |
+| Orphan detection | Heartbeat timeout + output scan |
+
+## Key files
+
+| File | Functions |
+|---|---|
+| `engine.js` | `discoverFromPrs()` — discovery + dispatch logic |
+| `engine/lifecycle.js` | `syncPrsFromOutput()`, `updatePrAfterReview()`, `updatePrAfterFix()` |
+| `engine/github.js` | `pollPrStatus()`, `pollPrHumanComments()`, `fetchGhBuildErrorLog()` |
+| `engine/ado.js` | `pollPrStatus()`, `pollPrHumanComments()`, `fetchAdoBuildErrorLog()` |
+| `engine/dispatch.js` | `addToDispatch()` — dedup by work item ID and dispatchKey |
+| `engine/cooldown.js` | `isBranchActive()`, cooldown management |
+| `playbooks/review.md` | Reviewer playbook |
+| `playbooks/fix.md` | Fix agent playbook |
+
+## PR state fields
+
+| Field | Set by | Purpose |
+|---|---|---|
+| `status` | Poller | `active` / `merged` / `abandoned` |
+| `reviewStatus` | Poller + post-completion | `pending` / `approved` / `changes-requested` / `waiting` |
+| `buildStatus` | Poller | `none` / `passing` / `failing` / `running` |
+| `buildErrorLog` | Poller | Actual CI error output for fix agents |
+| `buildFixAttempts` | Discovery (on dispatch) | Counter for escalation cap |
+| `buildFixEscalated` | Discovery (on cap) | Stops auto-dispatch |
+| `_buildFixPushedAt` | Discovery (on dispatch) | Grace period timestamp |
+| `_buildFailNotified` | Discovery | Dedup for inbox alert |
+| `lastPushedAt` | Poller (new commit) | Tracks latest push for re-review logic |
+| `lastReviewedAt` | `updatePrAfterReview()` | Prevents re-dispatch if reviewed |
+| `minionsReview` | Post-completion hooks | `{ reviewer, reviewedAt, note, fixedAt }` |
+| `humanFeedback` | `pollPrHumanComments()` | `{ pendingFix, feedbackContent, lastProcessedCommentDate }` |

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.703",
+  "version": "0.1.705",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"