@yemi33/minions 0.1.696 → 0.1.698

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.696 (2026-04-09)
+## 0.1.698 (2026-04-09)
 
 ### Fixes
 -  ADO build error log fetches all failing pipelines, not just first
@@ -8,6 +8,10 @@
 -  ADO build error log fallback when targetUrl lacks buildId
 -  syncPrsFromOutput missed PRs mentioned in assistant text blocks
 
+### Other
+- simplify: hoist textCreatedPattern regex out of block loop
+- refactor: reorder card buttons (Approve first), split modal approve/reject
+
 ## 0.1.692 (2026-04-09)
 
 ### Fixes

package/dashboard/js/render-plans.js

@@ -211,8 +211,8 @@ function renderPlans(plans) {
       // For awaiting-approval: show Execute (re-generate PRD from updated plan) + Approve (use current PRD as-is)
       if (effectiveStatus === 'awaiting-approval' && isDraft && prdFile) {
         actions = '<div class="plan-card-actions" onclick="event.stopPropagation()">' +
-          '<button class="plan-btn approve" onclick="planExecute(\'' + escHtml(p.file) + '\',\'' + escHtml(p.project || '') + '\',this)">Re-execute</button>' +
-          '<button class="plan-btn approve" style="opacity:0.7" onclick="planApprove(\'' + escHtml(actionTarget) + '\')">Approve as-is</button>' +
+          '<button class="plan-btn approve" onclick="planApprove(\'' + escHtml(actionTarget) + '\')">Approve</button>' +
+          '<button class="plan-btn approve" style="opacity:0.7" onclick="planExecute(\'' + escHtml(p.file) + '\',\'' + escHtml(p.project || '') + '\',this)">Re-execute</button>' +
           '<button class="plan-btn reject" onclick="planReject(\'' + escHtml(actionTarget) + '\')">Reject</button>' +
         '</div>';
       } else {
@@ -465,10 +465,10 @@ function _renderPlanModal(normalizedFile, raw, lastMod) {
   const isActuallyPaused = planStatus === 'paused' || linkedPrd?.status === 'paused';
   const modalApproveLabel = isActuallyPaused ? 'Resume' : 'Approve';
   const showRejectInModal = linkedPrdAwaiting || planStatus === 'awaiting-approval';
-  const modalResumeBtn = modalShowResume ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--green)" ' +
-    'onclick="planApprove(\'' + escHtml(modalApproveTarget) + '\',this)">' + modalApproveLabel + '</button>' +
-    (showRejectInModal ? ' <button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--red)" ' +
-    'onclick="planReject(\'' + escHtml(modalApproveTarget) + '\')">Reject</button>' : '') : '';
+  const modalApproveBtn = modalShowResume ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--green)" ' +
+    'onclick="planApprove(\'' + escHtml(modalApproveTarget) + '\',this)">' + modalApproveLabel + '</button>' : '';
+  const modalRejectBtn = showRejectInModal ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--red)" ' +
+    'onclick="planReject(\'' + escHtml(modalApproveTarget) + '\')">Reject</button>' : '';
   const modalVerifyWi = (window._lastWorkItems || []).find(w => w.itemType === 'verify' && w.sourcePlan === normalizedFile);
   const modalVerifyBtn = isModalCompleted && !modalVerifyWi ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--green)" ' +
     'onclick="triggerVerify(\'' + escHtml(normalizedFile) + '\',this)">Verify</button>' : '';
@@ -477,7 +477,7 @@ function _renderPlanModal(normalizedFile, raw, lastMod) {
     'onclick="planArchive(\'' + escHtml(normalizedFile) + '\')">Archive</button>';
   const lastModLabel = lastMod ? '<div style="font-size:10px;color:var(--muted);font-weight:400;margin-top:2px">Last updated: ' + new Date(lastMod).toLocaleString() + '</div>' : '';
   const actionBtns = '<div style="display:flex;gap:4px;flex-wrap:wrap;margin-top:4px">' +
-    (modalCompletedLabel || '') + (modalAwaitingLabel || '') + (modalInProgressLabel || '') + (modalReExecuteBtn || '') + (modalExecuteBtn || '') + (modalPauseBtn || '') + (modalResumeBtn || '') + (modalVerifyBtn || '') + (modalVerifyInfo || '') +
+    (modalCompletedLabel || '') + (modalAwaitingLabel || '') + (modalInProgressLabel || '') + (modalApproveBtn || '') + (modalReExecuteBtn || '') + (modalExecuteBtn || '') + (modalPauseBtn || '') + (modalRejectBtn || '') + (modalVerifyBtn || '') + (modalVerifyInfo || '') +
     ' ' + modalArchiveBtn +
     ' <button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--red)" ' +
     'onclick="planDelete(\'' + escHtml(normalizedFile) + '\')">Delete</button>' +

package/engine/lifecycle.js

@@ -567,6 +567,7 @@ function syncPrsFromOutput(output, agentId, meta, config) {
 
   const prMatches = new Set();
   const urlPattern = /(?:visualstudio\.com|dev\.azure\.com)[^\s"]*?pullrequest\/(\d+)|github\.com\/[^\s"]*?\/pull\/(\d+)/g;
+  const textCreatedPattern = /(?:PR created|created PR|E2E PR)[:\s#-]*(\d{1,})/gi;
   let match;
 
   try {
@@ -586,7 +587,7 @@ function syncPrsFromOutput(output, agentId, meta, config) {
           // Also scan assistant text blocks for PR URLs and "PR created" patterns
           if (block.type === 'text' && block.text) {
             while ((match = urlPattern.exec(block.text)) !== null) prMatches.add(match[1] || match[2]);
-            const textCreatedPattern = /(?:PR created|created PR|E2E PR)[:\s#-]*(\d{1,})/gi;
+            textCreatedPattern.lastIndex = 0;
             let m2;
             while ((m2 = textCreatedPattern.exec(block.text)) !== null) prMatches.add(m2[1]);
           }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.696",
+  "version": "0.1.698",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"