@yemi33/minions 0.1.695 → 0.1.697

package/CHANGELOG.md

@@ -1,12 +1,16 @@
 # Changelog
 
-## 0.1.695 (2026-04-09)
+## 0.1.697 (2026-04-09)
 
 ### Fixes
+-  ADO build error log fetches all failing pipelines, not just first
 -  verify/implement playbooks must include PR URL in final message
 -  ADO build error log fallback when targetUrl lacks buildId
 -  syncPrsFromOutput missed PRs mentioned in assistant text blocks
 
+### Other
+- refactor: reorder card buttons (Approve first), split modal approve/reject
+
 ## 0.1.692 (2026-04-09)
 
 ### Fixes

package/dashboard/js/render-plans.js

@@ -211,8 +211,8 @@ function renderPlans(plans) {
       // For awaiting-approval: show Execute (re-generate PRD from updated plan) + Approve (use current PRD as-is)
       if (effectiveStatus === 'awaiting-approval' && isDraft && prdFile) {
         actions = '<div class="plan-card-actions" onclick="event.stopPropagation()">' +
-          '<button class="plan-btn approve" onclick="planExecute(\'' + escHtml(p.file) + '\',\'' + escHtml(p.project || '') + '\',this)">Re-execute</button>' +
-          '<button class="plan-btn approve" style="opacity:0.7" onclick="planApprove(\'' + escHtml(actionTarget) + '\')">Approve as-is</button>' +
+          '<button class="plan-btn approve" onclick="planApprove(\'' + escHtml(actionTarget) + '\')">Approve</button>' +
+          '<button class="plan-btn approve" style="opacity:0.7" onclick="planExecute(\'' + escHtml(p.file) + '\',\'' + escHtml(p.project || '') + '\',this)">Re-execute</button>' +
           '<button class="plan-btn reject" onclick="planReject(\'' + escHtml(actionTarget) + '\')">Reject</button>' +
         '</div>';
       } else {
@@ -465,10 +465,10 @@ function _renderPlanModal(normalizedFile, raw, lastMod) {
   const isActuallyPaused = planStatus === 'paused' || linkedPrd?.status === 'paused';
   const modalApproveLabel = isActuallyPaused ? 'Resume' : 'Approve';
   const showRejectInModal = linkedPrdAwaiting || planStatus === 'awaiting-approval';
-  const modalResumeBtn = modalShowResume ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--green)" ' +
-    'onclick="planApprove(\'' + escHtml(modalApproveTarget) + '\',this)">' + modalApproveLabel + '</button>' +
-    (showRejectInModal ? ' <button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--red)" ' +
-    'onclick="planReject(\'' + escHtml(modalApproveTarget) + '\')">Reject</button>' : '') : '';
+  const modalApproveBtn = modalShowResume ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--green)" ' +
+    'onclick="planApprove(\'' + escHtml(modalApproveTarget) + '\',this)">' + modalApproveLabel + '</button>' : '';
+  const modalRejectBtn = showRejectInModal ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--red)" ' +
+    'onclick="planReject(\'' + escHtml(modalApproveTarget) + '\')">Reject</button>' : '';
   const modalVerifyWi = (window._lastWorkItems || []).find(w => w.itemType === 'verify' && w.sourcePlan === normalizedFile);
   const modalVerifyBtn = isModalCompleted && !modalVerifyWi ? '<button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--green)" ' +
     'onclick="triggerVerify(\'' + escHtml(normalizedFile) + '\',this)">Verify</button>' : '';
@@ -477,7 +477,7 @@ function _renderPlanModal(normalizedFile, raw, lastMod) {
     'onclick="planArchive(\'' + escHtml(normalizedFile) + '\')">Archive</button>';
   const lastModLabel = lastMod ? '<div style="font-size:10px;color:var(--muted);font-weight:400;margin-top:2px">Last updated: ' + new Date(lastMod).toLocaleString() + '</div>' : '';
   const actionBtns = '<div style="display:flex;gap:4px;flex-wrap:wrap;margin-top:4px">' +
-    (modalCompletedLabel || '') + (modalAwaitingLabel || '') + (modalInProgressLabel || '') + (modalReExecuteBtn || '') + (modalExecuteBtn || '') + (modalPauseBtn || '') + (modalResumeBtn || '') + (modalVerifyBtn || '') + (modalVerifyInfo || '') +
+    (modalCompletedLabel || '') + (modalAwaitingLabel || '') + (modalInProgressLabel || '') + (modalApproveBtn || '') + (modalReExecuteBtn || '') + (modalExecuteBtn || '') + (modalPauseBtn || '') + (modalRejectBtn || '') + (modalVerifyBtn || '') + (modalVerifyInfo || '') +
     ' ' + modalArchiveBtn +
     ' <button class="pr-pager-btn" style="font-size:10px;padding:2px 10px;color:var(--red)" ' +
     'onclick="planDelete(\'' + escHtml(normalizedFile) + '\')">Delete</button>' +

package/engine/ado.js

@@ -99,7 +99,7 @@ const BUILD_ERROR_LOG_MAX_LINES = 150;
  * for failed tasks, and fetches their logs.
  * Returns truncated log text or null if unavailable.
  */
-async function fetchAdoBuildErrorLog(orgBase, project, failedStatus, token, pr) {
+async function fetchAdoBuildErrorLog(orgBase, project, failedStatus, token, pr, seenBuildIds) {
   try {
     // Try extracting buildId from targetUrl (e.g. .../_build/results?buildId=12345)
     const targetUrl = failedStatus?.targetUrl || '';
@@ -112,10 +112,11 @@ async function fetchAdoBuildErrorLog(orgBase, project, failedStatus, token, pr)
       try {
         const branch = pr?.branch || pr?.sourceRefName?.replace('refs/heads/', '');
         if (branch) {
-          const buildsUrl = `${orgBase}/${project.adoProject}/_apis/build/builds?branchName=refs/heads/${encodeURIComponent(branch)}&statusFilter=completed&resultFilter=failed&$top=1&api-version=7.1`;
+          const buildsUrl = `${orgBase}/${project.adoProject}/_apis/build/builds?branchName=refs/heads/${encodeURIComponent(branch)}&statusFilter=completed&resultFilter=failed&$top=3&api-version=7.1`;
           const builds = await adoFetch(buildsUrl, token);
-          if (builds?.value?.[0]?.id) {
-            buildId = String(builds.value[0].id);
+          const fresh = (builds?.value || []).find(b => !seenBuildIds?.has(String(b.id)));
+          if (fresh?.id) {
+            buildId = String(fresh.id);
             log('debug', `Found buildId ${buildId} via branch query for ${branch}`);
           }
         }
@@ -125,6 +126,8 @@ async function fetchAdoBuildErrorLog(orgBase, project, failedStatus, token, pr)
       log('debug', `No buildId from targetUrl or branch query: ${targetUrl.slice(0, 120)}`);
       return null;
     }
+    if (seenBuildIds?.has(buildId)) return null; // already fetched this build
+    if (seenBuildIds) seenBuildIds.add(buildId);
 
     // Fetch build timeline to find failed tasks
     const timelineUrl = `${orgBase}/${project.adoProject}/_apis/build/builds/${buildId}/timeline?api-version=7.1`;
@@ -390,11 +393,16 @@ async function pollPrStatus(config) {
 
       // Fetch actual compiler/build error logs when transitioning to failing
       if (buildStatus === 'failing') {
-        const failedStatusObj = buildStatuses.find(s => s.state === 'failed' || s.state === 'error');
-        const errorLog = await fetchAdoBuildErrorLog(orgBase, project, failedStatusObj, token, pr);
-        if (errorLog) {
-          pr.buildErrorLog = errorLog;
-          log('info', `PR ${pr.id}: fetched ${errorLog.split('\n').length} lines of build error log`);
+        const failedStatusObjs = buildStatuses.filter(s => s.state === 'failed' || s.state === 'error').slice(0, 3);
+        const logParts = [];
+        const seenBuildIds = new Set();
+        for (const failedStatusObj of failedStatusObjs) {
+          const errorLog = await fetchAdoBuildErrorLog(orgBase, project, failedStatusObj, token, pr, seenBuildIds);
+          if (errorLog) logParts.push(errorLog);
+        }
+        if (logParts.length > 0) {
+          pr.buildErrorLog = logParts.join('\n\n');
+          log('info', `PR ${pr.id}: fetched error logs from ${logParts.length} failing pipeline(s)`);
         }
       }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.695",
+  "version": "0.1.697",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"