@yemi33/minions 0.1.667 → 0.1.669

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.1.669 (2026-04-09)
+
+### Fixes
+- interrupt blocking tool calls immediately on steering (closes #627) (#632)
+- reduce Bash blocking grace and errored task dedup window (closes #593) (#630)
+
 ## 0.1.667 (2026-04-09)
 
 ### Features

package/engine/cooldown.js

@@ -95,11 +95,13 @@ function isAlreadyDispatched(key) {
   // Check pending and active
   const inFlight = [...dispatch.pending, ...(dispatch.active || [])];
   if (inFlight.some(d => d.meta?.dispatchKey === key)) return true;
-  // Also check recently completed (last hour) to prevent re-dispatch
-  const oneHourAgo = Date.now() - 3600000;
-  const recentCompleted = (dispatch.completed || []).filter(d =>
-    d.completed_at && new Date(d.completed_at).getTime() > oneHourAgo
-  );
+  // Also check recently completed — shorter window for errors (15min) vs success (1hr)
+  const now = Date.now();
+  const recentCompleted = (dispatch.completed || []).filter(d => {
+    if (!d.completed_at) return false;
+    const windowMs = d.result === 'error' ? 900000 : 3600000; // 15 min for errors, 1 hr for success
+    return now - new Date(d.completed_at).getTime() < windowMs;
+  });
   return recentCompleted.some(d => d.meta?.dispatchKey === key);
 }
 

package/engine/timeout.js

@@ -54,9 +54,28 @@ function checkIdleThreshold(config) {
 
 // ─── Steering Checker ────────────────────────────────────────────────────────
 
+// How long to wait for a steered agent to exit before retrying the kill
+const STEERING_KILL_RETRY_MS = 30000;
+
 function checkSteering(config) {
   const activeProcesses = engine().activeProcesses;
   for (const [id, info] of activeProcesses) {
+    // Recovery: if steering kill hasn't resulted in process exit within 30s, force-retry.
+    // This catches cases where killImmediate silently failed (e.g., orphaned subprocess
+    // on Unix where SIGKILL only hit spawn-agent.js, not the Claude CLI tree).
+    if (info._steeringAt && Date.now() - info._steeringAt > STEERING_KILL_RETRY_MS) {
+      if (!info._steeringRetried) {
+        log('warn', `Steering: ${info.agentId} (${id}) didn't exit ${STEERING_KILL_RETRY_MS / 1000}s after kill — retrying`);
+        shared.killImmediate(info.proc);
+        // On Unix, also try to kill children that may have been orphaned
+        if (process.platform !== 'win32' && info.proc?.pid) {
+          try { shared.exec(`pkill -KILL -P ${info.proc.pid}`, { timeout: 3000 }); } catch { /* children may already be dead */ }
+        }
+        info._steeringRetried = true;
+      }
+      continue;
+    }
+
     // Skip if already being steered (prevents double-kill race)
     if (info._steeringMessage || info._steeringAt) continue;
 
@@ -64,19 +83,34 @@ function checkSteering(config) {
     let steerMtime;
     try { steerMtime = fs.statSync(steerPath).mtimeMs; } catch { continue; } // ENOENT = no steering message
 
+    // Read and consume the message immediately — always delete to prevent stale messages
+    const message = safeRead(steerPath);
+    try { fs.unlinkSync(steerPath); } catch { /* cleanup */ }
+    if (!message) continue;
+
     const sessionId = info.sessionId;
     if (!sessionId) {
-      if (Date.now() - steerMtime > 300000) {
-        log('warn', `Steering: no sessionId for ${info.agentId} after 5m — deleting stale message`);
-        try { fs.unlinkSync(steerPath); } catch {}
-      }
+      // No session to resume — kill agent and deliver message via inbox for retry.
+      // Previously this silently skipped for up to 5m then deleted the message (#627).
+      log('info', `Steering: no sessionId for ${info.agentId} (${id}) — killing and forwarding message to inbox`);
+
+      // Write steering message to agent inbox so it survives the retry
+      const inboxDir = path.join(AGENTS_DIR, info.agentId, 'inbox');
+      try { fs.mkdirSync(inboxDir, { recursive: true }); } catch {}
+      safeWrite(path.join(inboxDir, `steering-${Date.now()}.md`), `# Steering Message (Forwarded)\n\nOriginal steering from human:\n\n${message}\n`);
+
+      // Append to live output so user sees confirmation in the dashboard
+      try {
+        const liveLogPath = path.join(AGENTS_DIR, info.agentId, 'live-output.log');
+        fs.appendFileSync(liveLogPath, `\n[steering] Message received but no session to resume. Killing agent — your message will be delivered on retry.\n`);
+      } catch { /* optional */ }
+
+      shared.killImmediate(info.proc);
+      info._steeringAt = Date.now();
+      info._steeringNoSession = true;
       continue;
     }
 
-    const message = safeRead(steerPath);
-    try { fs.unlinkSync(steerPath); } catch { /* cleanup */ }
-    if (!message) continue;
-
     log('info', `Steering: killing ${info.agentId} (${id}) for session resume with human message`);
 
     shared.killImmediate(info.proc);
@@ -187,8 +221,8 @@ function checkTimeouts(config) {
               }
               // Bash tool call — may be running a long build/install with no stdout
               if (name === 'Bash') {
-                // Use explicit timeout if set, otherwise default to 10min for any Bash call
-                const bashTimeout = input.timeout || 600000;
+                // Use explicit timeout if set, otherwise match Claude Code's actual Bash default (120s)
+                const bashTimeout = input.timeout || 120000;
                 blockingTimeout = Math.max(heartbeatTimeout, bashTimeout + 60000);
                 isBlocking = true;
               }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.667",
+  "version": "0.1.669",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"