@yemi33/minions 0.1.652 → 0.1.654

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.1.654 (2026-04-09)
+
+### Fixes
+-  kill process tree (not just parent) before worktree removal
+
+### Other
+- refactor: extract slugify/formatTranscriptEntry, fix pipeline completion
+
 ## 0.1.652 (2026-04-09)
 
 ### Fixes

package/dashboard.js

@@ -1266,7 +1266,7 @@ const server = http.createServer(async (req, res) => {
       fs.mkdirSync(inboxDir, { recursive: true });
       const today = new Date().toISOString().slice(0, 10);
       const author = body.author || os.userInfo().username;
-      const slug = (body.title || 'note').toLowerCase().replace(/[^a-z0-9]+/g, '-').slice(0, 40);
+      const slug = shared.slugify(body.title || 'note', 40);
       const filename = `${author}-${slug}-${today}-${shared.uid().slice(-4)}.md`;
       const content = `# ${body.title}\n\n**By:** ${author}\n**Date:** ${today}\n\n${body.what}\n${body.why ? '\n**Why:** ' + body.why + '\n' : ''}`;
       safeWrite(shared.uniquePath(path.join(inboxDir, filename)), content);
@@ -3362,7 +3362,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
 
     // Auto-generate ID from title if not provided
     if (!id) {
-      id = title.toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/^-|-$/g, '').slice(0, 40);
+      id = shared.slugify(title, 40);
       if (!id) id = 'schedule';
     }
 
@@ -3888,7 +3888,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
 
       const plansDir = path.join(MINIONS_DIR, 'plans');
       if (!fs.existsSync(plansDir)) fs.mkdirSync(plansDir, { recursive: true });
-      const slug = title.toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/^-|-$/g, '').slice(0, 50);
+      const slug = shared.slugify(title);
       const date = new Date().toISOString().slice(0, 10);
       const filename = `${slug}-${date}.md`;
       const filePath = shared.uniquePath(path.join(plansDir, filename));
@@ -3954,7 +3954,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       if (!category || !title || !content) return jsonReply(res, 400, { error: 'category, title, and content required' });
       const validCategories = ['architecture', 'conventions', 'project-notes', 'build-reports', 'reviews'];
       if (!validCategories.includes(category)) return jsonReply(res, 400, { error: 'Invalid category. Must be: ' + validCategories.join(', ') });
-      const slug = title.toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/^-|-$/g, '').slice(0, 60);
+      const slug = shared.slugify(title, 60);
       const filePath = path.join(MINIONS_DIR, 'knowledge', category, slug + '.md');
       const dir = path.dirname(filePath);
       if (!fs.existsSync(dir)) fs.mkdirSync(dir, { recursive: true });

package/engine/cleanup.js

@@ -74,14 +74,14 @@ function _killProcessInWorktree(dir, activeProcesses, activeIds) {
             const taskInfo = exec(`tasklist /FI "PID eq ${pid}" /NH`, { encoding: 'utf8', timeout: 3000, windowsHide: true });
             const taskLower = taskInfo.toLowerCase();
             if (!taskLower.includes('node') && !taskLower.includes('claude')) continue;
-            exec(`taskkill /F /PID ${pid}`, { stdio: 'pipe', timeout: 5000, windowsHide: true });
+            exec(`taskkill /F /T /PID ${pid}`, { stdio: 'pipe', timeout: 5000, windowsHide: true });
           } else {
             // Verify it's a node process before killing (prevent recycled PID kill)
             try {
               const psOut = exec(`ps -p ${pid} -o comm=`, { encoding: 'utf8', timeout: 3000 }).trim();
               if (!psOut.includes('node') && !psOut.includes('claude')) continue;
             } catch { continue; } // process dead or ps failed
-            process.kill(pid, 'SIGKILL');
+            try { process.kill(-pid, 'SIGKILL'); } catch { process.kill(pid, 'SIGKILL'); }
           }
           log('info', `Killed orphaned PID ${pid} (${f}) before worktree removal`);
         } catch {} // process may already be dead

package/engine/consolidation.js

@@ -140,7 +140,7 @@ function consolidateWithLLM(items, existingNotes, files, config) {
     const agentMatch = item.name.match(/^(\w+)-/);
     const agent = agentMatch ? agentMatch[1] : 'unknown';
     const titleMatch = (item.content || '').match(/^#\s+(.+)/m);
-    const titleSlug = titleMatch ? titleMatch[1].toLowerCase().replace(/[^a-z0-9]+/g, '-').slice(0, 50) : item.name.replace(/\.md$/, '');
+    const titleSlug = titleMatch ? shared.slugify(titleMatch[1]) : item.name.replace(/\.md$/, '');
     return { file: item.name, category: cat, kbPath: path.join('knowledge', cat, `${dateStamp()}-${agent}-${titleSlug}.md`) };
   });
 
@@ -415,7 +415,7 @@ function classifyToKnowledgeBase(items) {
     const agent = agentMatch ? agentMatch[1] : 'unknown';
     const titleMatch = content.match(/^#\s+(.+)/m);
     const titleSlug = titleMatch
-      ? titleMatch[1].toLowerCase().replace(/[^a-z0-9]+/g, '-').slice(0, 50)
+      ? shared.slugify(titleMatch[1])
       : item.name.replace(/\.md$/, '');
     const kbFilename = `${dateStamp()}-${agent}-${titleSlug}.md`;
     const kbPath = shared.uniquePath(path.join(categoryDirs[category], kbFilename));

package/engine/pipeline.js

@@ -7,7 +7,7 @@
 const fs = require('fs');
 const path = require('path');
 const shared = require('./shared');
-const { safeJson, safeWrite, safeRead, safeReadDir, uid, log, ts, dateStamp, mutateJsonFileLocked, mutateWorkItems, WI_STATUS, WORK_TYPE, PLAN_STATUS, PR_STATUS, PIPELINE_STATUS, STAGE_TYPE, MEETING_STATUS, ENGINE_DEFAULTS } = shared;
+const { safeJson, safeWrite, safeRead, safeReadDir, uid, log, ts, dateStamp, mutateJsonFileLocked, mutateWorkItems, slugify, formatTranscriptEntry, WI_STATUS, WORK_TYPE, PLAN_STATUS, PR_STATUS, PIPELINE_STATUS, STAGE_TYPE, MEETING_STATUS, ENGINE_DEFAULTS } = shared;
 const http = require('http');
 const { parseCronExpr, shouldRunNow } = require('./scheduler');
 
@@ -304,7 +304,7 @@ function _findExistingPlanForMeeting(meetingIds, plansDir) {
     const mtg = safeJson(path.join(__dirname, '..', 'meetings', mid + '.json'));
     if (mtg?.title) {
       // Dashboard convention: "Meeting follow-up: {title}" → slug
-      const dashSlug = ('meeting-follow-up-' + mtg.title).toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/^-|-$/g, '').slice(0, 50);
+      const dashSlug = slugify('meeting-follow-up-' + mtg.title);
       slugPrefixes.push(dashSlug);
     }
   }
@@ -324,7 +324,7 @@ async function executePlanStage(stage, stageState, run, config) {
   const plansDir = path.join(__dirname, '..', 'plans');
   if (!fs.existsSync(plansDir)) fs.mkdirSync(plansDir, { recursive: true });
 
-  const slug = (stage.title || 'pipeline-plan').toLowerCase().replace(/[^a-z0-9]+/g, '-').slice(0, 50);
+  const slug = slugify(stage.title || 'pipeline-plan');
   const wiPath = path.join(__dirname, '..', 'work-items.json');
   const wiId = `PL-${run.runId.slice(4, 12)}-${stage.id}-prd`;
 
@@ -364,9 +364,7 @@ async function executePlanStage(stage, stageState, run, config) {
     try {
       const mtg = safeJson(path.join(__dirname, '..', 'meetings', mid + '.json'));
       if (mtg) {
-        const transcript = (mtg.transcript || []).map(t =>
-          '### ' + (t.agent || 'agent') + ' (' + (t.type || '') + ', Round ' + (t.round || '?') + ')\n\n' + (t.content || '')
-        ).join('\n\n---\n\n');
+        const transcript = (mtg.transcript || []).map(formatTranscriptEntry).join('\n\n---\n\n');
         meetingContext += '# Meeting: ' + (mtg.title || mid) + '\n\n**Agenda:** ' + (mtg.agenda || '') + '\n\n' + transcript + '\n\n';
       }
     } catch (e) { log('warn', `Pipeline plan: failed to read meeting ${mid}: ${e.message}`); }
@@ -600,29 +598,32 @@ function isStageComplete(stage, stageState, run, config) {
       });
       if (!prdDone) return false;
 
-      // Discover PRDs and their work items
+      // Discover PRDs and their work items — collect into local arrays, then merge into artifacts
       const prdDir = path.join(__dirname, '..', 'prd');
       const plans = artifacts.plans || [];
+      const discoveredPrds = [];
+      const discoveredWiIds = [];
       for (const planFile of plans) {
         const prdFiles = fs.existsSync(prdDir) ? safeReadDir(prdDir).filter(f => f.endsWith('.json')) : [];
         for (const pf of prdFiles) {
           const prd = safeJson(path.join(prdDir, pf));
-          if (prd?.source_plan === planFile && !(artifacts.prds || []).includes(pf)) {
-            artifacts.prds = artifacts.prds || [];
-            artifacts.prds.push(pf);
+          if (prd?.source_plan === planFile && !(artifacts.prds || []).includes(pf) && !discoveredPrds.includes(pf)) {
+            discoveredPrds.push(pf);
           }
         }
-        // Find materialized work items for discovered PRDs
-        for (const prdFile of (artifacts.prds || [])) {
+        const allPrds = [...(artifacts.prds || []), ...discoveredPrds];
+        for (const prdFile of allPrds) {
           const prdItems = all.filter(w => w.sourcePlan === prdFile && w.type !== WORK_TYPE.PLAN_TO_PRD);
           for (const wi of prdItems) {
-            if (!(artifacts.workItems || []).includes(wi.id)) {
-              artifacts.workItems = artifacts.workItems || [];
-              artifacts.workItems.push(wi.id);
+            if (!(artifacts.workItems || []).includes(wi.id) && !discoveredWiIds.includes(wi.id)) {
+              discoveredWiIds.push(wi.id);
             }
           }
         }
       }
+      // Merge discovered artifacts (caller persists via updateRunStage)
+      if (discoveredPrds.length > 0) { artifacts.prds = [...(artifacts.prds || []), ...discoveredPrds]; }
+      if (discoveredWiIds.length > 0) { artifacts.workItems = [...(artifacts.workItems || []), ...discoveredWiIds]; }
 
       // Auto-approve if configured
       if (stage.autoApprove && artifacts.prds?.length > 0) {
@@ -792,7 +793,18 @@ async function discoverPipelineWork(config) {
           const result = await executeStage(stage, activeRun, pipeline, config);
           updateRunStage(pipeline.id, activeRun.runId, stage.id, { ...result, startedAt: ts() });
           Object.assign(stageState, result, { startedAt: ts() });
-          if (result.status === PIPELINE_STATUS.RUNNING) anyRunning = true;
+          if (result.status === PIPELINE_STATUS.RUNNING) {
+            // Check if stage is already complete (e.g. reconciled plan with done WI)
+            if (isStageComplete(stage, stageState, activeRun, config)) {
+              updateRunStage(pipeline.id, activeRun.runId, stage.id, {
+                status: PIPELINE_STATUS.COMPLETED, completedAt: ts(), artifacts: stageState.artifacts,
+              });
+              stageState.status = PIPELINE_STATUS.COMPLETED;
+              log('info', `Pipeline ${pipeline.id}: stage ${stage.id} completed immediately after start`);
+            } else {
+              anyRunning = true;
+            }
+          }
           // Condition stage signaled pipeline stop — complete the run immediately
           if (result._stopPipeline) {
             completeRun(pipeline.id, activeRun.runId, PIPELINE_STATUS.STOPPED);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.652",
+  "version": "0.1.654",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"