@yemi33/minions 0.1.624 → 0.1.626

package/CHANGELOG.md

@@ -1,8 +1,14 @@
 # Changelog
 
-## 0.1.624 (2026-04-08)
+## 0.1.626 (2026-04-08)
 
 ### Fixes
+-  add test/check steps and stop condition to work-item playbook
+
+## 0.1.625 (2026-04-08)
+
+### Fixes
+-  reorder implement-shared playbook — build & test before push
 -  reorder implement playbook — build & test before push
 
 ## 0.1.623 (2026-04-08)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.624",
+  "version": "0.1.626",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/playbooks/implement-shared.md

@@ -31,13 +31,7 @@ Check what's already on this branch:
 git log --oneline {{main_branch}}..HEAD
 ```
 
-Do ALL work in the worktree. When done:
-
-```bash
-git add <specific files>
-git commit -m "{{commit_message}}"
-git push origin {{branch_name}}
-```
+Do ALL work in the worktree.
 
 **Do NOT:**
 - Create a new branch — use `{{branch_name}}`
@@ -60,17 +54,27 @@ Use subagents only for genuinely parallel, independent tasks. For sequential wor
 3. Follow existing patterns exactly — check `CLAUDE.md` for conventions
 4. Build on existing work — don't duplicate or conflict with prior commits
 
-## Build and Verify
+## Build & Test (MANDATORY before pushing)
 
-After implementation:
-1. Build the project using the repo's build system (check CLAUDE.md, package.json, README)
+After implementation, verify everything works:
+
+1. **Build** the project using its build system (check CLAUDE.md, package.json, README, Makefile)
 2. Verify the build succeeds with your changes AND all prior commits on this branch
-3. If the build fails:
-   - Read the error output carefully
-   - Fix the issue (including issues from prior commits if needed)
-   - Re-run the build
-   - If it fails 3 times, report the build errors in your findings and stop
+3. **Run the full test suite** — fix any regressions you introduced
+4. **Run any other checks** the repo defines (linting, type checking, formatting)
+5. If the build fails 3 times, report the errors in your findings and stop
+6. Do NOT push code with a broken build or failing tests that you introduced
+
+## Push
+
+Only after build and tests pass:
+
+```bash
+git add <specific files>
+git commit -m "{{commit_message}}"
+git push origin {{branch_name}}
+```
 
 ## When to Stop
 
-Your task is complete once you have committed and pushed your changes to the shared branch. Do NOT create a PR — the engine creates one when all plan items are done. Stop after pushing.
+Your task is complete once you have: (1) confirmed build and tests pass, and (2) pushed to the shared branch. Do NOT create a PR — the engine creates one when all plan items are done. Stop after pushing.

package/playbooks/work-item.md

@@ -26,39 +26,35 @@ Keep branch names lowercase, use hyphens, max 60 chars.
 2. **Navigate** to the correct project directory: `{{project_path}}`
 3. You are already in a worktree on branch `{{branch_name}}`. Do NOT create additional worktrees.
 4. **Implement** the changes
-5. **Build and verify** — ensure the build passes. If it fails, fix and retry (up to 3 times)
-6. **Commit and push**:
+5. **Build** — using the repo's build system (check CLAUDE.md, package.json, README, Makefile). If it fails, fix and retry (up to 3 times).
+6. **Run the full test suite** — find the test command from project docs. Fix any regressions you introduced. Do NOT push with failing tests.
+7. **Run any other checks** the repo defines (linting, type checking, formatting)
+8. **Commit and push** (only after build and tests pass):
    ```bash
    git add <specific files>
    git commit -m "feat({{item_id}}): <description>"
    git push -u origin {{branch_name}}
    ```
-7. **Create a PR:**
+9. **Create a PR:**
    {{pr_create_instructions}}
    - sourceRefName: `refs/heads/feat/{{item_id}}-<short-desc>`
    - targetRefName: `refs/heads/{{main_branch}}`
    - title: `feat({{item_id}}): <description>`
-8. **Post implementation notes** as a PR thread comment:
-   {{pr_comment_instructions}}
-9. **Add PR to tracker** — append to `{{team_root}}/projects/{{project_name}}/pull-requests.json`:
-   ```json
-   { "id": "PR-<number>", "title": "...", "agent": "{{agent_name}}", "branch": "...", "reviewStatus": "pending", "status": "active", "created": "<date>", "url": "<pr-url>", "prdItems": ["{{item_id}}"] }
-   ```
-10. Do NOT remove the worktree — the engine handles cleanup automatically.
+10. **Post implementation notes** as a PR thread comment:
+    {{pr_comment_instructions}}
+
+Do NOT remove the worktree — the engine handles cleanup automatically.
 
 ## After Completion
 
 Write your findings to: `{{team_root}}/notes/inbox/{{agent_id}}-{{item_id}}-{{date}}.md`
 
-
-## Rules
-- Do not checkout branches in the main working tree — use worktrees
-- Use the repo host's MCP tools for PR creation — check available MCP tools before starting
-- Use PowerShell for build commands on Windows if applicable
-- If you discover a repeatable workflow, output it as a ```skill block (the engine auto-extracts it to ~/.claude/skills/)
-
 ## Handling Merge Conflicts
 If you encounter merge conflicts during push or PR creation:
 1. Resolve conflicts in the worktree, preferring your changes
 2. Commit the resolution
 3. Push again
+
+## When to Stop
+
+Your task is complete once you have: (1) confirmed build and tests pass, (2) pushed your branch, and (3) created the PR. Do NOT continue beyond the task description. Stop immediately.