@yemi33/minions 0.1.585 → 0.1.587

package/CHANGELOG.md

@@ -1,11 +1,15 @@
 # Changelog
 
-## 0.1.585 (2026-04-08)
+## 0.1.587 (2026-04-08)
 
 ### Fixes
+-  use TCP socket probe for minions dash port check
 -  minions dash opens browser when dashboard already running
 -  add conditional block support to playbook renderer
 
+### Other
+- perf: per-type max-turns and explicit stop conditions in playbooks
+
 ## 0.1.583 (2026-04-08)
 
 ### Fixes

package/bin/minions.js

@@ -705,11 +705,15 @@ if (!cmd || cmd === 'help' || cmd === '--help' || cmd === '-h') {
 } else if (cmd === 'dash' || cmd === 'dashboard') {
   ensureInstalled();
   // If dashboard is already running, just open the browser
-  const http = require('http');
+  const net = require('net');
   const dashPort = 7331;
-  const probe = http.get(`http://localhost:${dashPort}/api/status`, (res) => {
-    res.resume();
-    // Dashboard is running — open browser
+  const sock = new net.Socket();
+  let handled = false;
+  sock.setTimeout(1000);
+  sock.on('connect', () => {
+    sock.destroy();
+    if (handled) return;
+    handled = true;
     const url = `http://localhost:${dashPort}`;
     console.log(`\n  Dashboard already running: ${url}\n`);
     try {
@@ -717,11 +721,18 @@ if (!cmd || cmd === 'help' || cmd === '--help' || cmd === '-h') {
       execSync(openCmd, { stdio: 'ignore', windowsHide: true });
     } catch {}
   });
-  probe.on('error', () => {
-    // Dashboard not running — start it
+  sock.on('error', () => {
+    if (handled) return;
+    handled = true;
     delegate('dashboard.js', rest);
   });
-  probe.setTimeout(2000, () => { probe.destroy(); delegate('dashboard.js', rest); });
+  sock.on('timeout', () => {
+    sock.destroy();
+    if (handled) return;
+    handled = true;
+    delegate('dashboard.js', rest);
+  });
+  sock.connect(dashPort, '127.0.0.1');
 } else if (engineCmds.has(cmd)) {
   delegate('engine.js', [cmd, ...rest]);
 } else {

package/engine.js

@@ -147,6 +147,17 @@ let engineRestartGraceUntil = 0; // timestamp — suppress orphan detection unti
 // Cleared at the start of each tick cycle (see tickInner)
 const _failedRefCache = new Set();
 const _FAST_WORK_TYPES = new Set([WORK_TYPE.EXPLORE, WORK_TYPE.ASK, WORK_TYPE.REVIEW]);
+const _MAX_TURNS_BY_TYPE = {
+  [WORK_TYPE.EXPLORE]: 30, [WORK_TYPE.ASK]: 20, [WORK_TYPE.REVIEW]: 30,
+  [WORK_TYPE.DECOMPOSE]: 15, [WORK_TYPE.PLAN]: 30, [WORK_TYPE.PLAN_TO_PRD]: 20,
+  [WORK_TYPE.MEETING]: 30,
+  [WORK_TYPE.IMPLEMENT]: 75, [WORK_TYPE.IMPLEMENT_LARGE]: 75, [WORK_TYPE.FIX]: 50,
+  [WORK_TYPE.TEST]: 50, [WORK_TYPE.VERIFY]: 100, [WORK_TYPE.DOCS]: 30,
+};
+function _maxTurnsForType(type, engineConfig) {
+  // User override takes precedence, then per-type default, then global default
+  return engineConfig.maxTurns || _MAX_TURNS_BY_TYPE[type] || DEFAULTS.maxTurns;
+}
 
 // Resolve dependency plan item IDs to their PR branches
 function resolveDependencyBranches(depIds, sourcePlan, project, config) {
@@ -484,7 +495,7 @@ async function spawnAgent(dispatchItem, config) {
   // Build claude CLI args
   const args = [
     '--output-format', claudeConfig.outputFormat || 'stream-json',
-    '--max-turns', String(engineConfig.maxTurns || DEFAULTS.maxTurns),
+    '--max-turns', String(_maxTurnsForType(type, engineConfig)),
     '--verbose',
     '--permission-mode', claudeConfig.permissionMode || 'bypassPermissions'
   ];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.585",
+  "version": "0.1.587",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/playbooks/explore.md

@@ -63,5 +63,9 @@ Use subagents only for genuinely parallel, independent tasks. For reading files,
 - Read `notes.md` for all team rules before starting.
 - If you discover a repeatable workflow, output it as a ```skill block (the engine auto-extracts it to ~/.claude/skills/)
 
+## When to Stop
+
+Your task is complete once you have written your findings to the inbox file. Do NOT continue reading additional files, exploring tangential areas, or producing extra analysis beyond what was asked. Write your findings and stop.
+
 ## Team Decisions
 {{notes_content}}

package/playbooks/fix.md

@@ -60,6 +60,8 @@ Before pushing your fix, run the project's test suite:
 3. If any tests fail due to your changes, fix them before pushing
 4. Do NOT push code that breaks existing tests
 
-## Signal Completion
+## When to Stop
+
+Your task is complete once you have: (1) pushed the fix, (2) created or updated the PR, and (3) confirmed tests pass. Do NOT continue exploring unrelated code or making additional improvements. Stop immediately after the fix is verified.
 
 **Note:** Do NOT write to `agents/*/status.json` — the engine manages your status automatically.

package/playbooks/implement.md

@@ -60,7 +60,9 @@ Do NOT remove the worktree — the engine handles cleanup automatically.
 
 {{pr_section}}
 
-## Signal Completion
+## When to Stop
+
+Your task is complete once you have: (1) pushed your branch, (2) created the PR, and (3) confirmed the build passes. Do NOT continue exploring, refactoring, or adding features beyond the task description. Stop immediately after the PR is created and verified.
 
 **Note:** Do NOT write to `agents/*/status.json` — the engine manages your status automatically.
 

package/playbooks/review.md

@@ -67,6 +67,8 @@ If you encounter merge conflicts (e.g., the PR shows conflicts):
 
 ## Do not run git checkout on the main working tree. Use `git diff` and `git show` only.
 
-## Signal Completion
+## When to Stop
+
+Your task is complete once you have: (1) posted your review comment on the PR, and (2) cast your vote. Do NOT continue reading unrelated files or performing additional analysis. Stop after voting.
 
 **Note:** Do NOT write to `agents/*/status.json` — the engine manages your status automatically.