@yemi33/minions 0.1.554 → 0.1.556

package/CHANGELOG.md

@@ -1,11 +1,13 @@
 # Changelog
 
-## 0.1.554 (2026-04-07)
+## 0.1.556 (2026-04-07)
 
 ### Features
 -  add pin/unpin button to inbox and KB document modals
 
 ### Fixes
+- defer dispatched status until spawnAgent succeeds + add _any_ routing token (#482)
+-  move pin button to modal header next to Copy button
 - fetch actual build error logs instead of just reason string (#489)
 
 ## 0.1.552 (2026-04-07)

package/dashboard/js/modal-qa.js

@@ -5,6 +5,7 @@ let _modalFilePath = null; // file path for steering (null = read-only Q&A only)
 
 function showModalQa() {
   document.getElementById('modal-qa').style.display = '';
+  updateModalPinBtn();
 }
 
 function _qaNotifySidebar(filePath) {

package/dashboard/js/modal.js

@@ -41,6 +41,7 @@ function closeModal() {
   body.contentEditable = 'false';
   body.style.border = '';
   body.style.padding = '';
+  document.getElementById('modal-pin-btn').style.display = 'none';
   document.getElementById('modal-edit-btn').style.display = 'none';
   document.getElementById('modal-save-btn').style.display = 'none';
   document.getElementById('modal-cancel-edit-btn').style.display = 'none';

package/dashboard/js/render-kb.js

@@ -216,13 +216,9 @@ async function kbOpenItem(category, file) {
   try {
     const content = await fetch('/api/knowledge/' + category + '/' + encodeURIComponent(file)).then(r => r.text());
     const display = content.replace(/^---[\s\S]*?---\n*/m, '');
-    var pk = kbPinKey(category, file);
-    var pinned = isPinned(pk);
     document.getElementById('modal-title').textContent = file;
     const modalBody = document.getElementById('modal-body');
-    modalBody.innerHTML =
-      '<div style="margin-bottom:12px"><button class="pr-pager-btn pin-btn' + (pinned ? ' pinned' : '') + '" style="font-size:10px;padding:3px 10px" data-pin-key="' + escHtml(pk) + '" onclick="_togglePinAndRefresh(this.dataset.pinKey,\'kb\');kbOpenItem(\'' + escHtml(category) + '\',\'' + escHtml(file) + '\')">' + (pinned ? 'Unpin' : 'Pin to top') + '</button></div>' +
-      renderMd(display);
+    modalBody.innerHTML = renderMd(display);
     _modalDocContext = { title: file, content: display, selection: '' };
     _modalFilePath = 'knowledge/' + category + '/' + file; showModalQa();
     // Clear notification badge when opening this document

package/dashboard/js/render-prs.js

@@ -91,14 +91,9 @@ function openAllPrs() {
 function openModal(i) {
   const item = inboxData[i];
   if (!item) return;
-  var pk = inboxPinKey(item.name);
-  var pinned = isPinned(pk);
   document.getElementById('modal-title').textContent = item.name;
   document.getElementById('modal-body').innerHTML =
-    '<div style="margin-bottom:12px;display:flex;gap:8px;align-items:center">' +
-      '<button class="pr-pager-btn pin-btn' + (pinned ? ' pinned' : '') + '" style="font-size:10px;padding:3px 10px" data-pin-key="' + escHtml(pk) + '" onclick="_togglePinAndRefresh(this.dataset.pinKey,\'inbox\');openModal(' + i + ')">' + (pinned ? 'Unpin' : 'Pin to top') + '</button>' +
-      '<button class="pr-pager-btn" style="font-size:10px;padding:3px 10px" onclick="promoteToKB(\'' + escHtml(item.name) + '\')">Add to Knowledge Base</button>' +
-    '</div>' +
+    '<div style="margin-bottom:12px"><button class="pr-pager-btn" style="font-size:10px;padding:3px 10px" onclick="promoteToKB(\'' + escHtml(item.name) + '\')">Add to Knowledge Base</button></div>' +
     '<div style="font-size:12px;line-height:1.7;color:var(--muted)">' + renderMd(item.content) + '</div>';
   _modalDocContext = { title: item.name, content: item.content, selection: '' };
   _modalFilePath = 'notes/inbox/' + item.name; showModalQa();

package/dashboard/js/utils.js

@@ -35,6 +35,27 @@ function _togglePinAndRefresh(key, source) {
   else if (source === 'kb') renderKnowledgeBase();
 }
 
+function updateModalPinBtn() {
+  var btn = document.getElementById('modal-pin-btn');
+  if (!btn) return;
+  // Only show for inbox and KB docs (pinnable paths)
+  if (!_modalFilePath || (!_modalFilePath.startsWith('notes/inbox/') && !_modalFilePath.startsWith('knowledge/'))) {
+    btn.style.display = 'none'; return;
+  }
+  btn.style.display = '';
+  var pinned = isPinned(_modalFilePath);
+  btn.textContent = pinned ? 'Unpin' : 'Pin';
+  btn.classList.toggle('pinned', pinned);
+}
+function toggleModalPin() {
+  if (!_modalFilePath) return;
+  var pinned = togglePin(_modalFilePath);
+  showToast('cmd-toast', pinned ? 'Pinned to top' : 'Unpinned', true);
+  updateModalPinBtn();
+  if (_modalFilePath.startsWith('notes/inbox/')) renderInbox(inboxData);
+  else if (_modalFilePath.startsWith('knowledge/')) renderKnowledgeBase();
+}
+
 function escHtml(s) {
   return String(s).replace(/&/g,'&amp;').replace(/</g,'&lt;').replace(/>/g,'&gt;').replace(/"/g,'&quot;').replace(/'/g,'&#39;');
 }

package/dashboard/layout.html

@@ -101,6 +101,7 @@
         <button class="modal-copy" id="modal-edit-btn" onclick="modalToggleEdit()" title="Edit" style="display:none"><svg width="12" height="12" viewBox="0 0 16 16" fill="currentColor"><path d="M11.013 1.427a1.75 1.75 0 012.474 0l1.086 1.086a1.75 1.75 0 010 2.474l-8.61 8.61c-.21.21-.47.364-.756.445l-3.251.93a.75.75 0 01-.927-.928l.929-3.25c.081-.286.235-.547.445-.758l8.61-8.61zM12.9 2.97L4.288 11.58l-.537 1.878 1.878-.537L14.242 4.31 12.9 2.97z"/></svg> Edit</button>
         <button class="modal-copy" id="modal-save-btn" onclick="modalSaveEdit()" title="Save" style="display:none;color:var(--green);border-color:var(--green)"><svg width="12" height="12" viewBox="0 0 16 16" fill="currentColor"><path d="M13.78 4.22a.75.75 0 010 1.06l-7.25 7.25a.75.75 0 01-1.06 0L2.22 9.28a.75.75 0 011.06-1.06L6 10.94l6.72-6.72a.75.75 0 011.06 0z"/></svg> Save</button>
         <button class="modal-copy" id="modal-cancel-edit-btn" onclick="modalCancelEdit()" title="Cancel edit" style="display:none">Cancel</button>
+        <button class="modal-copy pin-btn" id="modal-pin-btn" onclick="toggleModalPin()" title="Pin to top" style="display:none">Pin</button>
         <button class="modal-copy" id="modal-copy-btn" onclick="copyModalContent()" title="Copy to clipboard"><svg width="12" height="12" viewBox="0 0 16 16" fill="currentColor"><path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 010 1.5h-1.5a.25.25 0 00-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 00.25-.25v-1.5a.75.75 0 011.5 0v1.5A1.75 1.75 0 019.25 16h-7.5A1.75 1.75 0 010 14.25z"/><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0114.25 11h-7.5A1.75 1.75 0 015 9.25zm1.75-.25a.25.25 0 00-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 00.25-.25v-7.5a.25.25 0 00-.25-.25z"/></svg> Copy</button>
         <button class="modal-close" onclick="closeModal()">X</button>
       </div>

package/engine/routing.js

@@ -121,16 +121,26 @@ function resolveAgent(workType, config, authorAgent = null) {
     return true;
   };
 
-  // Check preferred and fallback first (routing table order)
-  if (preferred && isAvailable(preferred)) { _claimedAgents.add(preferred); return preferred; }
-  if (fallback && isAvailable(fallback)) { _claimedAgents.add(fallback); return fallback; }
+  // Helper: pick any idle agent sorted by error rate
+  const pickAnyIdle = (exclude = []) => {
+    const excludeSet = new Set(exclude.filter(Boolean));
+    const idle = Object.keys(agents)
+      .filter(id => !excludeSet.has(id) && isAvailable(id))
+      .sort((a, b) => getAgentErrorRate(a) - getAgentErrorRate(b));
+    if (idle[0]) { _claimedAgents.add(idle[0]); return idle[0]; }
+    return null;
+  };
 
-  // Fall back to any idle agent, preferring lower error rates
-  const idle = Object.keys(agents)
-    .filter(id => id !== preferred && id !== fallback && isAvailable(id))
-    .sort((a, b) => getAgentErrorRate(a) - getAgentErrorRate(b));
+  // Resolve _any_ token — pick any available agent (#480)
+  if (preferred === '_any_') { const pick = pickAnyIdle(); if (pick) return pick; }
+  else if (preferred && isAvailable(preferred)) { _claimedAgents.add(preferred); return preferred; }
 
-  if (idle[0]) { _claimedAgents.add(idle[0]); return idle[0]; }
+  if (fallback === '_any_') { const pick = pickAnyIdle([preferred]); if (pick) return pick; }
+  else if (fallback && isAvailable(fallback)) { _claimedAgents.add(fallback); return fallback; }
+
+  // Fall back to any idle agent, preferring lower error rates
+  const anyIdle = pickAnyIdle([preferred, fallback]);
+  if (anyIdle) return anyIdle;
 
   // No idle configured agent — try temp agent if enabled
   if (config.engine?.allowTempAgents) {

package/engine.js

@@ -1556,7 +1556,7 @@ function discoverFromWorkItems(config, project) {
   const items = safeJson(projectWorkItemsPath(project)) || [];
   const cooldownMs = (src.cooldownMinutes || 0) * 60 * 1000;
   const newWork = [];
-  const prdSyncQueue = [];
+  // PRD sync for dispatched status deferred to spawnAgent success (#480)
   const skipped = { gated: 0, noAgent: 0 };
   let needsWrite = false;
   const selfHealKeys = new Set(); // Collect keys for batched self-heal (1 lock instead of N)
@@ -1603,10 +1603,11 @@ function discoverFromWorkItems(config, project) {
       needsWrite = true;
     }
     if (isAlreadyDispatched(key)) {
-      if (item.status === WI_STATUS.PENDING) { item.status = WI_STATUS.DISPATCHED; needsWrite = true; }
-      if (!item.dispatched_to) {
-        const existing = getDispatch().active?.find(d => d.meta?.dispatchKey === key);
-        if (existing?.agent) { item.dispatched_to = existing.agent; needsWrite = true; }
+      // Only self-heal to DISPATCHED if actually in dispatch.active (agent spawned) (#480)
+      const existingActive = getDispatch().active?.find(d => d.meta?.dispatchKey === key);
+      if (existingActive) {
+        if (item.status === WI_STATUS.PENDING) { item.status = WI_STATUS.DISPATCHED; needsWrite = true; }
+        if (!item.dispatched_to && existingActive.agent) { item.dispatched_to = existingActive.agent; needsWrite = true; }
       }
       if (item._pendingReason !== 'already_dispatched') { item._pendingReason = 'already_dispatched'; needsWrite = true; }
       skipped.gated++; continue;
@@ -1691,12 +1692,11 @@ function discoverFromWorkItems(config, project) {
       continue;
     }
 
-    // Mark item as dispatched BEFORE adding to newWork (prevents race on next tick)
-    item.status = WI_STATUS.DISPATCHED;
-    item.dispatched_at = ts();
-    item.dispatched_to = agentId;
+    // Don't mark dispatched here — item stays pending until spawnAgent succeeds.
+    // spawnAgent() atomically stamps dispatched_to/dispatched_at/status via locked write (#480).
+    // isAlreadyDispatched(key) prevents re-discovery on subsequent ticks.
     delete item._pendingReason;
-    prdSyncQueue.push({ id: item.id, sourcePlan: item.sourcePlan });
+    needsWrite = true;
 
     newWork.push({
       type: workType,
@@ -1738,12 +1738,9 @@ function discoverFromWorkItems(config, project) {
     }
   }
 
-  // Write back updated statuses (always, since we mark items dispatched before newWork check)
-  if (newWork.length > 0 || needsWrite) {
+  // Write back updated statuses (pendingReason clears, checkpoint counts, decompose flags, etc.)
+  if (needsWrite) {
     mutateWorkItems(projectWorkItemsPath(project), () => items);
-    if (newWork.length > 0) {
-      for (const s of prdSyncQueue) syncPrdItemStatus(s.id, 'dispatched', s.sourcePlan);
-    }
   }
 
   const skipTotal = skipped.gated + skipped.noAgent;
@@ -2030,13 +2027,14 @@ function discoverCentralWorkItems(config) {
     const key = `central-work-${item.id}`;
     // Self-heal: if already dispatched but work item is still pending, fix the status
     if (isAlreadyDispatched(key)) {
-      const m = {};
-      if (item.status === WI_STATUS.PENDING) { m.status = WI_STATUS.DISPATCHED; }
-      if (!item.dispatched_to) {
-        const existing = getDispatch().active?.find(d => d.meta?.dispatchKey === key);
-        if (existing?.agent) { m.dispatched_to = existing.agent; }
+      // Only self-heal to DISPATCHED if actually in dispatch.active (agent spawned) (#480)
+      const existingActive = getDispatch().active?.find(d => d.meta?.dispatchKey === key);
+      if (existingActive) {
+        const m = {};
+        if (item.status === WI_STATUS.PENDING) { m.status = WI_STATUS.DISPATCHED; }
+        if (!item.dispatched_to && existingActive.agent) { m.dispatched_to = existingActive.agent; }
+        if (Object.keys(m).length > 0) mutations.set(item.id, m);
       }
-      if (Object.keys(m).length > 0) mutations.set(item.id, m);
       continue;
     }
     if (isOnCooldown(key, 0)) continue;
@@ -2109,15 +2107,13 @@ function discoverCentralWorkItems(config) {
         });
       }
 
+      // Don't mark dispatched here — spawnAgent stamps status atomically (#480)
       mutations.set(item.id, {
-        status: WI_STATUS.DISPATCHED,
-        dispatched_at: ts(),
-        dispatched_to: idleAgents.map(a => a.id).join(', '),
         scope: 'fan-out',
         fanOutAgents: idleAgents.map(a => a.id),
       });
       setCooldown(key);
-      log('info', `Fan-out: ${item.id} dispatched to ${idleAgents.length} agents: ${idleAgents.map(a => a.name).join(', ')}`);
+      log('info', `Fan-out: ${item.id} queued for ${idleAgents.length} agents: ${idleAgents.map(a => a.name).join(', ')}`);
 
     } else {
       // ─── Normal: single agent dispatch ──────────────────────────────
@@ -2215,12 +2211,7 @@ function discoverCentralWorkItems(config) {
         continue;
       }
 
-      const dispatchMutation = {
-        status: WI_STATUS.DISPATCHED,
-        dispatched_at: ts(),
-        dispatched_to: agentId,
-      };
-      mutations.set(item.id, Object.assign(mutations.get(item.id) || {}, dispatchMutation));
+      // Don't mark dispatched here — spawnAgent stamps status atomically (#480)
 
       newWork.push({
         type: workType,
@@ -2675,6 +2666,11 @@ async function tickInner() {
         }
       } else {
         dispatched.add(item.id);
+        // Sync PRD item status after successful spawn (#480)
+        if (item.meta?.item?.sourcePlan) {
+          try { syncPrdItemStatus(item.meta.item.id, WI_STATUS.DISPATCHED, item.meta.item.sourcePlan); }
+          catch (e) { log('warn', `prd sync after spawn: ${e.message}`); }
+        }
       }
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.554",
+  "version": "0.1.556",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/routing.md

@@ -10,7 +10,7 @@ How the engine decides who handles what. Parsed by engine.js — keep the table
 | implement | dallas | ralph |
 | implement:large | rebecca | dallas |
 | review | ripley | lambert |
-| fix | _author_ | dallas |
+| fix | _author_ | _any_ |
 | plan | ripley | rebecca |
 | plan-to-prd | lambert | rebecca |
 | explore | ripley | rebecca |
@@ -22,6 +22,7 @@ How the engine decides who handles what. Parsed by engine.js — keep the table
 
 Notes:
 - `_author_` means route to the PR author
+- `_any_` means route to any available idle agent (lowest error rate first)
 - `implement:large` is for items with `estimated_complexity: "large"`
 - Engine falls back to any idle agent if both preferred and fallback are busy