@yemi33/minions 0.1.552 → 0.1.554

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.1.554 (2026-04-07)
+
+### Features
+-  add pin/unpin button to inbox and KB document modals
+
+### Fixes
+- fetch actual build error logs instead of just reason string (#489)
+
 ## 0.1.552 (2026-04-07)
 
 ### Features

package/dashboard/js/render-kb.js

@@ -216,9 +216,13 @@ async function kbOpenItem(category, file) {
   try {
     const content = await fetch('/api/knowledge/' + category + '/' + encodeURIComponent(file)).then(r => r.text());
     const display = content.replace(/^---[\s\S]*?---\n*/m, '');
+    var pk = kbPinKey(category, file);
+    var pinned = isPinned(pk);
     document.getElementById('modal-title').textContent = file;
     const modalBody = document.getElementById('modal-body');
-    modalBody.innerHTML = renderMd(display);
+    modalBody.innerHTML =
+      '<div style="margin-bottom:12px"><button class="pr-pager-btn pin-btn' + (pinned ? ' pinned' : '') + '" style="font-size:10px;padding:3px 10px" data-pin-key="' + escHtml(pk) + '" onclick="_togglePinAndRefresh(this.dataset.pinKey,\'kb\');kbOpenItem(\'' + escHtml(category) + '\',\'' + escHtml(file) + '\')">' + (pinned ? 'Unpin' : 'Pin to top') + '</button></div>' +
+      renderMd(display);
     _modalDocContext = { title: file, content: display, selection: '' };
     _modalFilePath = 'knowledge/' + category + '/' + file; showModalQa();
     // Clear notification badge when opening this document

package/dashboard/js/render-prs.js

@@ -91,9 +91,14 @@ function openAllPrs() {
 function openModal(i) {
   const item = inboxData[i];
   if (!item) return;
+  var pk = inboxPinKey(item.name);
+  var pinned = isPinned(pk);
   document.getElementById('modal-title').textContent = item.name;
   document.getElementById('modal-body').innerHTML =
-    '<div style="margin-bottom:12px"><button class="pr-pager-btn" style="font-size:10px;padding:3px 10px" onclick="promoteToKB(\'' + escHtml(item.name) + '\')">Add to Knowledge Base</button></div>' +
+    '<div style="margin-bottom:12px;display:flex;gap:8px;align-items:center">' +
+      '<button class="pr-pager-btn pin-btn' + (pinned ? ' pinned' : '') + '" style="font-size:10px;padding:3px 10px" data-pin-key="' + escHtml(pk) + '" onclick="_togglePinAndRefresh(this.dataset.pinKey,\'inbox\');openModal(' + i + ')">' + (pinned ? 'Unpin' : 'Pin to top') + '</button>' +
+      '<button class="pr-pager-btn" style="font-size:10px;padding:3px 10px" onclick="promoteToKB(\'' + escHtml(item.name) + '\')">Add to Knowledge Base</button>' +
+    '</div>' +
     '<div style="font-size:12px;line-height:1.7;color:var(--muted)">' + renderMd(item.content) + '</div>';
   _modalDocContext = { title: item.name, content: item.content, selection: '' };
   _modalFilePath = 'notes/inbox/' + item.name; showModalQa();

package/engine/ado.js

@@ -82,6 +82,73 @@ async function adoFetch(url, token, _retryCount = 0) {
   return JSON.parse(text);
 }
 
+/** Fetch raw text from ADO API (for build logs which aren't JSON). */
+async function adoFetchText(url, token) {
+  const res = await fetch(url, {
+    headers: { 'Authorization': `Bearer ${token}` }
+  });
+  if (!res.ok) throw new Error(`ADO API ${res.status}: ${res.statusText}`);
+  return res.text();
+}
+
+const BUILD_ERROR_LOG_MAX_LINES = 150;
+
+/**
+ * Fetch actual build/compiler error logs from ADO when a build fails.
+ * Extracts buildId from the failed status's targetUrl, queries the build timeline
+ * for failed tasks, and fetches their logs.
+ * Returns truncated log text or null if unavailable.
+ */
+async function fetchAdoBuildErrorLog(orgBase, project, failedStatus, token) {
+  try {
+    // Extract buildId from the targetUrl (e.g. .../_build/results?buildId=12345)
+    const targetUrl = failedStatus?.targetUrl || '';
+    const buildIdMatch = targetUrl.match(/buildId=(\d+)/);
+    if (!buildIdMatch) {
+      log('debug', `No buildId in targetUrl: ${targetUrl.slice(0, 120)}`);
+      return null;
+    }
+    const buildId = buildIdMatch[1];
+
+    // Fetch build timeline to find failed tasks
+    const timelineUrl = `${orgBase}/${project.adoProject}/_apis/build/builds/${buildId}/timeline?api-version=7.1`;
+    const timeline = await adoFetch(timelineUrl, token);
+    if (!timeline?.records) return null;
+
+    // Find failed records that have logs
+    const failedRecords = timeline.records.filter(r =>
+      r.result === 'failed' && r.log?.id
+    );
+    if (failedRecords.length === 0) return null;
+
+    // Fetch logs for failed tasks (cap at 3 to limit API calls)
+    const logParts = [];
+    for (const record of failedRecords.slice(0, 3)) {
+      try {
+        const logUrl = `${orgBase}/${project.adoProject}/_apis/build/builds/${buildId}/logs/${record.log.id}?api-version=7.1`;
+        const text = await adoFetchText(logUrl, token);
+        if (text) {
+          logParts.push(`--- ${record.name || 'Task'} ---\n${text}`);
+        }
+      } catch { /* skip individual log fetch failures */ }
+    }
+
+    if (logParts.length === 0) return null;
+
+    // Join and truncate to last N lines
+    const combined = logParts.join('\n\n');
+    const lines = combined.split('\n');
+    if (lines.length > BUILD_ERROR_LOG_MAX_LINES) {
+      return `... (truncated, showing last ${BUILD_ERROR_LOG_MAX_LINES} lines)\n` +
+        lines.slice(-BUILD_ERROR_LOG_MAX_LINES).join('\n');
+    }
+    return combined;
+  } catch (e) {
+    log('warn', `Failed to fetch ADO build error log: ${e.message}`);
+    return null;
+  }
+}
+
 // ─── Shared PR Polling Loop ──────────────────────────────────────────────────
 
 /**
@@ -185,6 +252,7 @@ async function pollPrStatus(config) {
         if (pr.buildStatus && pr.buildStatus !== 'none') {
           delete pr.buildStatus;
           delete pr.buildFailReason;
+          delete pr.buildErrorLog;
           delete pr._buildFailNotified;
         }
         await engine().handlePostMerge(pr, project, config, newStatus);
@@ -294,8 +362,21 @@ async function pollPrStatus(config) {
       pr.buildStatus = buildStatus;
       if (buildFailReason) pr.buildFailReason = buildFailReason;
       else delete pr.buildFailReason;
-      if (buildStatus !== 'failing') delete pr._buildFailNotified;
+      if (buildStatus !== 'failing') {
+        delete pr._buildFailNotified;
+        delete pr.buildErrorLog;
+      }
       updated = true;
+
+      // Fetch actual compiler/build error logs when transitioning to failing
+      if (buildStatus === 'failing') {
+        const failedStatusObj = buildStatuses.find(s => s.state === 'failed' || s.state === 'error');
+        const errorLog = await fetchAdoBuildErrorLog(orgBase, project, failedStatusObj, token);
+        if (errorLog) {
+          pr.buildErrorLog = errorLog;
+          log('info', `PR ${pr.id}: fetched ${errorLog.split('\n').length} lines of build error log`);
+        }
+      }
     }
 
     return updated;

package/engine/github.js

@@ -94,6 +94,61 @@ async function ghApiWithBackoff(endpoint, slug) {
   return result;
 }
 
+const BUILD_ERROR_LOG_MAX_LINES = 150;
+
+/**
+ * Fetch actual build/compiler error logs from GitHub when a check run fails.
+ * Tries annotations first (structured error messages), then falls back to the
+ * Actions job log. Returns truncated log text or null if unavailable.
+ */
+async function fetchGhBuildErrorLog(slug, failedRuns) {
+  try {
+    const logParts = [];
+
+    for (const run of (failedRuns || []).slice(0, 3)) {
+      if (!run?.id) continue;
+
+      // Try annotations first — these contain structured compiler/lint errors
+      try {
+        const annotations = await ghApi(`/check-runs/${run.id}/annotations`, slug);
+        if (Array.isArray(annotations) && annotations.length > 0) {
+          const formatted = annotations
+            .filter(a => a.annotation_level === 'failure' || a.annotation_level === 'warning')
+            .map(a => `${a.path || ''}:${a.start_line || ''} [${a.annotation_level}] ${a.message || ''}`)
+            .join('\n');
+          if (formatted) {
+            logParts.push(`--- ${run.name || 'Check'} (annotations) ---\n${formatted}`);
+            continue; // annotations are sufficient for this run
+          }
+        }
+      } catch { /* fall through to job log */ }
+
+      // Fallback: fetch the full Actions job log
+      try {
+        const cmd = `gh api "repos/${slug}/actions/jobs/${run.id}/logs" 2>&1`;
+        const result = await execAsync(cmd, { timeout: 15000, encoding: 'utf-8' });
+        if (result && !result.includes('Not Found')) {
+          logParts.push(`--- ${run.name || 'Check'} ---\n${result}`);
+        }
+      } catch { /* skip individual log fetch failures */ }
+    }
+
+    if (logParts.length === 0) return null;
+
+    // Join and truncate to last N lines
+    const combined = logParts.join('\n\n');
+    const lines = combined.split('\n');
+    if (lines.length > BUILD_ERROR_LOG_MAX_LINES) {
+      return `... (truncated, showing last ${BUILD_ERROR_LOG_MAX_LINES} lines)\n` +
+        lines.slice(-BUILD_ERROR_LOG_MAX_LINES).join('\n');
+    }
+    return combined;
+  } catch (e) {
+    log('warn', `Failed to fetch GitHub build error log: ${e.message}`);
+    return null;
+  }
+}
+
 // ─── Shared PR Polling Loop ─────────────────────────────────────────────────
 
 async function forEachActiveGhPr(config, callback) {
@@ -237,6 +292,7 @@ async function pollPrStatus(config) {
         if (pr.buildStatus && pr.buildStatus !== 'none') {
           delete pr.buildStatus;
           delete pr.buildFailReason;
+          delete pr.buildErrorLog;
           delete pr._buildFailNotified;
         }
         await engine().handlePostMerge(pr, project, config, newStatus);
@@ -334,8 +390,21 @@ async function pollPrStatus(config) {
           pr.buildStatus = buildStatus;
           if (buildFailReason) pr.buildFailReason = buildFailReason;
           else delete pr.buildFailReason;
-          if (buildStatus !== 'failing') delete pr._buildFailNotified;
+          if (buildStatus !== 'failing') {
+            delete pr._buildFailNotified;
+            delete pr.buildErrorLog;
+          }
           updated = true;
+
+          // Fetch actual compiler/build error logs when transitioning to failing
+          if (buildStatus === 'failing') {
+            const failedRuns = runs.filter(r => r.conclusion === 'failure' || r.conclusion === 'timed_out');
+            const errorLog = await fetchGhBuildErrorLog(slug, failedRuns);
+            if (errorLog) {
+              pr.buildErrorLog = errorLog;
+              log('info', `PR ${pr.id}: fetched ${errorLog.split('\n').length} lines of build error log`);
+            }
+          }
         }
       }
     }

package/engine.js

@@ -1503,20 +1503,29 @@ async function discoverFromPrs(config, project) {
       const agentId = resolveAgent('fix', config, pr.agent);
       if (!agentId) continue;
 
+      let reviewNote = `Build is failing: ${pr.buildFailReason || 'Check CI pipeline for details'}. Fix the build errors and push.`;
+      if (pr.buildErrorLog) {
+        reviewNote += `\n\n## Build Error Log\n\n\`\`\`\n${pr.buildErrorLog}\n\`\`\``;
+      }
+
       const item = buildPrDispatch(agentId, config, project, pr, 'fix', {
         pr_id: pr.id, pr_branch: pr.branch || '',
-        review_note: `Build is failing: ${pr.buildFailReason || 'Check CI pipeline for details'}. Fix the build errors and push.`,
+        review_note: reviewNote,
       }, `Fix build failure on PR ${pr.id}`, { dispatchKey: key, source: 'pr', pr, branch: pr.branch, project: projMeta });
       if (item) { newWork.push(item); setCooldown(key); }
 
       // Notify the author agent about the build failure
       if (pr.agent && !pr._buildFailNotified) {
-        writeInboxAlert(`build-fail-${pr.agent}-${pr.id}`,
-          `# Build Failure Notification\n\n` +
+        let alertBody = `# Build Failure Notification\n\n` +
           `**Your PR ${pr.id}** on branch \`${pr.branch || 'unknown'}\` has a failing build.\n` +
-          `**Reason:** ${pr.buildFailReason || 'Check CI pipeline for details'}\n\n` +
-          `A fix agent has been dispatched to address this. Review the fix when complete.\n`
-        );
+          `**Reason:** ${pr.buildFailReason || 'Check CI pipeline for details'}\n\n`;
+        if (pr.buildErrorLog) {
+          // Include first 30 lines of error log in notification (full log in fix agent prompt)
+          const logPreview = pr.buildErrorLog.split('\n').slice(0, 30).join('\n');
+          alertBody += `**Error preview:**\n\`\`\`\n${logPreview}\n\`\`\`\n\n`;
+        }
+        alertBody += `A fix agent has been dispatched to address this. Review the fix when complete.\n`;
+        writeInboxAlert(`build-fail-${pr.agent}-${pr.id}`, alertBody);
         // Mark notified to prevent duplicate alerts
         try {
           const prPath = projectPrPath(project);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.552",
+  "version": "0.1.554",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"