@yemi33/minions 0.1.550 → 0.1.551

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.1.551 (2026-04-07)
+
+### Fixes
+- mark stale build status on ADO auth failure, bypass 6-tick cadence for recovery (#483)
+
 ## 0.1.550 (2026-04-07)
 
 ### Fixes

package/dashboard/js/render-prs.js

@@ -12,8 +12,8 @@ function prRow(pr) {
   const reviewSource = sq.status || effectiveReviewStatus || 'pending';
   const reviewClass = reviewSource === 'approved' ? 'approved' : (reviewSource === 'changes-requested' || reviewSource === 'rejected') ? 'rejected' : reviewSource === 'waiting' ? 'building' : 'draft';
   const reviewLabel = sq.status === 'waiting' ? 'reviewing (minions)' : sq.status ? sq.status + ' (minions)' : (effectiveReviewStatus || 'pending');
-  const buildClass = pr.buildStatus === 'passing' ? 'build-pass' : pr.buildStatus === 'failing' ? 'build-fail' : pr.buildStatus === 'running' ? 'building' : 'no-build';
-  const buildLabel = pr.buildStatus || 'none';
+  const buildClass = pr._buildStatusStale ? 'build-stale' : pr.buildStatus === 'passing' ? 'build-pass' : pr.buildStatus === 'failing' ? 'build-fail' : pr.buildStatus === 'running' ? 'building' : 'no-build';
+  const buildLabel = (pr.buildStatus || 'none') + (pr._buildStatusStale ? ' (stale)' : '');
   const statusClass = pr.status === 'merged' ? 'merged' : pr.status === 'abandoned' ? 'rejected' : pr.status === 'active' ? 'active' : 'draft';
   const statusLabel = pr.status || 'active';
   const url = pr.url || '#';

package/dashboard/styles.css

@@ -251,6 +251,7 @@
   .pr-badge.build-pass { background: rgba(63,185,80,0.15); color: var(--green); border: 1px solid var(--green); }
   .pr-badge.build-fail { background: rgba(248,81,73,0.15); color: var(--red); border: 1px solid var(--red); }
   .pr-badge.no-build { background: var(--surface); color: var(--muted); border: 1px solid var(--border); }
+  .pr-badge.build-stale { background: rgba(210,153,34,0.15); color: var(--orange); border: 1px dashed var(--orange); }
   .error-details-btn { font-size: var(--text-xs); padding: var(--space-1) var(--space-3); margin-left: var(--space-2); background: rgba(248,81,73,0.15); color: var(--red); border: 1px solid var(--red); border-radius: var(--radius-lg); cursor: pointer; font-weight: 600; text-transform: uppercase; letter-spacing: 0.3px; }
   .error-details-btn:hover { background: rgba(248,81,73,0.3); }
   .pr-empty { color: var(--muted); font-style: italic; font-size: var(--text-md); padding: var(--space-6) 0; }

package/engine/ado.js

@@ -21,6 +21,20 @@ function engine() {
 let _adoTokenCache = { token: null, expiresAt: 0 };
 let _adoTokenFailedUntil = 0; // backoff: skip azureauth calls until this timestamp
 
+// ─── Auth Failure Tracking ──────────────────────────────────────────────────
+// Set when pollPrStatus encounters auth errors mid-loop. The engine checks this
+// to bypass the normal 6-tick cadence and re-poll on the next tick.
+let _adoPollHadAuthFailure = false;
+
+/** Check if auth failure during PR poll means an early re-poll is needed. */
+function needsAdoPollRetry() { return _adoPollHadAuthFailure; }
+
+/** Detect auth-related errors from adoFetch (HTML redirect, 401, 403). */
+function isAdoAuthError(err) {
+  const msg = err?.message || '';
+  return msg.includes('auth redirect') || msg.includes('HTML instead of JSON') || /ADO API (401|403)/.test(msg);
+}
+
 async function getAdoToken() {
   if (_adoTokenCache.token && Date.now() < _adoTokenCache.expiresAt) {
     return _adoTokenCache.token;
@@ -133,16 +147,23 @@ async function forEachActivePr(config, token, callback) {
 // ─── PR Status Polling ───────────────────────────────────────────────────────
 
 async function pollPrStatus(config) {
+  _adoPollHadAuthFailure = false; // reset before polling — set again if errors recur
+
   const token = await getAdoToken();
   if (!token) {
     log('warn', 'Skipping PR status poll — no ADO token available');
+    _adoPollHadAuthFailure = true; // trigger retry on next tick
     return;
   }
 
   const totalUpdated = await forEachActivePr(config, token, async (project, pr, prNum, orgBase) => {
+    try {
     const repoBase = `${orgBase}/${project.adoProject}/_apis/git/repositories/${project.repositoryId}/pullrequests/${prNum}`;
     let updated = false;
 
+    // Clear stale flag — we're attempting a fresh poll
+    if (pr._buildStatusStale) { delete pr._buildStatusStale; updated = true; }
+
     const prData = await adoFetch(`${repoBase}?api-version=7.1`, token);
 
     let newStatus = pr.status;
@@ -278,6 +299,17 @@ async function pollPrStatus(config) {
     }
 
     return updated;
+    } catch (err) {
+      // Auth errors → mark build status stale so dashboard shows uncertainty
+      // and engine re-polls on next tick instead of waiting 6 ticks
+      if (isAdoAuthError(err)) {
+        pr._buildStatusStale = true;
+        _adoPollHadAuthFailure = true;
+        log('warn', `PR ${pr.id}: build status marked stale (auth error: ${err.message})`);
+        return true; // count as updated to persist the stale flag
+      }
+      throw err; // re-throw non-auth errors for forEachActivePr to handle
+    }
   });
 
   if (totalUpdated > 0) {
@@ -520,5 +552,7 @@ module.exports = {
   pollPrHumanComments,
   reconcilePrs,
   checkLiveReviewStatus,
+  needsAdoPollRetry,
+  isAdoAuthError, // exported for testing
 };
 

package/engine.js

@@ -937,7 +937,7 @@ function reconcileItemsWithPrs(items, allPrs, { onlyIds } = {}) {
 // ─── Inbox Consolidation (extracted to engine/consolidation.js) ──────────────
 
 const { consolidateInbox } = require('./engine/consolidation');
-const { pollPrStatus, pollPrHumanComments, reconcilePrs, checkLiveReviewStatus: adoCheckLiveReview } = require('./engine/ado');
+const { pollPrStatus, pollPrHumanComments, reconcilePrs, checkLiveReviewStatus: adoCheckLiveReview, needsAdoPollRetry } = require('./engine/ado');
 const { pollPrStatus: ghPollPrStatus, pollPrHumanComments: ghPollPrHumanComments, reconcilePrs: ghReconcilePrs, checkLiveReviewStatus: ghCheckLiveReview } = require('./engine/github');
 
 // ─── State Snapshot ─────────────────────────────────────────────────────────
@@ -2447,7 +2447,8 @@ async function tickInner() {
 
   // 2.6. Poll PR status: build, review, merge (every 6 ticks = ~3 minutes)
   // Awaited so PR state is consistent before discoverWork reads it
-  if (tickCount % 6 === 0) {
+  // Also re-polls early if previous tick had ADO auth failures (stale build status recovery)
+  if (tickCount % 6 === 0 || needsAdoPollRetry()) {
     try { await pollPrStatus(config); } catch (err) { log('warn', `ADO PR status poll error: ${err?.message || err}${err?.stack ? ' | ' + err.stack.split('\n')[1]?.trim() : ''}`); }
     try { await ghPollPrStatus(config); } catch (err) { log('warn', `GitHub PR status poll error: ${err?.message || err}${err?.stack ? ' | ' + err.stack.split('\n')[1]?.trim() : ''}`); }
     // Sync PR status back to PRD items (missing → done when active PR exists)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.550",
+  "version": "0.1.551",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"