@yemi33/minions 0.1.545 → 0.1.547

package/CHANGELOG.md

@@ -1,12 +1,18 @@
 # Changelog
 
-## 0.1.545 (2026-04-07)
+## 0.1.547 (2026-04-07)
+
+### Fixes
+- remap sequential PRD item IDs to prevent cross-PRD collisions (#474)
+
+## 0.1.546 (2026-04-07)
 
 ### Features
 - add DEFAULT_AGENT_METRICS constant to shared.js (#464)
 - remove inline require('fs') calls from engine/shared.js (#463)
 
 ### Fixes
+-  make restart reliably kill orphan processes on all OS
 -  make discoverFromPrs/discoverWork async to match await usage
 -  await checkLiveReviewStatus in pre-dispatch vote check (closes #462) (#469)
 

package/bin/minions.js

@@ -39,7 +39,7 @@ function killByPort(port) {
         const pid = line.trim().split(/\s+/).pop();
         if (pid && /^\d+$/.test(pid) && pid !== '0' && pid !== String(process.pid)) pids.add(pid);
       }
-      for (const pid of pids) try { process.kill(parseInt(pid)); } catch {}
+      for (const pid of pids) try { execSync(`taskkill /F /PID ${pid}`, { stdio: 'ignore', timeout: 5000, windowsHide: true }); } catch {}
     } else {
       execSync(`lsof -ti:${port} | xargs kill -9 2>/dev/null`, { timeout: 5000 });
     }
@@ -54,7 +54,7 @@ function killMinionsProcesses(patterns) {
       for (const line of out.split('\n')) {
         if (patterns.some(p => line.includes(p))) {
           const pid = line.split(',').pop()?.trim();
-          if (pid && /^\d+$/.test(pid) && pid !== String(process.pid)) try { process.kill(parseInt(pid)); } catch {}
+          if (pid && /^\d+$/.test(pid) && pid !== String(process.pid)) try { execSync(`taskkill /F /PID ${pid}`, { stdio: 'ignore', timeout: 5000, windowsHide: true }); } catch {}
         }
       }
     } else {
@@ -529,10 +529,11 @@ if (!cmd || cmd === 'help' || cmd === '--help' || cmd === '-h') {
 } else if (cmd === 'restart') {
   // Start both engine and dashboard — the go-to command after a reboot
   ensureInstalled();
-  // Stop engine if running
+  // Stop engine if running (graceful attempt)
   try { execSync(`node "${path.join(MINIONS_HOME, 'engine.js')}" stop`, { stdio: 'ignore', cwd: MINIONS_HOME }); } catch {}
-  // Kill existing dashboard — port-based is reliable across all setups
+  // Kill all existing engine/dashboard processes — handles crashed engines and orphan dashboards
   killByPort(7331);
+  killMinionsProcesses(['engine.js', 'dashboard.js']);
   const engineProc = spawn(process.execPath, [path.join(MINIONS_HOME, 'engine.js'), 'start'], {
     cwd: MINIONS_HOME, stdio: 'ignore', detached: true, windowsHide: true
   });

package/engine.js

@@ -1077,10 +1077,39 @@ function materializePlansAsWorkItems(config) {
   let planFiles;
   try { planFiles = fs.readdirSync(PRD_DIR).filter(f => f.endsWith('.json')); } catch { return; }
 
+  // Regex for detecting sequential PRD item IDs (P-001, P-002) — hoisted outside loop
+  const SEQUENTIAL_ID_RE = /^P-?\d+$/;
+
   for (const file of planFiles) {
     const plan = safeJson(path.join(PRD_DIR, file));
     if (!plan?.missing_features) continue;
 
+    // ID collision prevention: remap sequential IDs (P-001, P-002) to globally unique P-<uid> IDs.
+    // Agents are instructed to use P-<uuid> format but sometimes generate sequential IDs,
+    // which collide across PRDs causing phantom done/dispatched status (see #466).
+    try {
+      if (plan.missing_features.some(f => SEQUENTIAL_ID_RE.test(f.id))) {
+        const allWorkItems = queries.getWorkItems(config);
+        const anyMaterialized = plan.missing_features.some(f =>
+          SEQUENTIAL_ID_RE.test(f.id) && allWorkItems.some(w => w.id === f.id && w.sourcePlan === file));
+        if (!anyMaterialized) {
+          const idMap = new Map();
+          for (const f of plan.missing_features) {
+            if (SEQUENTIAL_ID_RE.test(f.id)) {
+              const newId = 'P-' + shared.uid();
+              idMap.set(f.id, newId);
+              f.id = newId;
+            }
+          }
+          for (const f of plan.missing_features) {
+            if (f.depends_on) f.depends_on = f.depends_on.map(d => idMap.get(d) || d);
+          }
+          safeWrite(path.join(PRD_DIR, file), plan);
+          log('info', `Remapped ${idMap.size} sequential ID(s) in ${file} to prevent cross-PRD collisions`);
+        }
+      }
+    } catch (e) { log('warn', `Sequential ID remapping failed for ${file}: ${e.message}`); }
+
     // Plan staleness: if source_plan .md was modified since last sync, auto-clean and re-sync
     if (plan.source_plan) {
       const sourcePlanPath = path.join(PLANS_DIR, plan.source_plan);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.545",
+  "version": "0.1.547",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"