@yemi33/minions 0.1.543 → 0.1.545

package/CHANGELOG.md

@@ -1,8 +1,13 @@
 # Changelog
 
-## 0.1.543 (2026-04-07)
+## 0.1.545 (2026-04-07)
+
+### Features
+- add DEFAULT_AGENT_METRICS constant to shared.js (#464)
+- remove inline require('fs') calls from engine/shared.js (#463)
 
 ### Fixes
+-  make discoverFromPrs/discoverWork async to match await usage
 -  await checkLiveReviewStatus in pre-dispatch vote check (closes #462) (#469)
 
 ## 0.1.542 (2026-04-07)

package/engine/github.js

@@ -170,10 +170,11 @@ async function forEachActiveGhPr(config, callback) {
       const updated = await callback(null, pr, prNum, slug);
       if (updated) {
         // Also update title/author/branch if still placeholder
-        if (pr.title.includes('polling...') || pr.agent === 'human') {
+        if (pr.title.includes('polling...') || pr.agent === 'human' || pr.description === undefined) {
           const prData = await ghApi(`/pulls/${prNum}`, slug);
           if (prData) {
             if (pr.title.includes('polling...')) pr.title = (prData.title || pr.title).slice(0, 120);
+            if (pr.description === undefined) pr.description = (prData.body || '').slice(0, 500);
             if (pr.agent === 'human' && prData.user?.login) pr.agent = prData.user.login;
             if (!pr.branch && prData.head?.ref) pr.branch = prData.head.ref;
           }

package/engine/lifecycle.js

@@ -9,7 +9,7 @@ const os = require('os');
 const shared = require('./shared');
 const { safeRead, safeJson, safeWrite, mutateJsonFileLocked, mutateWorkItems, execSilent, projectPrPath, getPrLinks, addPrLink,
   log, ts, dateStamp, WI_STATUS, DONE_STATUSES, WORK_TYPE, PLAN_STATUS, PR_STATUS, DISPATCH_RESULT,
-  ENGINE_DEFAULTS } = shared;
+  ENGINE_DEFAULTS, DEFAULT_AGENT_METRICS } = shared;
 const { trackEngineUsage } = require('./llm');
 const queries = require('./queries');
 const { getConfig, getInboxFiles, getNotes, getPrs, getDispatch,
@@ -734,8 +734,8 @@ async function updatePrAfterReview(agentId, pr, project, config) {
   const authorAgentId = (pr.agent || '').toLowerCase();
   if (authorAgentId && config.agents?.[authorAgentId]) {
     shared.mutateJsonFileLocked(path.join(ENGINE_DIR, 'metrics.json'), (metrics) => {
-      if (!metrics[authorAgentId]) metrics[authorAgentId] = { tasksCompleted:0, tasksErrored:0, prsCreated:0, prsApproved:0, prsRejected:0, reviewsDone:0, lastTask:null, lastCompleted:null };
-      if (!metrics[agentId]) metrics[agentId] = { tasksCompleted:0, tasksErrored:0, prsCreated:0, prsApproved:0, prsRejected:0, reviewsDone:0, lastTask:null, lastCompleted:null };
+      if (!metrics[authorAgentId]) metrics[authorAgentId] = { ...DEFAULT_AGENT_METRICS };
+      if (!metrics[agentId]) metrics[agentId] = { ...DEFAULT_AGENT_METRICS };
       metrics[agentId].reviewsDone = (metrics[agentId].reviewsDone || 0) + 1;
       return metrics;
     }, { defaultValue: {} });
@@ -847,7 +847,7 @@ async function handlePostMerge(pr, project, config, newStatus) {
   if (agentId && config.agents?.[agentId]) {
     const metricsPath = path.join(ENGINE_DIR, 'metrics.json');
     mutateJsonFileLocked(metricsPath, (metrics) => {
-      if (!metrics[agentId]) metrics[agentId] = { tasksCompleted:0, tasksErrored:0, prsCreated:0, prsApproved:0, prsRejected:0, prsMerged:0, reviewsDone:0, lastTask:null, lastCompleted:null };
+      if (!metrics[agentId]) metrics[agentId] = { ...DEFAULT_AGENT_METRICS };
       metrics[agentId].prsMerged = (metrics[agentId].prsMerged || 0) + 1;
       return metrics;
     });
@@ -1010,8 +1010,7 @@ function updateMetrics(agentId, dispatchItem, result, taskUsage, prsCreatedCount
   mutateJsonFileLocked(metricsPath, metrics => {
     metrics = metrics || {};
     if (!metrics[agentId]) {
-      metrics[agentId] = { tasksCompleted: 0, tasksErrored: 0, prsCreated: 0, prsApproved: 0, prsRejected: 0,
-        reviewsDone: 0, lastTask: null, lastCompleted: null, totalCostUsd: 0, totalInputTokens: 0, totalOutputTokens: 0, totalCacheRead: 0 };
+      metrics[agentId] = { ...DEFAULT_AGENT_METRICS };
     }
     const m = metrics[agentId];
     m.lastTask = dispatchItem.task;

package/engine/shared.js

@@ -562,6 +562,14 @@ const MEETING_STATUS = {
   COMPLETED: 'completed', ARCHIVED: 'archived',
 };
 
+const DEFAULT_AGENT_METRICS = {
+  tasksCompleted: 0, tasksErrored: 0,
+  prsCreated: 0, prsApproved: 0, prsRejected: 0, prsMerged: 0,
+  reviewsDone: 0,
+  lastTask: null, lastCompleted: null,
+  totalCostUsd: 0, totalInputTokens: 0, totalOutputTokens: 0, totalCacheRead: 0,
+};
+
 const DEFAULT_AGENTS = {
   ripley:  { name: 'Ripley',  emoji: '\u{1F3D7}\uFE0F',  role: 'Lead / Explorer', skills: ['architecture', 'codebase-exploration', 'design-review'] },
   dallas:  { name: 'Dallas',  emoji: '\u{1F527}',  role: 'Engineer', skills: ['implementation', 'typescript', 'docker', 'testing'] },
@@ -600,7 +608,7 @@ function projectRoot(project) {
 function projectStateDir(project) {
   const name = project.name || path.basename(project.localPath);
   const dir = path.join(MINIONS_DIR, 'projects', name);
-  if (!require('fs').existsSync(dir)) require('fs').mkdirSync(dir, { recursive: true });
+  if (!fs.existsSync(dir)) fs.mkdirSync(dir, { recursive: true });
   return dir;
 }
 
@@ -705,7 +713,6 @@ function getPrLinks() {
   // Primary source: derive from all projects/*/pull-requests.json prdItems
   const projectsDir = path.join(MINIONS_DIR, 'projects');
   try {
-    const fs = require('fs');
     for (const d of fs.readdirSync(projectsDir, { withFileTypes: true })) {
       if (!d.isDirectory()) continue;
       try {
@@ -721,7 +728,7 @@ function getPrLinks() {
   } catch { /* projects dir missing */ }
   // Fallback: static pr-links.json for entries not covered above
   try {
-    const static_ = JSON.parse(require('fs').readFileSync(PR_LINKS_PATH, 'utf8'));
+    const static_ = JSON.parse(fs.readFileSync(PR_LINKS_PATH, 'utf8'));
     for (const [k, v] of Object.entries(static_)) {
       if (!links[k]) links[k] = v;
     }
@@ -825,6 +832,7 @@ module.exports = {
   ENGINE_DEFAULTS,
   WI_STATUS, DONE_STATUSES, WORK_TYPE, PLAN_STATUS, PR_STATUS, DISPATCH_RESULT,
   PIPELINE_STATUS, STAGE_TYPE, MEETING_STATUS,
+  DEFAULT_AGENT_METRICS,
   DEFAULT_AGENTS,
   DEFAULT_CLAUDE,
   getProjects,

package/engine.js

@@ -1350,7 +1350,7 @@ function clearPendingHumanFeedbackFlag(projectMeta, prId) {
 /**
  * Scan pull-requests.json for PRs needing review or fixes
  */
-function discoverFromPrs(config, project) {
+async function discoverFromPrs(config, project) {
   const src = project?.workSources?.pullRequests || config.workSources?.pullRequests;
   if (!src?.enabled) return [];
 
@@ -2226,7 +2226,7 @@ function discoverCentralWorkItems(config) {
  * Run all work discovery sources and queue new items
  * Priority: fix (0) > ask (1) > review (1) > implement (2) > work-items (3) > central (4)
  */
-function discoverWork(config) {
+async function discoverWork(config) {
   resetClaimedAgents(); // Reset per-tick agent claims for fair distribution
   const projects = getProjects(config);
   let allFixes = [], allReviews = [], allWorkItems = [];
@@ -2240,7 +2240,7 @@ function discoverWork(config) {
     if (!root || !fs.existsSync(root)) continue;
 
     // Source 1: Pull Requests → fixes, reviews, build-test
-    const prWork = discoverFromPrs(config, project);
+    const prWork = await discoverFromPrs(config, project);
     allFixes.push(...prWork.filter(w => w.type === WORK_TYPE.FIX));
     allReviews.push(...prWork.filter(w => w.type === WORK_TYPE.REVIEW));
     allWorkItems.push(...prWork.filter(w => w.type === WORK_TYPE.TEST));
@@ -2550,7 +2550,7 @@ async function tickInner() {
 
   // 3. Discover new work from sources
   let discoveryOk = true;
-  try { discoverWork(config); } catch (e) { log('warn', 'discoverWork: ' + e.message); discoveryOk = false; }
+  try { await discoverWork(config); } catch (e) { log('warn', 'discoverWork: ' + e.message); discoveryOk = false; }
 
   // 4. Update snapshot
   safe('updateSnapshot', () => updateSnapshot(config));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.543",
+  "version": "0.1.545",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"