@yemi33/minions 0.1.526 → 0.1.527

package/CHANGELOG.md

@@ -1,9 +1,13 @@
 # Changelog
 
+## 0.1.527 (2026-04-07)
+
+### Features
+- Replace direct safeJson reads of work-items.json with getWorkItems() (#424)
+
 ## 0.1.526 (2026-04-07)
 
 ### Features
-- Replace new Date().toISOString() with ts() from shared.js (#411)
 - Add Concurrency & Lock Ordering section to CLAUDE.md (#409)
 -  9 test isolation verification tests — run last to detect pollution
 

package/dashboard/js/render-work-items.js

@@ -175,8 +175,8 @@ async function submitWorkItemEdit(id, source, e) {
   const refsRaw = document.getElementById('wi-edit-refs')?.value || '';
   const references = refsRaw.split('\n').filter(function(l) { return l.trim(); }).map(function(l) {
     var parts = l.split('|').map(function(s) { return s.trim(); });
-    return { url: parts[0], title: parts[1] || parts[0], type: parts[2] || 'link' };
-  });
+    return { url: parts[0] || '', title: parts[1] || parts[0] || '', type: parts[2] || 'link' };
+  }).filter(function(r) { return r.url; });
   const acRaw = document.getElementById('wi-edit-ac')?.value || '';
   const acceptanceCriteria = acRaw.split('\n').filter(function(l) { return l.trim(); });
   if (!title) { if (btn) { btn.disabled = false; btn.textContent = 'Save'; } alert('Title is required'); return; }
@@ -387,8 +387,8 @@ async function _submitCreateWorkItem(e) {
   const refsRaw = document.getElementById('wi-new-refs')?.value || '';
   const references = refsRaw.split('\n').filter(l => l.trim()).map(l => {
     const parts = l.split('|').map(s => s.trim());
-    return { url: parts[0], title: parts[1] || parts[0], type: parts[2] || 'link' };
-  });
+    return { url: parts[0] || '', title: parts[1] || parts[0] || '', type: parts[2] || 'link' };
+  }).filter(r => r.url);
 
   try {
     const body = { title, description: desc, type, priority };

package/dashboard.js

@@ -192,8 +192,8 @@ async function checkNpmVersion() {
     _npmVersionCache = { latest: version || null, checkedAt: new Date().toISOString() };
     _npmVersionCacheTs = now;
   } catch (e) {
-    console.error('[version-check] npm view failed:', e.message?.split('\n')[0]);
-    _npmVersionCache = _npmVersionCache || { latest: null, checkedAt: null, error: e.message?.split('\n')[0] || 'check failed' };
+    console.error('[version-check] npm view failed:', e.message?.split('\n')?.[0]);
+    _npmVersionCache = _npmVersionCache || { latest: null, checkedAt: null, error: e.message?.split('\n')?.[0] || 'check failed' };
   }
   return _npmVersionCache;
 }
@@ -3816,7 +3816,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       // Determine project
       reloadConfig();
       const projects = shared.getProjects(CONFIG);
-      const targetProject = projectName ? projects.find(p => p.name?.toLowerCase() === projectName.toLowerCase()) : projects[0];
+      const targetProject = projectName ? projects.find(p => p.name?.toLowerCase() === projectName.toLowerCase()) : (projects[0] || null);
       const prPath = targetProject ? shared.projectPrPath(targetProject) : path.join(MINIONS_DIR, 'pull-requests.json');
 
       // Extract PR number from URL

package/engine/cleanup.js

@@ -308,15 +308,9 @@ function runCleanup(config, verbose = false) {
     // Collect all work item IDs across all sources
     const allWiIds = new Set();
     try {
-      const central = safeJson(path.join(MINIONS_DIR, 'work-items.json')) || [];
-      central.forEach(w => allWiIds.add(w.id));
-    } catch (e) { log('warn', 'read central work items for orphan check: ' + e.message); }
-    for (const project of projects) {
-      try {
-        const projItems = safeJson(projectWorkItemsPath(project)) || [];
-        projItems.forEach(w => allWiIds.add(w.id));
-      } catch (e) { log('warn', 'read project work items for orphan check: ' + e.message); }
-    }
+      const allItems = queries.getWorkItems();
+      allItems.forEach(w => allWiIds.add(w.id));
+    } catch (e) { log('warn', 'read work items for orphan check: ' + e.message); }
 
     let changed = false;
     for (const queue of ['pending', 'active']) {

package/engine/dispatch.js

@@ -126,14 +126,8 @@ function completeDispatch(id, result = DISPATCH_RESULT.SUCCESS, reason = '', res
     if (processWorkItemFailure && result === DISPATCH_RESULT.ERROR && item.meta?.item?.id) {
       let retries = (item.meta.item._retryCount || 0);
       try {
-        const wiPath = lifecycle().resolveWorkItemPath(item.meta);
-        if (wiPath) {
-          const items = safeJson(wiPath);
-          if (items && Array.isArray(items)) {
-            const wi = items.find(i => i.id === item.meta.item.id);
-            if (wi) retries = wi._retryCount || 0;
-          }
-        }
+        const wi = queries.getWorkItems().find(i => i.id === item.meta.item.id);
+        if (wi) retries = wi._retryCount || 0;
       } catch (e) { log('warn', 'read retry count: ' + e.message); }
       const maxRetries = ENGINE_DEFAULTS.maxRetries;
       if (retryableFailure && retries < maxRetries) {
@@ -178,13 +172,8 @@ function completeDispatch(id, result = DISPATCH_RESULT.SUCCESS, reason = '', res
           const config = getConfig();
           const failedId = item.meta.item.id;
           const blockedItems = [];
-          for (const p of getProjects(config)) {
-            const items = safeJson(projectWorkItemsPath(p)) || [];
-            items.filter(w => w.status === WI_STATUS.PENDING && (w.depends_on || []).includes(failedId))
-              .forEach(w => blockedItems.push(`- \`${w.id}\` — ${w.title}`));
-          }
-          const centralItems = safeJson(path.join(MINIONS_DIR, 'work-items.json')) || [];
-          centralItems.filter(w => w.status === WI_STATUS.PENDING && (w.depends_on || []).includes(failedId))
+          const allItems = queries.getWorkItems(config);
+          allItems.filter(w => w.status === WI_STATUS.PENDING && (w.depends_on || []).includes(failedId))
             .forEach(w => blockedItems.push(`- \`${w.id}\` — ${w.title}`));
 
           writeInboxAlert(`failed-${failedId}`,

package/engine/lifecycle.js

@@ -30,20 +30,7 @@ function checkPlanCompletion(meta, config) {
   const projects = shared.getProjects(config);
 
   // Collect work items from ALL projects + central (PRD items can be in either)
-  let allWorkItems = [];
-  for (const p of projects) {
-    try {
-      const wi = safeJson(shared.projectWorkItemsPath(p)) || [];
-      allWorkItems = allWorkItems.concat(wi);
-    } catch { /* optional */ }
-  }
-  // Also check central work-items.json (for no-project setups)
-  try {
-    const central = safeJson(path.join(MINIONS_DIR, 'work-items.json')) || [];
-    for (const w of central) {
-      if (!allWorkItems.some(existing => existing.id === w.id)) allWorkItems.push(w);
-    }
-  } catch { /* optional */ }
+  const allWorkItems = queries.getWorkItems(config);
   const planItems = allWorkItems.filter(w => w.sourcePlan === planFile && w.itemType !== 'pr' && w.itemType !== 'verify');
   if (planItems.length === 0) return;
 
@@ -330,19 +317,7 @@ function archivePlan(planFile, plan, projects, config) {
     if (plan.feature_branch) branchSlugs.add(shared.sanitizeBranch(plan.feature_branch).toLowerCase());
 
     // Collect work items for this plan
-    let allWorkItems = [];
-    for (const p of projects) {
-      try {
-        const wi = safeJson(shared.projectWorkItemsPath(p)) || [];
-        allWorkItems = allWorkItems.concat(wi);
-      } catch { /* optional */ }
-    }
-    try {
-      const central = safeJson(path.join(MINIONS_DIR, 'work-items.json')) || [];
-      for (const w of central) {
-        if (!allWorkItems.some(existing => existing.id === w.id)) allWorkItems.push(w);
-      }
-    } catch { /* optional */ }
+    const allWorkItems = queries.getWorkItems(config);
     const planItems = allWorkItems.filter(w => w.sourcePlan === planFile);
     const doneItems = planItems.filter(w => DONE_STATUSES.has(w.status));
 

package/engine/playbook.js

@@ -133,7 +133,7 @@ function resolveTaskContext(item, config) {
       try {
         const plans = fs.readdirSync(path.join(MINIONS_DIR, 'plans')).filter(f => f.endsWith('.md') || f.endsWith('.json'));
         // Check work-items to find which plan file this agent created
-        const workItems = safeJson(path.join(MINIONS_DIR, 'work-items.json')) || [];
+        const workItems = queries.getWorkItems();
         const agentPlanItems = workItems.filter(w =>
           w.type === WORK_TYPE.PLAN && w.dispatched_to === agent.id && w.status === WI_STATUS.DONE && w._planFileName
         ).sort((a, b) => (b.completedAt || '').localeCompare(a.completedAt || ''));

package/engine/shared.js

@@ -738,6 +738,34 @@ function killImmediate(proc) {
   }
 }
 
+// ─── Work Items & Pull Requests Mutation Helpers ────────────────────────────
+
+/**
+ * Atomic read-modify-write for work-items JSON files.
+ * Wraps mutateJsonFileLocked with defaultValue of [].
+ * @param {string} filePath - Path to the work-items JSON file
+ * @param {Function} mutator - Receives the array, mutates in place or returns new value
+ */
+function mutateWorkItems(filePath, mutator) {
+  return mutateJsonFileLocked(filePath, (data) => {
+    if (!Array.isArray(data)) data = [];
+    return mutator(data) || data;
+  }, { defaultValue: [] });
+}
+
+/**
+ * Atomic read-modify-write for pull-requests JSON files.
+ * Wraps mutateJsonFileLocked with defaultValue of [].
+ * @param {string} filePath - Path to the pull-requests JSON file
+ * @param {Function} mutator - Receives the array, mutates in place or returns new value
+ */
+function mutatePullRequests(filePath, mutator) {
+  return mutateJsonFileLocked(filePath, (data) => {
+    if (!Array.isArray(data)) data = [];
+    return mutator(data) || data;
+  }, { defaultValue: [] });
+}
+
 module.exports = {
   MINIONS_DIR,
   PR_LINKS_PATH,
@@ -753,6 +781,8 @@ module.exports = {
   safeUnlink,
   withFileLock,
   mutateJsonFileLocked,
+  mutateWorkItems,
+  mutatePullRequests,
   uid,
   uniquePath,
   writeToInbox,

package/engine.js

@@ -149,16 +149,8 @@ function resolveDependencyBranches(depIds, sourcePlan, project, config) {
   const projects = shared.getProjects(config);
 
   // Find work items for each dependency plan item
-  const depWorkItems = [];
-  for (const p of projects) {
-    const wiPath = shared.projectWorkItemsPath(p);
-    const items = safeJson(wiPath) || [];
-    for (const wi of items) {
-      if (depIds.includes(wi.id)) {
-        depWorkItems.push(wi);
-      }
-    }
-  }
+  const allItems = queries.getWorkItems(config);
+  const depWorkItems = allItems.filter(wi => depIds.includes(wi.id));
 
   // Find PR branches for each dependency work item
   for (const p of projects) {
@@ -837,13 +829,7 @@ function areDependenciesMet(item, config) {
   const projects = getProjects(config);
 
   // Collect work items from ALL projects (dependencies can be cross-project)
-  let allWorkItems = [];
-  for (const p of projects) {
-    try {
-      const wi = safeJson(projectWorkItemsPath(p)) || [];
-      allWorkItems = allWorkItems.concat(wi);
-    } catch (e) { log('warn', 'read project work items for deps: ' + e.message); }
-  }
+  const allWorkItems = queries.getWorkItems(config);
   // PRD item statuses that count as "done" for dep resolution
   const PRD_MET_STATUSES = DONE_STATUSES;
 
@@ -1195,13 +1181,7 @@ function materializePlansAsWorkItems(config) {
     const statusFilter = ['missing', 'planned'];
     // Also materialize in-pr/done items that never got a work item (race with PR status sync)
     const allExistingWiIds = new Set();
-    for (const p of allProjects) {
-      for (const w of (safeJson(projectWorkItemsPath(p)) || [])) {
-        if (w.id) allExistingWiIds.add(w.id);
-      }
-    }
-    // Also check central work-items.json
-    for (const w of (safeJson(path.join(MINIONS_DIR, 'work-items.json')) || [])) {
+    for (const w of queries.getWorkItems()) {
       if (w.id) allExistingWiIds.add(w.id);
     }
     const items = plan.missing_features.filter(f =>
@@ -2307,10 +2287,9 @@ function discoverWork(config) {
   }
 
   // Gate reviews and fixes: do not dispatch until all implement items are complete
-  const hasIncompleteImplements = projects.some(project => {
-    const items = safeJson(projectWorkItemsPath(project)) || [];
-    return items.some(i => ['queued', 'pending', 'dispatched'].includes(i.status) && (i.type || '').startsWith('implement'));
-  });
+  const hasIncompleteImplements = queries.getWorkItems(config).some(i =>
+    ['queued', 'pending', 'dispatched'].includes(i.status) && (i.type || '').startsWith('implement')
+  );
   if (hasIncompleteImplements) {
     if (allReviews.length > 0) {
       log('info', `Gating ${allReviews.length} reviews — implement items still in progress`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.526",
+  "version": "0.1.527",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"