@yemi33/minions 0.1.525 → 0.1.526

package/CHANGELOG.md

@@ -1,8 +1,10 @@
 # Changelog
 
-## 0.1.525 (2026-04-07)
+## 0.1.526 (2026-04-07)
 
 ### Features
+- Replace new Date().toISOString() with ts() from shared.js (#411)
+- Add Concurrency & Lock Ordering section to CLAUDE.md (#409)
 -  9 test isolation verification tests — run last to detect pollution
 
 ### Fixes

package/engine/ado.js

@@ -173,7 +173,7 @@ async function pollPrStatus(config) {
     const headCommit = prData.lastMergeSourceCommit?.commitId || prData.sourceRefName || '';
     if (headCommit && pr._adoHeadCommit !== headCommit) {
       if (pr._adoHeadCommit) { // skip first detection — only track changes
-        pr.lastPushedAt = new Date().toISOString();
+        pr.lastPushedAt = ts();
       }
       pr._adoHeadCommit = headCommit;
       updated = true;

package/engine/cli.js

@@ -6,7 +6,7 @@
 const fs = require('fs');
 const path = require('path');
 const shared = require('./shared');
-const { safeRead, safeJson, safeWrite, WI_STATUS, WORK_TYPE, PLAN_STATUS, PR_STATUS, DISPATCH_RESULT } = shared;
+const { safeRead, safeJson, safeWrite, ts, WI_STATUS, WORK_TYPE, PLAN_STATUS, PR_STATUS, DISPATCH_RESULT } = shared;
 const queries = require('./queries');
 const { getConfig, getControl, getDispatch, getAgentStatus,
   MINIONS_DIR, ENGINE_DIR, AGENTS_DIR, PLANS_DIR, PRD_DIR, CONTROL_PATH, DISPATCH_PATH } = queries;
@@ -174,7 +174,7 @@ const commands = {
               if (wi && wi.status !== WI_STATUS.DISPATCHED) {
                 wi.status = WI_STATUS.DISPATCHED;
                 wi.dispatched_to = wi.dispatched_to || agentId;
-                wi.dispatched_at = wi.dispatched_at || new Date().toISOString();
+                wi.dispatched_at = wi.dispatched_at || ts();
                 safeWrite(wiPath, wiItems);
               }
             } catch (err) { console.log(`    Warning: failed to sync work item status: ${err.message}`); }
@@ -273,8 +273,8 @@ const commands = {
                   const wi = items.find(w => w.id === item.meta.item.id);
                   if (wi) {
                     wi.status = status;
-                    if (isSuccess) { wi.completedAt = new Date().toISOString(); delete wi.failReason; }
-                    else { wi.failedAt = new Date().toISOString(); wi.failReason = 'Completed while engine was down'; }
+                    if (isSuccess) { wi.completedAt = ts(); delete wi.failReason; }
+                    else { wi.failedAt = ts(); wi.failReason = 'Completed while engine was down'; }
                     safeWrite(wiPath, items);
                   }
                 }

package/engine/consolidation.js

@@ -9,7 +9,7 @@ const path = require('path');
 const crypto = require('crypto');
 const shared = require('./shared');
 const { safeRead, safeWrite, safeUnlink, runFile, cleanChildEnv,
-  parseStreamJsonOutput, classifyInboxItem, KB_CATEGORIES, log, dateStamp } = shared;
+  parseStreamJsonOutput, classifyInboxItem, KB_CATEGORIES, log, ts, dateStamp } = shared;
 const { trackEngineUsage } = require('./llm');
 const queries = require('./queries');
 const { getInboxFiles, getNotes, INBOX_DIR, ENGINE_DIR, MINIONS_DIR,
@@ -440,7 +440,7 @@ function classifyToKnowledgeBase(items) {
       const dir = path.join(KNOWLEDGE_DIR, cat);
       if (fs.existsSync(dir)) count += fs.readdirSync(dir).length;
     }
-    safeWrite(path.join(ENGINE_DIR, 'kb-checkpoint.json'), JSON.stringify({ count, updatedAt: new Date().toISOString() }));
+    safeWrite(path.join(ENGINE_DIR, 'kb-checkpoint.json'), JSON.stringify({ count, updatedAt: ts() }));
   } catch (err) { log('warn', `KB checkpoint: ${err.message}`); }
 }
 

package/engine/github.js

@@ -217,7 +217,7 @@ async function pollPrStatus(config) {
     // Track head SHA changes to detect new pushes (used for review re-dispatch gating)
     if (prData.head?.sha && pr.headSha !== prData.head.sha) {
       pr.headSha = prData.head.sha;
-      pr.lastPushedAt = new Date().toISOString();
+      pr.lastPushedAt = ts();
       updated = true;
     }
 

package/engine/lifecycle.js

@@ -121,7 +121,7 @@ function checkPlanCompletion(meta, config) {
     ``,
     `**Project:** ${plan.project || 'Unknown'}`,
     `**Strategy:** ${plan.branch_strategy || 'parallel'}`,
-    `**Completed:** ${new Date().toISOString().slice(0, 16).replace('T', ' ')}`,
+    `**Completed:** ${ts().slice(0, 16).replace('T', ' ')}`,
     `**Runtime:** ${runtimeMin >= 60 ? Math.floor(runtimeMin / 60) + 'h ' + (runtimeMin % 60) + 'm' : runtimeMin + 'm'}`,
     ``,
     `## Results`,
@@ -1136,7 +1136,7 @@ function handleDecompositionResult(stdout, meta, config) {
           sourcePlan: p.sourcePlan,
           branchStrategy: p.branchStrategy,
           featureBranch: p.featureBranch,
-          created: new Date().toISOString(),
+          created: ts(),
           createdBy: 'decomposition',
         });
       }
@@ -1162,7 +1162,7 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
   if (isSuccess && sessionId && agentId && !agentId.startsWith('temp-')) {
     try {
       shared.safeWrite(path.join(AGENTS_DIR, agentId, 'session.json'), {
-        sessionId, dispatchId: dispatchItem.id, savedAt: new Date().toISOString(),
+        sessionId, dispatchId: dispatchItem.id, savedAt: ts(),
         branch: dispatchItem.meta?.branch || null,
       });
     } catch (err) { log('warn', `Session save: ${err.message}`); }

package/engine/llm.js

@@ -5,7 +5,7 @@
 
 const path = require('path');
 const shared = require('./shared');
-const { safeWrite, safeUnlink, uid, runFile, cleanChildEnv, parseStreamJsonOutput, mutateJsonFileLocked } = shared;
+const { safeWrite, safeUnlink, uid, ts, runFile, cleanChildEnv, parseStreamJsonOutput, mutateJsonFileLocked } = shared;
 
 const MINIONS_DIR = shared.MINIONS_DIR;
 const ENGINE_DIR = path.join(MINIONS_DIR, 'engine');
@@ -28,7 +28,7 @@ function trackEngineUsage(category, usage) {
       cat.cacheRead += usage.cacheRead || 0;
       cat.cacheCreation = (cat.cacheCreation || 0) + (usage.cacheCreation || 0);
 
-      const today = new Date().toISOString().slice(0, 10);
+      const today = ts().slice(0, 10);
       if (!metrics._daily) metrics._daily = {};
       if (!metrics._daily[today]) metrics._daily[today] = { costUsd: 0, inputTokens: 0, outputTokens: 0, cacheRead: 0, tasks: 0 };
       const daily = metrics._daily[today];

package/engine/meeting.js

@@ -6,7 +6,7 @@
 const fs = require('fs');
 const path = require('path');
 const shared = require('./shared');
-const { safeJson, safeWrite, safeRead, uid, log, ENGINE_DEFAULTS, WORK_TYPE, DISPATCH_RESULT } = shared;
+const { safeJson, safeWrite, safeRead, uid, log, ts, ENGINE_DEFAULTS, WORK_TYPE, DISPATCH_RESULT } = shared;
 const queries = require('./queries');
 const { getDispatch, getConfig } = queries;
 const { renderPlaybook } = require('./playbook');
@@ -51,8 +51,8 @@ function createMeeting({ title, agenda, participants }) {
     round: 1,
     participants: participants || [],
     createdBy: 'human',
-    createdAt: new Date().toISOString(),
-    roundStartedAt: new Date().toISOString(),
+    createdAt: ts(),
+    roundStartedAt: ts(),
     findings: {},
     debate: {},
     conclusion: null,
@@ -209,16 +209,16 @@ function collectMeetingFindings(meetingId, agentId, roundName, output) {
   const content = rawContent;
 
   if (roundName === 'investigate') {
-    meeting.findings[agentId] = { content, submittedAt: new Date().toISOString() };
-    meeting.transcript.push({ round: meeting.round, agent: agentId, type: 'finding', content, at: new Date().toISOString() });
+    meeting.findings[agentId] = { content, submittedAt: ts() };
+    meeting.transcript.push({ round: meeting.round, agent: agentId, type: 'finding', content, at: ts() });
   } else if (roundName === 'debate') {
-    meeting.debate[agentId] = { content, submittedAt: new Date().toISOString() };
-    meeting.transcript.push({ round: meeting.round, agent: agentId, type: 'debate', content, at: new Date().toISOString() });
+    meeting.debate[agentId] = { content, submittedAt: ts() };
+    meeting.transcript.push({ round: meeting.round, agent: agentId, type: 'debate', content, at: ts() });
   } else if (roundName === 'conclude') {
-    meeting.conclusion = { content, agent: agentId, submittedAt: new Date().toISOString() };
-    meeting.transcript.push({ round: meeting.round, agent: agentId, type: 'conclusion', content, at: new Date().toISOString() });
+    meeting.conclusion = { content, agent: agentId, submittedAt: ts() };
+    meeting.transcript.push({ round: meeting.round, agent: agentId, type: 'conclusion', content, at: ts() });
     meeting.status = 'completed';
-    meeting.completedAt = new Date().toISOString();
+    meeting.completedAt = ts();
 
     // Write transcript to inbox so agents learn from it (slug-based dedup)
     try {
@@ -246,12 +246,12 @@ function collectMeetingFindings(meetingId, agentId, roundName, output) {
     if (meeting.status === 'investigating') {
       meeting.status = 'debating';
       meeting.round = 2;
-      meeting.roundStartedAt = new Date().toISOString();
+      meeting.roundStartedAt = ts();
       log('info', `Meeting ${meetingId}: all findings in — advancing to debate`);
     } else if (meeting.status === 'debating') {
       meeting.status = 'concluding';
       meeting.round = 3;
-      meeting.roundStartedAt = new Date().toISOString();
+      meeting.roundStartedAt = ts();
       log('info', `Meeting ${meetingId}: all debate responses in — advancing to conclusion`);
     }
   }
@@ -263,7 +263,7 @@ function addMeetingNote(meetingId, note) {
   const meeting = getMeeting(meetingId);
   if (!meeting) return null;
   meeting.humanNotes.push(note);
-  meeting.transcript.push({ round: meeting.round, agent: 'human', type: 'note', content: note, at: new Date().toISOString() });
+  meeting.transcript.push({ round: meeting.round, agent: 'human', type: 'note', content: note, at: ts() });
   saveMeeting(meeting);
   return meeting;
 }
@@ -279,7 +279,7 @@ function _killMeetingDispatches(meetingId) {
       dp.active = (dp.active || []).filter(d => d.meta?.meetingId !== meetingId);
       dp.completed = dp.completed || [];
       for (const d of toKill) {
-        dp.completed.push({ ...d, result: DISPATCH_RESULT.ERROR, reason: 'Meeting ended/advanced by human', completed_at: new Date().toISOString() });
+        dp.completed.push({ ...d, result: DISPATCH_RESULT.ERROR, reason: 'Meeting ended/advanced by human', completed_at: ts() });
       }
       if (dp.completed.length > 100) dp.completed = dp.completed.slice(-100);
       return dp;
@@ -295,9 +295,9 @@ function advanceMeetingRound(meetingId) {
   _killMeetingDispatches(meetingId);
   if (meeting.status === 'investigating') { meeting.status = 'debating'; meeting.round = 2; }
   else if (meeting.status === 'debating') { meeting.status = 'concluding'; meeting.round = 3; }
-  else if (meeting.status === 'concluding') { meeting.status = 'completed'; meeting.completedAt = new Date().toISOString(); }
+  else if (meeting.status === 'concluding') { meeting.status = 'completed'; meeting.completedAt = ts(); }
   else return meeting; // no change
-  meeting.roundStartedAt = new Date().toISOString();
+  meeting.roundStartedAt = ts();
   saveMeeting(meeting);
   return meeting;
 }
@@ -307,7 +307,7 @@ function endMeeting(meetingId) {
   if (!meeting) return null;
   _killMeetingDispatches(meetingId);
   meeting.status = 'completed';
-  meeting.completedAt = new Date().toISOString();
+  meeting.completedAt = ts();
   saveMeeting(meeting);
   return meeting;
 }
@@ -316,7 +316,7 @@ function archiveMeeting(id) {
   const meeting = getMeeting(id);
   if (!meeting) return null;
   meeting.status = 'archived';
-  meeting.archivedAt = new Date().toISOString();
+  meeting.archivedAt = ts();
   saveMeeting(meeting);
   return meeting;
 }
@@ -364,17 +364,17 @@ function checkMeetingTimeouts(config) {
 
     if (meeting.status === 'investigating') {
       log('warn', `Meeting ${meeting.id}: round 1 timed out after ${Math.round(elapsed / 60000)}min — ${respondedCount}/${totalCount} responded, advancing to debate`);
-      meeting.transcript.push({ round: meeting.round, agent: 'system', type: 'timeout', content: `Round 1 timed out — ${respondedCount}/${totalCount} findings received`, at: new Date().toISOString() });
+      meeting.transcript.push({ round: meeting.round, agent: 'system', type: 'timeout', content: `Round 1 timed out — ${respondedCount}/${totalCount} findings received`, at: ts() });
       meeting.status = 'debating';
       meeting.round = 2;
-      meeting.roundStartedAt = new Date().toISOString();
+      meeting.roundStartedAt = ts();
       saveMeeting(meeting);
     } else if (meeting.status === 'debating') {
       log('warn', `Meeting ${meeting.id}: round 2 timed out after ${Math.round(elapsed / 60000)}min — ${respondedCount}/${totalCount} responded, advancing to conclusion`);
-      meeting.transcript.push({ round: meeting.round, agent: 'system', type: 'timeout', content: `Round 2 timed out — ${respondedCount}/${totalCount} debate responses received`, at: new Date().toISOString() });
+      meeting.transcript.push({ round: meeting.round, agent: 'system', type: 'timeout', content: `Round 2 timed out — ${respondedCount}/${totalCount} debate responses received`, at: ts() });
       meeting.status = 'concluding';
       meeting.round = 3;
-      meeting.roundStartedAt = new Date().toISOString();
+      meeting.roundStartedAt = ts();
       saveMeeting(meeting);
     } else if (meeting.status === 'concluding') {
       log('warn', `Meeting ${meeting.id}: conclusion round timed out after ${Math.round(elapsed / 60000)}min — auto-summarizing`);
@@ -386,10 +386,10 @@ function checkMeetingTimeouts(config) {
         `**${(config.agents || {})[agent]?.name || agent}**: ${(d.content || '').slice(0, 200)}`
       ).join('\n');
       const autoConclusion = `*Auto-generated — conclusion round timed out.*\n\n## Key Findings\n${findingsSummary || '(none)'}\n\n## Debate Summary\n${debateSummary || '(none)'}`;
-      meeting.conclusion = { content: autoConclusion, agent: 'system', submittedAt: new Date().toISOString() };
-      meeting.transcript.push({ round: meeting.round, agent: 'system', type: 'conclusion', content: autoConclusion, at: new Date().toISOString() });
+      meeting.conclusion = { content: autoConclusion, agent: 'system', submittedAt: ts() };
+      meeting.transcript.push({ round: meeting.round, agent: 'system', type: 'conclusion', content: autoConclusion, at: ts() });
       meeting.status = 'completed';
-      meeting.completedAt = new Date().toISOString();
+      meeting.completedAt = ts();
 
       // Write transcript to inbox (same as normal conclusion path)
       try {

package/engine/playbook.js

@@ -9,7 +9,7 @@ const path = require('path');
 const shared = require('./shared');
 const queries = require('./queries');
 
-const { safeJson, safeRead, getProjects, log, dateStamp, WI_STATUS, WORK_TYPE, PR_STATUS, DISPATCH_RESULT } = shared;
+const { safeJson, safeRead, getProjects, log, ts, dateStamp, WI_STATUS, WORK_TYPE, PR_STATUS, DISPATCH_RESULT } = shared;
 const { getConfig, getDispatch, getNotes, getAgentCharter, getPrs, AGENTS_DIR } = queries;
 
 const MINIONS_DIR = path.resolve(__dirname, '..');
@@ -241,7 +241,7 @@ function renderPlaybook(type, vars) {
   content += `**Never delete, move, or overwrite files in \`knowledge/\`.** The sweep (consolidation engine) is the only process that writes to \`knowledge/\`. If you think a KB file is wrong, note it in your learnings file — do not touch \`knowledge/\` directly.\n`;
 
   // Inject learnings requirement
-  const timeStamp = new Date().toISOString().slice(11, 16).replace(':', '');
+  const timeStamp = ts().slice(11, 16).replace(':', '');
   const inboxSlug = [vars.agent_id || 'agent', vars.task_id || '', dateStamp(), timeStamp].filter(Boolean).join('-');
   content += `\n\n---\n\n## REQUIRED: Write Learnings\n\n`;
   content += `After completing your task, write **one** findings file to:\n`;

package/engine/scheduler.js

@@ -24,7 +24,7 @@
 const fs = require('fs');
 const path = require('path');
 const shared = require('./shared');
-const { safeJson, safeWrite, mutateJsonFileLocked, WI_STATUS } = shared;
+const { safeJson, safeWrite, mutateJsonFileLocked, ts, WI_STATUS } = shared;
 
 const SCHEDULE_RUNS_PATH = path.join(__dirname, 'schedule-runs.json');
 
@@ -126,7 +126,7 @@ function discoverScheduledWork(config) {
         priority: sched.priority || 'medium',
         description: sched.description || sched.title,
         status: WI_STATUS.PENDING,
-        created: new Date().toISOString(),
+        created: ts(),
         createdBy: 'scheduler',
         agent: sched.agent || null,
         project: sched.project || null,
@@ -134,7 +134,7 @@ function discoverScheduledWork(config) {
       });
 
       // Record run time inside the lock
-      runs[sched.id] = new Date().toISOString();
+      runs[sched.id] = ts();
     }
   }, { defaultValue: {} });
 

package/engine/spawn-agent.js

@@ -8,7 +8,7 @@
 
 const fs = require('fs');
 const path = require('path');
-const { exec, runFile, cleanChildEnv, killGracefully, killImmediate } = require('./shared');
+const { exec, runFile, cleanChildEnv, killGracefully, killImmediate, ts } = require('./shared');
 
 const [,, promptFile, sysPromptFile, ...extraArgs] = process.argv;
 
@@ -83,7 +83,7 @@ if (!claudeBin) {
 const tmpDir = path.join(__dirname, 'tmp');
 if (!fs.existsSync(tmpDir)) fs.mkdirSync(tmpDir, { recursive: true });
 const debugPath = path.join(tmpDir, 'spawn-debug.log');
-fs.writeFileSync(debugPath, `spawn-agent.js at ${new Date().toISOString()}\nclaudeBin=${claudeBin || 'not found'}\nnative=${claudeIsNative}\nprompt=${promptFile}\nsysPrompt=${sysPromptFile}\nextraArgs=${extraArgs.join(' ')}\n`);
+fs.writeFileSync(debugPath, `spawn-agent.js at ${ts()}\nclaudeBin=${claudeBin || 'not found'}\nnative=${claudeIsNative}\nprompt=${promptFile}\nsysPrompt=${sysPromptFile}\nextraArgs=${extraArgs.join(' ')}\n`);
 
 // When resuming a session, skip system prompt (it's baked into the session)
 const isResume = extraArgs.includes('--resume');
@@ -119,7 +119,7 @@ if (_sysPromptFileSupported === null) {
       ? spawnSync(claudeBin, ['--help'], { encoding: 'utf8', timeout: 10000, windowsHide: true })
       : spawnSync(process.execPath, [claudeBin, '--help'], { encoding: 'utf8', timeout: 10000, windowsHide: true });
     _sysPromptFileSupported = (testResult.stdout || '').includes('system-prompt-file');
-    try { fs.writeFileSync(capsCachePath, JSON.stringify({ claudeBin, sysPromptFile: _sysPromptFileSupported, checkedAt: new Date().toISOString() })); } catch { /* optional */ }
+    try { fs.writeFileSync(capsCachePath, JSON.stringify({ claudeBin, sysPromptFile: _sysPromptFileSupported, checkedAt: ts() })); } catch { /* optional */ }
   } catch { _sysPromptFileSupported = true; /* assume supported */ }
 }
 if (!isResume) try {

package/engine.js

@@ -24,7 +24,7 @@
 const fs = require('fs');
 const path = require('path');
 const shared = require('./engine/shared');
-const { exec, execSilent, runFile, ENGINE_DEFAULTS: DEFAULTS,
+const { exec, execSilent, runFile, ts, ENGINE_DEFAULTS: DEFAULTS,
   WI_STATUS, DONE_STATUSES, WORK_TYPE, PLAN_STATUS, PR_STATUS, DISPATCH_RESULT } = shared;
 const queries = require('./engine/queries');
 
@@ -542,7 +542,7 @@ function spawnAgent(dispatchItem, config) {
           if (obj.session_id) {
             procInfo.sessionId = obj.session_id;
             safeWrite(path.join(AGENTS_DIR, agentId, 'session.json'), {
-              sessionId: obj.session_id, dispatchId: id, savedAt: new Date().toISOString(), branch: branchName
+              sessionId: obj.session_id, dispatchId: id, savedAt: ts(), branch: branchName
             });
             break;
           }
@@ -1098,7 +1098,7 @@ function materializePlansAsWorkItems(config) {
           log('info', `Source plan ${plan.source_plan} updated — re-syncing PRD ${file}`);
           autoCleanPrdWorkItems(file, config);
           plan.sourcePlanModifiedAt = new Date(sourceMtime).toISOString();
-          plan.lastSyncedFromPlan = new Date().toISOString();
+          plan.lastSyncedFromPlan = ts();
 
           // Handle PRD based on current status
           const prdStatus = plan.status || (plan.requires_approval ? 'awaiting-approval' : null);
@@ -1170,7 +1170,7 @@ function materializePlansAsWorkItems(config) {
     if (planStatus === 'awaiting-approval') {
       if (config.engine?.autoApprovePlans) {
         plan.status = 'approved';
-        plan.approvedAt = new Date().toISOString();
+        plan.approvedAt = ts();
         plan.approvedBy = 'auto-mode';
         safeWrite(path.join(PRD_DIR, file), plan);
         log('info', `Auto-approved plan: ${file}`);
@@ -1452,7 +1452,7 @@ function discoverFromPrs(config, project) {
       if (isAlreadyDispatched(key) || isOnCooldown(key, cooldownMs)) {
         // Coalesce: save feedback for next dispatch
         if (pr.humanFeedback?.feedbackContent) {
-          setCooldownWithContext(key, { feedbackContent: pr.humanFeedback.feedbackContent, timestamp: new Date().toISOString() });
+          setCooldownWithContext(key, { feedbackContent: pr.humanFeedback.feedbackContent, timestamp: ts() });
         }
         continue;
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.525",
+  "version": "0.1.526",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"