@yemi33/minions 0.1.520 → 0.1.522

package/CHANGELOG.md

@@ -1,6 +1,12 @@
 # Changelog
 
-## 0.1.520 (2026-04-07)
+## 0.1.522 (2026-04-07)
+
+### Features
+-  test isolation — tests no longer pollute production data
+
+### Fixes
+-  reconcile failed work items that have attached PRs (#407) (#430)
 
 ### Other
 - perf: reduce curl timeout to 5s, cache getDispatch() reads

package/engine/cleanup.js

@@ -431,7 +431,30 @@ function runCleanup(config, verbose = false) {
     }
   } catch (e) { log('warn', 'KB watchdog check: ' + e.message); }
 
-  // 6. Migrate legacy work-item statuses to canonical 'done'
+  // 6a. Reconcile failed work items that have an attached PR (#407)
+  // If a work item is 'failed' but already has _pr, it should be 'done'.
+  for (const project of projects) {
+    try {
+      const wiPath = projectWorkItemsPath(project);
+      const items = safeJson(wiPath) || [];
+      let reconciled = 0;
+      for (const item of items) {
+        if (item.status === shared.WI_STATUS.FAILED && item._pr) {
+          item.status = shared.WI_STATUS.DONE;
+          if (item.failReason) delete item.failReason;
+          if (item.failedAt) delete item.failedAt;
+          if (!item.completedAt) item.completedAt = shared.ts();
+          reconciled++;
+        }
+      }
+      if (reconciled > 0) {
+        safeWrite(wiPath, items);
+        log('info', `Reconciled ${reconciled} failed-with-PR item(s) → done in ${project.name}`);
+      }
+    } catch (e) { log('warn', 'reconcile failed-with-PR: ' + e.message); }
+  }
+
+  // 6b. Migrate legacy work-item statuses to canonical 'done'
   // in-pr, implemented, complete → done (one-time correction per item)
   const LEGACY_DONE_ALIASES = new Set(['in-pr', 'implemented', 'complete']);
   for (const project of projects) {

package/engine/lifecycle.js

@@ -1012,6 +1012,7 @@ function createReviewFeedbackForAuthor(reviewerAgentId, pr, config) {
 }
 
 function updateMetrics(agentId, dispatchItem, result, taskUsage, prsCreatedCount, model) {
+  if (!agentId || agentId.startsWith('temp-') || agentId === 'agent1' || agentId === 'reviewer' || agentId.startsWith('_test')) return;
 
   const metricsPath = path.join(ENGINE_DIR, 'metrics.json');
   mutateJsonFileLocked(metricsPath, metrics => {
@@ -1371,7 +1372,8 @@ function syncPrdFromPrs(config) {
     for (const project of allProjects) {
       const wiPath = shared.projectWorkItemsPath(project);
       const items = safeJson(wiPath) || [];
-      const hasReconcilable = items.some(wi => (wi.status === WI_STATUS.PENDING || wi.status === WI_STATUS.FAILED) && !wi._pr);
+      const hasReconcilable = items.some(wi =>
+        (wi.status === WI_STATUS.PENDING && !wi._pr) || wi.status === WI_STATUS.FAILED);
       if (!hasReconcilable) continue;
       let reconciled = 0;
       const reconciledItems = mutateJsonFileLocked(wiPath, data => {
@@ -1388,7 +1390,7 @@ function syncPrdFromPrs(config) {
       }
     }
     if (totalReconciled > 0) {
-      log('info', `PR sync: reconciled ${totalReconciled} pending work item(s) to done`);
+      log('info', `PR sync: reconciled ${totalReconciled} work item(s) to done`);
     }
   } catch (err) {
     // Non-fatal — log and continue

package/engine/llm.js

@@ -7,11 +7,12 @@ const path = require('path');
 const shared = require('./shared');
 const { safeWrite, safeUnlink, uid, runFile, cleanChildEnv, parseStreamJsonOutput, mutateJsonFileLocked } = shared;
 
-const MINIONS_DIR = path.resolve(__dirname, '..');
-const ENGINE_DIR = __dirname;
+const MINIONS_DIR = shared.MINIONS_DIR;
+const ENGINE_DIR = path.join(MINIONS_DIR, 'engine');
 
 function trackEngineUsage(category, usage) {
   if (!usage) return;
+  if (category && (category.startsWith('_test') || category.startsWith('test-'))) return;
   try {
     const metricsPath = path.join(ENGINE_DIR, 'metrics.json');
     mutateJsonFileLocked(metricsPath, (metrics) => {

package/engine/shared.js

@@ -6,7 +6,7 @@
 const fs = require('fs');
 const path = require('path');
 
-const MINIONS_DIR = path.resolve(__dirname, '..');
+const MINIONS_DIR = process.env.MINIONS_TEST_DIR || path.resolve(__dirname, '..');
 const PR_LINKS_PATH = path.join(MINIONS_DIR, 'engine', 'pr-links.json');
 const LOG_PATH = path.join(__dirname, 'log.json');
 

package/engine.js

@@ -878,6 +878,16 @@ function reconcileItemsWithPrs(items, allPrs, { onlyIds } = {}) {
     if (wi.status !== WI_STATUS.PENDING && wi.status !== WI_STATUS.FAILED) continue;
     if (onlyIds && !onlyIds.has(wi.id)) continue;
 
+    // Short-circuit: failed item already has a PR attached — mark done directly (#407)
+    if (wi.status === WI_STATUS.FAILED && wi._pr) {
+      wi.status = WI_STATUS.DONE;
+      if (wi.failReason) delete wi.failReason;
+      if (wi.failedAt) delete wi.failedAt;
+      if (!wi.completedAt) wi.completedAt = ts();
+      reconciled++;
+      continue;
+    }
+
     let exactPr = allPrs.find(pr => (pr.prdItems || []).includes(wi.id));
     if (!exactPr) {
       const linkedPrId = Object.keys(prLinks).find(prId => prLinks[prId] === wi.id);
@@ -893,7 +903,7 @@ function reconcileItemsWithPrs(items, allPrs, { onlyIds } = {}) {
       // Clear failure artifacts if reconciling a previously failed item
       if (wi.failReason) delete wi.failReason;
       if (wi.failedAt) delete wi.failedAt;
-      if (!wi.completedAt) wi.completedAt = new Date().toISOString();
+      if (!wi.completedAt) wi.completedAt = ts();
       reconciled++;
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.520",
+  "version": "0.1.522",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"