@yemi33/minions 0.1.492 → 0.1.493

package/CHANGELOG.md

@@ -1,8 +1,9 @@
 # Changelog
 
-## 0.1.492 (2026-04-07)
+## 0.1.493 (2026-04-07)
 
 ### Fixes
+-  reconcile agent completions during engine downtime (closes #376) (#385)
 -  settings button shows modal immediately with loading state
 -  CC respects user scroll position — no auto-scroll when reading history
 -  steering feedback — toast notification, ensure polling resumes

package/engine/cli.js

@@ -221,17 +221,43 @@ const commands = {
           const hasError = output.includes('"is_error":true') || output.includes('"is_error": true');
           if (!hasResult && !hasError) continue;
 
-          const isSuccess = hasResult && !hasError;
-          const result = isSuccess ? DISPATCH_RESULT.SUCCESS : DISPATCH_RESULT.ERROR;
-
-          e.log('info', `Orphan recovery: ${agentId} (${item.id}) completed while engine was down — result: ${result}`);
+          let isSuccess = hasResult && !hasError;
 
-          // Extract PRs from output
+          // Extract PRs from output first — if PRs were created, the agent succeeded
+          // regardless of intermediate error lines in the log
           let prsCreated = 0;
           try {
             prsCreated = lifecycle.syncPrsFromOutput(output, agentId, item.meta, config);
           } catch (err) { e.log('warn', `Orphan PR sync: ${err.message}`); }
 
+          // If PRs were created or a matching PR exists, treat as success
+          if (!isSuccess && prsCreated > 0) {
+            e.log('info', `Orphan recovery: ${agentId} (${item.id}) has ${prsCreated} PR(s) — overriding to success`);
+            isSuccess = true;
+          }
+
+          // Fallback: check pull-requests.json for a matching PR by work item ID
+          if (!isSuccess && item.meta?.item?.id) {
+            try {
+              const projName = item.meta.project?.name;
+              if (projName) {
+                const prPath = path.join(MINIONS_DIR, 'projects', projName, 'pull-requests.json');
+                const prs = safeJson(prPath) || [];
+                const matchingPr = prs.find(pr =>
+                  (pr.prdItems || []).includes(item.meta.item.id) &&
+                  pr.status !== 'abandoned' && pr.status !== 'closed'
+                );
+                if (matchingPr) {
+                  e.log('info', `Orphan recovery: ${agentId} (${item.id}) has matching PR ${matchingPr.id} — overriding to success`);
+                  isSuccess = true;
+                }
+              }
+            } catch (err) { e.log('warn', `Orphan PR lookup: ${err.message}`); }
+          }
+
+          const result = isSuccess ? DISPATCH_RESULT.SUCCESS : DISPATCH_RESULT.ERROR;
+          e.log('info', `Orphan recovery: ${agentId} (${item.id}) completed while engine was down — result: ${result}`);
+
           // Update work item status
           if (item.meta?.item?.id) {
             const status = isSuccess ? WI_STATUS.DONE : WI_STATUS.FAILED;

package/engine.js

@@ -838,7 +838,10 @@ function reconcileItemsWithPrs(items, allPrs, { onlyIds } = {}) {
   const prLinks = shared.getPrLinks();
   let reconciled = 0;
   for (const wi of items) {
-    if (wi.status !== WI_STATUS.PENDING || wi._pr) continue;
+    // Reconcile pending items AND failed items that have a matching PR
+    // (failed items may have been incorrectly marked during engine downtime)
+    if (wi._pr && wi.status !== WI_STATUS.FAILED) continue;
+    if (wi.status !== WI_STATUS.PENDING && wi.status !== WI_STATUS.FAILED) continue;
     if (onlyIds && !onlyIds.has(wi.id)) continue;
 
     let exactPr = allPrs.find(pr => (pr.prdItems || []).includes(wi.id));
@@ -849,6 +852,10 @@ function reconcileItemsWithPrs(items, allPrs, { onlyIds } = {}) {
     if (exactPr) {
       wi.status = WI_STATUS.DONE;
       wi._pr = exactPr.id;
+      // Clear failure artifacts if reconciling a previously failed item
+      if (wi.failReason) delete wi.failReason;
+      if (wi.failedAt) delete wi.failedAt;
+      if (!wi.completedAt) wi.completedAt = new Date().toISOString();
       reconciled++;
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.492",
+  "version": "0.1.493",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"