@yemi33/minions 0.1.474 → 0.1.476

package/CHANGELOG.md

@@ -1,11 +1,15 @@
 # Changelog
 
-## 0.1.474 (2026-04-07)
+## 0.1.476 (2026-04-07)
 
 ### Features
+- Optimize getAgentStatus() to read only head+tail of live-output.log
+- Fix unlocked metrics.json in lifecycle.js post-merge hook
+- Fix unlocked metrics.json read-modify-write in trackEngineUsage
 - Limit SSE initial live-stream payload to last 64KB
 
 ### Fixes
+-  add optional chaining for config.agents in updatePrAfterReview
 -  pass config to updatePrAfterReview to fix test failure
 
 ## 0.1.473 (2026-04-07)

package/engine/lifecycle.js

@@ -717,7 +717,7 @@ function updatePrAfterReview(agentId, pr, project, config) {
   if (!pr?.id) return;
 
   if (!config) config = getConfig();
-  const reviewerName = config.agents[agentId]?.name || agentId;
+  const reviewerName = config.agents?.[agentId]?.name || agentId;
   const dispatch = getDispatch();
   const completedEntry = (dispatch.completed || []).find(d => d.agent === agentId && d.type === 'review');
 
@@ -853,10 +853,11 @@ async function handlePostMerge(pr, project, config, newStatus) {
   const agentId = (pr.agent || '').toLowerCase();
   if (agentId && config.agents?.[agentId]) {
     const metricsPath = path.join(ENGINE_DIR, 'metrics.json');
-    const metrics = safeJson(metricsPath) || {};
-    if (!metrics[agentId]) metrics[agentId] = { tasksCompleted:0, tasksErrored:0, prsCreated:0, prsApproved:0, prsRejected:0, prsMerged:0, reviewsDone:0, lastTask:null, lastCompleted:null };
-    metrics[agentId].prsMerged = (metrics[agentId].prsMerged || 0) + 1;
-    shared.safeWrite(metricsPath, metrics);
+    mutateJsonFileLocked(metricsPath, (metrics) => {
+      if (!metrics[agentId]) metrics[agentId] = { tasksCompleted:0, tasksErrored:0, prsCreated:0, prsApproved:0, prsRejected:0, prsMerged:0, reviewsDone:0, lastTask:null, lastCompleted:null };
+      metrics[agentId].prsMerged = (metrics[agentId].prsMerged || 0) + 1;
+      return metrics;
+    });
   }
 
   const teamsUrl = process.env.TEAMS_PLAN_FLOW_URL;

package/engine/llm.js

@@ -5,7 +5,7 @@
 
 const path = require('path');
 const shared = require('./shared');
-const { safeRead, safeWrite, safeUnlink, uid, runFile, cleanChildEnv, parseStreamJsonOutput } = shared;
+const { safeWrite, safeUnlink, uid, runFile, cleanChildEnv, parseStreamJsonOutput, mutateJsonFileLocked } = shared;
 
 const MINIONS_DIR = path.resolve(__dirname, '..');
 const ENGINE_DIR = __dirname;
@@ -14,31 +14,30 @@ function trackEngineUsage(category, usage) {
   if (!usage) return;
   try {
     const metricsPath = path.join(ENGINE_DIR, 'metrics.json');
-    const raw = safeRead(metricsPath);
-    const metrics = raw ? JSON.parse(raw) : {};
-
-    if (!metrics._engine) metrics._engine = {};
-    if (!metrics._engine[category]) {
-      metrics._engine[category] = { calls: 0, costUsd: 0, inputTokens: 0, outputTokens: 0, cacheRead: 0, cacheCreation: 0 };
-    }
-    const cat = metrics._engine[category];
-    cat.calls++;
-    cat.costUsd += usage.costUsd || 0;
-    cat.inputTokens += usage.inputTokens || 0;
-    cat.outputTokens += usage.outputTokens || 0;
-    cat.cacheRead += usage.cacheRead || 0;
-    cat.cacheCreation = (cat.cacheCreation || 0) + (usage.cacheCreation || 0);
-
-    const today = new Date().toISOString().slice(0, 10);
-    if (!metrics._daily) metrics._daily = {};
-    if (!metrics._daily[today]) metrics._daily[today] = { costUsd: 0, inputTokens: 0, outputTokens: 0, cacheRead: 0, tasks: 0 };
-    const daily = metrics._daily[today];
-    daily.costUsd += usage.costUsd || 0;
-    daily.inputTokens += usage.inputTokens || 0;
-    daily.outputTokens += usage.outputTokens || 0;
-    daily.cacheRead += usage.cacheRead || 0;
-
-    safeWrite(metricsPath, metrics);
+    mutateJsonFileLocked(metricsPath, (metrics) => {
+      if (!metrics._engine) metrics._engine = {};
+      if (!metrics._engine[category]) {
+        metrics._engine[category] = { calls: 0, costUsd: 0, inputTokens: 0, outputTokens: 0, cacheRead: 0, cacheCreation: 0 };
+      }
+      const cat = metrics._engine[category];
+      cat.calls++;
+      cat.costUsd += usage.costUsd || 0;
+      cat.inputTokens += usage.inputTokens || 0;
+      cat.outputTokens += usage.outputTokens || 0;
+      cat.cacheRead += usage.cacheRead || 0;
+      cat.cacheCreation = (cat.cacheCreation || 0) + (usage.cacheCreation || 0);
+
+      const today = new Date().toISOString().slice(0, 10);
+      if (!metrics._daily) metrics._daily = {};
+      if (!metrics._daily[today]) metrics._daily[today] = { costUsd: 0, inputTokens: 0, outputTokens: 0, cacheRead: 0, tasks: 0 };
+      const daily = metrics._daily[today];
+      daily.costUsd += usage.costUsd || 0;
+      daily.inputTokens += usage.inputTokens || 0;
+      daily.outputTokens += usage.outputTokens || 0;
+      daily.cacheRead += usage.cacheRead || 0;
+
+      return metrics;
+    });
   } catch (e) { console.error('metrics update:', e.message); }
 }
 

package/engine/queries.js

@@ -13,6 +13,35 @@ const { safeRead, safeReadDir, safeJson, safeWrite, getProjects,
   projectWorkItemsPath, projectPrPath, parseSkillFrontmatter, KB_CATEGORIES,
   WI_STATUS } = shared;
 
+/**
+ * Read the first `bytes` and last `bytes` of a file efficiently using byte offsets.
+ * For files <= 2*bytes, reads the whole file. Returns { head, tail } strings.
+ * Returns { head: '', tail: '' } on any error.
+ */
+function readHeadTail(filePath, bytes = 1024) {
+  try {
+    const stat = fs.statSync(filePath);
+    const size = stat.size;
+    if (size === 0) return { head: '', tail: '' };
+    if (size <= bytes * 2) {
+      const full = fs.readFileSync(filePath, 'utf8');
+      return { head: full, tail: full };
+    }
+    const fd = fs.openSync(filePath, 'r');
+    try {
+      const headBuf = Buffer.alloc(bytes);
+      fs.readSync(fd, headBuf, 0, bytes, 0);
+      const tailBuf = Buffer.alloc(bytes);
+      fs.readSync(fd, tailBuf, 0, bytes, size - bytes);
+      return { head: headBuf.toString('utf8'), tail: tailBuf.toString('utf8') };
+    } finally {
+      fs.closeSync(fd);
+    }
+  } catch {
+    return { head: '', tail: '' };
+  }
+}
+
 // ── Paths ───────────────────────────────────────────────────────────────────
 
 const MINIONS_DIR = shared.MINIONS_DIR;
@@ -130,19 +159,20 @@ function getAgentStatus(agentId) {
       branch: active.meta?.branch || '',
       started_at: active.started_at || active.created_at || null,
     };
-    // Detect permission-waiting: check live output for non-bypass permission mode
+    // Detect permission-waiting: read only head+tail of live-output.log (max 2KB total)
     try {
-      const liveLog = shared.safeRead(path.join(AGENTS_DIR, agentId, 'live-output.log'));
-      if (liveLog) {
-        // Check init message for permission mode
-        const initMatch = liveLog.match(/"permissionMode"\s*:\s*"([^"]+)"/);
+      const liveLogPath = path.join(AGENTS_DIR, agentId, 'live-output.log');
+      const { head, tail } = readHeadTail(liveLogPath, 1024);
+      if (head) {
+        // Check init message (in head) for permission mode
+        const initMatch = head.match(/"permissionMode"\s*:\s*"([^"]+)"/);
         if (initMatch && initMatch[1] !== 'bypassPermissions') {
           result._permissionMode = initMatch[1];
         }
-        // Check if agent has been silent for >60s (possible permission prompt wait)
-        const lastLine = liveLog.trimEnd().split('\n').pop();
+        // Check if agent has been silent for >60s (use tail for recent activity)
+        const lastLine = tail.trimEnd().split('\n').pop();
         if (lastLine && lastLine.includes('"type":"assistant"') && lastLine.includes('"tool_use"')) {
-          const liveStat = fs.statSync(path.join(AGENTS_DIR, agentId, 'live-output.log'));
+          const liveStat = fs.statSync(liveLogPath);
           const silentMs = Date.now() - liveStat.mtimeMs;
           if (silentMs > 60000 && result._permissionMode) {
             result._warning = 'Possibly waiting for permission approval — agent is not in bypass mode';
@@ -748,6 +778,7 @@ module.exports = {
 
   // Helpers
   timeSince,
+  readHeadTail, // exported for testing
 
   // Core state
   getConfig, getControl, getDispatch, getDispatchQueue,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.474",
+  "version": "0.1.476",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"