@yemi33/minions 0.1.473 → 0.1.475

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## 0.1.475 (2026-04-07)
+
+### Features
+- Fix unlocked metrics.json in lifecycle.js post-merge hook
+- Fix unlocked metrics.json read-modify-write in trackEngineUsage
+- Limit SSE initial live-stream payload to last 64KB
+
+### Fixes
+-  add optional chaining for config.agents in updatePrAfterReview
+-  pass config to updatePrAfterReview to fix test failure
+
 ## 0.1.473 (2026-04-07)
 
 ### Fixes

package/dashboard.js

@@ -1511,15 +1511,25 @@ const server = http.createServer(async (req, res) => {
       'Connection': 'keep-alive',
     });
 
-    // Send initial content
+    // Send initial content — tail only (last 64KB by default) to avoid memory spikes
+    const params = new URL(req.url, 'http://localhost').searchParams;
+    const tailBytes = Math.max(0, parseInt(params.get('tail') || '65536', 10) || 65536);
     let offset = 0;
     try {
-      const content = fs.readFileSync(liveLogPath, 'utf8');
-      if (content.length > 0) {
-        safeWrite(`data: ${JSON.stringify(content)}\n\n`);
-        offset = Buffer.byteLength(content, 'utf8');
+      const stat = fs.statSync(liveLogPath);
+      const fileSize = stat.size;
+      if (fileSize > 0) {
+        const readStart = Math.max(0, fileSize - tailBytes);
+        const readLen = fileSize - readStart;
+        const fd = fs.openSync(liveLogPath, 'r');
+        const buf = Buffer.alloc(readLen);
+        fs.readSync(fd, buf, 0, readLen, readStart);
+        fs.closeSync(fd);
+        const content = buf.toString('utf8');
+        if (content) safeWrite(`data: ${JSON.stringify(content)}\n\n`);
+        offset = fileSize;
       }
-    } catch { /* optional */ }
+    } catch { /* optional — file may not exist yet */ }
 
     // Watch for changes using fs.watchFile (cross-platform, works on Windows)
     const watcher = () => {

package/engine/lifecycle.js

@@ -712,12 +712,12 @@ function syncPrsFromOutput(output, agentId, meta, config) {
 
 // ─── Post-Completion Hooks ──────────────────────────────────────────────────
 
-function updatePrAfterReview(agentId, pr, project) {
+function updatePrAfterReview(agentId, pr, project, config) {
 
   if (!pr?.id) return;
 
-  const config = getConfig();
-  const reviewerName = config.agents[agentId]?.name || agentId;
+  if (!config) config = getConfig();
+  const reviewerName = config.agents?.[agentId]?.name || agentId;
   const dispatch = getDispatch();
   const completedEntry = (dispatch.completed || []).find(d => d.agent === agentId && d.type === 'review');
 
@@ -853,10 +853,11 @@ async function handlePostMerge(pr, project, config, newStatus) {
   const agentId = (pr.agent || '').toLowerCase();
   if (agentId && config.agents?.[agentId]) {
     const metricsPath = path.join(ENGINE_DIR, 'metrics.json');
-    const metrics = safeJson(metricsPath) || {};
-    if (!metrics[agentId]) metrics[agentId] = { tasksCompleted:0, tasksErrored:0, prsCreated:0, prsApproved:0, prsRejected:0, prsMerged:0, reviewsDone:0, lastTask:null, lastCompleted:null };
-    metrics[agentId].prsMerged = (metrics[agentId].prsMerged || 0) + 1;
-    shared.safeWrite(metricsPath, metrics);
+    mutateJsonFileLocked(metricsPath, (metrics) => {
+      if (!metrics[agentId]) metrics[agentId] = { tasksCompleted:0, tasksErrored:0, prsCreated:0, prsApproved:0, prsRejected:0, prsMerged:0, reviewsDone:0, lastTask:null, lastCompleted:null };
+      metrics[agentId].prsMerged = (metrics[agentId].prsMerged || 0) + 1;
+      return metrics;
+    });
   }
 
   const teamsUrl = process.env.TEAMS_PLAN_FLOW_URL;
@@ -1322,7 +1323,7 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
     }
   }
 
-  if (type === WORK_TYPE.REVIEW) updatePrAfterReview(agentId, meta?.pr, meta?.project);
+  if (type === WORK_TYPE.REVIEW) updatePrAfterReview(agentId, meta?.pr, meta?.project, config);
   if (type === WORK_TYPE.FIX) updatePrAfterFix(meta?.pr, meta?.project, meta?.source);
   checkForLearnings(agentId, config.agents[agentId], dispatchItem.task);
   if (effectiveSuccess) {

package/engine/llm.js

@@ -5,7 +5,7 @@
 
 const path = require('path');
 const shared = require('./shared');
-const { safeRead, safeWrite, safeUnlink, uid, runFile, cleanChildEnv, parseStreamJsonOutput } = shared;
+const { safeWrite, safeUnlink, uid, runFile, cleanChildEnv, parseStreamJsonOutput, mutateJsonFileLocked } = shared;
 
 const MINIONS_DIR = path.resolve(__dirname, '..');
 const ENGINE_DIR = __dirname;
@@ -14,31 +14,30 @@ function trackEngineUsage(category, usage) {
   if (!usage) return;
   try {
     const metricsPath = path.join(ENGINE_DIR, 'metrics.json');
-    const raw = safeRead(metricsPath);
-    const metrics = raw ? JSON.parse(raw) : {};
-
-    if (!metrics._engine) metrics._engine = {};
-    if (!metrics._engine[category]) {
-      metrics._engine[category] = { calls: 0, costUsd: 0, inputTokens: 0, outputTokens: 0, cacheRead: 0, cacheCreation: 0 };
-    }
-    const cat = metrics._engine[category];
-    cat.calls++;
-    cat.costUsd += usage.costUsd || 0;
-    cat.inputTokens += usage.inputTokens || 0;
-    cat.outputTokens += usage.outputTokens || 0;
-    cat.cacheRead += usage.cacheRead || 0;
-    cat.cacheCreation = (cat.cacheCreation || 0) + (usage.cacheCreation || 0);
-
-    const today = new Date().toISOString().slice(0, 10);
-    if (!metrics._daily) metrics._daily = {};
-    if (!metrics._daily[today]) metrics._daily[today] = { costUsd: 0, inputTokens: 0, outputTokens: 0, cacheRead: 0, tasks: 0 };
-    const daily = metrics._daily[today];
-    daily.costUsd += usage.costUsd || 0;
-    daily.inputTokens += usage.inputTokens || 0;
-    daily.outputTokens += usage.outputTokens || 0;
-    daily.cacheRead += usage.cacheRead || 0;
-
-    safeWrite(metricsPath, metrics);
+    mutateJsonFileLocked(metricsPath, (metrics) => {
+      if (!metrics._engine) metrics._engine = {};
+      if (!metrics._engine[category]) {
+        metrics._engine[category] = { calls: 0, costUsd: 0, inputTokens: 0, outputTokens: 0, cacheRead: 0, cacheCreation: 0 };
+      }
+      const cat = metrics._engine[category];
+      cat.calls++;
+      cat.costUsd += usage.costUsd || 0;
+      cat.inputTokens += usage.inputTokens || 0;
+      cat.outputTokens += usage.outputTokens || 0;
+      cat.cacheRead += usage.cacheRead || 0;
+      cat.cacheCreation = (cat.cacheCreation || 0) + (usage.cacheCreation || 0);
+
+      const today = new Date().toISOString().slice(0, 10);
+      if (!metrics._daily) metrics._daily = {};
+      if (!metrics._daily[today]) metrics._daily[today] = { costUsd: 0, inputTokens: 0, outputTokens: 0, cacheRead: 0, tasks: 0 };
+      const daily = metrics._daily[today];
+      daily.costUsd += usage.costUsd || 0;
+      daily.inputTokens += usage.inputTokens || 0;
+      daily.outputTokens += usage.outputTokens || 0;
+      daily.cacheRead += usage.cacheRead || 0;
+
+      return metrics;
+    });
   } catch (e) { console.error('metrics update:', e.message); }
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.473",
+  "version": "0.1.475",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"