@yemi33/minions 0.1.471 → 0.1.472

package/CHANGELOG.md

@@ -1,8 +1,9 @@
 # Changelog
 
-## 0.1.471 (2026-04-07)
+## 0.1.472 (2026-04-07)
 
 ### Fixes
+-  steering audit — prevent double-kill, clean up temp files, fix leaks
 -  steering resume improvements — better error logging, heartbeat restart
 -  prevent slow work item modal on large descriptions
 -  only cache sessionId for steering when actually resuming same branch

package/engine/timeout.js

@@ -57,18 +57,19 @@ function checkIdleThreshold(config) {
 function checkSteering(config) {
   const activeProcesses = engine().activeProcesses;
   for (const [id, info] of activeProcesses) {
+    // Skip if already being steered (prevents double-kill race)
+    if (info._steeringMessage || info._steeringAt) continue;
+
     const steerPath = path.join(AGENTS_DIR, info.agentId, 'steer.md');
     let steerMtime;
     try { steerMtime = fs.statSync(steerPath).mtimeMs; } catch { continue; } // ENOENT = no steering message
 
     const sessionId = info.sessionId;
     if (!sessionId) {
-      // No sessionId yet — check stale (>5 min means it'll never arrive)
       if (Date.now() - steerMtime > 300000) {
         log('warn', `Steering: no sessionId for ${info.agentId} after 5m — deleting stale message`);
         try { fs.unlinkSync(steerPath); } catch {}
       }
-      // Leave steer.md in place — retry next tick when sessionId may be available
       continue;
     }
 
@@ -78,13 +79,11 @@ function checkSteering(config) {
 
     log('info', `Steering: killing ${info.agentId} (${id}) for session resume with human message`);
 
-    // Kill current process
     shared.killImmediate(info.proc);
 
-    // Store steering context for re-spawn on close
     info._steeringMessage = message;
     info._steeringSessionId = sessionId;
-    info._steeringAt = Date.now(); // prevent timeout checker from treating this as orphaned
+    info._steeringAt = Date.now();
   }
 }
 

package/engine.js

@@ -631,10 +631,11 @@ function spawnAgent(dispatchItem, config) {
 
       // Re-wire close handler for the resumed process
       resumeProc.on('close', (resumeCode) => {
+        if (heartbeatTimer) { clearInterval(heartbeatTimer); heartbeatTimer = null; }
+        try { fs.unlinkSync(steerPromptPath); } catch { /* cleanup */ }
         if (resumeCode !== 0) {
           log('warn', `Steering resume for ${agentId} exited with code ${resumeCode} | stderr: ${stderr.slice(-300).replace(/\n/g, ' ')}`);
           activeProcesses.delete(id);
-          // Don't burn a retry slot — complete as success so work item stays done/dispatched
           completeDispatch(id, DISPATCH_RESULT.SUCCESS, 'Steering resume failed but original work completed', '', { processWorkItemFailure: false });
           return;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.471",
+  "version": "0.1.472",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"