@yemi33/minions 0.1.461 → 0.1.463

package/CHANGELOG.md

@@ -1,8 +1,14 @@
 # Changelog
 
-## 0.1.461 (2026-04-07)
+## 0.1.463 (2026-04-07)
 
 ### Fixes
+-  clear stale session.json on resume failure, hang kill, and orphan
+
+## 0.1.462 (2026-04-07)
+
+### Fixes
+-  show 'shared branch' label in work item PR column when no PR yet
 -  plan card click opens modal immediately with loading state
 -  remove non-functional Discuss & Revise button from plan cards
 -  steering no longer causes pending/active flip

package/dashboard/js/render-work-items.js

@@ -37,7 +37,9 @@ function wiRow(item) {
   const priBadge = (p) => '<span class="prd-item-priority ' + (p || '') + '">' + escHtml(p || 'medium') + '</span>';
   const prLink = item._pr
     ? '<a class="pr-title" href="' + escHtml(item._prUrl || '#') + '" target="_blank" style="font-size:10px">' + escHtml(item._pr) + '</a>'
-    : '<span style="color:var(--muted)">—</span>';
+    : (item.branchStrategy === 'shared-branch' && item.status === 'done')
+      ? '<span style="font-size:9px;color:var(--muted)" title="Part of shared branch — aggregate PR created at verify stage">shared branch</span>'
+      : '<span style="color:var(--muted)">—</span>';
   return '<tr style="cursor:pointer" onclick="openWorkItemDetail(\'' + escHtml(item.id) + '\')">' +
     '<td><span class="pr-id">' + escHtml(item.id || '') + '</span></td>' +
     '<td style="max-width:220px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap" title="' + escHtml((item.title || '').slice(0, 200)) + '">' + escHtml(item.title || '') + '</td>' +

package/dashboard.js

@@ -844,6 +844,9 @@ function cleanDispatchEntries(matchFn) {
   const engineDir = path.join(MINIONS_DIR, 'engine');
   try {
     let removed = 0;
+    // Collect PIDs and file paths inside the lock, execute kills outside
+    const pidsToKill = [];
+    const filesToDelete = [];
     mutateJsonFileLocked(dispatchPath, (dispatch) => {
       dispatch.pending = Array.isArray(dispatch.pending) ? dispatch.pending : [];
       dispatch.active = Array.isArray(dispatch.active) ? dispatch.active : [];
@@ -853,17 +856,16 @@ function cleanDispatchEntries(matchFn) {
         if (queue === 'active') {
           for (const d of dispatch[queue]) {
             if (!matchFn(d)) continue;
-            // Kill the running agent process via PID file
+            // Collect PID and cleanup paths — actual I/O happens after lock release
             const pidFile = path.join(engineDir, `pid-${d.id}.pid`);
             try {
               const pid = parseInt(fs.readFileSync(pidFile, 'utf8').trim());
-              if (pid) process.kill(pid, 'SIGTERM');
-            } catch { /* process may be dead */ }
-            try { fs.unlinkSync(pidFile); } catch { /* cleanup */ }
-            // Clean up temp prompt files
-            try { fs.unlinkSync(path.join(engineDir, 'tmp', `prompt-${d.id}.md`)); } catch { /* cleanup */ }
-            try { fs.unlinkSync(path.join(engineDir, 'tmp', `sysprompt-${d.id}.md`)); } catch { /* cleanup */ }
-            try { fs.unlinkSync(path.join(engineDir, 'tmp', `sysprompt-${d.id}.md.tmp`)); } catch { /* cleanup */ }
+              if (pid) pidsToKill.push(pid);
+            } catch { /* PID file may not exist */ }
+            filesToDelete.push(pidFile);
+            filesToDelete.push(path.join(engineDir, 'tmp', `prompt-${d.id}.md`));
+            filesToDelete.push(path.join(engineDir, 'tmp', `sysprompt-${d.id}.md`));
+            filesToDelete.push(path.join(engineDir, 'tmp', `sysprompt-${d.id}.md.tmp`));
           }
         }
         dispatch[queue] = dispatch[queue].filter(d => !matchFn(d));
@@ -871,6 +873,22 @@ function cleanDispatchEntries(matchFn) {
       }
       return dispatch;
     }, { defaultValue: { pending: [], active: [], completed: [] } });
+    // Kill processes outside the lock — these can take hundreds of ms on Windows
+    for (const pid of pidsToKill) {
+      try {
+        const safePid = shared.validatePid(pid);
+        if (process.platform === 'win32') {
+          const { execFileSync } = require('child_process');
+          execFileSync('taskkill', ['/PID', String(safePid), '/T'], { stdio: 'pipe', timeout: 5000, windowsHide: true });
+        } else {
+          process.kill(safePid, 'SIGTERM');
+        }
+      } catch { /* process may already be dead */ }
+    }
+    // Clean up files outside the lock
+    for (const fp of filesToDelete) {
+      try { fs.unlinkSync(fp); } catch { /* file may not exist */ }
+    }
     return removed;
   } catch { return 0; }
 }

package/engine/timeout.js

@@ -211,6 +211,8 @@ function checkTimeouts(config) {
     if (!hasProcess && silentMs > effectiveTimeout && Date.now() > engineRestartGraceUntil) {
       // No tracked process AND no recent output past effective timeout AND grace period expired → orphaned
       log('warn', `Orphan detected: ${item.agent} (${item.id}) — no process tracked, silent for ${silentSec}s${isBlocking ? ' (blocking timeout exceeded)' : ''}`);
+      // Clear session so retry starts fresh
+      try { shared.safeUnlink(path.join(AGENTS_DIR, item.agent, 'session.json')); } catch {}
       deadItems.push({ item, reason: `Orphaned — no process, silent for ${silentSec}s` });
     } else if (hasProcess && silentMs > effectiveTimeout) {
       // Has process but no output past effective timeout → hung
@@ -220,6 +222,8 @@ function checkTimeouts(config) {
         shared.killGracefully(procInfo.proc, 5000);
         activeProcesses.delete(item.id);
       }
+      // Clear session so retry starts fresh instead of resuming the killed session
+      try { shared.safeUnlink(path.join(AGENTS_DIR, item.agent, 'session.json')); } catch {}
       deadItems.push({ item, reason: `Hung — no output for ${silentSec}s` });
     }
     // If has process and recent output → healthy, let it run

package/engine.js

@@ -562,6 +562,12 @@ function spawnAgent(dispatchItem, config) {
     if (heartbeatTimer) { clearInterval(heartbeatTimer); heartbeatTimer = null; }
     log('info', `Agent ${agentId} (${id}) exited with code ${code}`);
 
+    // Clear stale session if resume failed — prevents burning all retries on the same bad session
+    if (code !== 0 && cachedSessionId && stderr.includes('No conversation found')) {
+      log('warn', `Stale session ${cachedSessionId} for ${agentId} — clearing session.json`);
+      try { shared.safeUnlink(path.join(AGENTS_DIR, agentId, 'session.json')); } catch {}
+    }
+
     // Check if this was a steering kill — re-spawn with resume
     const procInfo = activeProcesses.get(id);
     if (procInfo?._steeringMessage) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.461",
+  "version": "0.1.463",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"