@yemi33/minions 0.1.460 → 0.1.462

package/CHANGELOG.md

@@ -1,8 +1,10 @@
 # Changelog
 
-## 0.1.460 (2026-04-07)
+## 0.1.462 (2026-04-07)
 
 ### Fixes
+-  show 'shared branch' label in work item PR column when no PR yet
+-  plan card click opens modal immediately with loading state
 -  remove non-functional Discuss & Revise button from plan cards
 -  steering no longer causes pending/active flip
 

package/dashboard/js/render-plans.js

@@ -476,6 +476,12 @@ async function planView(file) {
   _stopPlanPoll();
   try {
     const normalizedFile = normalizePlanFile(file);
+
+    // Show modal immediately with loading state
+    document.getElementById('modal-title').textContent = normalizedFile;
+    document.getElementById('modal-body').innerHTML = '<p style="color:var(--muted)">Loading...</p>';
+    document.getElementById('modal').classList.add('open');
+
     const planRes = await fetch('/api/plans/' + encodeURIComponent(normalizedFile));
     const lastMod = planRes.headers.get('Last-Modified');
     const resolvedPath = planRes.headers.get('X-Resolved-Path');
@@ -487,7 +493,6 @@ async function planView(file) {
     _modalFilePath = resolvedPath || ((normalizedFile.endsWith('.json') ? 'prd/' : 'plans/') + normalizedFile); showModalQa();
     const card = findCardForFile(_modalFilePath);
     if (card) clearNotifBadge(card);
-    document.getElementById('modal').classList.add('open');
 
     // Live-poll while modal is open
     _planPollFile = normalizedFile;
@@ -625,6 +630,9 @@ async function planDiscuss(file) {
 
 async function planOpenInDocChat(file) {
   try {
+    document.getElementById('modal-title').textContent = file;
+    document.getElementById('modal-body').innerHTML = '<p style="color:var(--muted)">Loading...</p>';
+    document.getElementById('modal').classList.add('open');
     const normalizedFile = normalizePlanFile(file);
     const planRes = await fetch('/api/plans/' + encodeURIComponent(normalizedFile));
     const resolvedPath = planRes.headers.get('X-Resolved-Path');

package/dashboard/js/render-work-items.js

@@ -37,7 +37,9 @@ function wiRow(item) {
   const priBadge = (p) => '<span class="prd-item-priority ' + (p || '') + '">' + escHtml(p || 'medium') + '</span>';
   const prLink = item._pr
     ? '<a class="pr-title" href="' + escHtml(item._prUrl || '#') + '" target="_blank" style="font-size:10px">' + escHtml(item._pr) + '</a>'
-    : '<span style="color:var(--muted)">—</span>';
+    : (item.branchStrategy === 'shared-branch' && item.status === 'done')
+      ? '<span style="font-size:9px;color:var(--muted)" title="Part of shared branch — aggregate PR created at verify stage">shared branch</span>'
+      : '<span style="color:var(--muted)">—</span>';
   return '<tr style="cursor:pointer" onclick="openWorkItemDetail(\'' + escHtml(item.id) + '\')">' +
     '<td><span class="pr-id">' + escHtml(item.id || '') + '</span></td>' +
     '<td style="max-width:220px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap" title="' + escHtml((item.title || '').slice(0, 200)) + '">' + escHtml(item.title || '') + '</td>' +

package/dashboard.js

@@ -844,6 +844,9 @@ function cleanDispatchEntries(matchFn) {
   const engineDir = path.join(MINIONS_DIR, 'engine');
   try {
     let removed = 0;
+    // Collect PIDs and file paths inside the lock, execute kills outside
+    const pidsToKill = [];
+    const filesToDelete = [];
     mutateJsonFileLocked(dispatchPath, (dispatch) => {
       dispatch.pending = Array.isArray(dispatch.pending) ? dispatch.pending : [];
       dispatch.active = Array.isArray(dispatch.active) ? dispatch.active : [];
@@ -853,17 +856,16 @@ function cleanDispatchEntries(matchFn) {
         if (queue === 'active') {
           for (const d of dispatch[queue]) {
             if (!matchFn(d)) continue;
-            // Kill the running agent process via PID file
+            // Collect PID and cleanup paths — actual I/O happens after lock release
             const pidFile = path.join(engineDir, `pid-${d.id}.pid`);
             try {
               const pid = parseInt(fs.readFileSync(pidFile, 'utf8').trim());
-              if (pid) process.kill(pid, 'SIGTERM');
-            } catch { /* process may be dead */ }
-            try { fs.unlinkSync(pidFile); } catch { /* cleanup */ }
-            // Clean up temp prompt files
-            try { fs.unlinkSync(path.join(engineDir, 'tmp', `prompt-${d.id}.md`)); } catch { /* cleanup */ }
-            try { fs.unlinkSync(path.join(engineDir, 'tmp', `sysprompt-${d.id}.md`)); } catch { /* cleanup */ }
-            try { fs.unlinkSync(path.join(engineDir, 'tmp', `sysprompt-${d.id}.md.tmp`)); } catch { /* cleanup */ }
+              if (pid) pidsToKill.push(pid);
+            } catch { /* PID file may not exist */ }
+            filesToDelete.push(pidFile);
+            filesToDelete.push(path.join(engineDir, 'tmp', `prompt-${d.id}.md`));
+            filesToDelete.push(path.join(engineDir, 'tmp', `sysprompt-${d.id}.md`));
+            filesToDelete.push(path.join(engineDir, 'tmp', `sysprompt-${d.id}.md.tmp`));
           }
         }
         dispatch[queue] = dispatch[queue].filter(d => !matchFn(d));
@@ -871,6 +873,22 @@ function cleanDispatchEntries(matchFn) {
       }
       return dispatch;
     }, { defaultValue: { pending: [], active: [], completed: [] } });
+    // Kill processes outside the lock — these can take hundreds of ms on Windows
+    for (const pid of pidsToKill) {
+      try {
+        const safePid = shared.validatePid(pid);
+        if (process.platform === 'win32') {
+          const { execFileSync } = require('child_process');
+          execFileSync('taskkill', ['/PID', String(safePid), '/T'], { stdio: 'pipe', timeout: 5000, windowsHide: true });
+        } else {
+          process.kill(safePid, 'SIGTERM');
+        }
+      } catch { /* process may already be dead */ }
+    }
+    // Clean up files outside the lock
+    for (const fp of filesToDelete) {
+      try { fs.unlinkSync(fp); } catch { /* file may not exist */ }
+    }
     return removed;
   } catch { return 0; }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.460",
+  "version": "0.1.462",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"