@yemi33/minions 0.1.454 → 0.1.456

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.1.456 (2026-04-07)
+
+### Fixes
+-  pre-dispatch live vote check prevents reviewing approved PRs
+
+## 0.1.455 (2026-04-07)
+
+### Fixes
+-  agents write one inbox file per task, not two
+
 ## 0.1.454 (2026-04-07)
 
 ### Fixes

package/engine/ado.js

@@ -482,11 +482,39 @@ async function reconcilePrs(config) {
   }
 }
 
+/**
+ * Fetch live review status for a single PR from ADO (synchronous).
+ * Returns 'approved', 'changes-requested', 'waiting', or 'pending'.
+ * Returns null if the check fails (token unavailable, API error).
+ * Used as a pre-dispatch gate to avoid dispatching reviews for already-approved PRs.
+ */
+function checkLiveReviewStatus(pr, project) {
+  try {
+    const token = getAdoToken();
+    if (!token) return null;
+    const orgBase = shared.getAdoOrgBase(project);
+    const prNum = (pr.id || '').replace(/^PR-/, '');
+    const url = `${orgBase}/${project.adoProject}/_apis/git/repositories/${project.repositoryId}/pullrequests/${prNum}?api-version=7.1`;
+    const result = exec(`curl -s -H "Authorization: Bearer ${token}" "${url}"`, { encoding: 'utf-8', timeout: 15000, windowsHide: true });
+    const prData = JSON.parse(result);
+    const votes = (prData.reviewers || []).map(r => r.vote).filter(v => v !== undefined);
+    if (votes.length === 0) return 'pending';
+    if (votes.some(v => v === -10)) return 'changes-requested';
+    if (votes.some(v => v >= 5)) return 'approved';
+    if (votes.some(v => v === -5)) return 'waiting';
+    return 'pending';
+  } catch (e) {
+    log('warn', `Live review check for ${pr.id}: ${e.message}`);
+    return null;
+  }
+}
+
 module.exports = {
   getAdoToken,
   adoFetch,
   pollPrStatus,
   pollPrHumanComments,
   reconcilePrs,
+  checkLiveReviewStatus,
 };
 

package/engine/github.js

@@ -466,9 +466,37 @@ async function reconcilePrs(config) {
   }
 }
 
+/**
+ * Fetch live review status for a single PR from GitHub. Returns 'approved', 'changes-requested',
+ * 'waiting', or 'pending'. Returns null if the check fails.
+ */
+function checkLiveReviewStatus(pr, project) {
+  try {
+    const slug = getRepoSlug(project);
+    if (!slug) return null;
+    const prNum = (pr.id || '').replace(/^PR-/, '');
+    const reviews = ghApi(`/pulls/${prNum}/reviews`, slug);
+    if (!reviews || !Array.isArray(reviews)) return null;
+    const latestByUser = new Map();
+    for (const r of reviews) {
+      if (r.state === 'COMMENTED') continue;
+      latestByUser.set(r.user?.login || '', r.state);
+    }
+    const states = [...latestByUser.values()];
+    if (states.some(s => s === 'CHANGES_REQUESTED')) return 'changes-requested';
+    if (states.some(s => s === 'APPROVED')) return 'approved';
+    if (states.length > 0) return 'pending';
+    return 'pending';
+  } catch (e) {
+    log('warn', `Live review check for ${pr.id}: ${e.message}`);
+    return null;
+  }
+}
+
 module.exports = {
   pollPrStatus,
   pollPrHumanComments,
   reconcilePrs,
+  checkLiveReviewStatus,
 };
 

package/engine/playbook.js

@@ -241,12 +241,13 @@ function renderPlaybook(type, vars) {
   content += `**Never delete, move, or overwrite files in \`knowledge/\`.** The sweep (consolidation engine) is the only process that writes to \`knowledge/\`. If you think a KB file is wrong, note it in your learnings file — do not touch \`knowledge/\` directly.\n`;
 
   // Inject learnings requirement
-  content += `\n\n---\n\n## REQUIRED: Write Learnings\n\n`;
-  content += `After completing your task, you MUST write a findings/learnings file to:\n`;
   const timeStamp = new Date().toISOString().slice(11, 16).replace(':', '');
   const inboxSlug = [vars.agent_id || 'agent', vars.task_id || '', dateStamp(), timeStamp].filter(Boolean).join('-');
+  content += `\n\n---\n\n## REQUIRED: Write Learnings\n\n`;
+  content += `After completing your task, write **one** findings file to:\n`;
   content += `\`${MINIONS_DIR}/notes/inbox/${inboxSlug}.md\`\n\n`;
-  content += `Include:\n`;
+  content += `**IMPORTANT: Write exactly ONE inbox file per task.** If the playbook above already specifies an inbox path, use THAT path instead and include your learnings in the same document. Do NOT create a second file — duplicates clog consolidation.\n\n`;
+  content += `Include in your findings file:\n`;
   content += `- What you learned about the codebase\n`;
   content += `- Patterns you discovered or established\n`;
   content += `- Gotchas or warnings for future agents\n`;

package/engine.js

@@ -830,8 +830,8 @@ function reconcileItemsWithPrs(items, allPrs, { onlyIds } = {}) {
 // ─── Inbox Consolidation (extracted to engine/consolidation.js) ──────────────
 
 const { consolidateInbox } = require('./engine/consolidation');
-const { pollPrStatus, pollPrHumanComments, reconcilePrs } = require('./engine/ado');
-const { pollPrStatus: ghPollPrStatus, pollPrHumanComments: ghPollPrHumanComments, reconcilePrs: ghReconcilePrs } = require('./engine/github');
+const { pollPrStatus, pollPrHumanComments, reconcilePrs, checkLiveReviewStatus: adoCheckLiveReview } = require('./engine/ado');
+const { pollPrStatus: ghPollPrStatus, pollPrHumanComments: ghPollPrHumanComments, reconcilePrs: ghReconcilePrs, checkLiveReviewStatus: ghCheckLiveReview } = require('./engine/github');
 
 // ─── State Snapshot ─────────────────────────────────────────────────────────
 
@@ -1291,6 +1291,27 @@ function discoverFromPrs(config, project) {
     if (needsReview) {
       const key = `review-${project?.name || 'default'}-${pr.id}`;
       if (isAlreadyDispatched(key) || isOnCooldown(key, cooldownMs)) continue;
+
+      // Pre-dispatch live vote check — cached reviewStatus may be stale (poll lag ~6 min)
+      try {
+        const checkFn = project.repoHost === 'github' ? ghCheckLiveReview : adoCheckLiveReview;
+        const liveStatus = checkFn(pr, project);
+        if (liveStatus && liveStatus !== 'pending') {
+          log('info', `Pre-dispatch vote check: ${pr.id} is ${liveStatus} (cached was pending) — skipping review`);
+          pr.reviewStatus = liveStatus;
+          // Persist so next tick doesn't re-check
+          try {
+            mutateJsonFileLocked(projectPrPath(project), data => {
+              if (!Array.isArray(data)) return data;
+              const target = data.find(p => p.id === pr.id);
+              if (target) target.reviewStatus = liveStatus;
+              return data;
+            });
+          } catch {}
+          continue;
+        }
+      } catch (e) { log('warn', `Pre-dispatch vote check for ${pr.id}: ${e.message}`); }
+
       const agentId = resolveAgent('review', config);
       if (!agentId) continue;
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.454",
+  "version": "0.1.456",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"