@yemi33/minions 0.1.451 → 0.1.453

package/CHANGELOG.md

@@ -1,11 +1,13 @@
 # Changelog
 
-## 0.1.451 (2026-04-07)
+## 0.1.453 (2026-04-07)
 
 ### Features
 -  notification dot on Notes & KB sidebar when sweep completes/fails
 
 ### Fixes
+-  wrap inbox writes in try-catch on both meeting conclusion paths
+-  remove duplicate retry logic causing dispatch double-queueing
 -  plan archive/unarchive now optimistic — immediate UI feedback
 -  meeting conclude timeout synthesizes conclusion instead of null
 -  track ADO head commit for push detection — unblocks re-review cycle

package/engine/lifecycle.js

@@ -1189,52 +1189,18 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
     meta._agentId = agentId;
     updateWorkItemStatus(meta, WI_STATUS.DONE, '');
   }
-  if (!effectiveSuccess && meta?.item?.id) {
-    // Auto-retry: read fresh _retryCount from file (not stale dispatch-time snapshot)
-    let retries = (meta.item._retryCount || 0);
+  // Failure retry is handled by completeDispatch in dispatch.js — not duplicated here.
+  // Only clear _decomposing flag on failure so decompose items don't get permanently stuck.
+  if (!effectiveSuccess && meta?.item?.id && type === WORK_TYPE.DECOMPOSE) {
     const wiPath = resolveWorkItemPath(meta);
-    try {
-      if (wiPath) {
-        const items = safeJson(wiPath) || [];
-        const wi = items.find(i => i.id === meta.item.id);
-        if (wi) retries = (wi._retryCount || 0); // Use fresh value from file
-      }
-    } catch { /* optional */ }
-
-    if (retries < ENGINE_DEFAULTS.maxRetries) {
-      log('info', `Agent failed for ${meta.item.id} — auto-retry ${retries + 1}/${ENGINE_DEFAULTS.maxRetries}`);
-      updateWorkItemStatus(meta, WI_STATUS.PENDING, '');
+    if (wiPath) {
       try {
-        if (wiPath) {
-          mutateJsonFileLocked(wiPath, data => {
-            if (!Array.isArray(data)) return data;
-            const wi = data.find(i => i.id === meta.item.id);
-            if (!wi) return data;
-            // Don't revert if already completed by another code path
-            if (wi.status === WI_STATUS.DONE || wi.completedAt) {
-              log('info', `Skip retry for ${meta.item.id} — already completed`);
-              return data;
-            }
-            wi._retryCount = retries + 1; wi.status = WI_STATUS.PENDING; delete wi.dispatched_at; delete wi.dispatched_to; delete wi.failReason;
-            if (type === WORK_TYPE.DECOMPOSE) delete wi._decomposing;
-            return data;
-          });
-        }
-      } catch (err) { log('warn', `Retry update: ${err.message}`); }
-    } else {
-      updateWorkItemStatus(meta, WI_STATUS.FAILED, `Agent failed (${ENGINE_DEFAULTS.maxRetries} retries exhausted)`);
-    }
-    // Clear _decomposing flag on failure so item doesn't get permanently stuck
-    if (type === WORK_TYPE.DECOMPOSE) {
-      try {
-        if (wiPath) {
-          mutateJsonFileLocked(wiPath, data => {
-            if (!Array.isArray(data)) return data;
-            const wi = data.find(i => i.id === meta.item.id);
-            if (wi) delete wi._decomposing;
-            return data;
-          });
-        }
+        mutateJsonFileLocked(wiPath, data => {
+          if (!Array.isArray(data)) return data;
+          const wi = data.find(i => i.id === meta.item.id);
+          if (wi) delete wi._decomposing;
+          return data;
+        });
       } catch (err) { log('warn', `Decompose cleanup: ${err.message}`); }
     }
   }

package/engine/meeting.js

@@ -221,12 +221,14 @@ function collectMeetingFindings(meetingId, agentId, roundName, output) {
     meeting.completedAt = new Date().toISOString();
 
     // Write transcript to inbox so agents learn from it (slug-based dedup)
-    const config = queries.getConfig();
-    const agents = config.agents || {};
-    const transcript = meeting.transcript.map(t =>
-      `### ${agents[t.agent]?.name || t.agent} (${t.type}, Round ${t.round})\n\n${t.content}`
-    ).join('\n\n---\n\n');
-    shared.writeToInbox('meeting', meetingId, `# Meeting Transcript: ${meeting.title}\n\n${transcript}`);
+    try {
+      const config = queries.getConfig();
+      const agents = config.agents || {};
+      const transcript = meeting.transcript.map(t =>
+        `### ${agents[t.agent]?.name || t.agent} (${t.type}, Round ${t.round})\n\n${t.content}`
+      ).join('\n\n---\n\n');
+      shared.writeToInbox('meeting', meetingId, `# Meeting Transcript: ${meeting.title}\n\n${transcript}`);
+    } catch (e) { log('warn', `Meeting ${meetingId} inbox write: ${e.message}`); }
 
     log('info', `Meeting ${meetingId} completed — transcript written to inbox`);
     saveMeeting(meeting);
@@ -390,11 +392,13 @@ function checkMeetingTimeouts(config) {
       meeting.completedAt = new Date().toISOString();
 
       // Write transcript to inbox (same as normal conclusion path)
-      const agents = config.agents || {};
-      const transcript = meeting.transcript.map(t =>
-        `### ${agents[t.agent]?.name || t.agent} (${t.type}, Round ${t.round})\n\n${t.content}`
-      ).join('\n\n---\n\n');
-      shared.writeToInbox('meeting', meeting.id, `# Meeting Transcript: ${meeting.title}\n\n${transcript}`);
+      try {
+        const agents = config.agents || {};
+        const transcript = meeting.transcript.map(t =>
+          `### ${agents[t.agent]?.name || t.agent} (${t.type}, Round ${t.round})\n\n${t.content}`
+        ).join('\n\n---\n\n');
+        shared.writeToInbox('meeting', meeting.id, `# Meeting Transcript: ${meeting.title}\n\n${transcript}`);
+      } catch (e) { log('warn', `Meeting ${meeting.id} inbox write: ${e.message}`); }
 
       saveMeeting(meeting);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.451",
+  "version": "0.1.453",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"