@yemi33/minions 0.1.450 → 0.1.452

package/CHANGELOG.md

@@ -1,11 +1,13 @@
 # Changelog
 
-## 0.1.450 (2026-04-07)
+## 0.1.452 (2026-04-07)
 
 ### Features
 -  notification dot on Notes & KB sidebar when sweep completes/fails
 
 ### Fixes
+-  remove duplicate retry logic causing dispatch double-queueing
+-  plan archive/unarchive now optimistic — immediate UI feedback
 -  meeting conclude timeout synthesizes conclusion instead of null
 -  track ADO head commit for push detection — unblocks re-review cycle
 -  block all fix dispatches while awaiting re-review after a fix

package/dashboard/js/render-plans.js

@@ -550,18 +550,18 @@ async function planDelete(file) {
 
 async function planArchive(file, btn) {
   _stopPlanPoll();
-  if (btn) { btn.dataset.origText = btn.textContent; btn.textContent = 'Archiving...'; btn.style.pointerEvents = 'none'; btn.style.opacity = '0.6'; }
-  function resetBtn() { if (btn) { btn.textContent = btn.dataset.origText || 'Archive'; btn.style.pointerEvents = ''; btn.style.opacity = ''; } }
+  markDeleted('plan:' + file);
+  try { closeModal(); } catch { /* may not be open */ }
+  showToast('cmd-toast', 'Plan archived', true);
   try {
     const res = await fetch('/api/plans/archive', {
       method: 'POST', headers: { 'Content-Type': 'application/json' },
       body: JSON.stringify({ file })
     });
     const ct = res.headers.get('content-type') || '';
-    if (!ct.includes('json')) { resetBtn(); alert('Archive failed — dashboard may need a restart'); return; }
+    if (!ct.includes('json')) { refresh(); return; }
     const d = await res.json().catch(() => ({}));
     if (res.ok && d.ok) {
-      try { closeModal(); } catch { /* may not be open */ }
       var msg = 'Archived';
       if (d.archivedSource) msg += ' PRD + source plan (' + d.archivedSource + ')';
       if (d.cancelledItems) msg += ', cancelled ' + d.cancelledItems + ' pending item(s)';
@@ -721,25 +721,16 @@ async function triggerVerify(file, btn) {
 }
 
 async function planUnarchive(file, btn) {
-  if (btn) { btn.dataset.origText = btn.textContent; btn.textContent = 'Restoring...'; btn.style.pointerEvents = 'none'; btn.style.opacity = '0.6'; }
-  function resetBtn() { if (btn) { btn.textContent = btn.dataset.origText || 'Unarchive'; btn.style.pointerEvents = ''; btn.style.opacity = ''; } }
+  try { closeModal(); } catch {}
+  showToast('cmd-toast', 'Restored from archive', true);
   try {
     const res = await fetch('/api/plans/unarchive', {
       method: 'POST', headers: { 'Content-Type': 'application/json' },
       body: JSON.stringify({ file })
     });
-    const ct = res.headers.get('content-type') || '';
-    if (!ct.includes('json')) { resetBtn(); alert('Unarchive failed — dashboard may need a restart'); return; }
-    const d = await res.json().catch(() => ({}));
-    if (res.ok && d.ok) {
-      showToast('cmd-toast', 'Restored from archive', true);
-      refreshPlans();
-      refresh();
-    } else {
-      resetBtn();
-      alert('Unarchive failed: ' + (d.error || 'unknown'));
-    }
-  } catch (e) { resetBtn(); alert('Error: ' + e.message); }
+    if (res.ok) { refreshPlans(); refresh(); }
+    else { const d = await res.json().catch(() => ({})); alert('Unarchive failed: ' + (d.error || 'unknown')); refresh(); }
+  } catch (e) { alert('Error: ' + e.message); refresh(); }
 }
 
 window.MinionsPlans = { openCreatePlanModal, refreshPlans, derivePlanStatus, renderPlans, openArchivedPlansModal, planExecute, planSubmitRevise, planShowRevise, planHideRevise, planView, planApprove, planArchive, planUnarchive, planDelete, planPause, planReject, planDiscuss, planOpenInDocChat, planRegeneratePRD, openVerifyGuide, triggerVerify };

package/engine/lifecycle.js

@@ -1189,52 +1189,18 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
     meta._agentId = agentId;
     updateWorkItemStatus(meta, WI_STATUS.DONE, '');
   }
-  if (!effectiveSuccess && meta?.item?.id) {
-    // Auto-retry: read fresh _retryCount from file (not stale dispatch-time snapshot)
-    let retries = (meta.item._retryCount || 0);
+  // Failure retry is handled by completeDispatch in dispatch.js — not duplicated here.
+  // Only clear _decomposing flag on failure so decompose items don't get permanently stuck.
+  if (!effectiveSuccess && meta?.item?.id && type === WORK_TYPE.DECOMPOSE) {
     const wiPath = resolveWorkItemPath(meta);
-    try {
-      if (wiPath) {
-        const items = safeJson(wiPath) || [];
-        const wi = items.find(i => i.id === meta.item.id);
-        if (wi) retries = (wi._retryCount || 0); // Use fresh value from file
-      }
-    } catch { /* optional */ }
-
-    if (retries < ENGINE_DEFAULTS.maxRetries) {
-      log('info', `Agent failed for ${meta.item.id} — auto-retry ${retries + 1}/${ENGINE_DEFAULTS.maxRetries}`);
-      updateWorkItemStatus(meta, WI_STATUS.PENDING, '');
+    if (wiPath) {
       try {
-        if (wiPath) {
-          mutateJsonFileLocked(wiPath, data => {
-            if (!Array.isArray(data)) return data;
-            const wi = data.find(i => i.id === meta.item.id);
-            if (!wi) return data;
-            // Don't revert if already completed by another code path
-            if (wi.status === WI_STATUS.DONE || wi.completedAt) {
-              log('info', `Skip retry for ${meta.item.id} — already completed`);
-              return data;
-            }
-            wi._retryCount = retries + 1; wi.status = WI_STATUS.PENDING; delete wi.dispatched_at; delete wi.dispatched_to; delete wi.failReason;
-            if (type === WORK_TYPE.DECOMPOSE) delete wi._decomposing;
-            return data;
-          });
-        }
-      } catch (err) { log('warn', `Retry update: ${err.message}`); }
-    } else {
-      updateWorkItemStatus(meta, WI_STATUS.FAILED, `Agent failed (${ENGINE_DEFAULTS.maxRetries} retries exhausted)`);
-    }
-    // Clear _decomposing flag on failure so item doesn't get permanently stuck
-    if (type === WORK_TYPE.DECOMPOSE) {
-      try {
-        if (wiPath) {
-          mutateJsonFileLocked(wiPath, data => {
-            if (!Array.isArray(data)) return data;
-            const wi = data.find(i => i.id === meta.item.id);
-            if (wi) delete wi._decomposing;
-            return data;
-          });
-        }
+        mutateJsonFileLocked(wiPath, data => {
+          if (!Array.isArray(data)) return data;
+          const wi = data.find(i => i.id === meta.item.id);
+          if (wi) delete wi._decomposing;
+          return data;
+        });
       } catch (err) { log('warn', `Decompose cleanup: ${err.message}`); }
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.450",
+  "version": "0.1.452",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"