@yemi33/minions 0.1.434 → 0.1.435

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.434 (2026-04-06)
+## 0.1.435 (2026-04-06)
 
 ### Features
 -  version check interval on settings page
@@ -11,6 +11,7 @@
 - Convert remaining lifecycle.js safeWrite calls to mutateJsonFileLocked
 
 ### Fixes
+-  prevent triple dispatch on same PR — 3 root causes
 -  don't show 'update available' when running from git repo
 -  CC network error shows helpful message + New Session button
 -  clicking outside command center dismisses it

package/engine/ado.js

@@ -170,7 +170,15 @@ async function pollPrStatus(config) {
     const votes = reviewers.map(r => r.vote).filter(v => v !== undefined);
     let newReviewStatus = pr.reviewStatus || 'pending';
     if (votes.length > 0) {
-      if (votes.some(v => v === -10)) newReviewStatus = 'changes-requested';
+      if (votes.some(v => v === -10)) {
+        // Don't re-trigger 'changes-requested' if fix agent already responded (waiting state).
+        // Only re-trigger if there's been a new push since the fix (reviewer re-reviewed).
+        if (pr.reviewStatus === 'waiting' && pr.minionsReview?.fixedAt && (!pr.lastPushedAt || pr.lastPushedAt <= pr.minionsReview.fixedAt)) {
+          newReviewStatus = 'waiting'; // fix was submitted, same vote still present — wait for re-review
+        } else {
+          newReviewStatus = 'changes-requested';
+        }
+      }
       else if (votes.some(v => v >= 5)) newReviewStatus = 'approved';
       else if (votes.some(v => v === -5)) newReviewStatus = 'waiting';
       else newReviewStatus = 'pending';

package/engine/github.js

@@ -204,7 +204,14 @@ async function pollPrStatus(config) {
       }
 
       let newReviewStatus = pr.reviewStatus || 'pending';
-      if (states.some(s => s === 'CHANGES_REQUESTED')) newReviewStatus = 'changes-requested';
+      if (states.some(s => s === 'CHANGES_REQUESTED')) {
+        // Don't re-trigger if fix agent already responded — wait for re-review
+        if (pr.reviewStatus === 'waiting' && pr.minionsReview?.fixedAt && (!pr.lastPushedAt || pr.lastPushedAt <= pr.minionsReview.fixedAt)) {
+          newReviewStatus = 'waiting';
+        } else {
+          newReviewStatus = 'changes-requested';
+        }
+      }
       else if (states.some(s => s === 'APPROVED')) newReviewStatus = 'approved';
       else if (states.length > 0) newReviewStatus = 'pending';
       // If all reviews were COMMENTED (filtered out), states is empty but reviews exist.

package/engine/lifecycle.js

@@ -762,8 +762,9 @@ function updatePrAfterFix(pr, project, source) {
     const target = prs.find(p => p.id === pr.id);
     if (!target) return prs;
     target.reviewStatus = 'waiting';
+    // Always clear pendingFix — a fix dispatch (regardless of source) addresses all pending feedback
+    if (target.humanFeedback) target.humanFeedback.pendingFix = false;
     if (source === 'pr-human-feedback') {
-      if (target.humanFeedback) target.humanFeedback.pendingFix = false;
       target.minionsReview = { ...target.minionsReview, note: 'Fixed human feedback, awaiting re-review', fixedAt: ts() };
       log('info', `Updated ${pr.id} → cleared humanFeedback.pendingFix, reset to waiting for re-review`);
     } else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.434",
+  "version": "0.1.435",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"