@yemi33/minions 0.1.418 → 0.1.420

package/CHANGELOG.md

@@ -1,10 +1,15 @@
 # Changelog
 
-## 0.1.418 (2026-04-06)
+## 0.1.420 (2026-04-06)
 
 ### Features
+- Low-priority cleanup: dedupe regex, consolidate streaming parse, add path validation alignment
+- Fix 6 medium bugs: dispatch pruning, null guards, skill regex, meeting advancement, CLI PID check, pipeline retry
 - Convert remaining lifecycle.js safeWrite calls to mutateJsonFileLocked
 
+### Fixes
+-  address review feedback — pipeline.js socket leak and magic numbers
+
 ## 0.1.417 (2026-04-06)
 
 ### Features

package/dashboard.js

@@ -2329,9 +2329,8 @@ If nothing to do: { "duplicates": [], "reclassify": [], "remove": [] }`;
     try {
       const body = await readBody(req);
       if (!body.file) return jsonReply(res, 400, { error: 'file required' });
-      if (body.file.includes('..') || body.file.includes('\0') || body.file.includes('/') || body.file.includes('\\')) {
-        return jsonReply(res, 400, { error: 'invalid filename' });
-      }
+      try { shared.sanitizePath(body.file, body.file.endsWith('.json') ? PRD_DIR : PLANS_DIR); }
+      catch { return jsonReply(res, 400, { error: 'invalid filename' }); }
       const isJson = body.file.endsWith('.json');
       const targetDir = isJson ? PRD_DIR : PLANS_DIR;
       const archivePath = path.join(targetDir, 'archive', body.file);

package/engine/ado.js

@@ -381,7 +381,7 @@ async function reconcilePrs(config) {
       const title = adoPr.title || '';
       // Extract item ID from branch name or PR title (e.g., feat(P-2cafdc2a): ...)
       const branchMatch = branch.match(/(P-[a-z0-9]{6,})/i) || branch.match(/(W-[a-z0-9]{6,})/i) || branch.match(/(PL-[a-z0-9]{6,})/i);
-      const titleMatch = title.match(/\((P-[a-z0-9]{6,})\)/) || title.match(/\((W-[a-z0-9]{6,})\)/) || title.match(/\((W-[a-z0-9]{6,})\)/) || title.match(/\((PL-[a-z0-9]{6,})\)/);
+      const titleMatch = title.match(/\((P-[a-z0-9]{6,})\)/) || title.match(/\((W-[a-z0-9]{6,})\)/) || title.match(/\((PL-[a-z0-9]{6,})\)/);
       const linkedItemId = branchMatch?.[1] || titleMatch?.[1] || null;
       const linkedItem = linkedItemId ? allItems.find(i => i.id === linkedItemId) : null;
       const confirmedItemId = linkedItem ? linkedItemId : null;

package/engine/dispatch.js

@@ -87,7 +87,7 @@ function completeDispatch(id, result = DISPATCH_RESULT.SUCCESS, reason = '', res
     if (reason) item.reason = reason;
     if (resultSummary) item.resultSummary = resultSummary;
     delete item.prompt;
-    if (dispatch.completed.length > 100) {
+    if (dispatch.completed.length >= 100) {
       dispatch.completed = dispatch.completed.slice(-100);
     }
     dispatch.completed.push(item);

package/engine/lifecycle.js

@@ -901,6 +901,7 @@ function extractSkillsFromOutput(output, agentId, dispatchItem, config) {
   if (!fullText) fullText = output;
   const skillBlocks = [];
   const skillRegex = /```skill\s*\n([\s\S]*?)```/g;
+  skillRegex.lastIndex = 0;
   let match;
   while ((match = skillRegex.exec(fullText)) !== null) {
     skillBlocks.push(match[1].trim());

package/engine/llm.js

@@ -160,25 +160,12 @@ function callLLMStreaming(promptText, sysPromptText, { timeout = 120000, label =
               if (block.type === 'text' && block.text && block.text !== lastTextSent) {
                 lastTextSent = block.text;
                 onChunk(block.text);
-              }
-            }
-          }
-        } catch { /* incomplete JSON or non-JSON line */ }
-      }
-      // Also emit tool_use events so the frontend can show "Using tool: Read..."
-      for (const line of lines) {
-        const trimmed = line.trim();
-        if (!trimmed || !trimmed.startsWith('{')) continue;
-        try {
-          const obj = JSON.parse(trimmed);
-          if (obj.type === 'assistant' && obj.message?.content) {
-            for (const block of obj.message.content) {
-              if (block.type === 'tool_use' && block.name && onToolUse) {
+              } else if (block.type === 'tool_use' && block.name && onToolUse) {
                 onToolUse(block.name, block.input);
               }
             }
           }
-        } catch {}
+        } catch { /* incomplete JSON or non-JSON line */ }
       }
     });
     proc.stderr.on('data', d => { stderr += d.toString(); });

package/engine/pipeline.js

@@ -7,7 +7,8 @@
 const fs = require('fs');
 const path = require('path');
 const shared = require('./shared');
-const { safeJson, safeWrite, safeRead, safeReadDir, uid, log, ts, dateStamp, mutateJsonFileLocked, WI_STATUS, WORK_TYPE, PLAN_STATUS, PR_STATUS, PIPELINE_STATUS, STAGE_TYPE, MEETING_STATUS } = shared;
+const { safeJson, safeWrite, safeRead, safeReadDir, uid, log, ts, dateStamp, mutateJsonFileLocked, WI_STATUS, WORK_TYPE, PLAN_STATUS, PR_STATUS, PIPELINE_STATUS, STAGE_TYPE, MEETING_STATUS, ENGINE_DEFAULTS } = shared;
+const http = require('http');
 const { parseCronExpr, shouldRunNow } = require('./scheduler');
 
 const PIPELINES_DIR = path.join(__dirname, '..', 'pipelines');
@@ -313,18 +314,34 @@ function executeApiStage(stage, stageState, run) {
   for (const call of calls) {
     const url = `http://localhost:${process.env.MINIONS_PORT || 7331}${call.endpoint}`;
     const body = typeof call.body === 'string' ? call.body : JSON.stringify(call.body || {});
-    // Fire and forget — use Node's http module
-    try {
-      const http = require('http');
-      const parsed = new URL(url);
-      const req = http.request({
-        hostname: parsed.hostname, port: parsed.port, path: parsed.pathname,
-        method: call.method || 'POST',
-        headers: { 'Content-Type': 'application/json' },
-      });
-      req.write(body);
-      req.end();
-    } catch (e) { log('warn', `Pipeline API call failed: ${e.message}`); }
+    const maxAttempts = ENGINE_DEFAULTS.pipelineApiRetries;
+    const retryDelay = ENGINE_DEFAULTS.pipelineApiRetryDelay;
+    const makeRequest = (attempt) => {
+      try {
+        const parsed = new URL(url);
+        const req = http.request({
+          hostname: parsed.hostname, port: parsed.port, path: parsed.pathname,
+          method: call.method || 'POST',
+          headers: { 'Content-Type': 'application/json' },
+        }, (res) => {
+          res.resume(); // drain body to free socket
+          if (res.statusCode >= 400) {
+            log('warn', `Pipeline API call to ${call.endpoint} returned ${res.statusCode} (attempt ${attempt})`);
+            if (attempt < maxAttempts) setTimeout(() => makeRequest(attempt + 1), retryDelay);
+          }
+        });
+        req.on('error', (err) => {
+          log('warn', `Pipeline API call to ${call.endpoint} failed: ${err.message} (attempt ${attempt})`);
+          if (attempt < maxAttempts) setTimeout(() => makeRequest(attempt + 1), retryDelay);
+        });
+        req.write(body);
+        req.end();
+      } catch (e) {
+        log('warn', `Pipeline API call to ${call.endpoint} threw: ${e.message} (attempt ${attempt})`);
+        if (attempt < maxAttempts) setTimeout(() => makeRequest(attempt + 1), retryDelay);
+      }
+    };
+    makeRequest(1);
   }
   return { status: PIPELINE_STATUS.COMPLETED, completedAt: ts() };
 }

package/engine/preflight.js

@@ -27,7 +27,13 @@ function findClaudeBinary() {
     path.join(path.dirname(process.execPath), '..', 'lib', 'node_modules', '@anthropic-ai', 'claude-code', 'cli.js'),
     // fnm / volta — sibling to the node binary
     path.join(path.dirname(process.execPath), 'node_modules', '@anthropic-ai', 'claude-code', 'cli.js'),
-  ].filter(Boolean);
+  ].filter(p => {
+    if (!p) {
+      if (process.env.MINIONS_DEBUG) console.log('[preflight] Dropped empty CLI search path entry');
+      return false;
+    }
+    return true;
+  });
   for (const p of searchPaths) {
     try { if (fs.existsSync(p)) return p; } catch {}
   }

package/engine/shared.js

@@ -438,6 +438,8 @@ const ENGINE_DEFAULTS = {
   evalMaxIterations: 3, // max review→fix cycles before escalating to human
   evalMaxCost: null, // USD ceiling per work item across all eval iterations; null = no limit (gather baseline data first)
   maxRetries: 3, // max dispatch retries before marking work item as failed
+  pipelineApiRetries: 2, // max attempts for pipeline API calls
+  pipelineApiRetryDelay: 2000, // ms delay between pipeline API retries
 };
 
 // ─── Status & Type Constants ─────────────────────────────────────────────────

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.418",
+  "version": "0.1.420",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"