@yemi33/minions 0.1.415 → 0.1.417

package/CHANGELOG.md

@@ -1,10 +1,15 @@
 # Changelog
 
-## 0.1.415 (2026-04-06)
+## 0.1.417 (2026-04-06)
 
 ### Features
+- Fix notes.md race condition and null guards in consolidation.js
+- Replace 5 raw status strings with WI_STATUS constants
 - Fix null crashes in lifecycle.js syncPrsFromOutput and createReviewFeedbackForAuthor
 
+### Fixes
+-  restart kills zombie dashboard via port-based detection
+
 ## 0.1.414 (2026-04-06)
 
 ### Fixes

package/bin/minions.js

@@ -28,6 +28,42 @@ const os = require('os');
 const { spawn, execSync } = require('child_process');
 
 const PKG_ROOT = path.resolve(__dirname, '..');
+
+/** Kill process(es) listening on a given port. Works cross-platform. */
+function killByPort(port) {
+  try {
+    if (process.platform === 'win32') {
+      const out = execSync(`netstat -ano | findstr ":${port} " | findstr LISTENING`, { encoding: 'utf8', timeout: 5000, windowsHide: true });
+      const pids = new Set();
+      for (const line of out.split('\n')) {
+        const pid = line.trim().split(/\s+/).pop();
+        if (pid && /^\d+$/.test(pid) && pid !== '0' && pid !== String(process.pid)) pids.add(pid);
+      }
+      for (const pid of pids) try { process.kill(parseInt(pid)); } catch {}
+    } else {
+      execSync(`lsof -ti:${port} | xargs kill -9 2>/dev/null`, { timeout: 5000 });
+    }
+  } catch {}
+}
+
+/** Kill minions processes by command-line pattern matching (wmic on Windows, pkill on Unix). */
+function killMinionsProcesses(patterns) {
+  try {
+    if (process.platform === 'win32') {
+      const out = execSync('wmic process where "name=\'node.exe\'" get processid,commandline /format:csv', { encoding: 'utf8', timeout: 10000, windowsHide: true });
+      for (const line of out.split('\n')) {
+        if (patterns.some(p => line.includes(p))) {
+          const pid = line.split(',').pop()?.trim();
+          if (pid && /^\d+$/.test(pid) && pid !== String(process.pid)) try { process.kill(parseInt(pid)); } catch {}
+        }
+      }
+    } else {
+      for (const p of patterns) {
+        try { execSync(`pkill -f "${p}" 2>/dev/null`, { timeout: 5000 }); } catch {}
+      }
+    }
+  } catch {}
+}
 const DEFAULT_MINIONS_HOME = path.join(os.homedir(), '.minions');
 const ROOT_POINTER_PATH = path.join(os.homedir(), '.minions-root');
 const LEGACY_DEFAULT_SQUAD_HOME = path.join(os.homedir(), '.squad');
@@ -495,20 +531,8 @@ if (!cmd || cmd === 'help' || cmd === '--help' || cmd === '-h') {
   ensureInstalled();
   // Stop engine if running
   try { execSync(`node "${path.join(MINIONS_HOME, 'engine.js')}" stop`, { stdio: 'ignore', cwd: MINIONS_HOME }); } catch {}
-  // Kill existing dashboard
-  try {
-    if (process.platform === 'win32') {
-      const out = execSync('wmic process where "name=\'node.exe\'" get processid,commandline /format:csv', { encoding: 'utf8', timeout: 10000, windowsHide: true });
-      for (const line of out.split('\n')) {
-        if (line.includes('dashboard.js') && line.includes('minions')) {
-          const pid = line.split(',').pop()?.trim();
-          if (pid && pid !== String(process.pid)) try { process.kill(parseInt(pid)); } catch {}
-        }
-      }
-    } else {
-      try { execSync('lsof -ti:7331 | xargs kill -9 2>/dev/null', { timeout: 5000 }); } catch {}
-    }
-  } catch {}
+  // Kill existing dashboard — port-based is reliable across all setups
+  killByPort(7331);
   const engineProc = spawn(process.execPath, [path.join(MINIONS_HOME, 'engine.js'), 'start'], {
     cwd: MINIONS_HOME, stdio: 'ignore', detached: true, windowsHide: true
   });
@@ -550,22 +574,8 @@ if (!cmd || cmd === 'help' || cmd === '--help' || cmd === '-h') {
 
   // 1. Kill all processes
   try { execSync(`node "${path.join(MINIONS_HOME, 'engine.js')}" stop`, { stdio: 'ignore', cwd: MINIONS_HOME }); } catch {}
-  // Kill dashboard
-  try {
-    if (process.platform === 'win32') {
-      const out = execSync('wmic process where "name=\'node.exe\'" get processid,commandline /format:csv', { encoding: 'utf8', timeout: 10000, windowsHide: true });
-      for (const line of out.split('\n')) {
-        if (line.includes('minions') && (line.includes('engine.js') || line.includes('dashboard.js') || line.includes('spawn-agent.js'))) {
-          const pid = line.split(',').pop()?.trim();
-          if (pid && pid !== String(process.pid)) {
-            try { process.kill(parseInt(pid)); } catch {}
-          }
-        }
-      }
-    } else {
-      try { execSync('lsof -ti:7331 | xargs kill -9 2>/dev/null', { timeout: 5000 }); } catch {}
-    }
-  } catch {}
+  killByPort(7331);
+  killMinionsProcesses(['engine.js', 'dashboard.js', 'spawn-agent.js']);
   console.log('  Killed all processes');
 
   // 2. Delete runtime state
@@ -650,21 +660,8 @@ if (!cmd || cmd === 'help' || cmd === '--help' || cmd === '-h') {
 
   // 1. Kill all processes
   try { execSync(`node "${path.join(MINIONS_HOME, 'engine.js')}" stop`, { stdio: 'ignore', cwd: MINIONS_HOME, timeout: 10000 }); } catch {}
-  try {
-    if (process.platform === 'win32') {
-      const out = execSync('wmic process where "name=\'node.exe\'" get processid,commandline /format:csv', { encoding: 'utf8', timeout: 10000, windowsHide: true });
-      for (const line of out.split('\n')) {
-        if (line.includes('minions') && (line.includes('engine.js') || line.includes('dashboard.js') || line.includes('spawn-agent.js'))) {
-          const pid = line.split(',').pop()?.trim();
-          if (pid && pid !== String(process.pid)) try { process.kill(parseInt(pid)); } catch {}
-        }
-      }
-    } else {
-      try { execSync('pkill -f "minions.*engine.js" 2>/dev/null', { timeout: 5000 }); } catch {}
-      try { execSync('pkill -f "minions.*dashboard.js" 2>/dev/null', { timeout: 5000 }); } catch {}
-      try { execSync('lsof -ti:7331 | xargs kill -9 2>/dev/null', { timeout: 5000 }); } catch {}
-    }
-  } catch {}
+  killByPort(7331);
+  killMinionsProcesses(['engine.js', 'dashboard.js', 'spawn-agent.js']);
   console.log('  Killed all processes');
 
   // 2. Remove minions-authored skills from ~/.claude/skills/

package/engine/consolidation.js

@@ -38,7 +38,7 @@ function consolidateInbox(config) {
 
   const items = files.map(f => ({
     name: f,
-    content: safeRead(path.join(INBOX_DIR, f))
+    content: safeRead(path.join(INBOX_DIR, f)) || ''
   }));
 
   const existingNotes = getNotes() || '';
@@ -220,30 +220,33 @@ function consolidateWithLLM(items, existingNotes, files, config) {
       }
 
       const entry = '\n\n---\n\n' + digest;
-      const current = getNotes();
-      let newContent = current + entry;
-
-      if (newContent.length > 50000) {
-        // Truncate on section boundary — scan backward for last \n# before byte limit
-        // Never cut mid-section to preserve readability
-        const limit = 50000;
-        const lastSectionBoundary = newContent.lastIndexOf('\n---\n\n### ', limit);
-        if (lastSectionBoundary > 0) {
-          newContent = newContent.slice(0, lastSectionBoundary);
-          log('info', `Pruned notes.md at section boundary (pos ${lastSectionBoundary}) to stay under ${limit} bytes`);
-        } else {
-          // Fallback: use the old section-count approach
-          const sections = newContent.split('\n---\n\n### ');
-          if (sections.length > 10) {
-            const header = sections[0];
-            const recent = sections.slice(-8);
-            newContent = header + '\n---\n\n### ' + recent.join('\n---\n\n### ');
-            log('info', `Pruned notes.md: removed ${sections.length - 9} old sections`);
+      // Wrap read-modify-write in file lock to prevent race with concurrent consolidation or manual edits
+      shared.withFileLock(NOTES_PATH + '.lock', () => {
+        const current = getNotes() || '';
+        let newContent = current + entry;
+
+        if (newContent.length > 50000) {
+          // Truncate on section boundary — scan backward for last \n# before byte limit
+          // Never cut mid-section to preserve readability
+          const limit = 50000;
+          const lastSectionBoundary = newContent.lastIndexOf('\n---\n\n### ', limit);
+          if (lastSectionBoundary > 0) {
+            newContent = newContent.slice(0, lastSectionBoundary);
+            log('info', `Pruned notes.md at section boundary (pos ${lastSectionBoundary}) to stay under ${limit} bytes`);
+          } else {
+            // Fallback: use the old section-count approach
+            const sections = newContent.split('\n---\n\n### ');
+            if (sections.length > 10) {
+              const header = sections[0];
+              const recent = sections.slice(-8);
+              newContent = header + '\n---\n\n### ' + recent.join('\n---\n\n### ');
+              log('info', `Pruned notes.md: removed ${sections.length - 9} old sections`);
+            }
           }
         }
-      }
 
-      safeWrite(NOTES_PATH, newContent);
+        safeWrite(NOTES_PATH, newContent);
+      });
       classifyToKnowledgeBase(items);
       archiveInboxFiles(files);
       log('info', `LLM consolidation complete: ${files.length} notes processed by Haiku`);
@@ -297,10 +300,10 @@ function consolidateWithRegex(items, files) {
       if (!trimmed || sectionPattern.test(trimmed)) continue;
       let insight = null;
       const numMatch = trimmed.match(numberedPattern);
-      if (numMatch) insight = `**${numMatch[1].trim()}**: ${numMatch[2].trim()}`;
+      if (numMatch && numMatch[1] && numMatch[2]) insight = `**${numMatch[1].trim()}**: ${numMatch[2].trim()}`;
       if (!insight) {
         const bulMatch = trimmed.match(bulletPattern);
-        if (bulMatch) insight = `**${bulMatch[1].trim()}**: ${bulMatch[2].trim()}`;
+        if (bulMatch && bulMatch[1] && bulMatch[2]) insight = `**${bulMatch[1].trim()}**: ${bulMatch[2].trim()}`;
       }
       if (!insight && importantKeywords.test(trimmed) && !trimmed.startsWith('#') && trimmed.length > 30 && trimmed.length < 500) {
         insight = trimmed;
@@ -363,19 +366,22 @@ function consolidateWithRegex(items, files) {
   const dupCount = allInsights.length - deduped.length;
   if (dupCount > 0) entry += `_Deduplication: ${dupCount} duplicate(s) removed._\n`;
 
-  const current = getNotes();
-  let newContent = current + entry;
-  if (newContent.length > 50000) {
-    const limit = 50000;
-    const lastBoundary = newContent.lastIndexOf('\n---\n\n### ', limit);
-    if (lastBoundary > 0) {
-      newContent = newContent.slice(0, lastBoundary);
-    } else {
-      const sections = newContent.split('\n---\n\n### ');
-      if (sections.length > 10) { newContent = sections[0] + '\n---\n\n### ' + sections.slice(-8).join('\n---\n\n### '); }
+  // Wrap read-modify-write in file lock to prevent race with concurrent consolidation or manual edits
+  shared.withFileLock(NOTES_PATH + '.lock', () => {
+    const current = getNotes() || '';
+    let newContent = current + entry;
+    if (newContent.length > 50000) {
+      const limit = 50000;
+      const lastBoundary = newContent.lastIndexOf('\n---\n\n### ', limit);
+      if (lastBoundary > 0) {
+        newContent = newContent.slice(0, lastBoundary);
+      } else {
+        const sections = newContent.split('\n---\n\n### ');
+        if (sections.length > 10) { newContent = sections[0] + '\n---\n\n### ' + sections.slice(-8).join('\n---\n\n### '); }
+      }
     }
-  }
-  safeWrite(NOTES_PATH, newContent);
+    safeWrite(NOTES_PATH, newContent);
+  });
   classifyToKnowledgeBase(items);
   archiveInboxFiles(files);
   log('info', `Regex fallback: consolidated ${files.length} notes \u2192 ${deduped.length} insights into notes.md`);

package/engine/dispatch.js

@@ -116,7 +116,7 @@ function completeDispatch(id, result = DISPATCH_RESULT.SUCCESS, reason = '', res
       const maxRetries = ENGINE_DEFAULTS.maxRetries;
       if (retryableFailure && retries < maxRetries) {
         log('info', `Dispatch error for ${item.meta.item.id} — auto-retry ${retries + 1}/${maxRetries}`);
-        lifecycle().updateWorkItemStatus(item.meta, 'pending', '');
+        lifecycle().updateWorkItemStatus(item.meta, WI_STATUS.PENDING, '');
         // Remove this dispatch key from completed so dedupe doesn't block immediate redispatch.
         if (item.meta?.dispatchKey) {
           try {
@@ -150,7 +150,7 @@ function completeDispatch(id, result = DISPATCH_RESULT.SUCCESS, reason = '', res
         const finalReason = !retryableFailure
           ? `Non-retryable failure: ${reason || 'Unknown error'}`
           : (reason || `Failed after ${maxRetries} retries`);
-        lifecycle().updateWorkItemStatus(item.meta, 'failed', finalReason);
+        lifecycle().updateWorkItemStatus(item.meta, WI_STATUS.FAILED, finalReason);
         // Alert: find items blocked by this failure and write inbox note
         try {
           const config = getConfig();

package/engine/queries.js

@@ -10,7 +10,8 @@ const os = require('os');
 const shared = require('./shared');
 
 const { safeRead, safeReadDir, safeJson, safeWrite, getProjects,
-  projectWorkItemsPath, projectPrPath, parseSkillFrontmatter, KB_CATEGORIES } = shared;
+  projectWorkItemsPath, projectPrPath, parseSkillFrontmatter, KB_CATEGORIES,
+  WI_STATUS } = shared;
 
 // ── Paths ───────────────────────────────────────────────────────────────────
 
@@ -179,7 +180,7 @@ function getAgentStatus(agentId) {
     const latestInFlight = allItems
       .filter(w =>
         (w.dispatched_to || '').toLowerCase() === String(agentId).toLowerCase() &&
-        w.status === 'dispatched'
+        w.status === WI_STATUS.DISPATCHED
       )
       .sort((a, b) => (b.dispatched_at || '').localeCompare(a.dispatched_at || ''))[0];
     if (latestInFlight) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.415",
+  "version": "0.1.417",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"