@yemi33/minions 0.1.409 → 0.1.411

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.1.411 (2026-04-06)
+
+### Fixes
+-  steering messages retry instead of being silently dropped
+
+### Other
+- refactor: simplify steering — remove redundant session read, fix TOCTOU
+
 ## 0.1.409 (2026-04-06)
 
 ### Fixes

package/engine/cli.js

@@ -149,8 +149,8 @@ const commands = {
         if (agentPid && agentPid > 0) {
           try {
             if (process.platform === 'win32') {
-              const out = exec(`tasklist /FI "PID eq ${agentPid}" /NH`, { encoding: 'utf8', timeout: 3000 });
-              if (!out.includes(String(agentPid))) agentPid = null;
+              const out = exec(`tasklist /FI "PID eq ${agentPid}" /NH`, { encoding: 'utf8', timeout: 3000 }).trim();
+              if (!new RegExp(`\\b${agentPid}\\b`).test(out)) agentPid = null;
             } else {
               process.kill(agentPid, 0);
             }
@@ -158,7 +158,13 @@ const commands = {
         }
 
         if (agentPid) {
-          e.activeProcesses.set(item.id, { proc: { pid: agentPid > 0 ? agentPid : null }, agentId, startedAt: item.created_at, reattached: true });
+          // Load sessionId from session.json for steering support
+          let sessionId = null;
+          try {
+            const sj = safeJson(path.join(AGENTS_DIR, agentId, 'session.json'));
+            if (sj?.sessionId) sessionId = sj.sessionId;
+          } catch {}
+          e.activeProcesses.set(item.id, { proc: { pid: agentPid > 0 ? agentPid : null }, agentId, startedAt: item.created_at, reattached: true, sessionId });
           // Sync work item status to dispatched — direct file write to avoid lifecycle lazy init issues
           if (item.meta?.item?.id && item.meta?.project?.localPath) {
             try {

package/engine/timeout.js

@@ -58,18 +58,24 @@ function checkSteering(config) {
   const activeProcesses = engine().activeProcesses;
   for (const [id, info] of activeProcesses) {
     const steerPath = path.join(AGENTS_DIR, info.agentId, 'steer.md');
-    if (!fs.existsSync(steerPath)) continue;
-
-    const message = safeRead(steerPath);
-    try { fs.unlinkSync(steerPath); } catch { /* cleanup */ }
-    if (!message) continue;
+    let steerMtime;
+    try { steerMtime = fs.statSync(steerPath).mtimeMs; } catch { continue; } // ENOENT = no steering message
 
     const sessionId = info.sessionId;
     if (!sessionId) {
-      log('warn', `Steering: no sessionId for ${info.agentId} — cannot resume. Message dropped.`);
+      // No sessionId yet — check stale (>5 min means it'll never arrive)
+      if (Date.now() - steerMtime > 300000) {
+        log('warn', `Steering: no sessionId for ${info.agentId} after 5m — deleting stale message`);
+        try { fs.unlinkSync(steerPath); } catch {}
+      }
+      // Leave steer.md in place — retry next tick when sessionId may be available
       continue;
     }
 
+    const message = safeRead(steerPath);
+    try { fs.unlinkSync(steerPath); } catch { /* cleanup */ }
+    if (!message) continue;
+
     log('info', `Steering: killing ${info.agentId} (${id}) for session resume with human message`);
 
     // Kill current process

package/engine.js

@@ -462,12 +462,14 @@ function spawnAgent(dispatchItem, config) {
   }
 
   // Session resume: reuse last session if same branch and recent enough (< 2 hours)
+  let cachedSessionId = null;
   // Only resume when the context is relevant — same branch means the agent is
   // continuing work on the same PR/feature (e.g., author fixing their own build failure)
   if (!agentId.startsWith('temp-')) {
     try {
       const sessionFile = safeJson(path.join(AGENTS_DIR, agentId, 'session.json'));
       if (sessionFile?.sessionId && sessionFile.savedAt) {
+        cachedSessionId = sessionFile.sessionId;
         const sessionAge = Date.now() - new Date(sessionFile.savedAt).getTime();
         const sameBranch = branchName && sessionFile.branch && sessionFile.branch === branchName;
         if (sessionAge < 2 * 60 * 60 * 1000 && sameBranch) {
@@ -655,10 +657,12 @@ function spawnAgent(dispatchItem, config) {
     }
 
     // Parse output and run all post-completion hooks
-    const { resultSummary } = runPostCompletionHooks(dispatchItem, agentId, code, stdout, config);
+    const { resultSummary, autoRecovered } = runPostCompletionHooks(dispatchItem, agentId, code, stdout, config);
 
     // Move from active to completed in dispatch (single source of truth for agent status)
-    completeDispatch(id, code === 0 ? DISPATCH_RESULT.SUCCESS : DISPATCH_RESULT.ERROR, '', resultSummary);
+    // autoRecovered: agent failed (e.g. heartbeat timeout) but created PRs — treat as success
+    const effectiveResult = (code === 0 || autoRecovered) ? DISPATCH_RESULT.SUCCESS : DISPATCH_RESULT.ERROR;
+    completeDispatch(id, effectiveResult, '', resultSummary);
 
     // Cleanup temp files (including PID file now that dispatch is complete)
     try { fs.unlinkSync(sysPromptPath); } catch { /* cleanup */ }
@@ -696,7 +700,7 @@ function spawnAgent(dispatchItem, config) {
   }, 3000);
 
   // Track process — even if PID isn't available yet (async on Windows)
-  activeProcesses.set(id, { proc, agentId, startedAt });
+  activeProcesses.set(id, { proc, agentId, startedAt, sessionId: cachedSessionId });
 
   // Log PID and persist to registry
   if (proc.pid) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.409",
+  "version": "0.1.411",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"