@yemi33/minions 0.1.406 → 0.1.407

package/CHANGELOG.md

@@ -1,8 +1,14 @@
 # Changelog
 
-## 0.1.406 (2026-04-06)
+## 0.1.407 (2026-04-06)
+
+### Features
+- Add missing return in mutateJsonFileLocked metrics callbacks
+- Fix SSE resource leak in handleAgentLiveStream
+- Add projects[0] length guards in engine.js
 
 ### Fixes
+-  npm version check uses npm view instead of raw https.get
 -  re-check npm registry every 4 hours via setInterval
 -  PR delete is optimistic — row removed immediately, reverted on failure
 -  PR delete searches all project files, not just the first project

package/dashboard.js

@@ -179,18 +179,14 @@ async function checkNpmVersion() {
   const now = Date.now();
   if (_npmVersionCache && (now - _npmVersionCacheTs) < NPM_CHECK_INTERVAL) return _npmVersionCache;
   try {
-    const https = require('https');
-    const data = await new Promise((resolve, reject) => {
-      const req = https.get(`https://registry.npmjs.org/${PKG_NAME}/latest`, { timeout: 5000 }, (resp) => {
-        if (resp.statusCode !== 200) { reject(new Error('npm registry ' + resp.statusCode)); resp.resume(); return; }
-        let body = '';
-        resp.on('data', c => body += c);
-        resp.on('end', () => { try { resolve(JSON.parse(body)); } catch { reject(new Error('bad json')); } });
+    // Use npm view — respects user's .npmrc proxy/registry config (unlike raw https.get)
+    const { execFile } = require('child_process');
+    const version = await new Promise((resolve, reject) => {
+      execFile('npm', ['view', PKG_NAME, 'version'], { timeout: 15000, windowsHide: true }, (err, stdout) => {
+        if (err) reject(err); else resolve((stdout || '').trim());
       });
-      req.on('error', reject);
-      req.on('timeout', () => { req.destroy(); reject(new Error('timeout')); });
     });
-    _npmVersionCache = { latest: data.version || null, checkedAt: new Date().toISOString() };
+    _npmVersionCache = { latest: version || null, checkedAt: new Date().toISOString() };
     _npmVersionCacheTs = now;
   } catch {
     _npmVersionCache = _npmVersionCache || { latest: null, checkedAt: null, error: 'check failed' };
@@ -1458,6 +1454,13 @@ const server = http.createServer(async (req, res) => {
     const agentId = match[1];
     const agentDir = path.join(MINIONS_DIR, 'agents', agentId);
     const liveLogPath = path.join(agentDir, 'live-output.log');
+    let _cleanedUp = false;
+
+    // Safe res.write wrapper — guards against writes after cleanup and EPIPE/ERR_STREAM_DESTROYED
+    const safeWrite = (data) => {
+      if (_cleanedUp) return;
+      try { res.write(data); } catch { /* EPIPE or ERR_STREAM_DESTROYED — client gone */ }
+    };
 
     // Check if agent directory exists — avoid dangling watchers on nonexistent paths
     if (!fs.existsSync(agentDir)) {
@@ -1479,13 +1482,14 @@ const server = http.createServer(async (req, res) => {
     try {
       const content = fs.readFileSync(liveLogPath, 'utf8');
       if (content.length > 0) {
-        res.write(`data: ${JSON.stringify(content)}\n\n`);
+        safeWrite(`data: ${JSON.stringify(content)}\n\n`);
         offset = Buffer.byteLength(content, 'utf8');
       }
     } catch { /* optional */ }
 
     // Watch for changes using fs.watchFile (cross-platform, works on Windows)
     const watcher = () => {
+      if (_cleanedUp) return;
       try {
         const stat = fs.statSync(liveLogPath);
         if (stat.size > offset) {
@@ -1495,29 +1499,32 @@ const server = http.createServer(async (req, res) => {
           fs.closeSync(fd);
           offset = stat.size;
           const chunk = buf.toString('utf8');
-          if (chunk) res.write(`data: ${JSON.stringify(chunk)}\n\n`);
+          if (chunk) safeWrite(`data: ${JSON.stringify(chunk)}\n\n`);
         }
       } catch { /* optional */ }
     };
 
     fs.watchFile(liveLogPath, { interval: 500 }, watcher);
 
-    // Cleanup helper to prevent handle leaks
+    // Idempotent cleanup helper to prevent handle leaks
     const cleanup = () => {
+      if (_cleanedUp) return;
+      _cleanedUp = true;
       try { clearInterval(doneCheck); } catch { /* optional */ }
       try { fs.unwatchFile(liveLogPath, watcher); } catch { /* optional */ }
     };
 
     // Check if agent is still active (poll every 5s)
     const doneCheck = setInterval(() => {
+      if (_cleanedUp) return;
       try {
         const dispatch = getDispatchQueue();
         const isActive = (dispatch.active || []).some(d => d.agent === agentId);
         if (!isActive) {
           watcher(); // flush final content
-          res.write(`event: done\ndata: complete\n\n`);
+          safeWrite(`event: done\ndata: complete\n\n`);
           cleanup();
-          res.end();
+          try { res.end(); } catch { /* optional */ }
         }
       } catch (e) {
         cleanup();

package/engine/ado.js

@@ -194,6 +194,7 @@ async function pollPrStatus(config) {
               if (!metrics[authorId]) metrics[authorId] = {};
               if (newReviewStatus === 'approved') metrics[authorId].prsApproved = (metrics[authorId].prsApproved || 0) + 1;
               else metrics[authorId].prsRejected = (metrics[authorId].prsRejected || 0) + 1;
+              return metrics;
             });
           } catch (err) { log('warn', `Metrics update: ${err.message}`); }
         }

package/engine/github.js

@@ -216,6 +216,7 @@ async function pollPrStatus(config) {
                 if (!metrics[authorId]) metrics[authorId] = {};
                 if (newReviewStatus === 'approved') metrics[authorId].prsApproved = (metrics[authorId].prsApproved || 0) + 1;
                 else metrics[authorId].prsRejected = (metrics[authorId].prsRejected || 0) + 1;
+                return metrics;
               });
             } catch (err) { log('warn', `Metrics update: ${err.message}`); }
           }

package/engine.js

@@ -1827,7 +1827,8 @@ function discoverCentralWorkItems(config) {
         const fanKey = `${key}-${agent.id}`;
         if (isAlreadyDispatched(fanKey)) continue;
 
-        const ap = assignedProject || projects[0];
+        const ap = assignedProject || (projects.length > 0 ? projects[0] : null);
+        if (!ap) { log('warn', `Fan-out: skipping ${fanKey} — no projects configured`); continue; }
         const vars = {
           ...buildBaseVars(agent.id, config, ap),
           item_id: item.id,
@@ -1897,7 +1898,8 @@ function discoverCentralWorkItems(config) {
 
       const agentName = config.agents[agentId]?.name || agentId;
       const agentRole = config.agents[agentId]?.role || 'Agent';
-      const firstProject = projects[0];
+      const firstProject = projects.length > 0 ? projects[0] : null;
+      if (!firstProject) { log('warn', `Dispatch: skipping ${item.id} — no projects configured`); continue; }
 
       const vars = {
         ...buildBaseVars(agentId, config, firstProject),
@@ -2291,7 +2293,7 @@ async function tickInner() {
             if (pendingWithBlockedDeps.length > 0) {
               // Auto-retry failed items that are blocking others (transient errors)
               for (const item of items) {
-                if (item.status !== 'failed' || isItemCompleted(item)) continue;
+                if (item.status !== WI_STATUS.FAILED || isItemCompleted(item)) continue;
                 // Only retry if something depends on this item
                 const isBlocking = items.some(w => w.status === WI_STATUS.PENDING && (w.depends_on || []).includes(item.id));
                 if (!isBlocking) continue;
@@ -2333,7 +2335,7 @@ async function tickInner() {
                   const blockers = (dep.depends_on || []).filter(d => retriedIds.has(d));
                   if (blockers.length > 0) {
                     log('info', `Stall recovery: un-failing ${dep.id} (blocker ${blockers.join(',')} retried)`);
-                    dep.status = 'pending';
+                    dep.status = WI_STATUS.PENDING;
                     dep._retryCount = 0;
                     delete dep.failReason;
                     delete dep.failedAt;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.406",
+  "version": "0.1.407",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"