@yemi33/minions 0.1.372 → 0.1.374

package/CHANGELOG.md

@@ -1,6 +1,11 @@
 # Changelog
 
-## 0.1.372 (2026-04-06)
+## 0.1.374 (2026-04-06)
+
+### Fixes
+-  medium bugs — KB declaration, meeting phantom archive, lifecycle race (#216)
+
+## 0.1.373 (2026-04-06)
 
 ### Features
 - Fix review re-dispatch infinite loop (#226)
@@ -8,6 +13,7 @@
 - Fix 2 failing source-pattern test assertions (#224)
 
 ### Fixes
+-  critical engine bugs — pipeline async, lifecycle null guard, scheduler (#215)
 -  restore dispatched_to on work items when marking done after retry
 -  copy button preserves markdown formatting
 

package/dashboard/js/render-kb.js

@@ -12,6 +12,7 @@ const KB_CAT_ICONS = {
   reviews: '\u{1F50D}', learnings: '\u{1F4A1}', decisions: '\u{2696}',
   incidents: '\u{1F6A8}', 'api-notes': '\u{1F517}',
 };
+let _kbData = {};
 let _kbActiveTab = 'all';
 const KB_PER_PAGE = 30;
 let _kbPage = 0;
@@ -86,7 +87,7 @@ function renderKnowledgeBase() {
         '<div class="kb-item-title">' + icon + ' ' + escHtml(item.title) + '</div>' +
         '<div class="kb-item-meta">' +
           '<span>' + label + '</span>' +
-          (item.agent ? '<span>' + item.agent + '</span>' : '') +
+          (item.agent ? '<span>' + escHtml(item.agent) + '</span>' : '') +
           '<span>' + (item.date || '') + '</span>' +
           '<span>' + Math.round(item.size / 1024) + 'KB</span>' +
         '</div>' +

package/dashboard/js/render-meetings.js

@@ -344,8 +344,8 @@ async function _archiveMeeting(id) {
       method: 'POST', headers: { 'Content-Type': 'application/json' },
       body: JSON.stringify({ id })
     });
-    if (!res.ok) { const d = await res.json().catch(() => ({})); alert('Failed: ' + (d.error || 'unknown')); refresh(); }
-  } catch (e) { alert('Error: ' + e.message); refresh(); }
+    if (!res.ok) { _deletedIds.delete('mtg:' + id); const d = await res.json().catch(() => ({})); alert('Failed: ' + (d.error || 'unknown')); refresh(); }
+  } catch (e) { _deletedIds.delete('mtg:' + id); alert('Error: ' + e.message); refresh(); }
 }
 
 async function _unarchiveMeeting(id) {

package/engine/lifecycle.js

@@ -457,24 +457,22 @@ function chainPlanToPrd(dispatchItem, meta, config) {
 
   log('info', `Plan chaining: queuing plan-to-prd for next tick (chained from ${dispatchItem.id})`);
   const wiPath = path.join(MINIONS_DIR, 'work-items.json');
-  let items = [];
-  try { items = JSON.parse(fs.readFileSync(wiPath, 'utf8')); } catch (err) {
-    log('warn', `Failed to parse ${wiPath}: ${err.message}`);
-    try { fs.copyFileSync(wiPath, wiPath + '.bak'); } catch {}
-  }
-  items.push({
-    id: 'W-' + shared.uid(),
-    title: `Convert plan to PRD: ${meta?.item?.title || planFile.name}`,
-    type: 'plan-to-prd',
-    priority: meta?.item?.priority || 'high',
-    description: `Plan file: plans/${planFile.name}\nChained from plan task ${dispatchItem.id}`,
-    status: WI_STATUS.PENDING,
-    created: ts(),
-    createdBy: 'engine:chain',
-    project: targetProject.name,
-    planFile: planFile.name,
-  });
-  shared.safeWrite(wiPath, items);
+  shared.mutateJsonFileLocked(wiPath, (items) => {
+    if (!Array.isArray(items)) items = [];
+    items.push({
+      id: 'W-' + shared.uid(),
+      title: `Convert plan to PRD: ${meta?.item?.title || planFile.name}`,
+      type: 'plan-to-prd',
+      priority: meta?.item?.priority || 'high',
+      description: `Plan file: plans/${planFile.name}\nChained from plan task ${dispatchItem.id}`,
+      status: WI_STATUS.PENDING,
+      created: ts(),
+      createdBy: 'engine:chain',
+      project: targetProject.name,
+      planFile: planFile.name,
+    });
+    return items;
+  }, { defaultValue: [] });
 }
 
 // ─── Work Item Path Resolution ───────────────────────────────────────────────
@@ -784,7 +782,7 @@ async function handlePostMerge(pr, project, config, newStatus) {
 
   const prNum = (pr.id || '').replace('PR-', '');
 
-  if (pr.branch) {
+  if (pr.branch && project) {
     const root = path.resolve(project.localPath);
     const wtRoot = path.resolve(root, config.engine?.worktreeRoot || '../worktrees');
     // Find worktrees matching this branch — dir format is {slug}-{branch}-{suffix}

package/engine/pipeline.js

@@ -358,7 +358,7 @@ function executeScheduleStage(stage, stageState, config) {
   return { status: 'completed', completedAt: ts() };
 }
 
-function executeParallelStage(stage, stageState, run, pipeline, config) {
+async function executeParallelStage(stage, stageState, run, pipeline, config) {
   const subStages = stage.stages || [];
   const subResults = {};
   for (const sub of subStages) {
@@ -496,7 +496,7 @@ function isStageComplete(stage, stageState, run, config) {
 
 // ── Discovery (called per tick) ──────────────────────────────────────────────
 
-function discoverPipelineWork(config) {
+async function discoverPipelineWork(config) {
   const pipelines = getPipelines();
   if (pipelines.length === 0) return;
 

package/engine/scheduler.js

@@ -114,7 +114,7 @@ function discoverScheduledWork(config) {
   mutateJsonFileLocked(SCHEDULE_RUNS_PATH, (runs) => {
     for (const sched of schedules) {
       if (!sched.id || !sched.cron || !sched.title) continue;
-      if (sched.enabled !== true) continue; // explicit true required — undefined/null/false all skip
+      if (!sched.enabled) continue; // truthy check — matches dashboard UI badge behavior
 
       const lastRun = runs[sched.id] || null;
       if (!shouldRunNow(sched, lastRun)) continue;

package/engine.js

@@ -2104,7 +2104,7 @@ function discoverWork(config) {
   // Pipeline orchestration — check stage completions and start ready stages
   try {
     const { discoverPipelineWork } = require('./engine/pipeline');
-    discoverPipelineWork(config);
+    await discoverPipelineWork(config);
   } catch (e) { log('warn', 'discover pipeline work: ' + e.message); }
 
   // Periodic plan completion sweep — catch PRDs that completed while engine was down

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.372",
+  "version": "0.1.374",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"